[jira] [Commented] (JENA-1515) Values added to subQuery are stripped by QueryBuilder
[ https://issues.apache.org/jira/browse/JENA-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649336#comment-16649336 ] ASF GitHub Bot commented on JENA-1515: -- Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/479 > Values added to subQuery are stripped by QueryBuilder > - > > Key: JENA-1515 > URL: https://issues.apache.org/jira/browse/JENA-1515 > Project: Apache Jena > Issue Type: Bug > Components: QueryBuilder >Affects Versions: Jena 3.6.0, Jena 3.7.0 >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Minor > > If values are added to a subQuery via the addValue methods the values are > stripped when the subquery is added to the outer query. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1515) Values added to subQuery are stripped by QueryBuilder
[ https://issues.apache.org/jira/browse/JENA-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649335#comment-16649335 ] ASF subversion and git services commented on JENA-1515: --- Commit a56eb06b8c2b577f6e1584f4cc9566d46d3efcf0 in jena's branch refs/heads/master from [~cla...@xenei.org] [ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=a56eb06 ] JENA-1515 Merge commit 'refs/pull/479/head' of github.com:apache/jena This closes #479 > Values added to subQuery are stripped by QueryBuilder > - > > Key: JENA-1515 > URL: https://issues.apache.org/jira/browse/JENA-1515 > Project: Apache Jena > Issue Type: Bug > Components: QueryBuilder >Affects Versions: Jena 3.6.0, Jena 3.7.0 >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Minor > > If values are added to a subQuery via the addValue methods the values are > stripped when the subquery is added to the outer query. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1515) Values added to subQuery are stripped by QueryBuilder
[ https://issues.apache.org/jira/browse/JENA-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649333#comment-16649333 ] ASF subversion and git services commented on JENA-1515: --- Commit a499b58a76704125f63a8407ffb2795b03e4d213 in jena's branch refs/heads/master from [~cla...@xenei.org] [ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=a499b58 ] fixes JENA-1515 > Values added to subQuery are stripped by QueryBuilder > - > > Key: JENA-1515 > URL: https://issues.apache.org/jira/browse/JENA-1515 > Project: Apache Jena > Issue Type: Bug > Components: QueryBuilder >Affects Versions: Jena 3.6.0, Jena 3.7.0 >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Minor > > If values are added to a subQuery via the addValue methods the values are > stripped when the subquery is added to the outer query. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1515) Values added to subQuery are stripped by QueryBuilder
[
https://issues.apache.org/jira/browse/JENA-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648494#comment-16648494
]
ASF GitHub Bot commented on JENA-1515:
--
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/479#discussion_r224923241
--- Diff:
jena-extras/jena-querybuilder/src/main/java/org/apache/jena/arq/querybuilder/rewriters/ElementRewriter.java
---
@@ -103,17 +103,13 @@ public void visit(ElementBind el) {
@Override
public void visit(ElementData el) {
ElementData retval = new ElementData();
- Iterator vars = el.getVars().iterator();
- Iterator bindings = el.getRows().iterator();
- while (vars.hasNext()) {
- Var v = vars.next();
- if (values.containsKey(v)) {
- bindings.next(); // skip the binding
- } else {
- retval.add(v);
- retval.add(rewrite(bindings.next()));
- }
+ for (Var v : el.getVars()) {
+ retval.add(v);
}
+ for (Binding binding : el.getRows())
+ {
--- End diff --
Code layout. Some of same-line { , some next line {
> Values added to subQuery are stripped by QueryBuilder
> -
>
> Key: JENA-1515
> URL: https://issues.apache.org/jira/browse/JENA-1515
> Project: Apache Jena
> Issue Type: Bug
> Components: QueryBuilder
>Affects Versions: Jena 3.6.0, Jena 3.7.0
>Reporter: Claude Warren
>Assignee: Claude Warren
>Priority: Minor
>
> If values are added to a subQuery via the addValue methods the values are
> stripped when the subquery is added to the outer query.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1515) Values added to subQuery are stripped by QueryBuilder
[
https://issues.apache.org/jira/browse/JENA-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648471#comment-16648471
]
ASF GitHub Bot commented on JENA-1515:
--
Github user Claudenw commented on a diff in the pull request:
https://github.com/apache/jena/pull/479#discussion_r224920678
--- Diff:
jena-extras/jena-querybuilder/src/main/java/org/apache/jena/arq/querybuilder/rewriters/ElementRewriter.java
---
@@ -103,17 +103,13 @@ public void visit(ElementBind el) {
@Override
public void visit(ElementData el) {
ElementData retval = new ElementData();
- Iterator vars = el.getVars().iterator();
- Iterator bindings = el.getRows().iterator();
- while (vars.hasNext()) {
- Var v = vars.next();
- if (values.containsKey(v)) {
- bindings.next(); // skip the binding
- } else {
- retval.add(v);
- retval.add(rewrite(bindings.next()));
- }
+ for (Var v : el.getVars()) {
+ retval.add(v);
}
+ for (Binding binding : el.getRows())
+ {
--- End diff --
not sure what this comment means. The style of the looping is different
and has a different result.
> Values added to subQuery are stripped by QueryBuilder
> -
>
> Key: JENA-1515
> URL: https://issues.apache.org/jira/browse/JENA-1515
> Project: Apache Jena
> Issue Type: Bug
> Components: QueryBuilder
>Affects Versions: Jena 3.6.0, Jena 3.7.0
>Reporter: Claude Warren
>Assignee: Claude Warren
>Priority: Minor
>
> If values are added to a subQuery via the addValue methods the values are
> stripped when the subquery is added to the outer query.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1515) Values added to subQuery are stripped by QueryBuilder
[
https://issues.apache.org/jira/browse/JENA-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641101#comment-16641101
]
ASF GitHub Bot commented on JENA-1515:
--
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/479#discussion_r223217292
--- Diff:
jena-extras/jena-querybuilder/src/main/java/org/apache/jena/arq/querybuilder/rewriters/ElementRewriter.java
---
@@ -103,17 +103,13 @@ public void visit(ElementBind el) {
@Override
public void visit(ElementData el) {
ElementData retval = new ElementData();
- Iterator vars = el.getVars().iterator();
- Iterator bindings = el.getRows().iterator();
- while (vars.hasNext()) {
- Var v = vars.next();
- if (values.containsKey(v)) {
- bindings.next(); // skip the binding
- } else {
- retval.add(v);
- retval.add(rewrite(bindings.next()));
- }
+ for (Var v : el.getVars()) {
+ retval.add(v);
}
+ for (Binding binding : el.getRows())
+ {
--- End diff --
Minor: different style. There is more of this later.
> Values added to subQuery are stripped by QueryBuilder
> -
>
> Key: JENA-1515
> URL: https://issues.apache.org/jira/browse/JENA-1515
> Project: Apache Jena
> Issue Type: Bug
> Components: QueryBuilder
>Affects Versions: Jena 3.6.0, Jena 3.7.0
>Reporter: Claude Warren
>Assignee: Claude Warren
>Priority: Minor
>
> If values are added to a subQuery via the addValue methods the values are
> stripped when the subquery is added to the outer query.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1515) Values added to subQuery are stripped by QueryBuilder
[ https://issues.apache.org/jira/browse/JENA-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641040#comment-16641040 ] ASF GitHub Bot commented on JENA-1515: -- GitHub user Claudenw opened a pull request: https://github.com/apache/jena/pull/479 1515/fix closes JENA-1515 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Claudenw/jena 1515/fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/479.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #479 commit 439f6ba0d690923cdcbb86c0780f6f8d0f5d6cd7 Author: Claude Warren Date: 2018-09-30T11:18:08Z added subquery values test commit a499b58a76704125f63a8407ffb2795b03e4d213 Author: Claude Warren Date: 2018-09-30T11:53:31Z fixes JENA-1515 commit e736bdfb1851a1069bd2dbd2d14c6eae1e259a97 Author: Claude Warren Date: 2018-10-07T11:24:17Z Merge branch 'master' into 1515/fix > Values added to subQuery are stripped by QueryBuilder > - > > Key: JENA-1515 > URL: https://issues.apache.org/jira/browse/JENA-1515 > Project: Apache Jena > Issue Type: Bug > Components: QueryBuilder >Affects Versions: Jena 3.6.0, Jena 3.7.0 >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Minor > > If values are added to a subQuery via the addValue methods the values are > stripped when the subquery is added to the outer query. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
