[jira] [Commented] (JENA-1561) Enable TDB2 in the Fuseki UI and on the Fuseki command line.
[ https://issues.apache.org/jira/browse/JENA-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509565#comment-16509565 ] ASF GitHub Bot commented on JENA-1561: -- Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/433 > Enable TDB2 in the Fuseki UI and on the Fuseki command line. > > > Key: JENA-1561 > URL: https://issues.apache.org/jira/browse/JENA-1561 > Project: Apache Jena > Issue Type: New Feature > Components: Fuseki >Affects Versions: Jena 3.7.0 >Reporter: Andy Seaborne >Assignee: Andy Seaborne >Priority: Major > Fix For: Jena 3.8.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1561) Enable TDB2 in the Fuseki UI and on the Fuseki command line.
[ https://issues.apache.org/jira/browse/JENA-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509564#comment-16509564 ] ASF subversion and git services commented on JENA-1561: --- Commit 4db45da0c028f89fe77d5f30bf4cabf75481f01c in jena's branch refs/heads/master from [~an...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=4db45da ] JENA-1561: Merge commit 'refs/pull/433/head' of https://github.com/apache/jena This closes #433. > Enable TDB2 in the Fuseki UI and on the Fuseki command line. > > > Key: JENA-1561 > URL: https://issues.apache.org/jira/browse/JENA-1561 > Project: Apache Jena > Issue Type: New Feature > Components: Fuseki >Affects Versions: Jena 3.7.0 >Reporter: Andy Seaborne >Assignee: Andy Seaborne >Priority: Major > Fix For: Jena 3.8.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1561) Enable TDB2 in the Fuseki UI and on the Fuseki command line.
[ https://issues.apache.org/jira/browse/JENA-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509563#comment-16509563 ] ASF subversion and git services commented on JENA-1561: --- Commit de3d637482d882573ec4204c7374b863a1cb2981 in jena's branch refs/heads/master from [~an...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=de3d637 ] JENA-1561: Enable TDB2 in UI and command line. > Enable TDB2 in the Fuseki UI and on the Fuseki command line. > > > Key: JENA-1561 > URL: https://issues.apache.org/jira/browse/JENA-1561 > Project: Apache Jena > Issue Type: New Feature > Components: Fuseki >Affects Versions: Jena 3.7.0 >Reporter: Andy Seaborne >Assignee: Andy Seaborne >Priority: Major > Fix For: Jena 3.8.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1561) Enable TDB2 in the Fuseki UI and on the Fuseki command line.
[
https://issues.apache.org/jira/browse/JENA-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508027#comment-16508027
]
ASF GitHub Bot commented on JENA-1561:
--
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/433#discussion_r194399246
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/mgt/ActionDatasets.java
---
@@ -351,15 +356,13 @@ private static void assemblerFromForm(HttpAction
action, StreamRDF dest) {
FusekiSystem.addGlobals(params);
//action.log.info(format("[%d] Create database : name = %s, type =
%s", action.id, dbName, dbType )) ;
-if ( ! dbType.equals(tDatabasetTDB) && !
dbType.equals(tDatabasetMem) )
-ServletOps.errorBadRequest(format("dbType can be only '%s' or
'%s'", tDatabasetTDB, tDatabasetMem)) ;
-String template = null ;
-if ( dbType.equalsIgnoreCase(tDatabasetTDB))
-template =
TemplateFunctions.templateFile(Template.templateTDBFN, params, Lang.TTL) ;
-if ( dbType.equalsIgnoreCase(tDatabasetMem))
-template =
TemplateFunctions.templateFile(Template.templateMemFN, params, Lang.TTL) ;
-RDFParser.create().source(new
StringReader(template)).base("http://base/";).lang(Lang.TTL).parse(dest);
+String template =
dbTypeToTemplate.get(dbType.toLowerCase(Locale.ROOT));
+if ( template == null )
+ServletOps.errorBadRequest(format("dbType can be only '%s'
or '%s'", tDatabaseTDB, tDatabaseMem)) ;
--- End diff --
Good point! Done.
> Enable TDB2 in the Fuseki UI and on the Fuseki command line.
>
>
> Key: JENA-1561
> URL: https://issues.apache.org/jira/browse/JENA-1561
> Project: Apache Jena
> Issue Type: New Feature
> Components: Fuseki
>Affects Versions: Jena 3.7.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Major
> Fix For: Jena 3.8.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1561) Enable TDB2 in the Fuseki UI and on the Fuseki command line.
[
https://issues.apache.org/jira/browse/JENA-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507847#comment-16507847
]
ASF GitHub Bot commented on JENA-1561:
--
Github user rvesse commented on a diff in the pull request:
https://github.com/apache/jena/pull/433#discussion_r194342614
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/mgt/ActionDatasets.java
---
@@ -351,15 +356,13 @@ private static void assemblerFromForm(HttpAction
action, StreamRDF dest) {
FusekiSystem.addGlobals(params);
//action.log.info(format("[%d] Create database : name = %s, type =
%s", action.id, dbName, dbType )) ;
-if ( ! dbType.equals(tDatabasetTDB) && !
dbType.equals(tDatabasetMem) )
-ServletOps.errorBadRequest(format("dbType can be only '%s' or
'%s'", tDatabasetTDB, tDatabasetMem)) ;
-String template = null ;
-if ( dbType.equalsIgnoreCase(tDatabasetTDB))
-template =
TemplateFunctions.templateFile(Template.templateTDBFN, params, Lang.TTL) ;
-if ( dbType.equalsIgnoreCase(tDatabasetMem))
-template =
TemplateFunctions.templateFile(Template.templateMemFN, params, Lang.TTL) ;
-RDFParser.create().source(new
StringReader(template)).base("http://base/";).lang(Lang.TTL).parse(dest);
+String template =
dbTypeToTemplate.get(dbType.toLowerCase(Locale.ROOT));
+if ( template == null )
+ServletOps.errorBadRequest(format("dbType can be only '%s'
or '%s'", tDatabaseTDB, tDatabaseMem)) ;
--- End diff --
This PR now allows three possibilities so the error message is now
inaccurate
> Enable TDB2 in the Fuseki UI and on the Fuseki command line.
>
>
> Key: JENA-1561
> URL: https://issues.apache.org/jira/browse/JENA-1561
> Project: Apache Jena
> Issue Type: New Feature
> Components: Fuseki
>Affects Versions: Jena 3.7.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Major
> Fix For: Jena 3.8.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1561) Enable TDB2 in the Fuseki UI and on the Fuseki command line.
[ https://issues.apache.org/jira/browse/JENA-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507138#comment-16507138 ] ASF GitHub Bot commented on JENA-1561: -- GitHub user afs opened a pull request: https://github.com/apache/jena/pull/433 JENA-1561: Enable TDB2 in Fuseki UI and on the command line. Both full and basic server command line code. You can merge this pull request into a Git repository by running: $ git pull https://github.com/afs/jena fuseki-tdb2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/433.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #433 commit df2e9838f513de6a515c2d3b9c9985466ccc26f8 Author: Andy Seaborne Date: 2018-06-09T18:07:10Z JENA-1561: Enable TDB2 in UI and command line. > Enable TDB2 in the Fuseki UI and on the Fuseki command line. > > > Key: JENA-1561 > URL: https://issues.apache.org/jira/browse/JENA-1561 > Project: Apache Jena > Issue Type: New Feature > Components: Fuseki >Affects Versions: Jena 3.7.0 >Reporter: Andy Seaborne >Assignee: Andy Seaborne >Priority: Major > Fix For: Jena 3.8.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
