[jira] [Commented] (JENA-1585) Reorganize the Fuseki codebase to split the server engine classes from the webapp classes
[ https://issues.apache.org/jira/browse/JENA-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571519#comment-16571519 ] ASF subversion and git services commented on JENA-1585: --- Commit 1d41d2ce4975ebc34e8a4dd4ff67cf1100421856 in jena's branch refs/heads/master from [~an...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=1d41d2c ] JENA-1585: Fuseki core reorg > Reorganize the Fuseki codebase to split the server engine classes from the > webapp classes > - > > Key: JENA-1585 > URL: https://issues.apache.org/jira/browse/JENA-1585 > Project: Apache Jena > Issue Type: Improvement > Components: Fuseki >Affects Versions: Jena 3.8.0 >Reporter: Andy Seaborne >Assignee: Andy Seaborne >Priority: Minor > Fix For: Jena 3.9.0 > > > This is a step towards separate packages for the fuseki server engine (the > servlets, request routing, some Jetty related support code) and the webapp > version of Fuseki that becomes the war and standalong jar in > jena-fuseki-server. > This first step is code reorganization with module jena-fuseki-core to put > the webapp java code it separate packages to the rest of the engine. > When split, the current jena-fuseki-core tests would go into > jena-fuseki-weabpp because they test the full server. The non-UI embeddable > server jena-fuseki-embedded and jena-fuseki-basic already gets test in the > integration tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1585) Reorganize the Fuseki codebase to split the server engine classes from the webapp classes
[ https://issues.apache.org/jira/browse/JENA-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571520#comment-16571520 ] ASF subversion and git services commented on JENA-1585: --- Commit 9dc0903475c92cd6155e8c0f5ddbf2a1ddaf5990 in jena's branch refs/heads/master from [~an...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=9dc0903 ] JENA-1585: Move resources, align web.xml, de-dup package-info.java > Reorganize the Fuseki codebase to split the server engine classes from the > webapp classes > - > > Key: JENA-1585 > URL: https://issues.apache.org/jira/browse/JENA-1585 > Project: Apache Jena > Issue Type: Improvement > Components: Fuseki >Affects Versions: Jena 3.8.0 >Reporter: Andy Seaborne >Assignee: Andy Seaborne >Priority: Minor > Fix For: Jena 3.9.0 > > > This is a step towards separate packages for the fuseki server engine (the > servlets, request routing, some Jetty related support code) and the webapp > version of Fuseki that becomes the war and standalong jar in > jena-fuseki-server. > This first step is code reorganization with module jena-fuseki-core to put > the webapp java code it separate packages to the rest of the engine. > When split, the current jena-fuseki-core tests would go into > jena-fuseki-weabpp because they test the full server. The non-UI embeddable > server jena-fuseki-embedded and jena-fuseki-basic already gets test in the > integration tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1585) Reorganize the Fuseki codebase to split the server engine classes from the webapp classes
[ https://issues.apache.org/jira/browse/JENA-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571531#comment-16571531 ] ASF GitHub Bot commented on JENA-1585: -- Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/456 > Reorganize the Fuseki codebase to split the server engine classes from the > webapp classes > - > > Key: JENA-1585 > URL: https://issues.apache.org/jira/browse/JENA-1585 > Project: Apache Jena > Issue Type: Improvement > Components: Fuseki >Affects Versions: Jena 3.8.0 >Reporter: Andy Seaborne >Assignee: Andy Seaborne >Priority: Minor > Fix For: Jena 3.9.0 > > > This is a step towards separate packages for the fuseki server engine (the > servlets, request routing, some Jetty related support code) and the webapp > version of Fuseki that becomes the war and standalong jar in > jena-fuseki-server. > This first step is code reorganization with module jena-fuseki-core to put > the webapp java code it separate packages to the rest of the engine. > When split, the current jena-fuseki-core tests would go into > jena-fuseki-weabpp because they test the full server. The non-UI embeddable > server jena-fuseki-embedded and jena-fuseki-basic already gets test in the > integration tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1585) Reorganize the Fuseki codebase to split the server engine classes from the webapp classes
[ https://issues.apache.org/jira/browse/JENA-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571527#comment-16571527 ] ASF subversion and git services commented on JENA-1585: --- Commit 59b38995d2586c4248be05727c76b0f77b80a421 in jena's branch refs/heads/master from [~an...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=59b3899 ] JENA-1585: Merge commit 'refs/pull/456/head' of https://github.com/apache/jena This closes #456. > Reorganize the Fuseki codebase to split the server engine classes from the > webapp classes > - > > Key: JENA-1585 > URL: https://issues.apache.org/jira/browse/JENA-1585 > Project: Apache Jena > Issue Type: Improvement > Components: Fuseki >Affects Versions: Jena 3.8.0 >Reporter: Andy Seaborne >Assignee: Andy Seaborne >Priority: Minor > Fix For: Jena 3.9.0 > > > This is a step towards separate packages for the fuseki server engine (the > servlets, request routing, some Jetty related support code) and the webapp > version of Fuseki that becomes the war and standalong jar in > jena-fuseki-server. > This first step is code reorganization with module jena-fuseki-core to put > the webapp java code it separate packages to the rest of the engine. > When split, the current jena-fuseki-core tests would go into > jena-fuseki-weabpp because they test the full server. The non-UI embeddable > server jena-fuseki-embedded and jena-fuseki-basic already gets test in the > integration tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1585) Reorganize the Fuseki codebase to split the server engine classes from the webapp classes
[ https://issues.apache.org/jira/browse/JENA-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571523#comment-16571523 ] ASF subversion and git services commented on JENA-1585: --- Commit f926341f7de962602ee77596b7635a7c75a83386 in jena's branch refs/heads/master from [~an...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=f926341 ] JENA-1585: Comment for FusekiBuildLib; typo in FusekiServer > Reorganize the Fuseki codebase to split the server engine classes from the > webapp classes > - > > Key: JENA-1585 > URL: https://issues.apache.org/jira/browse/JENA-1585 > Project: Apache Jena > Issue Type: Improvement > Components: Fuseki >Affects Versions: Jena 3.8.0 >Reporter: Andy Seaborne >Assignee: Andy Seaborne >Priority: Minor > Fix For: Jena 3.9.0 > > > This is a step towards separate packages for the fuseki server engine (the > servlets, request routing, some Jetty related support code) and the webapp > version of Fuseki that becomes the war and standalong jar in > jena-fuseki-server. > This first step is code reorganization with module jena-fuseki-core to put > the webapp java code it separate packages to the rest of the engine. > When split, the current jena-fuseki-core tests would go into > jena-fuseki-weabpp because they test the full server. The non-UI embeddable > server jena-fuseki-embedded and jena-fuseki-basic already gets test in the > integration tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1585) Reorganize the Fuseki codebase to split the server engine classes from the webapp classes
[ https://issues.apache.org/jira/browse/JENA-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569456#comment-16569456 ] ASF GitHub Bot commented on JENA-1585: -- Github user afs commented on the issue: https://github.com/apache/jena/pull/456 No problem on timing - I found I'd tripped myself up moving java resources around and tested against a setup that had old and new location materials. TravisCI caught this for me. > Reorganize the Fuseki codebase to split the server engine classes from the > webapp classes > - > > Key: JENA-1585 > URL: https://issues.apache.org/jira/browse/JENA-1585 > Project: Apache Jena > Issue Type: Improvement > Components: Fuseki >Affects Versions: Jena 3.8.0 >Reporter: Andy Seaborne >Assignee: Andy Seaborne >Priority: Minor > Fix For: Jena 3.9.0 > > > This is a step towards separate packages for the fuseki server engine (the > servlets, request routing, some Jetty related support code) and the webapp > version of Fuseki that becomes the war and standalong jar in > jena-fuseki-server. > This first step is code reorganization with module jena-fuseki-core to put > the webapp java code it separate packages to the rest of the engine. > When split, the current jena-fuseki-core tests would go into > jena-fuseki-weabpp because they test the full server. The non-UI embeddable > server jena-fuseki-embedded and jena-fuseki-basic already gets test in the > integration tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1585) Reorganize the Fuseki codebase to split the server engine classes from the webapp classes
[
https://issues.apache.org/jira/browse/JENA-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569454#comment-16569454
]
ASF GitHub Bot commented on JENA-1585:
--
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/456#discussion_r207735470
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/build/FusekiBuildLib.java
---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.jena.fuseki.build;
+
+import org.apache.jena.fuseki.FusekiConfigException;
+import org.apache.jena.fuseki.webapp.SystemState;
+import org.apache.jena.query.* ;
+import org.apache.jena.rdf.model.Literal ;
+import org.apache.jena.rdf.model.Model ;
+import org.apache.jena.rdf.model.RDFNode ;
+import org.apache.jena.rdf.model.Resource ;
+import org.apache.jena.shared.PrefixMapping ;
+import org.apache.jena.vocabulary.RDFS ;
+
+public class FusekiBuildLib {
--- End diff --
Good idea. And, yes, it is the build-specific operations.
Done.
> Reorganize the Fuseki codebase to split the server engine classes from the
> webapp classes
> -
>
> Key: JENA-1585
> URL: https://issues.apache.org/jira/browse/JENA-1585
> Project: Apache Jena
> Issue Type: Improvement
> Components: Fuseki
>Affects Versions: Jena 3.8.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Minor
> Fix For: Jena 3.9.0
>
>
> This is a step towards separate packages for the fuseki server engine (the
> servlets, request routing, some Jetty related support code) and the webapp
> version of Fuseki that becomes the war and standalong jar in
> jena-fuseki-server.
> This first step is code reorganization with module jena-fuseki-core to put
> the webapp java code it separate packages to the rest of the engine.
> When split, the current jena-fuseki-core tests would go into
> jena-fuseki-weabpp because they test the full server. The non-UI embeddable
> server jena-fuseki-embedded and jena-fuseki-basic already gets test in the
> integration tests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1585) Reorganize the Fuseki codebase to split the server engine classes from the webapp classes
[ https://issues.apache.org/jira/browse/JENA-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569449#comment-16569449 ] ASF GitHub Bot commented on JENA-1585: -- Github user kinow commented on the issue: https://github.com/apache/jena/pull/456 Great stuff! Noticed a few misspellings, and also had a question about when to use the new `FusekiBuildLib`. But other than that looks great! Thanks for the new comments, and removing unnecessary code (e.g. that one that simply did a `return;`). :tada: I also realized that I submitted my review at the same time you updated the branch with more commits I think (at least I received an e-mail from GitHub right after that). So apologies if my comments are now out of sync. Thanks > Reorganize the Fuseki codebase to split the server engine classes from the > webapp classes > - > > Key: JENA-1585 > URL: https://issues.apache.org/jira/browse/JENA-1585 > Project: Apache Jena > Issue Type: Improvement > Components: Fuseki >Affects Versions: Jena 3.8.0 >Reporter: Andy Seaborne >Assignee: Andy Seaborne >Priority: Minor > Fix For: Jena 3.9.0 > > > This is a step towards separate packages for the fuseki server engine (the > servlets, request routing, some Jetty related support code) and the webapp > version of Fuseki that becomes the war and standalong jar in > jena-fuseki-server. > This first step is code reorganization with module jena-fuseki-core to put > the webapp java code it separate packages to the rest of the engine. > When split, the current jena-fuseki-core tests would go into > jena-fuseki-weabpp because they test the full server. The non-UI embeddable > server jena-fuseki-embedded and jena-fuseki-basic already gets test in the > integration tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1585) Reorganize the Fuseki codebase to split the server engine classes from the webapp classes
[
https://issues.apache.org/jira/browse/JENA-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569445#comment-16569445
]
ASF GitHub Bot commented on JENA-1585:
--
Github user kinow commented on a diff in the pull request:
https://github.com/apache/jena/pull/456#discussion_r207734465
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/build/FusekiBuildLib.java
---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.jena.fuseki.build;
+
+import org.apache.jena.fuseki.FusekiConfigException;
+import org.apache.jena.fuseki.webapp.SystemState;
+import org.apache.jena.query.* ;
+import org.apache.jena.rdf.model.Literal ;
+import org.apache.jena.rdf.model.Model ;
+import org.apache.jena.rdf.model.RDFNode ;
+import org.apache.jena.rdf.model.Resource ;
+import org.apache.jena.shared.PrefixMapping ;
+import org.apache.jena.vocabulary.RDFS ;
+
+public class FusekiBuildLib {
--- End diff --
Is `FusekiBuildLib` going to replace `FusekiLib`? Would it be worth a
one/two lines comment explaining what each one does? Just so one does not
create a method in one, while the method was supposed to be in the other
class...
From a quick peek at the new classes, I think `FusekiLib` is for methods
used by Fuseki server, and `FusekiBuildLib` is more for handling
nodes/resources. In which case maybe `FusekiLib#addDataInto` methods sit in
between, but maybe could be in `FusekiBuildLib` too?
> Reorganize the Fuseki codebase to split the server engine classes from the
> webapp classes
> -
>
> Key: JENA-1585
> URL: https://issues.apache.org/jira/browse/JENA-1585
> Project: Apache Jena
> Issue Type: Improvement
> Components: Fuseki
>Affects Versions: Jena 3.8.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Minor
> Fix For: Jena 3.9.0
>
>
> This is a step towards separate packages for the fuseki server engine (the
> servlets, request routing, some Jetty related support code) and the webapp
> version of Fuseki that becomes the war and standalong jar in
> jena-fuseki-server.
> This first step is code reorganization with module jena-fuseki-core to put
> the webapp java code it separate packages to the rest of the engine.
> When split, the current jena-fuseki-core tests would go into
> jena-fuseki-weabpp because they test the full server. The non-UI embeddable
> server jena-fuseki-embedded and jena-fuseki-basic already gets test in the
> integration tests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1585) Reorganize the Fuseki codebase to split the server engine classes from the webapp classes
[
https://issues.apache.org/jira/browse/JENA-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569444#comment-16569444
]
ASF GitHub Bot commented on JENA-1585:
--
Github user kinow commented on a diff in the pull request:
https://github.com/apache/jena/pull/456#discussion_r207734712
--- Diff:
jena-fuseki2/jena-fuseki-core/src/test/java/org/apache/jena/fuseki/package-info.java
---
@@ -16,38 +16,17 @@
* limitations under the License.
*/
-package org.apache.jena.fuseki.servlets;
-
-import java.io.* ;
-
/**
-* Code needed to implement an OutputStream that does nothing.
-*/
-
-
-public class NullOutputStream extends /*Filter*/OutputStream
-{
- public NullOutputStream()
- {
- }
-
- // The OutputStream operations
- @Override
-public void close() { /* .close() ;*/ }
- @Override
-public void flush() { /* .flush() ;*/ }
-
- // Need to implement this one.
- @Override
-public void write(int b) { /* .write(b) ;*/ }
- @Override
-public void write(byte b[]) { /* this.write(b, 0, b.length) ; */}
+ * This package has the Fuseki full server tests. ServerCtl manages a
full server for tetsing.
--- End diff --
s/tetsing/testing
> Reorganize the Fuseki codebase to split the server engine classes from the
> webapp classes
> -
>
> Key: JENA-1585
> URL: https://issues.apache.org/jira/browse/JENA-1585
> Project: Apache Jena
> Issue Type: Improvement
> Components: Fuseki
>Affects Versions: Jena 3.8.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Minor
> Fix For: Jena 3.9.0
>
>
> This is a step towards separate packages for the fuseki server engine (the
> servlets, request routing, some Jetty related support code) and the webapp
> version of Fuseki that becomes the war and standalong jar in
> jena-fuseki-server.
> This first step is code reorganization with module jena-fuseki-core to put
> the webapp java code it separate packages to the rest of the engine.
> When split, the current jena-fuseki-core tests would go into
> jena-fuseki-weabpp because they test the full server. The non-UI embeddable
> server jena-fuseki-embedded and jena-fuseki-basic already gets test in the
> integration tests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1585) Reorganize the Fuseki codebase to split the server engine classes from the webapp classes
[
https://issues.apache.org/jira/browse/JENA-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569446#comment-16569446
]
ASF GitHub Bot commented on JENA-1585:
--
Github user kinow commented on a diff in the pull request:
https://github.com/apache/jena/pull/456#discussion_r207734729
--- Diff:
jena-fuseki2/jena-fuseki-embedded/src/main/java/org/apache/jena/fuseki/embedded/FusekiServer.java
---
@@ -246,6 +248,13 @@ public Builder enableStats(boolean withStats) {
return this;
}
+/** Add the "/$/ping" servlet that responds to HTTP very
efficiently.
+ * This is useful for testign whether a server is alove, for
example, from a load balencer.
--- End diff --
s/testign/testing & s/balencer/balancer
> Reorganize the Fuseki codebase to split the server engine classes from the
> webapp classes
> -
>
> Key: JENA-1585
> URL: https://issues.apache.org/jira/browse/JENA-1585
> Project: Apache Jena
> Issue Type: Improvement
> Components: Fuseki
>Affects Versions: Jena 3.8.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Minor
> Fix For: Jena 3.9.0
>
>
> This is a step towards separate packages for the fuseki server engine (the
> servlets, request routing, some Jetty related support code) and the webapp
> version of Fuseki that becomes the war and standalong jar in
> jena-fuseki-server.
> This first step is code reorganization with module jena-fuseki-core to put
> the webapp java code it separate packages to the rest of the engine.
> When split, the current jena-fuseki-core tests would go into
> jena-fuseki-weabpp because they test the full server. The non-UI embeddable
> server jena-fuseki-embedded and jena-fuseki-basic already gets test in the
> integration tests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1585) Reorganize the Fuseki codebase to split the server engine classes from the webapp classes
[ https://issues.apache.org/jira/browse/JENA-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569441#comment-16569441 ] ASF GitHub Bot commented on JENA-1585: -- GitHub user afs opened a pull request: https://github.com/apache/jena/pull/456 JENA-1585: Fuseki core reorg Class reorganisation within the the jena-fuseki-core module. jena-fuseki-embedded and jena-fuseki-basic changes show the cleaner split - no mention of the webapp or mgt packages where the webapp code now resides. You can merge this pull request into a Git repository by running: $ git pull https://github.com/afs/jena fuseki-reorg Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/456.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #456 commit 1d41d2ce4975ebc34e8a4dd4ff67cf1100421856 Author: Andy Seaborne Date: 2018-08-04T20:56:23Z JENA-1585: Fuseki core reorg > Reorganize the Fuseki codebase to split the server engine classes from the > webapp classes > - > > Key: JENA-1585 > URL: https://issues.apache.org/jira/browse/JENA-1585 > Project: Apache Jena > Issue Type: Improvement > Components: Fuseki >Affects Versions: Jena 3.8.0 >Reporter: Andy Seaborne >Assignee: Andy Seaborne >Priority: Minor > Fix For: Jena 3.9.0 > > > This is a step towards separate packages for the fuseki server engine (the > servlets, request routing, some Jetty related support code) and the webapp > version of Fuseki that becomes the war and standalong jar in > jena-fuseki-server. > This first step is code reorganization with module jena-fuseki-core to put > the webapp java code it separate packages to the rest of the engine. > When split, the current jena-fuseki-core tests would go into > jena-fuseki-weabpp because they test the full server. The non-UI embeddable > server jena-fuseki-embedded and jena-fuseki-basic already gets test in the > integration tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
