[jira] [Commented] (JENA-1642) Schemagen configuration option "header" throws exception
[ https://issues.apache.org/jira/browse/JENA-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703519#comment-16703519 ] ASF subversion and git services commented on JENA-1642: --- Commit 8938fc9b353d2c815c306b787cbfe08a612e213a in jena's branch refs/heads/master from [~an...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=8938fc9 ] JENA-1642: Merge commit 'refs/pull/500/head' of https://github.com/apache/jena This closes #500. > Schemagen configuration option "header" throws exception > > > Key: JENA-1642 > URL: https://issues.apache.org/jira/browse/JENA-1642 > Project: Apache Jena > Issue Type: Bug > Components: Jena, Maven Tools >Affects Versions: Jena 3.6.0 >Reporter: Joseph Sarjeant >Priority: Minor > Original Estimate: 1h > Remaining Estimate: 1h > > When using Jena Schemagen from the maven plugin the configuration option for > `header` throws a `BadBooleanException`. Schemagen is checking for `isTrue` > for this option while the value specified is intended to be a String. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1642) Schemagen configuration option "header" throws exception
[ https://issues.apache.org/jira/browse/JENA-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703521#comment-16703521 ] ASF GitHub Bot commented on JENA-1642: -- Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/500 > Schemagen configuration option "header" throws exception > > > Key: JENA-1642 > URL: https://issues.apache.org/jira/browse/JENA-1642 > Project: Apache Jena > Issue Type: Bug > Components: Jena, Maven Tools >Affects Versions: Jena 3.6.0 >Reporter: Joseph Sarjeant >Priority: Minor > Original Estimate: 1h > Remaining Estimate: 1h > > When using Jena Schemagen from the maven plugin the configuration option for > `header` throws a `BadBooleanException`. Schemagen is checking for `isTrue` > for this option while the value specified is intended to be a String. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1642) Schemagen configuration option "header" throws exception
[ https://issues.apache.org/jira/browse/JENA-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703513#comment-16703513 ] ASF GitHub Bot commented on JENA-1642: -- Github user afs commented on the issue: https://github.com/apache/jena/pull/500 > it appears that the maven tools are no being built as part of the main project. Is that the case? Yes, I'm afraid it is. Some tests fail when used with Apache parent >19 (I just checked with v21 - this is still the case). ``` [ERROR] The following builds failed: [ERROR] * schemagen-integration-1/pom.xml [ERROR] * schemagen-integration-4/pom.xml [ERROR] * schemagen-integration-2/pom.xml [ERROR] * schemagen-integration-0/pom.xml [ERROR] * schemagen-integration-3/pom.xml ``` > Schemagen configuration option "header" throws exception > > > Key: JENA-1642 > URL: https://issues.apache.org/jira/browse/JENA-1642 > Project: Apache Jena > Issue Type: Bug > Components: Jena, Maven Tools >Affects Versions: Jena 3.6.0 >Reporter: Joseph Sarjeant >Priority: Minor > Original Estimate: 1h > Remaining Estimate: 1h > > When using Jena Schemagen from the maven plugin the configuration option for > `header` throws a `BadBooleanException`. Schemagen is checking for `isTrue` > for this option while the value specified is intended to be a String. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1642) Schemagen configuration option "header" throws exception
[ https://issues.apache.org/jira/browse/JENA-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700825#comment-16700825 ] ASF GitHub Bot commented on JENA-1642: -- GitHub user jsarjeant opened a pull request: https://github.com/apache/jena/pull/500 JENA-1642: Check has value for header instead of is true When using schemagen from the maven plugin the `header` option does not work. `header` is intended to be a template string and when `isTrue` is checked the string is cast to a boolean and the `BadBooleanException` is thrown. I believe we should check for existence here instead of "truthiness" Also, it appears that the maven tools are no being built as part of the main project. Is that the case? You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsarjeant/jena master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/500.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #500 commit 471d1f8511def353f1b64776c2a986d1e6d8ab45 Author: Joseph Sarjeant Date: 2018-11-27T18:08:43Z Check has value for header instead of is true > Schemagen configuration option "header" throws exception > > > Key: JENA-1642 > URL: https://issues.apache.org/jira/browse/JENA-1642 > Project: Apache Jena > Issue Type: Bug > Components: Jena, Maven Tools >Affects Versions: Jena 3.6.0 >Reporter: Joseph Sarjeant >Priority: Minor > Original Estimate: 1h > Remaining Estimate: 1h > > When using Jena Schemagen from the maven plugin the configuration option for > `header` throws a `BadBooleanException`. Schemagen is checking for `isTrue` > for this option while the value specified is intended to be a String. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
