[jira] [Commented] (JENA-588) TDBLoader does not throw exception when disk full
[ https://issues.apache.org/jira/browse/JENA-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825557#comment-13825557 ] Andy Seaborne commented on JENA-588: Thanks for the details - helpful to know its 32 and 64 bit. The IO paths inside TDB are different. The patch is added (as is the fix to stop any other exceptions getting swallowed). tdbloader should now stop on the first disk error regardless of which of several things goes wrong first. > TDBLoader does not throw exception when disk full > - > > Key: JENA-588 > URL: https://issues.apache.org/jira/browse/JENA-588 > Project: Apache Jena > Issue Type: Bug > Components: TDB >Affects Versions: Jena 2.10.0 >Reporter: Brian Caruso >Assignee: Andy Seaborne > Attachments: jena.diskFull.patch > > > When using tdbload a full disk does not cause the load to throw an exception > and exit. The process displays logging messages about the disk and then > continues to attempt to save the next triple. > To reproduce fill up a temporary file system, then load a large NT file. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (JENA-588) TDBLoader does not throw exception when disk full
[ https://issues.apache.org/jira/browse/JENA-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825514#comment-13825514 ] Brian Caruso commented on JENA-588: --- I've seen this on two machines, one a RHEL 64 and another Ubuntu 32. I tested the patch on both of these machines. RHEL 64bit: $ java -version java version "1.7.0_45" Java(TM) SE Runtime Environment (build 1.7.0_45-b18) Java HotSpot(TM) 64-Bit Server VM (build 24.45-b08, mixed mode) $ uname -a Linux 2.6.18-348.3.1.el5 #1 SMP Tue Mar 5 13:19:32 EST 2013 x86_64 x86_64 x86_64 GNU/Linux Ubuntu 32 bit: $ java -version java version "1.7.0_40" Java(TM) SE Runtime Environment (build 1.7.0_40-b43) $ uname -a Linux caruso-laptop 3.5.0-40-generic #62-Ubuntu SMP Thu Aug 22 00:57:36 UTC 2013 i686 i686 i686 GNU/Linux > TDBLoader does not throw exception when disk full > - > > Key: JENA-588 > URL: https://issues.apache.org/jira/browse/JENA-588 > Project: Apache Jena > Issue Type: Bug > Components: TDB >Affects Versions: Jena 2.10.0 >Reporter: Brian Caruso >Assignee: Andy Seaborne > Attachments: jena.diskFull.patch > > > When using tdbload a full disk does not cause the load to throw an exception > and exit. The process displays logging messages about the disk and then > continues to attempt to save the next triple. > To reproduce fill up a temporary file system, then load a large NT file. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (JENA-588) TDBLoader does not throw exception when disk full
[ https://issues.apache.org/jira/browse/JENA-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824424#comment-13824424 ] Hudson commented on JENA-588: - SUCCESS: Integrated in Jena_Development_Test #1042 (See [https://builds.apache.org/job/Jena_Development_Test/1042/]) JENA-588 : Don't catch and surpress exception. (andy: rev 1542241) * /jena/trunk/jena-tdb/src/main/java/com/hp/hpl/jena/tdb/store/bulkloader/LoaderNodeTupleTable.java > TDBLoader does not throw exception when disk full > - > > Key: JENA-588 > URL: https://issues.apache.org/jira/browse/JENA-588 > Project: Apache Jena > Issue Type: Bug > Components: TDB >Affects Versions: Jena 2.10.0 >Reporter: Brian Caruso >Assignee: Andy Seaborne > Attachments: jena.diskFull.patch > > > When using tdbload a full disk does not cause the load to throw an exception > and exit. The process displays logging messages about the disk and then > continues to attempt to save the next triple. > To reproduce fill up a temporary file system, then load a large NT file. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (JENA-588) TDBLoader does not throw exception when disk full
[ https://issues.apache.org/jira/browse/JENA-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823808#comment-13823808 ] Hudson commented on JENA-588: - SUCCESS: Integrated in Jena_Development_Test_ARM #25 (See [https://builds.apache.org/job/Jena_Development_Test_ARM/25/]) JENA-588 : Don't catch and surpress exception. (andy: rev 1542241) * /jena/trunk/jena-tdb/src/main/java/com/hp/hpl/jena/tdb/store/bulkloader/LoaderNodeTupleTable.java > TDBLoader does not throw exception when disk full > - > > Key: JENA-588 > URL: https://issues.apache.org/jira/browse/JENA-588 > Project: Apache Jena > Issue Type: Bug > Components: TDB >Affects Versions: Jena 2.10.0 >Reporter: Brian Caruso >Assignee: Andy Seaborne > Attachments: jena.diskFull.patch > > > When using tdbload a full disk does not cause the load to throw an exception > and exit. The process displays logging messages about the disk and then > continues to attempt to save the next triple. > To reproduce fill up a temporary file system, then load a large NT file. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (JENA-588) TDBLoader does not throw exception when disk full
[ https://issues.apache.org/jira/browse/JENA-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823589#comment-13823589 ] ASF subversion and git services commented on JENA-588: -- Commit 1542241 from [~andy.seaborne] in branch 'jena/trunk' [ https://svn.apache.org/r1542241 ] JENA-588 : Don't catch and surpress exception. > TDBLoader does not throw exception when disk full > - > > Key: JENA-588 > URL: https://issues.apache.org/jira/browse/JENA-588 > Project: Apache Jena > Issue Type: Bug > Components: TDB >Affects Versions: Jena 2.10.0 >Reporter: Brian Caruso > Attachments: jena.diskFull.patch > > > When using tdbload a full disk does not cause the load to throw an exception > and exit. The process displays logging messages about the disk and then > continues to attempt to save the next triple. > To reproduce fill up a temporary file system, then load a large NT file. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (JENA-588) TDBLoader does not throw exception when disk full
[
https://issues.apache.org/jira/browse/JENA-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823588#comment-13823588
]
Andy Seaborne commented on JENA-588:
Thanks.
Which OS and which Java (32 or 64 bit?) are you using? I get different errors
although I have found-and-fixed one related issue.
Looking at the code it comes down to this code in BufferChannelFile:
{noformat}
public int write(ByteBuffer buffer)
{
try { return file.channel().write(buffer) ; }
catch (IOException e) { IO.exception(e) ; return -1 ; }
}
{noformat}
and {{IO.exception(e)}} throws an exception, wrapping the IOException, and you
don't get to the {{return -1}}.
I get a different errors Immediate exit on 64 bit Java7. Using 32 bit file
mode,
I found a place where the exception was being silent discarded.
I tried on Ubuntu 13.04 with a tmpfs.
> TDBLoader does not throw exception when disk full
> -
>
> Key: JENA-588
> URL: https://issues.apache.org/jira/browse/JENA-588
> Project: Apache Jena
> Issue Type: Bug
> Components: TDB
>Affects Versions: Jena 2.10.0
>Reporter: Brian Caruso
> Attachments: jena.diskFull.patch
>
>
> When using tdbload a full disk does not cause the load to throw an exception
> and exit. The process displays logging messages about the disk and then
> continues to attempt to save the next triple.
> To reproduce fill up a temporary file system, then load a large NT file.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (JENA-588) TDBLoader does not throw exception when disk full
[ https://issues.apache.org/jira/browse/JENA-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822852#comment-13822852 ] Brian Caruso commented on JENA-588: --- Attached patch that will cause an exception to be thrown when disk is full. > TDBLoader does not throw exception when disk full > - > > Key: JENA-588 > URL: https://issues.apache.org/jira/browse/JENA-588 > Project: Apache Jena > Issue Type: Bug > Components: TDB >Affects Versions: Jena 2.10.0 >Reporter: Brian Caruso > Attachments: jena.diskFull.patch > > > When using tdbload a full disk does not cause the load to throw an exception > and exit. The process displays logging messages about the disk and then > continues to attempt to save the next triple. > To reproduce fill up a temporary file system, then load a large NT file. -- This message was sent by Atlassian JIRA (v6.1#6144)
