Hi Qihong,
Good start.
I've managed to build a system from pull request 89 including mvn
package and I've started adding comments to the github pull request.
(I used the .diff version of the PR for working -- there is a github bug
in .patch versions; deleted files are still here after git apply)
Importantly - I have managed to build the parser from scratch with
javacc 5.0 and the SPARQL 1.1 grammar is indeed not changed. Great!
javacc 6.0 also works - but it has a slight different whitespace layout
(in worse ways sometimes).
To get reviewing before the tests are added, I tried using arq.qparse,
a utility that parses and print queries. arq.qparse is useful in
development because it does some checking - it parses and prints the
input query, but also reparses the output. It calls `Query::hashCode`
and `Query::equals` on the parsed and reparsed versions and expected
them to match.
At the moment, the printed query does not match the input.
I'll add further comments to the PR as I have time.
Andy
On 22/07/15 08:26, Qihong Lin wrote:
Hi,
Please confirm the pull of the first half part work of the GSoC
project (JENA-491):
https://github.com/apache/jena/pull/88
Note that confidencesun/master firstly is updated/merged from
apache/master, and then merged from confidencesun/JENA-491. Now
apache/master can pull from confidencesun/master so that the JENA-491
functions can be applied.
If it's OK, I'll further deal with construct quad support of fuseki.
The code have done. I can merge them in the same way.
regards,
Qihong
