date:20160319

Re: Remaining Work before Release of 3.0

2016-03-19 Thread Philippe Mouawad

Hi sebb,
With the last commits and comments on the issues you mentioned,
can we consider that remaining work is the following:
- sort the columns of saved columns per english translation : you seem to
be handling it
- for the output of reports, check that if -o is not used the default
target folder is not overwritten if not empty. I propose to delay other
propositions to next 3.1 and wait for user feedback. I can take it unless
sebb you want to
- fix the NTLM auth issue with https: Felix can you confirm you will be
able to fix it in a not too big delay ?
- screenshots for all modified elements, volunteers ?
- new and noteworthy section, I can start it


We're now 1 year since we released 2.13, I think users are waiting this 3.0
.

I am as a user


Thanks
On Tuesday, March 15, 2016, Philippe Mouawad 
wrote:

>
>
> On Tue, Mar 15, 2016 at 9:45 PM, Felix Schumacher <
> felix.schumac...@internetallee.de
> >
> wrote:
>
>>
>>
>> Am 14. März 2016 21:58:50 MEZ, schrieb Philippe Mouawad <
>> philippe.moua...@gmail.com
>> >:
>> >On Monday, March 14, 2016, Felix Schumacher <
>> >felix.schumac...@internetallee.de
>> >
>> wrote:
>> >
>> >> Am 14.03.2016 um 21:34 schrieb Philippe Mouawad:
>> >>
>> >>> Hello,
>> >>> All remaining issues before 3.0 are now fixed.
>> >>>
>> >> https://issues.apache.org/jira/browse/HTTPCLIENT-1712
>> >> means that we can't do kerberos with https. Is this a big problem?
>> >
>> >
>> >are we able to workaround in jmeter the issue ?
>> >If not it would mean we have to wait for a 4.5.3
>> >
>> >It does not seem critical for me but I don't know
>>
>> We could work around it. We would have to subclass two classes.
>> SPnegoScheme and its factory.
>>
> Let's do that Felix if you think we need to fix it before 3.0.
>
>>
>> The problem is fixed in httpclients trunk, but I don't know when a next
>> release is planned.
>>
>
> 4.5.2 was just released, I doubt a new one will be released for such a bug
>
>
>>
>> Felix
>>
>> >
>> >>
>> >> Felix
>> >>
>> >>>
>> >>> Except for the documentation screenshots everything is ready for a
>> >>> release.
>> >>>
>> >>> When do we launch the release of 3.0 ?
>> >>>
>> >>> Regards
>> >>> Philippe
>> >>>
>> >>>
>> >>> On Fri, Mar 11, 2016 at 8:20 AM, Milamber > >
>> >wrote:
>> >>>
>> >>>
>>  On 08/03/2016 23:02, Philippe Mouawad wrote:
>> 
>>  @Milamber, do you intend to take into account before 3.0 release
>> >the
>> > notes
>> > from Benoit Wiart:
>> > -https://bz.apache.org/bugzilla/show_bug.cgi?id=58426
>> >
>> > Not before the 3.0.
>> 
>> 
>>  If not, I suggest we close this one and open a new one to complete
>> >HiDPI
>> > support in 3.1
>> >
>> > That seems a good idea.
>> 
>> 
>>  Milamber
>> 
>> 
>> >>>
>> >>>
>> >>
>>
>>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>
>
>

-- 
Cordialement.
Philippe Mouawad.

Re: Remaining Work before Release of 3.0

2016-03-19 Thread Felix Schumacher



Am 16. März 2016 20:16:22 MEZ, schrieb Philippe Mouawad 
:
>Hi sebb,
>With the last commits and comments on the issues you mentioned,
>can we consider that remaining work is the following:
>- sort the columns of saved columns per english translation : you seem
>to
>be handling it
>- for the output of reports, check that if -o is not used the default
>target folder is not overwritten if not empty. I propose to delay other
>propositions to next 3.1 and wait for user feedback. I can take it
>unless
>sebb you want to
>- fix the NTLM auth issue with https: Felix can you confirm you will be
>able to fix it in a not too big delay ?

It's kerberos and I can do it probably tonight. 

Felix

>- screenshots for all modified elements, volunteers ?
>- new and noteworthy section, I can start it
>
>
>We're now 1 year since we released 2.13, I think users are waiting this
>3.0
>.
>
>I am as a user
>
>
>Thanks
>On Tuesday, March 15, 2016, Philippe Mouawad
>
>wrote:
>
>>
>>
>> On Tue, Mar 15, 2016 at 9:45 PM, Felix Schumacher <
>> felix.schumac...@internetallee.de
>> >
>> wrote:
>>
>>>
>>>
>>> Am 14. März 2016 21:58:50 MEZ, schrieb Philippe Mouawad <
>>> philippe.moua...@gmail.com
>>> >:
>>> >On Monday, March 14, 2016, Felix Schumacher <
>>> >felix.schumac...@internetallee.de
>>> >
>>> wrote:
>>> >
>>> >> Am 14.03.2016 um 21:34 schrieb Philippe Mouawad:
>>> >>
>>> >>> Hello,
>>> >>> All remaining issues before 3.0 are now fixed.
>>> >>>
>>> >> https://issues.apache.org/jira/browse/HTTPCLIENT-1712
>>> >> means that we can't do kerberos with https. Is this a big
>problem?
>>> >
>>> >
>>> >are we able to workaround in jmeter the issue ?
>>> >If not it would mean we have to wait for a 4.5.3
>>> >
>>> >It does not seem critical for me but I don't know
>>>
>>> We could work around it. We would have to subclass two classes.
>>> SPnegoScheme and its factory.
>>>
>> Let's do that Felix if you think we need to fix it before 3.0.
>>
>>>
>>> The problem is fixed in httpclients trunk, but I don't know when a
>next
>>> release is planned.
>>>
>>
>> 4.5.2 was just released, I doubt a new one will be released for such
>a bug
>>
>>
>>>
>>> Felix
>>>
>>> >
>>> >>
>>> >> Felix
>>> >>
>>> >>>
>>> >>> Except for the documentation screenshots everything is ready for
>a
>>> >>> release.
>>> >>>
>>> >>> When do we launch the release of 3.0 ?
>>> >>>
>>> >>> Regards
>>> >>> Philippe
>>> >>>
>>> >>>
>>> >>> On Fri, Mar 11, 2016 at 8:20 AM, Milamber >> >
>>> >wrote:
>>> >>>
>>> >>>
>>>  On 08/03/2016 23:02, Philippe Mouawad wrote:
>>> 
>>>  @Milamber, do you intend to take into account before 3.0
>release
>>> >the
>>> > notes
>>> > from Benoit Wiart:
>>> > -https://bz.apache.org/bugzilla/show_bug.cgi?id=58426
>>> >
>>> > Not before the 3.0.
>>> 
>>> 
>>>  If not, I suggest we close this one and open a new one to
>complete
>>> >HiDPI
>>> > support in 3.1
>>> >
>>> > That seems a good idea.
>>> 
>>> 
>>>  Milamber
>>> 
>>> 
>>> >>>
>>> >>>
>>> >>
>>>
>>>
>>
>>
>> --
>> Cordialement.
>> Philippe Mouawad.
>>
>>
>>

Re: [GitHub] jmeter pull request: java constants naming

2016-03-19 Thread Vladimir Sitnikov

Philippe>1/ I think you should put yourself at the place of the
contributor here.
Philippe>Why not say hello, thanks before discussing ?

You are right. That makes sense.

Philippe>2/ Discussion is great but In my opinion, discussion on the naming of a
Philippe>static variable contributed by somebody who followed the way we do it
Philippe>currently which conforms to standards is a bit too much.

Even though contributions like PR171 are important, it is still required
to review them.
As current style might be not that well defined (== the way "we do it
currently" is not defined), it might make sense to define the style,
make sure PR conforms to it and then proceed with merge.

Philippe>Let's open if you want, a thread called 'Checkstyle rules in
JMeter' and

I think it is better to add/enable/alter rules incrementally as required.
PR171 touches static finals. It is way easier to agree on the particular rule
here, apply/enable the rule and merge the PR in.

Vladimir

[GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

2016-03-19 Thread vlsi

Github user vlsi commented on a diff in the pull request:

https://github.com/apache/jmeter/pull/167#discussion_r56486961
  
--- Diff: src/core/org/apache/jmeter/services/FileServer.java ---
@@ -428,7 +431,7 @@ private BufferedReader createBufferedReader(FileEntry 
fileEntry) throws IOExcept
 isr = new InputStreamReader(fis);
 }
 return new BufferedReader(isr);
-}
+}
--- End diff --

Would you avoid adding extra spaces?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] jmeter pull request: java constants naming

2016-03-19 Thread Philippe Mouawad

Hi Vladimir,

1/ I think you should put yourself at the place of the contributor here.
Why not say hello, thanks before discussing ?

My note is about the first reaction by sebb here and the reply on another
PR by same contributor the same day:

   - https://bz.apache.org/bugzilla/show_bug.cgi?id=59197#c2

For recap:
https://www.apache.org/foundation/policies/conduct.html

   1.

   *Be empathetic
   ,
   welcoming, friendly, and patient.* We work together to resolve conflict,
   assume good intentions, and do our best to act in an empathetic fashion. We
   may all experience some frustration from time to time, but we do not allow
   frustration to turn into a personal attack. A community where people feel
   uncomfortable or threatened is not a productive one. We should be
   respectful when dealing with other community members as well as with people
   outside our community.

2/ Discussion is great but In my opinion, discussion on the naming of a
static variable contributed by somebody who followed the way we do it
currently which conforms to standards is a bit too much.
Let's open if you want, a thread called 'Checkstyle rules in JMeter' and
discuss there.

3/ +1 for checkstyle rules, this way we will stop discussing this and
concentrate on all other subjects.

Regards
Philippe

On Friday, March 18, 2016, Vladimir Sitnikov 
wrote:

> Philippe>- LOG (Upper Case) for static is the usual policy that is
> applied by all
> Philippe>   of us since few time
>
> In my opinion, log/logger is better treated as exception from "static
> final upper case" policy.
> It is used more often than other kind of static finals => it might
> deserve some exceptional casing rule.
>
> Philippe>  - and if we don't like it, why just not merge it and rename
> the
> Philippe>  variable ?
>
> I think we'd better agree on the style first, then merge.
> "log vs LOG vs LOGGER" might indeed be important, as it is better to
> follow the same style everywhere.
>
> Philippe> why just not merge
>
> It makes sense to activate relevant checkstyle rule, so invalid names
> could no longer get in.
>
> Philippe>do you think this kind of big discussion for a Variable
> naming without a
>
> I does not look like a big discussion yet.
> We are just solving one of the two hard things in Computer Science (see
> [1])
>
> [1] http://martinfowler.com/bliki/TwoHardThings.html
>
> Vladimir
>

Re: svn commit: r1735407 - in /jmeter/trunk: build.properties build.xml eclipse.classpath lib/ lib/aareadme.txt res/maven/ApacheJMeter_parent.pom xdocs/changes.xml

2016-03-19 Thread Philippe Mouawad

But accessors-smart is part of json-smart:
https://github.com/netplex/json-smart-v2

Do I need to add a file for accessort-smart ?

This is becoming a bit cumbersome each time we change a version

On Thu, Mar 17, 2016 at 8:24 PM, sebb  wrote:

> All 3rd party jars need to be mentioned in LICENSE.txt even if they use
> AL2.0
>
> On 17 March 2016 at 19:22, Philippe Mouawad 
> wrote:
> > Done
> >
> > On Thu, Mar 17, 2016 at 4:56 PM, sebb  wrote:
> >
> >> This is a new 3rd party jar.
> >> The license needs to be checked for compatibility and if OK must be
> >> documented in LICENSE - and stored locally if it is not AL 2.0
> >>
> >>
> >> On 17 March 2016 at 12:14,   wrote:
> >> > Author: pmouawad
> >> > Date: Thu Mar 17 12:14:44 2016
> >> > New Revision: 1735407
> >> >
> >> > URL: http://svn.apache.org/viewvc?rev=1735407=rev
> >> > Log:
> >> > Bug 59187 - JSON Post Processor : java.lang.NoClassDefFoundError:
> >> net/minidev/asm/FieldFilter at
> >> net.minidev.json.reader.JsonWriter.(JsonWriter.java:157) (affects
> nightly
> >> build before 3.0 release)
> >> > Bugzilla Id: 59187
> >> >
> >> > Modified:
> >> > jmeter/trunk/build.properties
> >> > jmeter/trunk/build.xml
> >> > jmeter/trunk/eclipse.classpath
> >> > jmeter/trunk/lib/   (props changed)
> >> > jmeter/trunk/lib/aareadme.txt
> >> > jmeter/trunk/res/maven/ApacheJMeter_parent.pom
> >> > jmeter/trunk/xdocs/changes.xml
> >> >
> >> > Modified: jmeter/trunk/build.properties
> >> > URL:
> >>
> http://svn.apache.org/viewvc/jmeter/trunk/build.properties?rev=1735407=1735406=1735407=diff
> >> >
> >>
> ==
> >> > --- jmeter/trunk/build.properties (original)
> >> > +++ jmeter/trunk/build.properties Thu Mar 17 12:14:44 2016
> >> > @@ -42,11 +42,21 @@
> >> >
> >> >  maven2.repo = https://repo1.maven.org/maven2
> >> >
> >> > +accessors-smart.version = 1.1
> >> > +accessors-smart.jar =
> >> accessors-smart-${accessors-smart.version}.jar
> >> > +accessors-smart.loc =
> >> ${maven2.repo}/net/minidev/accessors-smart/${accessors-smart.version}
> >> > +accessors-smart.md5 = b75cda0d7dadff9e6c20f4e7f3c3bc82
> >> > +
> >> >  apache-bsf.version  = 2.4.0
> >> >  apache-bsf.jar  = bsf-${apache-bsf.version}.jar
> >> >  apache-bsf.loc  =
> >> ${maven2.repo}/bsf/bsf/${apache-bsf.version}
> >> >  apache-bsf.md5  = 16e82d858c648962fb5c959f21959039
> >> >
> >> > +asm.version = 5.1
> >> > +asm.jar = asm-${asm.version}.jar
> >> > +asm.loc =
> >> ${maven2.repo}/org/ow2/asm/asm/${asm.version}
> >> > +asm.md5 = 3770466405f163d6616b65c32e16a3cd
> >> > +
> >> >  avalon-framework.version= 4.1.4
> >> >  avalon-framework.jar=
> >> avalon-framework-${avalon-framework.version}.jar
> >> >  avalon-framework.loc=
> >>
> ${maven2.repo}/avalon-framework/avalon-framework/${avalon-framework.version}
> >> >
> >> > Modified: jmeter/trunk/build.xml
> >> > URL:
> >>
> http://svn.apache.org/viewvc/jmeter/trunk/build.xml?rev=1735407=1735406=1735407=diff
> >> >
> >>
> ==
> >> > --- jmeter/trunk/build.xml (original)
> >> > +++ jmeter/trunk/build.xml Thu Mar 17 12:14:44 2016
> >> > @@ -360,7 +360,9 @@
> >> >
> >> >
> >> >
> >> > +   
> >> >  
> >> > +
> >> >  
> >> >  
> >> >  
> >> > @@ -432,7 +434,9 @@
> >> >
> >> >
> >> >  
> >> > +   
> >> >  
> >> > +
> >> >  
> >> >  
> >> >  
> >> > @@ -2848,7 +2852,9 @@ run JMeter unless all the JMeter jars ar
> >> >  conditional execution (it would be a lot easier if antcall
> >> supported if/unless).
> >> >  -->
> >> >  
> >> > -
> >> > +
> >> > +   
> >> > +
> >> >  
> >> >  
> >> >  
> >> >
> >> > Modified: jmeter/trunk/eclipse.classpath
> >> > URL:
> >>
> http://svn.apache.org/viewvc/jmeter/trunk/eclipse.classpath?rev=1735407=1735406=1735407=diff
> >> >
> >>
> ==
> >> > --- jmeter/trunk/eclipse.classpath (original)
> >> > +++ jmeter/trunk/eclipse.classpath Thu Mar 17 12:14:44 2016
> >> > @@ -43,6 +43,8 @@
> >> >  >> path="src/protocol/native"/>
> >> >  >> path="src/protocol/tcp"/>
> >> >  path="test/src"/>
> >> > +
> >> > +
> >> >  >> path="lib/avalon-framework-4.1.4.jar"/>
> >> > 
> >> > 
> >> >
> >> > Propchange: jmeter/trunk/lib/
> >> >
> >>
> --
> >> > --- svn:ignore (original)
> >> > +++ svn:ignore Thu Mar 17 12:14:44 2016
> >> > @@ -1,5 +1,7 @@
> >> >  ext
> >> >  src
> >> >

[GitHub] jmeter pull request: Bug 59197 : it should be possible to only run...

2016-03-19 Thread benbenw

GitHub user benbenw opened a pull request:

https://github.com/apache/jmeter/pull/170

Bug 59197 : it should be possible to only run a single threadgroup or a 
selection of threadgroups.

Right click on the TG and choose Start or Start no pauses

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/benbenw/jmeter runtg

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/170.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #170






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

2016-03-19 Thread Antonio Gomes Rodrigues

Hi,


Modification made and new commit provided

Do we have a checkstyle configuration or something like that to avoid waste
time (your time and mine) in how to code to JMeter?

Antonio

Cet e-mail a été envoyé depuis un ordinateur protégé par Avast.
www.avast.com

<#DDB4FAA8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

2016-03-17 12:02 GMT+01:00 vlsi :

> Github user vlsi commented on a diff in the pull request:
>
> https://github.com/apache/jmeter/pull/167#discussion_r56486961
>
> --- Diff: src/core/org/apache/jmeter/services/FileServer.java ---
> @@ -428,7 +431,7 @@ private BufferedReader
> createBufferedReader(FileEntry fileEntry) throws IOExcept
>  isr = new InputStreamReader(fis);
>  }
>  return new BufferedReader(isr);
> -}
> +}
> --- End diff --
>
> Would you avoid adding extra spaces?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

Re: [GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

2016-03-19 Thread Vladimir Sitnikov

Antonio>Do we have a checkstyle configuration or something like that
to avoid waste
Antonio>time (your time and mine) in how to code to JMeter?

There's a checkstyle (it is run as a part of Travis job), however it
would never check 100% of the issues.
My "else branch swap" request was just to make sure the diff does not
bring unintentional modifications.

By the way, have you seen that Travis job fails? Any chances your fix that?

Vladimir

Re: [GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

2016-03-19 Thread Antonio Gomes Rodrigues

Hi,

Unitary tests fixed

Antonio

Cet e-mail a été envoyé depuis un ordinateur protégé par Avast.
www.avast.com

<#DDB4FAA8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

2016-03-17 12:38 GMT+01:00 sebb :

> On 17 March 2016 at 11:20, Antonio Gomes Rodrigues 
> wrote:
> > I will fix the unit test asap
> >
> > Can you provide the checkstyle configuration to run it in local before
> > commit the change?
>
> It's in SVN.
>
> But as already noted it does not catch everything.
>
> The best is to follow the layout convention for the file that you are
> working on.
> This may vary between files (and certainly does for source file types).
>
> > Antonio
> >
> > Cet e-mail a été envoyé depuis un ordinateur protégé par Avast.
> > www.avast.com
> > <
> https://www.avast.com/fr-fr/lp-esg-fav?utm_medium=email_source=link_campaign=sig-email_content=webmail_term=OA-2109-B
> >
> > <#DDB4FAA8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
> >
> > 2016-03-17 12:15 GMT+01:00 Vladimir Sitnikov <
> sitnikov.vladi...@gmail.com>:
> >
> >> Antonio>Do we have a checkstyle configuration or something like that
> >> to avoid waste
> >> Antonio>time (your time and mine) in how to code to JMeter?
> >>
> >> There's a checkstyle (it is run as a part of Travis job), however it
> >> would never check 100% of the issues.
> >> My "else branch swap" request was just to make sure the diff does not
> >> bring unintentional modifications.
> >>
> >> By the way, have you seen that Travis job fails? Any chances your fix
> that?
> >>
> >> Vladimir
> >>
>

Re: [GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

2016-03-19 Thread Antonio Gomes Rodrigues

Hi,

Thanks to the feedback

check exists() is not necessary

canRead

public boolean canRead()

Tests whether the application can read the file denoted by this abstract
pathname.
Returns:true if and only if the file specified by this abstract pathname
exists *and* can be read by the application; false otherwise


New commit with exists() removed and else removed


Antonio




Cet e-mail a été envoyé depuis un ordinateur protégé par Avast.
www.avast.com

<#4184246894694592853_DDB4FAA8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

2016-03-17 10:54 GMT+01:00 sebb :

> On 17 March 2016 at 07:39, vlsi  wrote:
> > Github user vlsi commented on a diff in the pull request:
> >
> > https://github.com/apache/jmeter/pull/167#discussion_r56465359
> >
> > --- Diff: src/core/org/apache/jmeter/services/FileServer.java ---
> > @@ -418,16 +418,20 @@ private BufferedReader getReader(String alias,
> boolean recycle, boolean firstLin
> >  }
> >
> >  private BufferedReader createBufferedReader(FileEntry
> fileEntry) throws IOException {
> > -FileInputStream fis = new FileInputStream(fileEntry.file);
> > -InputStreamReader isr = null;
> > -// If file encoding is specified, read using that encoding,
> otherwise use default platform encoding
> > -String charsetName = fileEntry.charSetEncoding;
> > -if(!JOrphanUtils.isBlank(charsetName)) {
> > -isr = new InputStreamReader(fis, charsetName);
> > +if (!fileEntry.file.exists() || !fileEntry.file.canRead()
> || !fileEntry.file.isFile()) {
>
> Surely there's no need to check exists() if you check canRead()?
>
> > +throw new IllegalArgumentException("File "+
> fileEntry.file.getName()+ " must exist and be readable");
> >  } else {
> > --- End diff --
> >
> > Please remove `else` and the following braces.
> > It would avoid indenting the following code.
> >
> >
> > ---
> > If your project is set up for it, you can reply to this email and have
> your
> > reply appear on GitHub as well. If your project does not have this
> feature
> > enabled and wishes so, or if the feature is enabled but not working,
> please
> > contact infrastructure at infrastruct...@apache.org or file a JIRA
> ticket
> > with INFRA.
> > ---
>

Re: [GitHub] jmeter pull request: java constants naming

2016-03-19 Thread Vladimir Sitnikov

Philippe> No strong opinion on this:

What's your opinion on "log"?

Vladimir

buildbot failure in on jmeter-trunk

2016-03-19 Thread buildbot

The Buildbot has detected a new failure on builder jmeter-trunk while building 
. Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/853

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: hemera_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit' 
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1735574
Blamelist: fschumacher

BUILD FAILED: failed shell_2 shell_3

Sincerely,
 -The Buildbot

Re: [GitHub] jmeter pull request: java constants naming

2016-03-19 Thread sebb

On 18 March 2016 at 17:55, Vladimir Sitnikov
 wrote:
>>Why change log to LOGGER?
>>It would make more sense to change it to LOG
>
> Frankly speaking, I think lowercase log is just perfect.
> What is the purpose of making LOG shout at you?
>
> Isn't log.info(...) self-descriptive enough?

Good point.
[But if it is to be changed, it should be just upcased.]

On reflection I agree with you that it makes sense to leave "log" as lower-case.

For the other constants, using the conventional upper-case is generally helpful.

> Vladimir

[GitHub] jmeter pull request: Bug59190_BetterProxyExcludesSuggestedCaseSens...

2016-03-19 Thread ra0077

GitHub user ra0077 opened a pull request:

https://github.com/apache/jmeter/pull/169

Bug59190_BetterProxyExcludesSuggestedCaseSensitive

Hi,

I have modified the suggested excludes to be no case sensitive like in
Templates

Antonio

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ra0077/jmeter 
Bug59190_BetterProxyExcludesSuggestedCaseSensitive

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/169.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #169


commit f1dd3030f3d5d84651cb6544e7281f80e0be180a
Author: ra0077 
Date:   2016-03-17T14:05:51Z

Bug59190_BetterProxyExcludesSuggestedCaseSensitive

Hi,

I have modified the suggested excludes to be no case sensitive like in
Templates

Antonio




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request: Bug 59197 : it should be possible to only run...

2016-03-19 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/170


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] jmeter pull request: java constants naming

2016-03-19 Thread Philippe Mouawad

On Fri, Mar 18, 2016 at 9:20 PM, Vladimir Sitnikov <
sitnikov.vladi...@gmail.com> wrote:

> Philippe>1/ I think you should put yourself at the place of the
> contributor here.
> Philippe>Why not say hello, thanks before discussing ?
>
> You are right. That makes sense.
>
> Philippe>2/ Discussion is great but In my opinion, discussion on the
> naming of a
> Philippe>static variable contributed by somebody who followed the way we
> do it
> Philippe>currently which conforms to standards is a bit too much.
>
> Even though contributions like PR171 are important, it is still required
> to review them.
> As current style might be not that well defined (== the way "we do it
> currently" is not defined), it might make sense to define the style,
> make sure PR conforms to it and then proceed with merge.
>

Ok but let's not discourage contributor.
It is up to us once we have defined the style to merge the PR and change
the naming.



>
> Philippe>Let's open if you want, a thread called 'Checkstyle rules in
> JMeter' and
>
> I think it is better to add/enable/alter rules incrementally as required.
> PR171 touches static finals. It is way easier to agree on the particular
> rule
> here, apply/enable the rule and merge the PR in.
>

No strong opinion on this:
- LOG is okay for me
- LOGGER is okay for me


>
> Vladimir
>



-- 
Cordialement.
Philippe Mouawad.

Re: Management of Redirect and rfc7231

2016-03-19 Thread sebb

Ideally JMeter should delegate the redirect decision to the HTTP library.

However this may not be possible for all libraries.

On 17 March 2016 at 20:46, Philippe Mouawad  wrote:
> +1 for this change
>
> @all thoughts ?
>
> On Thu, Mar 17, 2016 at 4:15 PM, UBIK LOAD PACK Support <
> supp...@ubikloadpack.com> wrote:
>
>> Hello Team,
>> Is JMeter 3.0 supposed to support :
>>
>>- https://tools.ietf.org/html/rfc7231
>>
>>
>> 1/ If so there may be an issue in support of Redirect:
>>
>>- https://tools.ietf.org/html/rfc7231#section-6.4
>>
>>
>> Currently only Head is considered as Safe:
>>
>>-
>>
>> https://github.com/apache/jmeter/blob/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java#L1504
>>
>>
>> But as per https://tools.ietf.org/html/rfc7231#section-4.2.1:
>>
>> GET, HEAD, OPTIONS, and TRACE methods are defined to be safe.
>>
>>
>> So if JMeter is supposed to respect rfc7231, this should be fixed.
>>
>> 2/ Besides, as per https://tools.ietf.org/html/rfc7231#section-6.4.7, 307
>> redirect code does not allow to change the initial method , so 307 redirect
>> code should be managed differently
>>
>>
>> We can create a PR to fix this.
>>
>> Thanks
>>
>> Regards
>> UbikLoadPack Support Team
>>
>
>
>
> --
> Cordialement.
> Philippe Mouawad.

[GitHub] jmeter pull request: java constants naming

2016-03-19 Thread vlsi

Github user vlsi commented on the pull request:

https://github.com/apache/jmeter/pull/171#issuecomment-198529464
  
@benbenw , thanks for bringing this up.
Can you please enable relevant checkstyle rule so it would capture 
non-capital static finals violations in the future?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

2016-03-19 Thread sebb

On 17 March 2016 at 07:39, vlsi  wrote:
> Github user vlsi commented on a diff in the pull request:
>
> https://github.com/apache/jmeter/pull/167#discussion_r56465359
>
> --- Diff: src/core/org/apache/jmeter/services/FileServer.java ---
> @@ -418,16 +418,20 @@ private BufferedReader getReader(String alias, 
> boolean recycle, boolean firstLin
>  }
>
>  private BufferedReader createBufferedReader(FileEntry fileEntry) 
> throws IOException {
> -FileInputStream fis = new FileInputStream(fileEntry.file);
> -InputStreamReader isr = null;
> -// If file encoding is specified, read using that encoding, 
> otherwise use default platform encoding
> -String charsetName = fileEntry.charSetEncoding;
> -if(!JOrphanUtils.isBlank(charsetName)) {
> -isr = new InputStreamReader(fis, charsetName);
> +if (!fileEntry.file.exists() || !fileEntry.file.canRead() || 
> !fileEntry.file.isFile()) {

Surely there's no need to check exists() if you check canRead()?

> +throw new IllegalArgumentException("File "+ 
> fileEntry.file.getName()+ " must exist and be readable");
>  } else {
> --- End diff --
>
> Please remove `else` and the following braces.
> It would avoid indenting the following code.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---

[GitHub] jmeter pull request: Force JSONPATH to always return list of Objec...

2016-03-19 Thread max3163

Github user max3163 commented on the pull request:

https://github.com/apache/jmeter/pull/168#issuecomment-19667
  
First of all, In the present state of JMeter I can't use the the JSON-PATH 
post-processor : 
This error happen :

2016/03/17 09:53:18 ERROR - jmeter.threads.JMeterThread: Test failed! 
java.lang.NoClassDefFoundError: net/minidev/asm/FieldFilter
at net.minidev.json.reader.JsonWriter.(JsonWriter.java:157)

I had to add 2 jars "accessors-smart-1.1.jar" and "asm-5.0.3.jar" 

See below one example of my problem, solve by my PR : 

Consider the result of a rest call like this : 

{"tokenId":"1458205185" ,"passwordStatus":"OK , "code" : 200}

My post processor is : 

Variable : tokenId
Expression : $.tokenId
Match count : 1
Default : NOT_FOUND

I have this error on the log : 

2016/03/17 09:59:26 ERROR - 
jmeter.extractor.json.jsonpath.JSONPostProcessor: Error processing JSON content 
in Extracteur JSON-PATH - tokenId, message:java.lang.String cannot be cast to 
java.util.List 
2016/03/17 09:59:26 ERROR - 
jmeter.extractor.json.jsonpath.JSONPostProcessor: Error processing JSON content 
in Extracteur JSON-PATH - passwordStatus, message:java.lang.String cannot be 
cast to java.util.List 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] jmeter pull request: java constants naming

2016-03-19 Thread Vladimir Sitnikov

>Why change log to LOGGER?
>It would make more sense to change it to LOG

Frankly speaking, I think lowercase log is just perfect.
What is the purpose of making LOG shout at you?

Isn't log.info(...) self-descriptive enough?

Vladimir

Re: Management of Redirect and rfc7231

2016-03-19 Thread Philippe Mouawad

Well, httpclient 4.5.2 supports Rfc 2616
Only httpclient 5.0 will support Rfc 7230

So for now we will stick to the current behaviour.

When switching to 5.0 we will reconsider this.

Thanks for reporting

On Friday, March 18, 2016, sebb  wrote:

> Not sure what you mean by that.
>
> JMeter should use whatever the HTTP library provides.
>
> On 17 March 2016 at 21:43, Philippe Mouawad  > wrote:
> > Ok sebb, but what about the target rfc we want to support ?
> > Thanks
> >
> > On Thu, Mar 17, 2016 at 9:54 PM, sebb >
> wrote:
> >
> >> Ideally JMeter should delegate the redirect decision to the HTTP
> library.
> >>
> >> However this may not be possible for all libraries.
> >>
> >> On 17 March 2016 at 20:46, Philippe Mouawad  >
> >> wrote:
> >> > +1 for this change
> >> >
> >> > @all thoughts ?
> >> >
> >> > On Thu, Mar 17, 2016 at 4:15 PM, UBIK LOAD PACK Support <
> >> > supp...@ubikloadpack.com > wrote:
> >> >
> >> >> Hello Team,
> >> >> Is JMeter 3.0 supposed to support :
> >> >>
> >> >>- https://tools.ietf.org/html/rfc7231
> >> >>
> >> >>
> >> >> 1/ If so there may be an issue in support of Redirect:
> >> >>
> >> >>- https://tools.ietf.org/html/rfc7231#section-6.4
> >> >>
> >> >>
> >> >> Currently only Head is considered as Safe:
> >> >>
> >> >>-
> >> >>
> >>
> https://github.com/apache/jmeter/blob/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java#L1504
> >> >>
> >> >>
> >> >> But as per https://tools.ietf.org/html/rfc7231#section-4.2.1:
> >> >>
> >> >> GET, HEAD, OPTIONS, and TRACE methods are defined to be safe.
> >> >>
> >> >>
> >> >> So if JMeter is supposed to respect rfc7231, this should be fixed.
> >> >>
> >> >> 2/ Besides, as per https://tools.ietf.org/html/rfc7231#section-6.4.7
> ,
> >> 307
> >> >> redirect code does not allow to change the initial method , so 307
> >> redirect
> >> >> code should be managed differently
> >> >>
> >> >>
> >> >> We can create a PR to fix this.
> >> >>
> >> >> Thanks
> >> >>
> >> >> Regards
> >> >> UbikLoadPack Support Team
> >> >>
> >> >
> >> >
> >> >
> >> > --
> >> > Cordialement.
> >> > Philippe Mouawad.
> >>
> >
> >
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
>


-- 
Cordialement.
Philippe Mouawad.

Re: [GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

2016-03-19 Thread Antonio Gomes Rodrigues

I will fix the unit test asap

Can you provide the checkstyle configuration to run it in local before
commit the change?

Antonio

Cet e-mail a été envoyé depuis un ordinateur protégé par Avast.
www.avast.com

<#DDB4FAA8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

2016-03-17 12:15 GMT+01:00 Vladimir Sitnikov :

> Antonio>Do we have a checkstyle configuration or something like that
> to avoid waste
> Antonio>time (your time and mine) in how to code to JMeter?
>
> There's a checkstyle (it is run as a part of Travis job), however it
> would never check 100% of the issues.
> My "else branch swap" request was just to make sure the diff does not
> bring unintentional modifications.
>
> By the way, have you seen that Travis job fails? Any chances your fix that?
>
> Vladimir
>

Re: [GitHub] jmeter pull request: java constants naming

2016-03-19 Thread sebb

On 18 March 2016 at 16:44, benbenw  wrote:
> GitHub user benbenw opened a pull request:
>
> https://github.com/apache/jmeter/pull/171
>
> java constants naming
>
>
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/benbenw/jmeter javanaming
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/jmeter/pull/171.patch

Why change log to LOGGER?
It would make more sense to change it to LOG

> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #171
>
> 
> commit 2c291a3547387a43ecaed2aa926fef045d6f263d
> Author: benoit 
> Date:   2016-03-18T16:37:13Z
>
> java constants naming
>
> 
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---

Re: Deprecate Java Implementation in HTTP Request before dropping it in N+2 version ?

2016-03-19 Thread Philippe Mouawad

Hello,
Any thoughts on this one ?

Some additional reasons:

   - What is the RFC supported ? With HttpClient we support RFC2616, which
   one do we support with Java when we delegate Redirection management to it ?

Thanks

On Sun, Mar 6, 2016 at 12:30 PM, Antonio Gomes Rodrigues 
wrote:

> Hi,
>
> I never have to use Java implementation
>
> If HC3 and Java implementation are deprecated it will be great to remove it
> from GUI (and use only the propertie in jmeter.propertie)
>
> It will allow to:
> Don't disturb new comers with this choice
> Simplify the GUI
> Don't disturb user who don't care before
> Advanded user who have the need of it have still the choice (in the
> propertie file) before the remove of the feature
>
> Antonio
>
> 2016-03-05 0:45 GMT+01:00 Philippe Mouawad :
>
> > Hello,
> > What do you think of dropping Java Implementation in 3.1 version ?
> >
> > I see many issues in keeping it:
> >
> >- More work to maintain Http Request
> >- Algorithm complexity to handle this additional implementation
> >- The implementation is very limited compared to HC4 (it appears only
> >GET/POST/PUT are supported in our implementation)
> >- Features of HttpHC4Implementation are not supported, so it can be
> >disturbing when you switch between implementation that you lose some
> >feature:
> >   - It does not support the following methods: COPY, LOCK, MKCOL,
> MOVE,
> >   PATCH, PROPFIND, PROPPATCH, UNLOCK, REPORT, MKCALENDAR.
> >   - It does not support Kerberos Auth
> >   - https.use.cached.ssl.context
> >   - There is no control over how connections are re-used. When a
> >   connection is released by JMeter, it may or may not be re-used
> > by the same
> >   thread.
> >   - The API is best suited to single-threaded usage - various
> settings
> >   are defined via system properties, and therefore apply to all
> > connections.
> >   - There is a bug in the handling of HTTPS via a Proxy (the CONNECT
> is
> >   not handled correctly). See Java bugs 6226610 and 6208335.
> >   - It does not support virtual hosts.
> >   - It does not support client based certificate testing with
> Keystore
> >   Config.
> >   - Digest Auth
> >
> > In my experience there is only one case I see where it was useful
> > ,sometimes recording fails and only Java Impl is able to record:
> >
> >- I think bug is https://bz.apache.org/bugzilla/show_bug.cgi?id=59101
> .
> >
> >
> > So maybe we should deprecate it in 3.0 and ask users who are facing
> issues
> > with HC4 to report any problem.
> >
> > If nothing is reported we disable it in 3.1 (make it possible to enable
> it
> > by a property) and drop it in 3.2.
> > Regards
> > Philippe
> >
>



-- 
Cordialement.
Philippe Mouawad.

buildbot failure in on jmeter-trunk

2016-03-19 Thread buildbot

The Buildbot has detected a new failure on builder jmeter-trunk while building 
. Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/833

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: hemera_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit' 
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1735407
Blamelist: pmouawad

BUILD FAILED: failed shell_3

Sincerely,
 -The Buildbot

Re: svn commit: r1735407 - in /jmeter/trunk: build.properties build.xml eclipse.classpath lib/ lib/aareadme.txt res/maven/ApacheJMeter_parent.pom xdocs/changes.xml

2016-03-19 Thread sebb

All 3rd party jars need to be mentioned in LICENSE.txt even if they use AL2.0

On 17 March 2016 at 19:22, Philippe Mouawad  wrote:
> Done
>
> On Thu, Mar 17, 2016 at 4:56 PM, sebb  wrote:
>
>> This is a new 3rd party jar.
>> The license needs to be checked for compatibility and if OK must be
>> documented in LICENSE - and stored locally if it is not AL 2.0
>>
>>
>> On 17 March 2016 at 12:14,   wrote:
>> > Author: pmouawad
>> > Date: Thu Mar 17 12:14:44 2016
>> > New Revision: 1735407
>> >
>> > URL: http://svn.apache.org/viewvc?rev=1735407=rev
>> > Log:
>> > Bug 59187 - JSON Post Processor : java.lang.NoClassDefFoundError:
>> net/minidev/asm/FieldFilter at
>> net.minidev.json.reader.JsonWriter.(JsonWriter.java:157) (affects nightly
>> build before 3.0 release)
>> > Bugzilla Id: 59187
>> >
>> > Modified:
>> > jmeter/trunk/build.properties
>> > jmeter/trunk/build.xml
>> > jmeter/trunk/eclipse.classpath
>> > jmeter/trunk/lib/   (props changed)
>> > jmeter/trunk/lib/aareadme.txt
>> > jmeter/trunk/res/maven/ApacheJMeter_parent.pom
>> > jmeter/trunk/xdocs/changes.xml
>> >
>> > Modified: jmeter/trunk/build.properties
>> > URL:
>> http://svn.apache.org/viewvc/jmeter/trunk/build.properties?rev=1735407=1735406=1735407=diff
>> >
>> ==
>> > --- jmeter/trunk/build.properties (original)
>> > +++ jmeter/trunk/build.properties Thu Mar 17 12:14:44 2016
>> > @@ -42,11 +42,21 @@
>> >
>> >  maven2.repo = https://repo1.maven.org/maven2
>> >
>> > +accessors-smart.version = 1.1
>> > +accessors-smart.jar =
>> accessors-smart-${accessors-smart.version}.jar
>> > +accessors-smart.loc =
>> ${maven2.repo}/net/minidev/accessors-smart/${accessors-smart.version}
>> > +accessors-smart.md5 = b75cda0d7dadff9e6c20f4e7f3c3bc82
>> > +
>> >  apache-bsf.version  = 2.4.0
>> >  apache-bsf.jar  = bsf-${apache-bsf.version}.jar
>> >  apache-bsf.loc  =
>> ${maven2.repo}/bsf/bsf/${apache-bsf.version}
>> >  apache-bsf.md5  = 16e82d858c648962fb5c959f21959039
>> >
>> > +asm.version = 5.1
>> > +asm.jar = asm-${asm.version}.jar
>> > +asm.loc =
>> ${maven2.repo}/org/ow2/asm/asm/${asm.version}
>> > +asm.md5 = 3770466405f163d6616b65c32e16a3cd
>> > +
>> >  avalon-framework.version= 4.1.4
>> >  avalon-framework.jar=
>> avalon-framework-${avalon-framework.version}.jar
>> >  avalon-framework.loc=
>> ${maven2.repo}/avalon-framework/avalon-framework/${avalon-framework.version}
>> >
>> > Modified: jmeter/trunk/build.xml
>> > URL:
>> http://svn.apache.org/viewvc/jmeter/trunk/build.xml?rev=1735407=1735406=1735407=diff
>> >
>> ==
>> > --- jmeter/trunk/build.xml (original)
>> > +++ jmeter/trunk/build.xml Thu Mar 17 12:14:44 2016
>> > @@ -360,7 +360,9 @@
>> >
>> >
>> >
>> > +   
>> >  
>> > +
>> >  
>> >  
>> >  
>> > @@ -432,7 +434,9 @@
>> >
>> >
>> >  
>> > +   
>> >  
>> > +
>> >  
>> >  
>> >  
>> > @@ -2848,7 +2852,9 @@ run JMeter unless all the JMeter jars ar
>> >  conditional execution (it would be a lot easier if antcall
>> supported if/unless).
>> >  -->
>> >  
>> > -
>> > +
>> > +   
>> > +
>> >  
>> >  
>> >  
>> >
>> > Modified: jmeter/trunk/eclipse.classpath
>> > URL:
>> http://svn.apache.org/viewvc/jmeter/trunk/eclipse.classpath?rev=1735407=1735406=1735407=diff
>> >
>> ==
>> > --- jmeter/trunk/eclipse.classpath (original)
>> > +++ jmeter/trunk/eclipse.classpath Thu Mar 17 12:14:44 2016
>> > @@ -43,6 +43,8 @@
>> > > path="src/protocol/native"/>
>> > > path="src/protocol/tcp"/>
>> > 
>> > +
>> > +
>> > > path="lib/avalon-framework-4.1.4.jar"/>
>> > 
>> > 
>> >
>> > Propchange: jmeter/trunk/lib/
>> >
>> --
>> > --- svn:ignore (original)
>> > +++ svn:ignore Thu Mar 17 12:14:44 2016
>> > @@ -1,5 +1,7 @@
>> >  ext
>> >  src
>> > +accessors-smart-1.1.jar
>> > +asm-5.1.jar
>> >  avalon-framework-4.1.4.jar
>> >  bsf-2.4.0.jar
>> >  bsh-2.0b5.jar
>> >
>> > Modified: jmeter/trunk/lib/aareadme.txt
>> > URL:
>> http://svn.apache.org/viewvc/jmeter/trunk/lib/aareadme.txt?rev=1735407=1735406=1735407=diff
>> >
>> ==
>> > --- jmeter/trunk/lib/aareadme.txt (original)
>> > +++ jmeter/trunk/lib/aareadme.txt Thu Mar 17 12:14:44 2016
>> > @@ -13,6 +13,14 @@ Which jars are used by which modules?
>> >  
>> >  [not

[GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

2016-03-19 Thread ra0077

Github user ra0077 commented on the pull request:

https://github.com/apache/jmeter/pull/167#issuecomment-197735103
  
New commit with formating and swap else branch


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Management of Redirect and rfc7231

2016-03-19 Thread Philippe Mouawad

+1 for this change

@all thoughts ?

On Thu, Mar 17, 2016 at 4:15 PM, UBIK LOAD PACK Support <
supp...@ubikloadpack.com> wrote:

> Hello Team,
> Is JMeter 3.0 supposed to support :
>
>- https://tools.ietf.org/html/rfc7231
>
>
> 1/ If so there may be an issue in support of Redirect:
>
>- https://tools.ietf.org/html/rfc7231#section-6.4
>
>
> Currently only Head is considered as Safe:
>
>-
>
> https://github.com/apache/jmeter/blob/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java#L1504
>
>
> But as per https://tools.ietf.org/html/rfc7231#section-4.2.1:
>
> GET, HEAD, OPTIONS, and TRACE methods are defined to be safe.
>
>
> So if JMeter is supposed to respect rfc7231, this should be fixed.
>
> 2/ Besides, as per https://tools.ietf.org/html/rfc7231#section-6.4.7, 307
> redirect code does not allow to change the initial method , so 307 redirect
> code should be managed differently
>
>
> We can create a PR to fix this.
>
> Thanks
>
> Regards
> UbikLoadPack Support Team
>



-- 
Cordialement.
Philippe Mouawad.

[GitHub] jmeter pull request: deprecate some methods in JMeterUtils

2016-03-19 Thread benbenw

Github user benbenw commented on the pull request:

https://github.com/apache/jmeter/pull/148#issuecomment-198284154
  
ping


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: svn commit: r1735407 - in /jmeter/trunk: build.properties build.xml eclipse.classpath lib/ lib/aareadme.txt res/maven/ApacheJMeter_parent.pom xdocs/changes.xml

2016-03-19 Thread sebb

Yes, every 3rd party jar needs to be mentioned in LICENSE

It's important that users have confidence that the code is available
under the AL.
If a jar is not mentioned, then it is not obvious whether it is
compatible or not.
Users should not have to work out which jars belong to the same project.

On 17 March 2016 at 19:27, Philippe Mouawad  wrote:
> But accessors-smart is part of json-smart:
> https://github.com/netplex/json-smart-v2
>
> Do I need to add a file for accessort-smart ?
>
> This is becoming a bit cumbersome each time we change a version
>
> On Thu, Mar 17, 2016 at 8:24 PM, sebb  wrote:
>
>> All 3rd party jars need to be mentioned in LICENSE.txt even if they use
>> AL2.0
>>
>> On 17 March 2016 at 19:22, Philippe Mouawad 
>> wrote:
>> > Done
>> >
>> > On Thu, Mar 17, 2016 at 4:56 PM, sebb  wrote:
>> >
>> >> This is a new 3rd party jar.
>> >> The license needs to be checked for compatibility and if OK must be
>> >> documented in LICENSE - and stored locally if it is not AL 2.0
>> >>
>> >>
>> >> On 17 March 2016 at 12:14,   wrote:
>> >> > Author: pmouawad
>> >> > Date: Thu Mar 17 12:14:44 2016
>> >> > New Revision: 1735407
>> >> >
>> >> > URL: http://svn.apache.org/viewvc?rev=1735407=rev
>> >> > Log:
>> >> > Bug 59187 - JSON Post Processor : java.lang.NoClassDefFoundError:
>> >> net/minidev/asm/FieldFilter at
>> >> net.minidev.json.reader.JsonWriter.(JsonWriter.java:157) (affects
>> nightly
>> >> build before 3.0 release)
>> >> > Bugzilla Id: 59187
>> >> >
>> >> > Modified:
>> >> > jmeter/trunk/build.properties
>> >> > jmeter/trunk/build.xml
>> >> > jmeter/trunk/eclipse.classpath
>> >> > jmeter/trunk/lib/   (props changed)
>> >> > jmeter/trunk/lib/aareadme.txt
>> >> > jmeter/trunk/res/maven/ApacheJMeter_parent.pom
>> >> > jmeter/trunk/xdocs/changes.xml
>> >> >
>> >> > Modified: jmeter/trunk/build.properties
>> >> > URL:
>> >>
>> http://svn.apache.org/viewvc/jmeter/trunk/build.properties?rev=1735407=1735406=1735407=diff
>> >> >
>> >>
>> ==
>> >> > --- jmeter/trunk/build.properties (original)
>> >> > +++ jmeter/trunk/build.properties Thu Mar 17 12:14:44 2016
>> >> > @@ -42,11 +42,21 @@
>> >> >
>> >> >  maven2.repo = https://repo1.maven.org/maven2
>> >> >
>> >> > +accessors-smart.version = 1.1
>> >> > +accessors-smart.jar =
>> >> accessors-smart-${accessors-smart.version}.jar
>> >> > +accessors-smart.loc =
>> >> ${maven2.repo}/net/minidev/accessors-smart/${accessors-smart.version}
>> >> > +accessors-smart.md5 = b75cda0d7dadff9e6c20f4e7f3c3bc82
>> >> > +
>> >> >  apache-bsf.version  = 2.4.0
>> >> >  apache-bsf.jar  = bsf-${apache-bsf.version}.jar
>> >> >  apache-bsf.loc  =
>> >> ${maven2.repo}/bsf/bsf/${apache-bsf.version}
>> >> >  apache-bsf.md5  = 16e82d858c648962fb5c959f21959039
>> >> >
>> >> > +asm.version = 5.1
>> >> > +asm.jar = asm-${asm.version}.jar
>> >> > +asm.loc =
>> >> ${maven2.repo}/org/ow2/asm/asm/${asm.version}
>> >> > +asm.md5 = 3770466405f163d6616b65c32e16a3cd
>> >> > +
>> >> >  avalon-framework.version= 4.1.4
>> >> >  avalon-framework.jar=
>> >> avalon-framework-${avalon-framework.version}.jar
>> >> >  avalon-framework.loc=
>> >>
>> ${maven2.repo}/avalon-framework/avalon-framework/${avalon-framework.version}
>> >> >
>> >> > Modified: jmeter/trunk/build.xml
>> >> > URL:
>> >>
>> http://svn.apache.org/viewvc/jmeter/trunk/build.xml?rev=1735407=1735406=1735407=diff
>> >> >
>> >>
>> ==
>> >> > --- jmeter/trunk/build.xml (original)
>> >> > +++ jmeter/trunk/build.xml Thu Mar 17 12:14:44 2016
>> >> > @@ -360,7 +360,9 @@
>> >> >
>> >> >
>> >> >
>> >> > +   
>> >> >  
>> >> > +
>> >> >  
>> >> >  
>> >> >  
>> >> > @@ -432,7 +434,9 @@
>> >> >
>> >> >
>> >> >  
>> >> > +   
>> >> >  
>> >> > +
>> >> >  
>> >> >  
>> >> >  
>> >> > @@ -2848,7 +2852,9 @@ run JMeter unless all the JMeter jars ar
>> >> >  conditional execution (it would be a lot easier if antcall
>> >> supported if/unless).
>> >> >  -->
>> >> >  
>> >> > -
>> >> > +
>> >> > +   
>> >> > +
>> >> >  
>> >> >  
>> >> >  
>> >> >
>> >> > Modified: jmeter/trunk/eclipse.classpath
>> >> > URL:
>> >>
>> http://svn.apache.org/viewvc/jmeter/trunk/eclipse.classpath?rev=1735407=1735406=1735407=diff
>> >> >
>> >>
>> ==
>> >> > --- jmeter/trunk/eclipse.classpath (original)
>> >> > +++ jmeter/trunk/eclipse.classpath Thu Mar 17 12:14:44 2016
>> >> > @@ -43,6 +43,8 @@
>> >>

buildbot failure in on jmeter-trunk

2016-03-19 Thread buildbot

The Buildbot has detected a new failure on builder jmeter-trunk while building 
. Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/839

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: hemera_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit' 
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1735477
Blamelist: pmouawad

BUILD FAILED: failed shell_3

Sincerely,
 -The Buildbot

Re: [GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

2016-03-19 Thread Antonio Gomes Rodrigues

Hi all,

Do I need to modify something to allow the PR be accepted?

Thank
Antonio

2016-03-17 14:45 GMT+01:00 Antonio Gomes Rodrigues :

> Hi,
>
> Unitary tests fixed
>
> Antonio
>
> Cet e-mail a été envoyé depuis un ordinateur protégé par Avast.
> www.avast.com
> 
> <#6858209084203675670_DDB4FAA8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
>
> 2016-03-17 12:38 GMT+01:00 sebb :
>
>> On 17 March 2016 at 11:20, Antonio Gomes Rodrigues 
>> wrote:
>> > I will fix the unit test asap
>> >
>> > Can you provide the checkstyle configuration to run it in local before
>> > commit the change?
>>
>> It's in SVN.
>>
>> But as already noted it does not catch everything.
>>
>> The best is to follow the layout convention for the file that you are
>> working on.
>> This may vary between files (and certainly does for source file types).
>>
>> > Antonio
>> >
>> > Cet e-mail a été envoyé depuis un ordinateur protégé par Avast.
>> > www.avast.com
>> > <
>> https://www.avast.com/fr-fr/lp-esg-fav?utm_medium=email_source=link_campaign=sig-email_content=webmail_term=OA-2109-B
>> >
>> > <#DDB4FAA8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
>> >
>> > 2016-03-17 12:15 GMT+01:00 Vladimir Sitnikov <
>> sitnikov.vladi...@gmail.com>:
>> >
>> >> Antonio>Do we have a checkstyle configuration or something like that
>> >> to avoid waste
>> >> Antonio>time (your time and mine) in how to code to JMeter?
>> >>
>> >> There's a checkstyle (it is run as a part of Travis job), however it
>> >> would never check 100% of the issues.
>> >> My "else branch swap" request was just to make sure the diff does not
>> >> bring unintentional modifications.
>> >>
>> >> By the way, have you seen that Travis job fails? Any chances your fix
>> that?
>> >>
>> >> Vladimir
>> >>
>>
>
>

Re: svn commit: r1735575 - in /jmeter/trunk/test/src/org/apache/jmeter/protocol/http/parser: NotReusableParser.java ReusableParser.java TestBaseParser.java

2016-03-19 Thread Philippe Mouawad

Thanks Felix !

On Fri, Mar 18, 2016 at 12:17 PM,  wrote:

> Author: fschumacher
> Date: Fri Mar 18 11:17:47 2016
> New Revision: 1735575
>
> URL: http://svn.apache.org/viewvc?rev=1735575=rev
> Log:
> Unittests for BaseParser.
>
> Added:
>
> jmeter/trunk/test/src/org/apache/jmeter/protocol/http/parser/NotReusableParser.java
>  (with props)
>
> jmeter/trunk/test/src/org/apache/jmeter/protocol/http/parser/ReusableParser.java
>  (with props)
>
> jmeter/trunk/test/src/org/apache/jmeter/protocol/http/parser/TestBaseParser.java
>  (with props)
>
> Added:
> jmeter/trunk/test/src/org/apache/jmeter/protocol/http/parser/NotReusableParser.java
> URL:
> http://svn.apache.org/viewvc/jmeter/trunk/test/src/org/apache/jmeter/protocol/http/parser/NotReusableParser.java?rev=1735575=auto
>
> ==
> ---
> jmeter/trunk/test/src/org/apache/jmeter/protocol/http/parser/NotReusableParser.java
> (added)
> +++
> jmeter/trunk/test/src/org/apache/jmeter/protocol/http/parser/NotReusableParser.java
> Fri Mar 18 11:17:47 2016
> @@ -0,0 +1,43 @@
> +/*
> + * Licensed to the Apache Software Foundation (ASF) under one or more
> + * contributor license agreements.  See the NOTICE file distributed with
> + * this work for additional information regarding copyright ownership.
> + * The ASF licenses this file to You under the Apache License, Version 2.0
> + * (the "License"); you may not use this file except in compliance with
> + * the License.  You may obtain a copy of the License at
> + *
> + *   http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing, software
> + * distributed under the License is distributed on an "AS IS" BASIS,
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> implied.
> + * See the License for the specific language governing permissions and
> + * limitations under the License.
> + *
> + */
> +package org.apache.jmeter.protocol.http.parser;
> +
> +import java.net.URL;
> +import java.util.Iterator;
> +
> +import org.apache.commons.lang3.NotImplementedException;
> +
> +/**
> + * Test class, that implements an dummy {@link LinkExtractorParser} that
> is not
> + * reusable
> + */
> +public class NotReusableParser implements LinkExtractorParser {
> +
> +@Override
> +public Iterator getEmbeddedResourceURLs(String userAgent,
> +byte[] responseData, URL baseUrl, String encoding)
> +throws LinkExtractorParseException {
> +throw new NotImplementedException("Test class");
> +}
> +
> +@Override
> +public boolean isReusable() {
> +return false;
> +}
> +
> +}
>
> Propchange:
> jmeter/trunk/test/src/org/apache/jmeter/protocol/http/parser/NotReusableParser.java
>
> --
> svn:eol-style = native
>
> Added:
> jmeter/trunk/test/src/org/apache/jmeter/protocol/http/parser/ReusableParser.java
> URL:
> http://svn.apache.org/viewvc/jmeter/trunk/test/src/org/apache/jmeter/protocol/http/parser/ReusableParser.java?rev=1735575=auto
>
> ==
> ---
> jmeter/trunk/test/src/org/apache/jmeter/protocol/http/parser/ReusableParser.java
> (added)
> +++
> jmeter/trunk/test/src/org/apache/jmeter/protocol/http/parser/ReusableParser.java
> Fri Mar 18 11:17:47 2016
> @@ -0,0 +1,43 @@
> +/*
> + * Licensed to the Apache Software Foundation (ASF) under one or more
> + * contributor license agreements.  See the NOTICE file distributed with
> + * this work for additional information regarding copyright ownership.
> + * The ASF licenses this file to You under the Apache License, Version 2.0
> + * (the "License"); you may not use this file except in compliance with
> + * the License.  You may obtain a copy of the License at
> + *
> + *   http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing, software
> + * distributed under the License is distributed on an "AS IS" BASIS,
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> implied.
> + * See the License for the specific language governing permissions and
> + * limitations under the License.
> + *
> + */
> +package org.apache.jmeter.protocol.http.parser;
> +
> +import java.net.URL;
> +import java.util.Iterator;
> +
> +import org.apache.commons.lang3.NotImplementedException;
> +
> +/**
> + * Test class, that implements an dummy {@link LinkExtractorParser} that
> is
> + * reusable
> + */
> +public class ReusableParser implements LinkExtractorParser {
> +
> +@Override
> +public Iterator getEmbeddedResourceURLs(String userAgent,
> +byte[] responseData, URL baseUrl, String encoding)
> +throws LinkExtractorParseException {
> +throw new NotImplementedException("Test class");
> +}
> +
> +@Override
> +public boolean

[GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

2016-03-19 Thread vlsi

Github user vlsi commented on a diff in the pull request:

https://github.com/apache/jmeter/pull/167#discussion_r56465359
  
--- Diff: src/core/org/apache/jmeter/services/FileServer.java ---
@@ -418,16 +418,20 @@ private BufferedReader getReader(String alias, 
boolean recycle, boolean firstLin
 }
 
 private BufferedReader createBufferedReader(FileEntry fileEntry) 
throws IOException {
-FileInputStream fis = new FileInputStream(fileEntry.file);
-InputStreamReader isr = null;
-// If file encoding is specified, read using that encoding, 
otherwise use default platform encoding
-String charsetName = fileEntry.charSetEncoding;
-if(!JOrphanUtils.isBlank(charsetName)) {
-isr = new InputStreamReader(fis, charsetName);
+if (!fileEntry.file.exists() || !fileEntry.file.canRead() || 
!fileEntry.file.isFile()) {
+throw new IllegalArgumentException("File "+ 
fileEntry.file.getName()+ " must exist and be readable");
 } else {
--- End diff --

Please remove `else` and the following braces.
It would avoid indenting the following code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Remaining Work before Release of 3.0

2016-03-19 Thread Philippe Mouawad

On Thu, Mar 17, 2016 at 6:10 PM, sebb  wrote:

> On 17 March 2016 at 16:59, Philippe Mouawad 
> wrote:
> > Hi sebb,
> > I have fixed 1/4 issues reported in 59173 and think other "issues" should
> > be mentioned in changes and not fixed as I think some cannot be without
> > important work without real ROI.
>
> ? cannot parse.
>
I don't understand.
Can you read my comment
https://bz.apache.org/bugzilla/show_bug.cgi?id=59173#c4

>
> > Regarding 58832, it's a minor issue without effect as report works and
> > displays fine under ff, chrome, safari and IE and generation works fine
> on
> > windows, linux and macosx.
> > So unless you have an issue with it that you clearly find as blocker I
> > don't think it should delay release.
>
> I've already renamed the files and marked the bug fixed.
>

Great I missed it.

>
> > Can you answer my question on output report in the bugzilla your
> reopened ?
> > so that I can proceed withfix ?
>
> What question?
>

The one in this big thread:
"for the output of reports, check that if -o is not used the default target
folder is not overwritten if not empty. I propose to delay other
propositions to next 3.1 and wait for user feedback. I can take it unless
sebb you want to "



> > Finally regarding the order of columns in the Save configuration, you
> > commited something but issue is not in changes nor resolved, what's the
> > status on it ?
>
> Waiting for review to see if the order is sensible or not.
> We don't want to change it unnecessarily later.
>
Ok

>
> Also note that various new jars need to be mentioned in LICENSE.
>
Fixed

> This assumes that their licenses are compatible; I've not seen any
> analysis of them.
>
Yes, analysis was made but I forgot to add the license for asm, done now

>
> > Thanks
> >
> > On Wednesday, March 16, 2016, sebb  wrote:
> >
> >> There are some regressions/new bugs:
> >>
> >> Bug 59173
> >>
> >> Bug 58832
> >>
> >>
> >>
> >> On 16 March 2016 at 19:16, Philippe Mouawad  >> > wrote:
> >> > Hi sebb,
> >> > With the last commits and comments on the issues you mentioned,
> >> > can we consider that remaining work is the following:
> >> > - sort the columns of saved columns per english translation : you
> seem to
> >> > be handling it
> >> > - for the output of reports, check that if -o is not used the default
> >> > target folder is not overwritten if not empty. I propose to delay
> other
> >> > propositions to next 3.1 and wait for user feedback. I can take it
> unless
> >> > sebb you want to
> >> > - fix the NTLM auth issue with https: Felix can you confirm you will
> be
> >> > able to fix it in a not too big delay ?
> >> > - screenshots for all modified elements, volunteers ?
> >> > - new and noteworthy section, I can start it
> >> >
> >> >
> >> > We're now 1 year since we released 2.13, I think users are waiting
> this
> >> 3.0
> >> > .
> >> >
> >> > I am as a user
> >> >
> >> >
> >> > Thanks
> >> > On Tuesday, March 15, 2016, Philippe Mouawad <
> philippe.moua...@gmail.com
> >> >
> >> > wrote:
> >> >
> >> >>
> >> >>
> >> >> On Tue, Mar 15, 2016 at 9:45 PM, Felix Schumacher <
> >> >> felix.schumac...@internetallee.de 
> >> >>  >> ');>>
> >> >> wrote:
> >> >>
> >> >>>
> >> >>>
> >> >>> Am 14. März 2016 21:58:50 MEZ, schrieb Philippe Mouawad <
> >> >>> philippe.moua...@gmail.com 
> >> >>>  >> ');>>:
> >> >>> >On Monday, March 14, 2016, Felix Schumacher <
> >> >>> >felix.schumac...@internetallee.de 
> >> >>>  >> ');>>
> >> >>> wrote:
> >> >>> >
> >> >>> >> Am 14.03.2016 um 21:34 schrieb Philippe Mouawad:
> >> >>> >>
> >> >>> >>> Hello,
> >> >>> >>> All remaining issues before 3.0 are now fixed.
> >> >>> >>>
> >> >>> >> https://issues.apache.org/jira/browse/HTTPCLIENT-1712
> >> >>> >> means that we can't do kerberos with https. Is this a big
> problem?
> >> >>> >
> >> >>> >
> >> >>> >are we able to workaround in jmeter the issue ?
> >> >>> >If not it would mean we have to wait for a 4.5.3
> >> >>> >
> >> >>> >It does not seem critical for me but I don't know
> >> >>>
> >> >>> We could work around it. We would have to subclass two classes.
> >> >>> SPnegoScheme and its factory.
> >> >>>
> >> >> Let's do that Felix if you think we need to fix it before 3.0.
> >> >>
> >> >>>
> >> >>> The problem is fixed in httpclients trunk, but I don't know when a
> next
> >> >>> release is planned.
> >> >>>
> >> >>
> >> >> 4.5.2 was just released, I doubt a new one will be released for such
> a
> >> bug
> >> >>
> >> >>
> >> >>>
> >> >>> Felix
> >> >>>
> >> >>> >
> >> >>> >>
> >> >>> >> Felix
> >> >>> >>
> >> >>> >>>
> >> >>> >>> Except for the documentation screenshots

[GitHub] jmeter pull request: Bug59190_BetterProxyExcludesSuggestedCaseSens...

2016-03-19 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/169


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: svn commit: r1735407 - in /jmeter/trunk: build.properties build.xml eclipse.classpath lib/ lib/aareadme.txt res/maven/ApacheJMeter_parent.pom xdocs/changes.xml

2016-03-19 Thread sebb

I see the maintenance issue now.

The LICENSE file relies on the contents of licenses/bin to document
3rd party jars.
As such, even jars under the AL need a file.

It would be easier for the user - and probably easier to maintain - if
the LICENSE file listed all the 3rd party jars by name and version.
For jars that are not under AL 2.0 there would need to be a pointer to
the license under license/bin.
But only distinct licenses would need to be present.

When a jar is updated, only the LICENSE file would need to be updated
with the new version unless the license also changed.

The existing scheme worked OK when there weren't many 3rd party jars.
Not sure it's working properly now.

Note: we should also list the ASF jar versions in LICENSE to make it
easier for users.

It would even be possible then to write a test to scan LICENSE looking
for jar versions and compare against build.properties.


On 17 March 2016 at 20:03, Philippe Mouawad  wrote:
> Ok, I understand.
> Done
>
> On Thu, Mar 17, 2016 at 8:52 PM, sebb  wrote:
>
>> Yes, every 3rd party jar needs to be mentioned in LICENSE
>>
>> It's important that users have confidence that the code is available
>> under the AL.
>> If a jar is not mentioned, then it is not obvious whether it is
>> compatible or not.
>> Users should not have to work out which jars belong to the same project.
>>
>> On 17 March 2016 at 19:27, Philippe Mouawad 
>> wrote:
>> > But accessors-smart is part of json-smart:
>> > https://github.com/netplex/json-smart-v2
>> >
>> > Do I need to add a file for accessort-smart ?
>> >
>> > This is becoming a bit cumbersome each time we change a version
>> >
>> > On Thu, Mar 17, 2016 at 8:24 PM, sebb  wrote:
>> >
>> >> All 3rd party jars need to be mentioned in LICENSE.txt even if they use
>> >> AL2.0
>> >>
>> >> On 17 March 2016 at 19:22, Philippe Mouawad > >
>> >> wrote:
>> >> > Done
>> >> >
>> >> > On Thu, Mar 17, 2016 at 4:56 PM, sebb  wrote:
>> >> >
>> >> >> This is a new 3rd party jar.
>> >> >> The license needs to be checked for compatibility and if OK must be
>> >> >> documented in LICENSE - and stored locally if it is not AL 2.0
>> >> >>
>> >> >>
>> >> >> On 17 March 2016 at 12:14,   wrote:
>> >> >> > Author: pmouawad
>> >> >> > Date: Thu Mar 17 12:14:44 2016
>> >> >> > New Revision: 1735407
>> >> >> >
>> >> >> > URL: http://svn.apache.org/viewvc?rev=1735407=rev
>> >> >> > Log:
>> >> >> > Bug 59187 - JSON Post Processor : java.lang.NoClassDefFoundError:
>> >> >> net/minidev/asm/FieldFilter at
>> >> >> net.minidev.json.reader.JsonWriter.(JsonWriter.java:157) (affects
>> >> nightly
>> >> >> build before 3.0 release)
>> >> >> > Bugzilla Id: 59187
>> >> >> >
>> >> >> > Modified:
>> >> >> > jmeter/trunk/build.properties
>> >> >> > jmeter/trunk/build.xml
>> >> >> > jmeter/trunk/eclipse.classpath
>> >> >> > jmeter/trunk/lib/   (props changed)
>> >> >> > jmeter/trunk/lib/aareadme.txt
>> >> >> > jmeter/trunk/res/maven/ApacheJMeter_parent.pom
>> >> >> > jmeter/trunk/xdocs/changes.xml
>> >> >> >
>> >> >> > Modified: jmeter/trunk/build.properties
>> >> >> > URL:
>> >> >>
>> >>
>> http://svn.apache.org/viewvc/jmeter/trunk/build.properties?rev=1735407=1735406=1735407=diff
>> >> >> >
>> >> >>
>> >>
>> ==
>> >> >> > --- jmeter/trunk/build.properties (original)
>> >> >> > +++ jmeter/trunk/build.properties Thu Mar 17 12:14:44 2016
>> >> >> > @@ -42,11 +42,21 @@
>> >> >> >
>> >> >> >  maven2.repo = https://repo1.maven.org/maven2
>> >> >> >
>> >> >> > +accessors-smart.version = 1.1
>> >> >> > +accessors-smart.jar =
>> >> >> accessors-smart-${accessors-smart.version}.jar
>> >> >> > +accessors-smart.loc =
>> >> >> ${maven2.repo}/net/minidev/accessors-smart/${accessors-smart.version}
>> >> >> > +accessors-smart.md5 = b75cda0d7dadff9e6c20f4e7f3c3bc82
>> >> >> > +
>> >> >> >  apache-bsf.version  = 2.4.0
>> >> >> >  apache-bsf.jar  = bsf-${apache-bsf.version}.jar
>> >> >> >  apache-bsf.loc  =
>> >> >> ${maven2.repo}/bsf/bsf/${apache-bsf.version}
>> >> >> >  apache-bsf.md5  = 16e82d858c648962fb5c959f21959039
>> >> >> >
>> >> >> > +asm.version = 5.1
>> >> >> > +asm.jar = asm-${asm.version}.jar
>> >> >> > +asm.loc =
>> >> >> ${maven2.repo}/org/ow2/asm/asm/${asm.version}
>> >> >> > +asm.md5 = 3770466405f163d6616b65c32e16a3cd
>> >> >> > +
>> >> >> >  avalon-framework.version= 4.1.4
>> >> >> >  avalon-framework.jar=
>> >> >> avalon-framework-${avalon-framework.version}.jar
>> >> >> >  avalon-framework.loc=
>> >> >>
>> >>
>> ${maven2.repo}/avalon-framework/avalon-framework/${avalon-framework.version}
>> >> >> >
>> >> >> >

Re: [GitHub] jmeter pull request: java constants naming

2016-03-19 Thread Vladimir Sitnikov

Philippe>- LOG (Upper Case) for static is the usual policy that is
applied by all
Philippe>   of us since few time

In my opinion, log/logger is better treated as exception from "static
final upper case" policy.
It is used more often than other kind of static finals => it might
deserve some exceptional casing rule.

Philippe>  - and if we don't like it, why just not merge it and rename the
Philippe>  variable ?

I think we'd better agree on the style first, then merge.
"log vs LOG vs LOGGER" might indeed be important, as it is better to
follow the same style everywhere.

Philippe> why just not merge

It makes sense to activate relevant checkstyle rule, so invalid names
could no longer get in.

Philippe>do you think this kind of big discussion for a Variable
naming without a

I does not look like a big discussion yet.
We are just solving one of the two hard things in Computer Science (see [1])

[1] http://martinfowler.com/bliki/TwoHardThings.html

Vladimir

40 matches

Mail list logo