[GitHub] jmeter issue #283: Allow on JMeter client to use variables and functions for...

[pmouawad]

Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/283
  
Hello Maxime,
Thanks for patch.
My remarks:
- I think we need here JUnit tests to check no regression will occur. This 
part of the code is complex and critical and needs 100% coverage ideally 
through JUnit otherwise with a test plan running with Jacoco

- I would prefer to delay it after 3.2 release to avoid introducing another 
delay in release.

I'll review code more thoroughly in near future.


Regards
Philippe 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Trim JTexfield

[Philippe Mouawad]

Hi Maxime,
This "issue" has been diagnosed a while but unfortunately fixing it might
break a lot of fields in existing user test plans. You can search in
Bugzilla I think (but maybe closed as WONTFIX).

If we want to make a change we need to analyze case by case.
For now, I think the priority is to release 3.2 before.

Regards
Philippe



On Fri, Mar 10, 2017 at 4:41 PM, Maxime Chassagneux <
maxime.chassagn...@gmail.com> wrote:

> Hello,
>
> There is a reason why none JTexfield aren't trim by default ?
> In most cases, end spaces aren't desire and are problematic.
> By example, If you put one space after the Vuser number the run don't start
> without any error ...
> Yesterday I spent an hour to debug a problem on a JDBC connection
> configuration because I have a blank after the 'JDBC Driver Class' field
> due to a copy paste from internet...
>
> I'm the only one worry about that ?
>
> Regards
>



-- 
Cordialement.
Philippe Mouawad.
Ubik-Ingénierie

UBIK LOAD PACK Web Site 

UBIK LOAD PACK on TWITTER 

Trim JTexfield

[Maxime Chassagneux]

Hello,

There is a reason why none JTexfield aren't trim by default ?
In most cases, end spaces aren't desire and are problematic.
By example, If you put one space after the Vuser number the run don't start
without any error ...
Yesterday I spent an hour to debug a problem on a JDBC connection
configuration because I have a blank after the 'JDBC Driver Class' field
due to a copy paste from internet...

I'm the only one worry about that ?

Regards

[GitHub] jmeter pull request #283: Allow on JMeter client to use variables and functi...

[max3163]

GitHub user max3163 opened a pull request:

https://github.com/apache/jmeter/pull/283

Allow on JMeter client to use variables and functions for Listener

This patch allow to use in all ResultCollector and Backend sampler (
which are executed in the client side for a distributed test ) to have
access on test plan and user defined variables.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/max3163/jmeter ClientVariable

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/283.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #283


commit 35e0e0d1d02e2692a31651aabfcdb28c7065bd4c
Author: Maxime Chassagneux 
Date:   2017-03-10T14:32:31Z

Allow on JMeter client to use variables and functions for Listener

This patch allow to use in all ResultCollector and Backend sampler (
which are executed in the client side for a distributed test ) to have
access on test plan and user defined variables.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Variable in BackendListener

[Maxime Chassagneux]

Hi,

Could you look at the #283 PR on github to review my patch.

Thanks.

2017-03-09 14:58 GMT+01:00 Maxime Chassagneux 
:

>
> 2017-03-09 14:42 GMT+01:00 sebb :
>
>> On 9 March 2017 at 08:52, Maxime Chassagneux
>>  wrote:
>> > Hello,
>> >
>> > I can't variabilize parameter of BackendListener when I start a run via
>> > remote test.
>> > None of the value is replace.
>> >
>> > If I put something like this :
>> >
>> > influxdbUrl => ${__P(influxdbUrl, http://xxx.fr/influxdb_query/w
>> rite?db=
>> > qualif}
>>
>> Where exactly did you use this?
>>
>
> Here : https://www.dropbox.com/s/s569388q4s9x2c4/2017-03-09_
> 145548.png?dl=0
>
>
>>
>> > It cause one error :
>> >
>> > 2017-03-09 08:46:36,232 ERROR o.a.j.s.RemoteListenerWrapper:
>> > testStarted(host) on tlsqninjec10:7080
>> > java.lang.IllegalStateException: Failed calling setupTest
>> > Caused by: java.net.MalformedURLException: no protocol:
>> ${__P(influxdbUrl,
>> > http://xxx.fr/influxdb_query/write?db=qualif)}
>>
>> That indicates that the string is not being parsed for variable
>> references.
>>
>> > Of course it work localy.
>> >
>> > Is it normal ? Any tips ? Where I have to start looking for fix it ?
>>
>> The BackendListener code. Add some debug if necessary.
>>
>
> I will try :)
>
>