Re: svn commit: r1808595 - in /jmeter/trunk: bin/jmeter.properties src/components/org/apache/jmeter/config/CSVDataSetBeanInfo.java xdocs/changes.xml xdocs/images/screenshots/csvdatasetconfig.png xdocs

2017-09-16 Thread Philippe Mouawad
Thanks Antonio

On Sat, Sep 16, 2017 at 11:59 PM, Antonio Gomes Rodrigues 
wrote:

> I will made the change now
>
> Antonio
>
> 2017-09-16 23:52 GMT+02:00 Philippe Mouawad :
>
> > Hello,
> > Thanks
> > I would name property:
> >
> >- csvdataset.file.encoding_list
> >
> > Thanks
> >
> > On Sat, Sep 16, 2017 at 11:48 PM,  wrote:
> >
> > > Author: agomes
> > > Date: Sat Sep 16 21:48:06 2017
> > > New Revision: 1808595
> > >
> > > URL: http://svn.apache.org/viewvc?rev=1808595=rev
> > > Log:
> > > BUG61527 - CSV data set config : Add a list for main file encoding
> values
> > > for File encoding attribute
> > >
> > > Modified:
> > > jmeter/trunk/bin/jmeter.properties
> > > jmeter/trunk/src/components/org/apache/jmeter/config/
> > > CSVDataSetBeanInfo.java
> > > jmeter/trunk/xdocs/changes.xml
> > > jmeter/trunk/xdocs/images/screenshots/csvdatasetconfig.png
> > > jmeter/trunk/xdocs/usermanual/properties_reference.xml
> > >
> > > Modified: jmeter/trunk/bin/jmeter.properties
> > > URL: http://svn.apache.org/viewvc/jmeter/trunk/bin/jmeter.
> > > properties?rev=1808595=1808594=1808595=diff
> > > 
> > > ==
> > > --- jmeter/trunk/bin/jmeter.properties (original)
> > > +++ jmeter/trunk/bin/jmeter.properties Sat Sep 16 21:48:06 2017
> > > @@ -906,6 +906,9 @@ beanshell.server.file=../extras/startup.
> > >
> > >  # String to return at EOF (if recycle not used)
> > >  #csvdataset.eofstring=
> > > +#list in https://docs.oracle.com/javase/8/docs/technotes/
> > > guides/intl/encoding.doc.html
> > > +csvdataset.file.encoding=UTF-8|UTF-16|ISO-8859-15|US-ASCII
> > > +
> > >
> > >  #---
> > > 
> > >  # LDAP Sampler configuration
> > >
> > > Modified: jmeter/trunk/src/components/org/apache/jmeter/config/
> > > CSVDataSetBeanInfo.java
> > > URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/
> > > org/apache/jmeter/config/CSVDataSetBeanInfo.java?rev=
> > > 1808595=1808594=1808595=diff
> > > 
> > > ==
> > > --- jmeter/trunk/src/components/org/apache/jmeter/config/
> > CSVDataSetBeanInfo.java
> > > (original)
> > > +++ jmeter/trunk/src/components/org/apache/jmeter/config/
> > CSVDataSetBeanInfo.java
> > > Sat Sep 16 21:48:06 2017
> > > @@ -23,6 +23,8 @@ import java.beans.PropertyDescriptor;
> > >  import org.apache.jmeter.testbeans.BeanInfoSupport;
> > >  import org.apache.jmeter.testbeans.gui.FileEditor;
> > >  import org.apache.jmeter.testbeans.gui.TypeEditor;
> > > +import org.apache.jmeter.util.JMeterUtils;
> > > +import org.apache.jorphan.util.JOrphanUtils;
> > >
> > >  public class CSVDataSetBeanInfo extends BeanInfoSupport {
> > >
> > > @@ -64,10 +66,10 @@ public class CSVDataSetBeanInfo extends
> > >  p.setValue(NOT_EXPRESSION, Boolean.TRUE);
> > >  p.setPropertyEditorClass(FileEditor.class);
> > >
> > > -p = property(FILE_ENCODING);
> > > +p = property(FILE_ENCODING, TypeEditor.ComboStringEditor);
> > >  p.setValue(NOT_UNDEFINED, Boolean.TRUE);
> > >  p.setValue(DEFAULT, "");//$NON-NLS-1$
> > > -p.setValue(NOT_EXPRESSION, Boolean.TRUE);
> > > +p.setValue(TAGS, getListFileEncoding());
> > >
> > >  p = property(VARIABLE_NAMES);
> > >  p.setValue(NOT_UNDEFINED, Boolean.TRUE);
> > > @@ -124,4 +126,13 @@ public class CSVDataSetBeanInfo extends
> > >  System.arraycopy(SHARE_TAGS, 0, copy, 0, SHARE_TAGS.length);
> > >  return copy;
> > >  }
> > > +
> > > +/**
> > > + * Get the mains file encoding
> > > + * list from https://docs.oracle.com/javase/8/docs/technotes/
> > > guides/intl/encoding.doc.html
> > > + * @return a String[] with the list of file encoding
> > > + */
> > > +private String[] getListFileEncoding() {
> > > +return JOrphanUtils.split(JMeterUtils.getPropDefault("
> > csvdataset.file.encoding",
> > > ""), "|"); //$NON-NLS-1$
> > > +}
> > >  }
> > >
> > > Modified: jmeter/trunk/xdocs/changes.xml
> > > URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.
> > > xml?rev=1808595=1808594=1808595=diff
> > > 
> > > ==
> > > --- jmeter/trunk/xdocs/changes.xml [utf-8] (original)
> > > +++ jmeter/trunk/xdocs/changes.xml [utf-8] Sat Sep 16 21:48:06 2017
> > > @@ -114,6 +114,7 @@ Incorporated feed back about unclear doc
> > >  61525OS Process Sampler : Add browser button to
> > > Command and Working directory fields
> > >  60156 - TCPSampler : Latency is not measured for
> TCP
> > > Sampler. Contributed by Ubik Load Pack (support at ubikloadpack.com
> > )
> > >  61039CSV data set config : Add browser button to
> > > Filename field
> > > +61527CSV data set config : Add a 

Re: svn commit: r1808595 - in /jmeter/trunk: bin/jmeter.properties src/components/org/apache/jmeter/config/CSVDataSetBeanInfo.java xdocs/changes.xml xdocs/images/screenshots/csvdatasetconfig.png xdocs

2017-09-16 Thread Antonio Gomes Rodrigues
I will made the change now

Antonio

2017-09-16 23:52 GMT+02:00 Philippe Mouawad :

> Hello,
> Thanks
> I would name property:
>
>- csvdataset.file.encoding_list
>
> Thanks
>
> On Sat, Sep 16, 2017 at 11:48 PM,  wrote:
>
> > Author: agomes
> > Date: Sat Sep 16 21:48:06 2017
> > New Revision: 1808595
> >
> > URL: http://svn.apache.org/viewvc?rev=1808595=rev
> > Log:
> > BUG61527 - CSV data set config : Add a list for main file encoding values
> > for File encoding attribute
> >
> > Modified:
> > jmeter/trunk/bin/jmeter.properties
> > jmeter/trunk/src/components/org/apache/jmeter/config/
> > CSVDataSetBeanInfo.java
> > jmeter/trunk/xdocs/changes.xml
> > jmeter/trunk/xdocs/images/screenshots/csvdatasetconfig.png
> > jmeter/trunk/xdocs/usermanual/properties_reference.xml
> >
> > Modified: jmeter/trunk/bin/jmeter.properties
> > URL: http://svn.apache.org/viewvc/jmeter/trunk/bin/jmeter.
> > properties?rev=1808595=1808594=1808595=diff
> > 
> > ==
> > --- jmeter/trunk/bin/jmeter.properties (original)
> > +++ jmeter/trunk/bin/jmeter.properties Sat Sep 16 21:48:06 2017
> > @@ -906,6 +906,9 @@ beanshell.server.file=../extras/startup.
> >
> >  # String to return at EOF (if recycle not used)
> >  #csvdataset.eofstring=
> > +#list in https://docs.oracle.com/javase/8/docs/technotes/
> > guides/intl/encoding.doc.html
> > +csvdataset.file.encoding=UTF-8|UTF-16|ISO-8859-15|US-ASCII
> > +
> >
> >  #---
> > 
> >  # LDAP Sampler configuration
> >
> > Modified: jmeter/trunk/src/components/org/apache/jmeter/config/
> > CSVDataSetBeanInfo.java
> > URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/
> > org/apache/jmeter/config/CSVDataSetBeanInfo.java?rev=
> > 1808595=1808594=1808595=diff
> > 
> > ==
> > --- jmeter/trunk/src/components/org/apache/jmeter/config/
> CSVDataSetBeanInfo.java
> > (original)
> > +++ jmeter/trunk/src/components/org/apache/jmeter/config/
> CSVDataSetBeanInfo.java
> > Sat Sep 16 21:48:06 2017
> > @@ -23,6 +23,8 @@ import java.beans.PropertyDescriptor;
> >  import org.apache.jmeter.testbeans.BeanInfoSupport;
> >  import org.apache.jmeter.testbeans.gui.FileEditor;
> >  import org.apache.jmeter.testbeans.gui.TypeEditor;
> > +import org.apache.jmeter.util.JMeterUtils;
> > +import org.apache.jorphan.util.JOrphanUtils;
> >
> >  public class CSVDataSetBeanInfo extends BeanInfoSupport {
> >
> > @@ -64,10 +66,10 @@ public class CSVDataSetBeanInfo extends
> >  p.setValue(NOT_EXPRESSION, Boolean.TRUE);
> >  p.setPropertyEditorClass(FileEditor.class);
> >
> > -p = property(FILE_ENCODING);
> > +p = property(FILE_ENCODING, TypeEditor.ComboStringEditor);
> >  p.setValue(NOT_UNDEFINED, Boolean.TRUE);
> >  p.setValue(DEFAULT, "");//$NON-NLS-1$
> > -p.setValue(NOT_EXPRESSION, Boolean.TRUE);
> > +p.setValue(TAGS, getListFileEncoding());
> >
> >  p = property(VARIABLE_NAMES);
> >  p.setValue(NOT_UNDEFINED, Boolean.TRUE);
> > @@ -124,4 +126,13 @@ public class CSVDataSetBeanInfo extends
> >  System.arraycopy(SHARE_TAGS, 0, copy, 0, SHARE_TAGS.length);
> >  return copy;
> >  }
> > +
> > +/**
> > + * Get the mains file encoding
> > + * list from https://docs.oracle.com/javase/8/docs/technotes/
> > guides/intl/encoding.doc.html
> > + * @return a String[] with the list of file encoding
> > + */
> > +private String[] getListFileEncoding() {
> > +return JOrphanUtils.split(JMeterUtils.getPropDefault("
> csvdataset.file.encoding",
> > ""), "|"); //$NON-NLS-1$
> > +}
> >  }
> >
> > Modified: jmeter/trunk/xdocs/changes.xml
> > URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.
> > xml?rev=1808595=1808594=1808595=diff
> > 
> > ==
> > --- jmeter/trunk/xdocs/changes.xml [utf-8] (original)
> > +++ jmeter/trunk/xdocs/changes.xml [utf-8] Sat Sep 16 21:48:06 2017
> > @@ -114,6 +114,7 @@ Incorporated feed back about unclear doc
> >  61525OS Process Sampler : Add browser button to
> > Command and Working directory fields
> >  60156 - TCPSampler : Latency is not measured for TCP
> > Sampler. Contributed by Ubik Load Pack (support at ubikloadpack.com
> )
> >  61039CSV data set config : Add browser button to
> > Filename field
> > +61527CSV data set config : Add a list for main file
> > encoding values for File encoding attribute
> >  
> >
> >  Controllers
> >
> > Modified: jmeter/trunk/xdocs/images/screenshots/csvdatasetconfig.png
> > URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/images/
> > screenshots/csvdatasetconfig.png?rev=1808595=1808594=
> > 1808595=diff
> > 

Jenkins build is back to normal : JMeter-trunk #6303

2017-09-16 Thread Apache Jenkins Server
See 



Re: svn commit: r1808595 - in /jmeter/trunk: bin/jmeter.properties src/components/org/apache/jmeter/config/CSVDataSetBeanInfo.java xdocs/changes.xml xdocs/images/screenshots/csvdatasetconfig.png xdocs

2017-09-16 Thread Philippe Mouawad
Hello,
Thanks
I would name property:

   - csvdataset.file.encoding_list

Thanks

On Sat, Sep 16, 2017 at 11:48 PM,  wrote:

> Author: agomes
> Date: Sat Sep 16 21:48:06 2017
> New Revision: 1808595
>
> URL: http://svn.apache.org/viewvc?rev=1808595=rev
> Log:
> BUG61527 - CSV data set config : Add a list for main file encoding values
> for File encoding attribute
>
> Modified:
> jmeter/trunk/bin/jmeter.properties
> jmeter/trunk/src/components/org/apache/jmeter/config/
> CSVDataSetBeanInfo.java
> jmeter/trunk/xdocs/changes.xml
> jmeter/trunk/xdocs/images/screenshots/csvdatasetconfig.png
> jmeter/trunk/xdocs/usermanual/properties_reference.xml
>
> Modified: jmeter/trunk/bin/jmeter.properties
> URL: http://svn.apache.org/viewvc/jmeter/trunk/bin/jmeter.
> properties?rev=1808595=1808594=1808595=diff
> 
> ==
> --- jmeter/trunk/bin/jmeter.properties (original)
> +++ jmeter/trunk/bin/jmeter.properties Sat Sep 16 21:48:06 2017
> @@ -906,6 +906,9 @@ beanshell.server.file=../extras/startup.
>
>  # String to return at EOF (if recycle not used)
>  #csvdataset.eofstring=
> +#list in https://docs.oracle.com/javase/8/docs/technotes/
> guides/intl/encoding.doc.html
> +csvdataset.file.encoding=UTF-8|UTF-16|ISO-8859-15|US-ASCII
> +
>
>  #---
> 
>  # LDAP Sampler configuration
>
> Modified: jmeter/trunk/src/components/org/apache/jmeter/config/
> CSVDataSetBeanInfo.java
> URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/
> org/apache/jmeter/config/CSVDataSetBeanInfo.java?rev=
> 1808595=1808594=1808595=diff
> 
> ==
> --- 
> jmeter/trunk/src/components/org/apache/jmeter/config/CSVDataSetBeanInfo.java
> (original)
> +++ 
> jmeter/trunk/src/components/org/apache/jmeter/config/CSVDataSetBeanInfo.java
> Sat Sep 16 21:48:06 2017
> @@ -23,6 +23,8 @@ import java.beans.PropertyDescriptor;
>  import org.apache.jmeter.testbeans.BeanInfoSupport;
>  import org.apache.jmeter.testbeans.gui.FileEditor;
>  import org.apache.jmeter.testbeans.gui.TypeEditor;
> +import org.apache.jmeter.util.JMeterUtils;
> +import org.apache.jorphan.util.JOrphanUtils;
>
>  public class CSVDataSetBeanInfo extends BeanInfoSupport {
>
> @@ -64,10 +66,10 @@ public class CSVDataSetBeanInfo extends
>  p.setValue(NOT_EXPRESSION, Boolean.TRUE);
>  p.setPropertyEditorClass(FileEditor.class);
>
> -p = property(FILE_ENCODING);
> +p = property(FILE_ENCODING, TypeEditor.ComboStringEditor);
>  p.setValue(NOT_UNDEFINED, Boolean.TRUE);
>  p.setValue(DEFAULT, "");//$NON-NLS-1$
> -p.setValue(NOT_EXPRESSION, Boolean.TRUE);
> +p.setValue(TAGS, getListFileEncoding());
>
>  p = property(VARIABLE_NAMES);
>  p.setValue(NOT_UNDEFINED, Boolean.TRUE);
> @@ -124,4 +126,13 @@ public class CSVDataSetBeanInfo extends
>  System.arraycopy(SHARE_TAGS, 0, copy, 0, SHARE_TAGS.length);
>  return copy;
>  }
> +
> +/**
> + * Get the mains file encoding
> + * list from https://docs.oracle.com/javase/8/docs/technotes/
> guides/intl/encoding.doc.html
> + * @return a String[] with the list of file encoding
> + */
> +private String[] getListFileEncoding() {
> +return 
> JOrphanUtils.split(JMeterUtils.getPropDefault("csvdataset.file.encoding",
> ""), "|"); //$NON-NLS-1$
> +}
>  }
>
> Modified: jmeter/trunk/xdocs/changes.xml
> URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.
> xml?rev=1808595=1808594=1808595=diff
> 
> ==
> --- jmeter/trunk/xdocs/changes.xml [utf-8] (original)
> +++ jmeter/trunk/xdocs/changes.xml [utf-8] Sat Sep 16 21:48:06 2017
> @@ -114,6 +114,7 @@ Incorporated feed back about unclear doc
>  61525OS Process Sampler : Add browser button to
> Command and Working directory fields
>  60156 - TCPSampler : Latency is not measured for TCP
> Sampler. Contributed by Ubik Load Pack (support at ubikloadpack.com)
>  61039CSV data set config : Add browser button to
> Filename field
> +61527CSV data set config : Add a list for main file
> encoding values for File encoding attribute
>  
>
>  Controllers
>
> Modified: jmeter/trunk/xdocs/images/screenshots/csvdatasetconfig.png
> URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/images/
> screenshots/csvdatasetconfig.png?rev=1808595=1808594=
> 1808595=diff
> 
> ==
> Binary files - no diff available.
>
> Modified: jmeter/trunk/xdocs/usermanual/properties_reference.xml
> URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/usermanual/
> properties_reference.xml?rev=1808595=1808594=1808595=diff
> 
> 

Build failed in Jenkins: JMeter-trunk #6302

2017-09-16 Thread Apache Jenkins Server
See 


Changes:

[pmouawad] Updated to httpcore 4.4.7 (from 4.4.6)

[pmouawad] Use lambda

--
[...truncated 128.28 KB...]
  [javadoc] Loading source files for package 
org.apache.jmeter.gui.action.template...
  [javadoc] Loading source files for package 
org.apache.jmeter.gui.action.thinktime...
  [javadoc] Loading source files for package 
org.apache.jmeter.gui.action.validation...
  [javadoc] Loading source files for package org.apache.jmeter.gui.logging...
  [javadoc] Loading source files for package org.apache.jmeter.gui.plugin...
  [javadoc] Loading source files for package org.apache.jmeter.gui.tree...
  [javadoc] Loading source files for package org.apache.jmeter.gui.util...
  [javadoc] Loading source files for package org.apache.jmeter.plugin...
  [javadoc] Loading source files for package org.apache.jmeter.processor...
  [javadoc] Loading source files for package org.apache.jmeter.processor.gui...
  [javadoc] Loading source files for package org.apache.jmeter.report.config...
  [javadoc] Loading source files for package org.apache.jmeter.report.core...
  [javadoc] Loading source files for package 
org.apache.jmeter.report.dashboard...
  [javadoc] Loading source files for package 
org.apache.jmeter.report.processor...
  [javadoc] Loading source files for package 
org.apache.jmeter.report.processor.graph...
  [javadoc] Loading source files for package 
org.apache.jmeter.report.processor.graph.impl...
  [javadoc] Loading source files for package org.apache.jmeter.reporters...
  [javadoc] Loading source files for package org.apache.jmeter.reporters.gui...
  [javadoc] Loading source files for package org.apache.jmeter.samplers...
  [javadoc] Loading source files for package org.apache.jmeter.samplers.gui...
  [javadoc] Loading source files for package org.apache.jmeter.save...
  [javadoc] Loading source files for package 
org.apache.jmeter.save.converters...
  [javadoc] Loading source files for package org.apache.jmeter.services...
  [javadoc] Loading source files for package org.apache.jmeter.swing...
  [javadoc] Loading source files for package org.apache.jmeter.testbeans...
  [javadoc] Loading source files for package org.apache.jmeter.testbeans.gui...
  [javadoc] Loading source files for package org.apache.jmeter.testelement...
  [javadoc] Loading source files for package 
org.apache.jmeter.testelement.property...
  [javadoc] Loading source files for package org.apache.jmeter.threads...
  [javadoc] Loading source files for package org.apache.jmeter.threads.gui...
  [javadoc] Loading source files for package org.apache.jmeter.timers...
  [javadoc] Loading source files for package org.apache.jmeter.timers.gui...
  [javadoc] Loading source files for package org.apache.jmeter.util...
  [javadoc] Loading source files for package org.apache.jmeter.util.keystore...
  [javadoc] Loading source files for package org.apache.jmeter.visualizers...
  [javadoc] Loading source files for package 
org.apache.jmeter.visualizers.backend...
  [javadoc] Loading source files for package 
org.apache.jmeter.visualizers.gui...
  [javadoc] Loading source files for package org.apache.jmeter.extractor...
  [javadoc] Loading source files for package org.apache.jmeter.extractor.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.extractor.json.jsonpath...
  [javadoc] Loading source files for package 
org.apache.jmeter.extractor.json.jsonpath.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.extractor.json.render...
  [javadoc] Loading source files for package org.apache.jmeter.modifiers...
  [javadoc] Loading source files for package org.apache.jmeter.modifiers.gui...
  [javadoc] Loading source files for package org.apache.jmeter.sampler...
  [javadoc] Loading source files for package org.apache.jmeter.sampler.gui...
  [javadoc] Loading source files for package org.apache.jmeter.thinktime...
  [javadoc] Loading source files for package org.apache.jmeter.validation...
  [javadoc] Loading source files for package 
org.apache.jmeter.visualizers.backend.graphite...
  [javadoc] Loading source files for package 
org.apache.jmeter.visualizers.backend.influxdb...
  [javadoc] Loading source files for package 
org.apache.jmeter.visualizers.utils...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.config...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.config.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.control...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.control.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.modifier...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.modifier.gui...
  [javadoc] 

[GitHub] jmeter issue #300: Bug 57039 - Inconsistency with the undo/redo log

2017-09-16 Thread pmouawad
Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/300
  
Thanks @emilianbold , unfortunately I am still not able to generate diff 
nor patch file to merge it.



---


[GitHub] jmeter pull request #309: Bug61039 - CSV data set config : Add browser butto...

2017-09-16 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/309


---


[GitHub] jmeter pull request #309: Bug61039 - CSV data set config : Add browser butto...

2017-09-16 Thread ra0077
GitHub user ra0077 opened a pull request:

https://github.com/apache/jmeter/pull/309

Bug61039 - CSV data set config : Add browser button to Filename field

Better screenchot later

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ra0077/jmeter trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/309.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #309


commit af3142ca0efc0ec85fa90bb4e722d9f0438e1fcc
Author: ra77 
Date:   2017-09-15T18:53:55Z

Bug61525 : OS Process Sampler : Add browser button to Command and Working 
directory fields

commit d9fcb768fc6c0aefabcf492f6d815eabfba81d90
Author: ra77 
Date:   2017-09-16T19:47:05Z

Merge branch 'trunk' of https://github.com/apache/jmeter into trunk

commit c0d56ce401dc21e2db5ced9aa7367b922bc70947
Author: ra77 
Date:   2017-09-16T20:42:59Z

Bug 61039 : CSV data set config : Add browser button to Filename field




---


Build failed in Jenkins: JMeter Windows #736

2017-09-16 Thread Apache Jenkins Server
See 


Changes:

[milamber] Fix some javadoc warning

--
[...truncated 127.70 KB...]
   [jmeter] ... end of run
 [echo] Bug52968 output files compared OK

batchtest:
 [echo] Starting Bug50898 with file Bug50898.jmx using -X -Jdummy=dummy
   [jmeter] Creating summariser 
   [jmeter] Created the tree successfully using testfiles/Bug50898.jmx
   [jmeter] Starting the test @ Sat Sep 16 19:26:51 UTC 2017 (1505590011356)
   [jmeter] Waiting for possible Shutdown/StopTestNow/Heapdump message on port 
4445
   [jmeter] summary =  2 in 00:00:01 =3.6/s Avg:   197 Min:   101 Max:  
 294 Err: 0 (0.00%)
   [jmeter] Tidying up ...@ Sat Sep 16 19:26:52 UTC 2017 (1505590012905)
   [jmeter] ... end of run
 [echo] Bug50898 output files compared OK

batchtest:
 [echo] Starting Bug56243 with file Bug56243.jmx using -X -Jdummy=dummy
   [jmeter] Creating summariser 
   [jmeter] Created the tree successfully using testfiles/Bug56243.jmx
   [jmeter] Starting the test @ Sat Sep 16 19:26:56 UTC 2017 (1505590016276)
   [jmeter] Waiting for possible Shutdown/StopTestNow/Heapdump message on port 
4445
   [jmeter] summary =  9 in 00:00:00 =   33.1/s Avg: 1 Min: 0 Max:  
  12 Err: 0 (0.00%)
   [jmeter] Tidying up ...@ Sat Sep 16 19:26:57 UTC 2017 (1505590017477)
   [jmeter] ... end of run
 [echo] Bug56243 output files compared OK

batchtest:
 [echo] Starting Bug54685 with file Bug54685.jmx using -X 
-Jsample_variables=REFERENCE,JSESSIONID
   [jmeter] Creating summariser 
   [jmeter] Created the tree successfully using testfiles/Bug54685.jmx
   [jmeter] Starting the test @ Sat Sep 16 19:27:01 UTC 2017 (1505590021070)
   [jmeter] Waiting for possible Shutdown/StopTestNow/Heapdump message on port 
4445
   [jmeter] summary +  1 in 00:00:01 =1.9/s Avg:   327 Min:   327 Max:  
 327 Err: 0 (0.00%) Active: 1 Started: 1 Finished: 0
   [jmeter] summary =  1 in 00:00:01 =1.9/s Avg:   327 Min:   327 Max:  
 327 Err: 0 (0.00%)
   [jmeter] Tidying up ...@ Sat Sep 16 19:27:02 UTC 2017 (1505590022570)
   [jmeter] ... end of run
 [echo] Bug54685 output files compared OK

batchtest:
 [echo] Starting Bug55375 with file Bug55375.jmx using -X -Jdummy=dummy
   [jmeter] Creating summariser 
   [jmeter] Created the tree successfully using testfiles/Bug55375.jmx
   [jmeter] Starting the test @ Sat Sep 16 19:27:06 UTC 2017 (1505590026087)
   [jmeter] Waiting for possible Shutdown/StopTestNow/Heapdump message on port 
4445
   [jmeter] summary =  1 in 00:00:00 =2.5/s Avg:   236 Min:   236 Max:  
 236 Err: 0 (0.00%)
   [jmeter] Tidying up ...@ Sat Sep 16 19:27:07 UTC 2017 (1505590027476)
   [jmeter] ... end of run
 [echo] Bug55375 output files compared OK

batchtestserver:

batchtest:
 [echo] Starting Bug54685 with file Bug54685.jmx using -Rlocalhost:2045 
-Jsample_variables=REFERENCE,JSESSIONID
   [server] Created remote object: UnicastServerRef [liveRef: 
[endpoint:[10.20.2.147:54949](local),objID:[1a305e79:15e8c28af8b:-7fff, 
2379620297642041797]]]
   [client] Creating summariser 
   [client] Created the tree successfully using testfiles/Bug54685.jmx
   [client] Configuring remote engine: localhost:2045
   [client] Starting remote engines
   [client] Starting the test @ Sat Sep 16 19:27:13 UTC 2017 (1505590033374)
   [server] Starting the test on host localhost:2045 @ Sat Sep 16 19:27:15 UTC 
2017 (1505590035217)
   [client] Remote engines have been started
   [client] Waiting for possible Shutdown/StopTestNow/Heapdump message on port 
4445
   [client] summary =  1 in 00:00:00 =2.1/s Avg:   294 Min:   294 Max:  
 294 Err: 0 (0.00%)
   [server] Finished the test on host localhost:2045 @ Sat Sep 16 19:27:16 UTC 
2017 (1505590036545) - exit requested.
   [client] Tidying up remote @ Sat Sep 16 19:27:16 UTC 2017 (1505590036545)
   [client] ... end of run
 [echo] Bug54685 output files compared OK

batchtest:
 [echo] Starting Bug56811 with file Bug56811.jmx using -X -Jdummy=dummy
   [jmeter] Creating summariser 
   [jmeter] Created the tree successfully using testfiles/Bug56811.jmx
   [jmeter] Starting the test @ Sat Sep 16 19:27:25 UTC 2017 (1505590045065)
   [jmeter] Waiting for possible Shutdown/StopTestNow/Heapdump message on port 
4445
   [jmeter] summary +  1 in 00:00:08 =0.1/s Avg:   252 Min:   252 Max:  
 252 Err: 0 (0.00%) Active: 1 Started: 4 Finished: 3
   [jmeter] summary +  8 in 00:00:01 =6.2/s Avg:   159 Min: 1 Max:  
 258 Err: 3 (37.50%) Active: 0 Started: 4 Finished: 4
   [jmeter] summary =  9 in 00:00:09 =1.0/s Avg:   169 Min: 1 Max:  
 258 Err: 3 (33.33%)
   [jmeter] Tidying up ...@ Sat Sep 16 19:27:35 UTC 2017 (150559000)
   [jmeter] ... end of run
 [echo] Bug56811 output files compared OK

batchtest:
 [echo] Starting TEST_HTTPS with 

Re: Java 9 and JMeter

2017-09-16 Thread Antonio Gomes Rodrigues
Hi,

In my opinion, this change will not be in 3.3 release

I would like to have a 3.3 release asap and don't wait more time (test with
Java 9, fix bug if we detect it...)

Antonio

2017-09-16 18:47 GMT+02:00 Philippe Mouawad :

> Hello,
>
> *Java 9 Compilation:*
> I was able to compile with Java 9 after some changes:
>
>- removal of children() override in JMeterTreeNode as per Felix proposal
>- Fixing Code impacts of the previous changes
>
> This change will probably break existing plugins using this method. Should
> we do it for 3.3 ?
>
> Java 9 Running:
>
>- Running tests of a Java 8 compiled JMeter with Java 9 failed with
>NoClassDefFoundError accessing javax.activation.DataSource
>- Adding this option made it work:
>   - --add-modules java.activation
>
>
> I pushed :
>
>- https://github.com/apache/jmeter/pull/308
>
> I think even if we release as is 3.3, users will face issues with Java 9,
> mainly fixable through addition of :
>
>- --add-modules
>
> But maybe we should check samplers like :
>
> - jms
>
> - ldap
>
> ..
> --
> Cordialement.
> Philippe Mouawad.
>
>
>
>
> --
> Cordialement.
> Philippe Mouawad.
> Ubik-Ingénierie
>
> UBIK LOAD PACK Web Site 
>
> UBIK LOAD PACK on TWITTER 
>


Java 9 and JMeter

2017-09-16 Thread Philippe Mouawad
Hello,

*Java 9 Compilation:*
I was able to compile with Java 9 after some changes:

   - removal of children() override in JMeterTreeNode as per Felix proposal
   - Fixing Code impacts of the previous changes

This change will probably break existing plugins using this method. Should
we do it for 3.3 ?

Java 9 Running:

   - Running tests of a Java 8 compiled JMeter with Java 9 failed with
   NoClassDefFoundError accessing javax.activation.DataSource
   - Adding this option made it work:
  - --add-modules java.activation


I pushed :

   - https://github.com/apache/jmeter/pull/308

I think even if we release as is 3.3, users will face issues with Java 9,
mainly fixable through addition of :

   - --add-modules

But maybe we should check samplers like :

- jms

- ldap

..
-- 
Cordialement.
Philippe Mouawad.




-- 
Cordialement.
Philippe Mouawad.
Ubik-Ingénierie

UBIK LOAD PACK Web Site 

UBIK LOAD PACK on TWITTER 


[GitHub] jmeter pull request #308: Java9 migration

2017-09-16 Thread ubikloadpack
GitHub user ubikloadpack opened a pull request:

https://github.com/apache/jmeter/pull/308

Java9 migration



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ubikloadpack/jmeter Java9_Migration

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/308.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #308


commit 0ef44fdb7db335e4f85089ab90f7ca0e6d0d1666
Author: pmouawad 
Date:   2017-09-16T16:17:02Z

Fix to Java9_Migration

commit bd7a8a37c9ab0158d3162c9d664dcca916687738
Author: pmouawad 
Date:   2017-09-16T16:26:09Z

Handle Java 9




---


Commits mailing-list for committer of JMeter

2017-09-16 Thread Milamber

Hello committers,

Don't forget to subscribe the Commits mailing-list [1] to receive the 
svn commit history as mail when a committer push a change.


The SVN URL and the list of modified files can be (must) copy/paste to 
the bugzilla tickets as a reference of all changes about the ticket 
(this last being the reference into the changes list)


Thanks.

Milamber


[1] http://jmeter.apache.org/mail2.html#JMeterCommits




Re: Let's release a Major 3.3 version !

2017-09-16 Thread Antonio Gomes Rodrigues
Hi,

About Java 9, error prone detect a lot of :


[javac]
/home/ra77/Utils/ErrorProne/trunk/src/core/org/apache/jmeter/testelement/AbstractTestElement.java:74:
warning: [ClassNewInstance] Class.newInstance() bypasses exception
checking; prefer getDeclaredConstructor().newInstance()
[javac] TestElement clonedElement =
this.getClass().newInstance();

[javac]^
[javac] (see http://errorprone.info/bugpattern/ClassNewInstance)
[javac]   Did you mean 'TestElement clonedElement =
this.getClass().getDeclaredConstructor().newInstance();'?



2017-09-16 9:23 GMT+02:00 Philippe Mouawad :

> Also, can we make further tests for JDK 9 ?
>
> Thanks
>
> On Friday, September 15, 2017, Philippe Mouawad <
> philippe.moua...@gmail.com>
> wrote:
>
> > +1
> >
> > We need to update new and noteworthy section though.
> >
> > Regards
> > On Friday, September 15, 2017, Antonio Gomes Rodrigues  > > wrote:
> >
> >> +1
> >>
> >> Antonio
> >>
> >> 2017-09-15 23:23 GMT+02:00 Milamber :
> >>
> >> > Hello,
> >> >
> >> > Ready for me to prepare version 3.3 RC1 of JMeter?
> >> >
> >> > Milamber
> >> >
> >> >
> >> > On 05/09/2017 18:44, Milamber wrote:
> >> >
> >> >>
> >> >>
> >> >> On 05/09/2017 12:42, Philippe Mouawad wrote:
> >> >>
> >> >>> Hello,
> >> >>> This has been running since june :-)
> >> >>> Now version has become a major one with 33 bug fixes and 13
> >> enhancements.
> >> >>>
> >> >>> It would be nice if we could prepare a release by end of this week
> if
> >> >>> release manager is ready to
> >> >>>
> >> >>
> >> >> Unfortunately I will travel to Amsterdam from Thursday to Sunday. I
> >> could
> >> >> start the RC1 next weekend (16th september) if you are ok.
> >> >>
> >> >>
> >> >>
> >> >>
> >> >>
> >> >
> >>
> >
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
> >
> >
> >
> >
>
> --
> Cordialement.
> Philippe Mouawad.
>


Re: Let's release a Major 3.3 version !

2017-09-16 Thread Philippe Mouawad
Also, can we make further tests for JDK 9 ?

Thanks

On Friday, September 15, 2017, Philippe Mouawad 
wrote:

> +1
>
> We need to update new and noteworthy section though.
>
> Regards
> On Friday, September 15, 2017, Antonio Gomes Rodrigues  > wrote:
>
>> +1
>>
>> Antonio
>>
>> 2017-09-15 23:23 GMT+02:00 Milamber :
>>
>> > Hello,
>> >
>> > Ready for me to prepare version 3.3 RC1 of JMeter?
>> >
>> > Milamber
>> >
>> >
>> > On 05/09/2017 18:44, Milamber wrote:
>> >
>> >>
>> >>
>> >> On 05/09/2017 12:42, Philippe Mouawad wrote:
>> >>
>> >>> Hello,
>> >>> This has been running since june :-)
>> >>> Now version has become a major one with 33 bug fixes and 13
>> enhancements.
>> >>>
>> >>> It would be nice if we could prepare a release by end of this week if
>> >>> release manager is ready to
>> >>>
>> >>
>> >> Unfortunately I will travel to Amsterdam from Thursday to Sunday. I
>> could
>> >> start the RC1 next weekend (16th september) if you are ok.
>> >>
>> >>
>> >>
>> >>
>> >>
>> >
>>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>
>
>
>

-- 
Cordialement.
Philippe Mouawad.