[GitHub] jmeter issue #313: BZ61466: Comment addition to SampleResults

2017-10-05 Thread vherilier
Github user vherilier commented on the issue:

https://github.com/apache/jmeter/pull/313
  
I'll do it ASAP.
Thank you for the suggestion.


---


[GitHub] jmeter pull request #315: Fixing bin/jmeter.sh version error, working as exp...

2017-10-05 Thread matheuscunha
GitHub user matheuscunha opened a pull request:

https://github.com/apache/jmeter/pull/315

Fixing bin/jmeter.sh version error, working as expected with Oracle J…

Java 9 and OpenJDK 9. New binary from Java HotSpot just displays java 
version "9" which was breaking service initialization.

`+ MINIMAL_VERSION=1.8.0
++ awk '{ print $ NF }'
++ type java
+ _java=/usr/bin/java
++ /usr/bin/java -version
++ awk '-F"' '/version/ {print $2}'
+ CURRENT_VERSION=9
++ echo 1.8.0
++ awk -F. '{ print $2 }'
+ minimal_version=8
++ echo 9
++ awk -F. '{ print $2 }'
+ current_version=
+ '[' ']'
+ echo 'Not able to find Java executable or version. Please check your Java 
installation.'
Not able to find Java executable or version. Please check your Java 
installation.
+ exit 1`

As you can see, current_version is empty, and can't be checked.

Java version return:
`java version "9"
Java(TM) SE Runtime Environment (build 9+181)
Java HotSpot(TM) 64-Bit Server VM (build 9+181, mixed mode)`

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/matheuscunha/jmeter trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/315.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #315


commit 6bb3b1d5fcd0339630238498b0aebfa0ef24ed77
Author: Matheus Cunha 
Date:   2017-10-05T17:40:23Z

Fixing bin/jmeter.sh version error, working as expected with Oracle Java 9 
and OpenJDK 9. New binary from Java HotSpot just displays java version "9" 
which was breaking service initialization




---


Re: Percentile and Median improvements

2017-10-05 Thread Aleksei Balan
Hello Philippe Mouawad, hello Felix Schumacher,

Excuse me for returning to this already discussed topic.
I did not know about this mailing list to participate in discussion earlier.
About definition of percentile I absolutely agree with you.
Since median defined as a value dividing the tests by 2 then for even number
of tests the median can be any value between two middle values.
But in german Wikipedia it is said:
"Wenn die Anzahl der Werte gerade ist, wird der Median meist als
arithmetisches Mittel der beiden mittleren Zahlen definiert"
and in english it is also "the median is then usually defined to be
the mean of the two middle values"

In my real life experience with JMeter it is usually confusing to see
median 10 ms
for 3 successful tests of 10 ms and 3 unsuccessful of 2000 ms.

This is why my humble request to you is to agree with popular
definition of median
described in both Wikipedias.

Thank you.

Aleksei Balan


On 9/28/17, Philippe Mouawad  wrote:
> Hello Aleksei,
> We reviewed your PRs. Thank you.
>
> But following analysis by different team members, we end up thinking this:
> http://mail-archives.apache.org/mod_mbox/jmeter-dev/201705.mbox/%3C96b69e93f3e23098636fa16e3be50e7f%40internetallee.de%3E
>
> What's your thoughts on that ?
>
> Thanks
> Regards
>
> On Wed, Sep 27, 2017 at 12:50 AM, Aleksei Balan 
> wrote:
>
>> Hello Apache JMeter community,
>>
>> Can you please review these two pull requests
>> https://github.com/apache/jmeter/pull/295
>> https://github.com/apache/jmeter/pull/296
>>
>> They are fixing some calculation defects. I understand that these errors
>> affect the results very rarely (especially on big number of samples)
>> but still I think it is a good idea to have more precise calculations.
>>
>> Thank you.
>>
>> Aleksei Balan
>>
>


[GitHub] jmeter pull request #314: Fix to 61556

2017-10-05 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/314


---


[GitHub] jmeter issue #315: Fixing bin/jmeter.sh version error, working as expected w...

2017-10-05 Thread pmouawad
Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/315
  
Thanks for your PR.
But this code has recently been updated to work differently:
https://github.com/apache/jmeter/blob/trunk/bin/jmeter

We'll be happy to integrate an update for Windows script:
https://github.com/apache/jmeter/blob/trunk/bin/jmeter.bat

Thanks


---


[GitHub] jmeter pull request #315: Fixing bin/jmeter.sh version error, working as exp...

2017-10-05 Thread matheuscunha
Github user matheuscunha closed the pull request at:

https://github.com/apache/jmeter/pull/315


---


Jenkins build is back to normal : JMeter-trunk #6334

2017-10-05 Thread Apache Jenkins Server
See 




Use of RSyntaxTextArea in FunctionHelper GUI

2017-10-05 Thread Antonio Gomes Rodrigues
Hi,

I am working in FunctionHelper GUI and I would like to know why we use an
RSyntaxTextArea to display results?

Thank
Antonio


Re: Use of RSyntaxTextArea in FunctionHelper GUI

2017-10-05 Thread Philippe Mouawad
Hi Antonio,
Because it's nicer, provides line numbering.

Regards

On Thu, Oct 5, 2017 at 11:35 PM, Antonio Gomes Rodrigues 
wrote:

> Hi,
>
> I am working in FunctionHelper GUI and I would like to know why we use an
> RSyntaxTextArea to display results?
>
> Thank
> Antonio
>



-- 
Cordialement.
Philippe Mouawad.