Re: Release a 4.0 ?

2017-11-20 Thread Philippe Mouawad 
Hello,
Function is there , it is called __digest

Please confirm you find it.
Regards

On Tue, Nov 21, 2017 at 7:58 AM, jmeter tea  wrote:

> I think it's a good idea,
> Just a small issue, I didn't find DigestEncodeFunction.java which is called
> from TestDigestFunction (it was called DigestEncode)
> It's related to bug 61724
>
> Thank you
>
>
> On Mon, Nov 20, 2017 at 11:06 PM, Philippe Mouawad <
> philippe.moua...@gmail.com> wrote:
>
> > Hello,
> > We now have a version that contains:
> > - 49 enhancements
> > - 13 bug fixes
> > - 6 PR
> >
> > Version looks mature to me currently and brings interesting new features
> > and a nice new look.
> >
> > What do you think of releasing ?
> >
> > There are remaining PRs that could be merged but could introduce more
> delay
> > :
> >
> >- https://github.com/apache/jmeter/pull/320 => Migration to last HC4
> >APIs but it would need important tesint
> >- https://github.com/apache/jmeter/pull/313 => I asked a question
> about
> >it. I think we should adapt it to add a Metadata property instead of
> > Comment
> >
> >
> > Regards
> > Philippe M.
> >
>



-- 
Cordialement.
Philippe Mouawad.

Re: Release a 4.0 ?

2017-11-20 Thread jmeter tea 
I think it's a good idea,
Just a small issue, I didn't find DigestEncodeFunction.java which is called
from TestDigestFunction (it was called DigestEncode)
It's related to bug 61724

Thank you


On Mon, Nov 20, 2017 at 11:06 PM, Philippe Mouawad <
philippe.moua...@gmail.com> wrote:

> Hello,
> We now have a version that contains:
> - 49 enhancements
> - 13 bug fixes
> - 6 PR
>
> Version looks mature to me currently and brings interesting new features
> and a nice new look.
>
> What do you think of releasing ?
>
> There are remaining PRs that could be merged but could introduce more delay
> :
>
>- https://github.com/apache/jmeter/pull/320 => Migration to last HC4
>APIs but it would need important tesint
>- https://github.com/apache/jmeter/pull/313 => I asked a question about
>it. I think we should adapt it to add a Metadata property instead of
> Comment
>
>
> Regards
> Philippe M.
>

[GitHub] jmeter pull request #334: Enable running of JUnit tests from within IntelliJ...

2017-11-20 Thread ham1 
GitHub user ham1 opened a pull request:

https://github.com/apache/jmeter/pull/334

Enable running of JUnit tests from within IntelliJ with default config

## Description
With the default IntelliJ config tests are not run in the `bin` or project 
root folder which meant tests didn't run without a custom run setting.

## Motivation and Context
Makes running tests far easier in IntelliJ.

## How Has This Been Tested?
Running a sample of unit tests in IntelliJ

## Screenshots (if appropriate):

## Types of changes
- Dev enhancement
 
## Checklist:


- [x] My code follows the [code style][style-guide] of this project.
- [x] I have updated the documentation accordingly.

[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ham1/jmeter run-test-intellij

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/334.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #334


commit 57c8c3871d9eb7158a1c06d3e81c1917dd85357d
Author: Graham Russell 
Date:   2017-11-21T01:56:56Z

enabled running of JUnit tests from within IntelliJ with default config




---

Re: Release a 4.0 ?

2017-11-20 Thread Antonio Gomes Rodrigues 
Hi,

With all the changes, the screenshots of documentation are not up to date

I have modified some of them (few for the moment)

But we need to update
http://jmeter.apache.org/usermanual/jmeter_proxy_step_by_step.html at leat

Antonio

2017-11-20 22:42 GMT+01:00 Maxime Chassagneux :

> Hi,
>
> I just want to merge this PR tomorow :
> https://github.com/apache/jmeter/pull/321
>
> No problem for 4.0 for me.
>
> Regards
>
> --
> Max
>
> 2017-11-20 22:06 GMT+01:00 Philippe Mouawad :
>
> > Hello,
> > We now have a version that contains:
> > - 49 enhancements
> > - 13 bug fixes
> > - 6 PR
> >
> > Version looks mature to me currently and brings interesting new features
> > and a nice new look.
> >
> > What do you think of releasing ?
> >
> > There are remaining PRs that could be merged but could introduce more
> delay
> > :
> >
> >- https://github.com/apache/jmeter/pull/320 => Migration to last HC4
> >APIs but it would need important tesint
> >- https://github.com/apache/jmeter/pull/313 => I asked a question
> about
> >it. I think we should adapt it to add a Metadata property instead of
> > Comment
> >
> >
> > Regards
> > Philippe M.
> >
>

Re: Release a 4.0 ?

2017-11-20 Thread Maxime Chassagneux 
Hi,

I just want to merge this PR tomorow :
https://github.com/apache/jmeter/pull/321

No problem for 4.0 for me.

Regards

--
Max

2017-11-20 22:06 GMT+01:00 Philippe Mouawad :

> Hello,
> We now have a version that contains:
> - 49 enhancements
> - 13 bug fixes
> - 6 PR
>
> Version looks mature to me currently and brings interesting new features
> and a nice new look.
>
> What do you think of releasing ?
>
> There are remaining PRs that could be merged but could introduce more delay
> :
>
>- https://github.com/apache/jmeter/pull/320 => Migration to last HC4
>APIs but it would need important tesint
>- https://github.com/apache/jmeter/pull/313 => I asked a question about
>it. I think we should adapt it to add a Metadata property instead of
> Comment
>
>
> Regards
> Philippe M.
>

Jenkins build is back to normal : JMeter-trunk #6476

2017-11-20 Thread Apache Jenkins Server 
See

Release a 4.0 ?

2017-11-20 Thread Philippe Mouawad 
Hello,
We now have a version that contains:
- 49 enhancements
- 13 bug fixes
- 6 PR

Version looks mature to me currently and brings interesting new features
and a nice new look.

What do you think of releasing ?

There are remaining PRs that could be merged but could introduce more delay
:

   - https://github.com/apache/jmeter/pull/320 => Migration to last HC4
   APIs but it would need important tesint
   - https://github.com/apache/jmeter/pull/313 => I asked a question about
   it. I think we should adapt it to add a Metadata property instead of Comment


Regards
Philippe M.

Build failed in Jenkins: JMeter-trunk #6474

2017-11-20 Thread Apache Jenkins Server 
See 


Changes:

[pmouawad] Bug 61759 - New __changeCase function
Handle first char Uppercase error
Bugzilla Id: 61759

[pmouawad] Bug 61759 - New __changeCase function
Handle empty mode
Bugzilla Id: 61759

[pmouawad] Fix typo

[pmouawad] Improve naming of JDBC elements

[pmouawad] Added header check to checkstyle, fixed errors and minor cleanup
Contributed by Graham Russell
This closes #333

[pmouawad] Bug 61759 - New __changeCase function
Add i18n
Bugzilla Id: 61759

--
[...truncated 311.06 KB...]
[sonar:sonar] parsing 

[sonar:sonar] Reports path contains no files matching TEST-.*.xml : 

[sonar:sonar] Sensor SurefireSensor (done) | time=0ms
[sonar:sonar] Sensor JaCoCoSensor
[sonar:sonar] Analysing 

[sonar:sonar] No information about coverage per test.
[sonar:sonar] Sensor JaCoCoSensor (done) | time=413ms
[sonar:sonar] Sensor JaCoCoItSensor
[sonar:sonar] JaCoCoItSensor: JaCoCo IT report not found: 

[sonar:sonar] Sensor JaCoCoItSensor (done) | time=0ms
[sonar:sonar] Sensor JaCoCoOverallSensor
[sonar:sonar] Analysing 

[sonar:sonar] Analysing 

[sonar:sonar] No information about coverage per test.
[sonar:sonar] Sensor JaCoCoOverallSensor (done) | time=467ms
[sonar:sonar] Sensor XmlFileSensor
[sonar:sonar] Sensor XmlFileSensor (done) | time=0ms
[sonar:sonar] Sensor Zero Coverage Sensor
[sonar:sonar] Sensor Zero Coverage Sensor (done) | time=2ms
[sonar:sonar] Sensor Code Colorizer Sensor
[sonar:sonar] Sensor Code Colorizer Sensor (done) | time=0ms
[sonar:sonar] Sensor CPD Block Indexer
[sonar:sonar] JavaCpdBlockIndexer is used for java
[sonar:sonar] Sensor CPD Block Indexer (done) | time=14ms
[sonar:sonar] -  Scan jms
[sonar:sonar] Language is forced to java
[sonar:sonar] Excluded sources for coverage: 
[sonar:sonar]   **/BSF*.java
[sonar:sonar]   **/org/apache/log/**.java
[sonar:sonar]   **/org/apache/jmeter/examples/**.java
[sonar:sonar]   **/org/apache/jorphan/logging/**.java
[sonar:sonar] Base dir: 
[sonar:sonar] Working dir: 

[sonar:sonar] Source paths: src/protocol/jms
[sonar:sonar] Source encoding: ISO-8859-1, default locale: en_US
[sonar:sonar] Index files
[sonar:sonar] 29 files indexed
[sonar:sonar] Quality profile for java: Sonar way
[sonar:sonar] Sensor Lines Sensor
[sonar:sonar] Sensor Lines Sensor (done) | time=0ms
[sonar:sonar] Sensor JavaSquidSensor
[sonar:sonar] Configured Java source version (sonar.java.source): none
[sonar:sonar] JavaClasspath initialization
[sonar:sonar] JavaClasspath initialization (done) | time=2ms
[sonar:sonar] JavaTestClasspath initialization
[sonar:sonar] JavaTestClasspath initialization (done) | time=3ms
[sonar:sonar] Java Main Files AST scan
[sonar:sonar] 29 source files to be analyzed
[sonar:sonar] Class not found: javax.annotation.concurrent.ThreadSafe
[sonar:sonar] Class not found: javax.annotation.CheckForNull
[sonar:sonar] Class not found: javax.annotation.Nonnull
[sonar:sonar] Class not found: javax.annotation.Nonnegative
[sonar:sonar] Class not found: javax.annotation.concurrent.ThreadSafe
[sonar:sonar] Class not found: javax.annotation.CheckForNull
[sonar:sonar] Class not found: javax.annotation.Nonnull
[sonar:sonar] Class not found: javax.annotation.Nonnegative
[sonar:sonar] Class not found: javax.annotation.Nullable
[sonar:sonar] Class not found: javax.annotation.concurrent.ThreadSafe
[sonar:sonar] Class not found: javax.annotation.CheckForNull
[sonar:sonar] Class not found: javax.annotation.Nonnull
[sonar:sonar] Class not found: javax.annotation.Nonnegative
[sonar:sonar] Class not found: javax.annotation.concurrent.ThreadSafe
[sonar:sonar] Class not found: javax.annotation.CheckForNull
[sonar:sonar] Class not found: javax.annotation.Nonnull
[sonar:sonar] Class not found: javax.annotation.Nonnegative
[sonar:sonar] Class not found: javax.annotation.concurrent.ThreadSafe
[sonar:sonar] Class not found: javax.annotation.CheckForNull
[sonar:sonar] Class not found: javax.annotation.Nonnull
[sonar:sonar] Class not found: javax.annotation.Nonnegative
[sonar:sonar] Class not found: javax.annotation.concurrent.ThreadSafe
[sonar:sonar] Class not found: javax.annotation.CheckForNull
[sonar:sonar] Class not found: javax.annotation.Nonnull
[sonar:sonar] Class not found: javax.annotation.Nonnegative
[sonar:sonar] Class not found:

buildbot success in on jmeter-trunk

2017-11-20 Thread buildbot 
The Buildbot has detected a restored build on builder jmeter-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/3225

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: bb_slave1_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit' 
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1815845
Blamelist: pmouawad

Build succeeded!

Sincerely,
 -The Buildbot

buildbot failure in on jmeter-trunk

2017-11-20 Thread buildbot 
The Buildbot has detected a new failure on builder jmeter-trunk while building 
. Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/3224

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: bb_slave1_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit' 
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1815844
Blamelist: pmouawad

BUILD FAILED: failed shell_3

Sincerely,
 -The Buildbot

buildbot success in on jmeter-trunk

2017-11-20 Thread buildbot 
The Buildbot has detected a restored build on builder jmeter-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/3222

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: bb_slave1_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit' 
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1815839
Blamelist: pmouawad

Build succeeded!

Sincerely,
 -The Buildbot

[GitHub] jmeter pull request #333: Added header check to checkstyle, fixed errors and...

2017-11-20 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/333


---

Build failed in Jenkins: JMeter-trunk #6473

2017-11-20 Thread Apache Jenkins Server 
See 


Changes:

[pmouawad] Bug 61759 - New __changeCase function
Contributed by Orimarko
Bugzilla Id: 61759

[pmouawad] Document non callable API
Add getProperties()

--
[...truncated 500.01 KB...]
  [javadoc] Loading source files for package org.apache.jmeter.timers.gui...
  [javadoc] Loading source files for package org.apache.jmeter.util...
  [javadoc] Loading source files for package org.apache.jmeter.util.keystore...
  [javadoc] Loading source files for package org.apache.jmeter.visualizers...
  [javadoc] Loading source files for package 
org.apache.jmeter.visualizers.backend...
  [javadoc] Loading source files for package 
org.apache.jmeter.visualizers.gui...
  [javadoc] Loading source files for package org.apache.jmeter.extractor...
  [javadoc] Loading source files for package org.apache.jmeter.extractor.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.extractor.json.jsonpath...
  [javadoc] Loading source files for package 
org.apache.jmeter.extractor.json.jsonpath.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.extractor.json.render...
  [javadoc] Loading source files for package org.apache.jmeter.modifiers...
  [javadoc] Loading source files for package org.apache.jmeter.modifiers.gui...
  [javadoc] Loading source files for package org.apache.jmeter.sampler...
  [javadoc] Loading source files for package org.apache.jmeter.sampler.gui...
  [javadoc] Loading source files for package org.apache.jmeter.thinktime...
  [javadoc] Loading source files for package org.apache.jmeter.validation...
  [javadoc] Loading source files for package 
org.apache.jmeter.visualizers.backend.graphite...
  [javadoc] Loading source files for package 
org.apache.jmeter.visualizers.backend.influxdb...
  [javadoc] Loading source files for package 
org.apache.jmeter.visualizers.utils...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.config...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.config.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.control...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.control.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.modifier...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.modifier.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.parser...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.proxy...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.proxy.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.sampler...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.sampler.hc...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.util...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.util.accesslog...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.visualizers...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.ftp.config.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.ftp.control.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.ftp.sampler...
  [javadoc] Loading source files for package org.apache.jmeter.protocol.jdbc...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.jdbc.config...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.jdbc.processor...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.jdbc.sampler...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.java.config...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.java.config.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.java.control.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.java.sampler...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.java.test...
  [javadoc] Loading source files for package org.apache.jorphan.collections...
  [javadoc] Loading source files for package org.apache.jorphan.exec...
  [javadoc] Loading source files for package org.apache.jorphan.gui...
  [javadoc] Loading source files for package org.apache.jorphan.gui.layout...
  [javadoc] Loading source files for package org.apache.jorphan.io...
  [javadoc] Loading source files for package org.apache.jorphan.logging...
  [javadoc] Loading source files for package org.apache.jorphan.math...
  [javadoc] Loading source files for package org.apache.jorphan.reflect...
  [javadoc] Loading

buildbot failure in on jmeter-trunk

2017-11-20 Thread buildbot 
The Buildbot has detected a new failure on builder jmeter-trunk while building 
. Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/3221

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: bb_slave1_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit' 
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1815838
Blamelist: pmouawad

BUILD FAILED: failed shell_3

Sincerely,
 -The Buildbot

[GitHub] jmeter issue #333: Added header check to checkstyle, fixed errors and minor ...

2017-11-20 Thread codecov-io 
Github user codecov-io commented on the issue:

https://github.com/apache/jmeter/pull/333
  
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/333?src=pr=h1) 
Report
> Merging 
[#333](https://codecov.io/gh/apache/jmeter/pull/333?src=pr=desc) into 
[trunk](https://codecov.io/gh/apache/jmeter/commit/94a658650932bccafb6ea8c73b2b2269fd1c8826?src=pr=desc)
 will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/jmeter/pull/333/graphs/tree.svg?token=6Q7CI1wFSh=pr=150=650)](https://codecov.io/gh/apache/jmeter/pull/333?src=pr=tree)

```diff
@@ Coverage Diff  @@
##  trunk #333  +/-   ##

- Coverage 57.86%   57.86%   -0.01% 
+ Complexity 9994 9993   -1 

  Files  1146 1146  
  Lines 7361473614  
  Branches   7312 7312  

- Hits  4259842596   -2 
  Misses2853928539  
- Partials   2477 2479   +2
```


| [Impacted 
Files](https://codecov.io/gh/apache/jmeter/pull/333?src=pr=tree) | Coverage 
Δ | Complexity Δ | |
|---|---|---|---|
| 
[...he/jmeter/visualizers/backend/BackendListener.java](https://codecov.io/gh/apache/jmeter/pull/333?src=pr=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvdmlzdWFsaXplcnMvYmFja2VuZC9CYWNrZW5kTGlzdGVuZXIuamF2YQ==)
 | `10.34% <ø> (ø)` | `7 <0> (ø)` | :arrow_down: |
| 
[...org/apache/jmeter/util/CustomX509TrustManager.java](https://codecov.io/gh/apache/jmeter/pull/333?src=pr=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvdXRpbC9DdXN0b21YNTA5VHJ1c3RNYW5hZ2VyLmphdmE=)
 | `20.68% <ø> (ø)` | `4 <0> (ø)` | :arrow_down: |
| 
[...apache/jmeter/protocol/http/gui/DNSCachePanel.java](https://codecov.io/gh/apache/jmeter/pull/333?src=pr=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9ndWkvRE5TQ2FjaGVQYW5lbC5qYXZh)
 | `59.4% <ø> (ø)` | `15 <0> (ø)` | :arrow_down: |
| 
[...meter/protocol/http/control/gui/AjpSamplerGui.java](https://codecov.io/gh/apache/jmeter/pull/333?src=pr=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9jb250cm9sL2d1aS9BanBTYW1wbGVyR3VpLmphdmE=)
 | `100% <ø> (ø)` | `4 <0> (ø)` | :arrow_down: |
| 
[...er/visualizers/backend/BackendListenerContext.java](https://codecov.io/gh/apache/jmeter/pull/333?src=pr=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvdmlzdWFsaXplcnMvYmFja2VuZC9CYWNrZW5kTGlzdGVuZXJDb250ZXh0LmphdmE=)
 | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| 
[...pache/jmeter/assertions/gui/SMIMEAssertionGui.java](https://codecov.io/gh/apache/jmeter/pull/333?src=pr=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvYXNzZXJ0aW9ucy9ndWkvU01JTUVBc3NlcnRpb25HdWkuamF2YQ==)
 | `80.45% <ø> (ø)` | `9 <0> (ø)` | :arrow_down: |
| 
[...c/core/org/apache/jmeter/threads/JMeterThread.java](https://codecov.io/gh/apache/jmeter/pull/333?src=pr=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvdGhyZWFkcy9KTWV0ZXJUaHJlYWQuamF2YQ==)
 | `70.52% <ø> (ø)` | `93 <0> (ø)` | :arrow_down: |
| 
[...apache/jmeter/util/JMeterTreeNodeTransferable.java](https://codecov.io/gh/apache/jmeter/pull/333?src=pr=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvdXRpbC9KTWV0ZXJUcmVlTm9kZVRyYW5zZmVyYWJsZS5qYXZh)
 | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| 
[...pache/jmeter/protocol/http/sampler/AjpSampler.java](https://codecov.io/gh/apache/jmeter/pull/333?src=pr=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9zYW1wbGVyL0FqcFNhbXBsZXIuamF2YQ==)
 | `5.61% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: |
| 
[src/jorphan/org/apache/log/Logger.java](https://codecov.io/gh/apache/jmeter/pull/333?src=pr=tree#diff-c3JjL2pvcnBoYW4vb3JnL2FwYWNoZS9sb2cvTG9nZ2VyLmphdmE=)
 | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| ... and [9 
more](https://codecov.io/gh/apache/jmeter/pull/333?src=pr=tree-more) | |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/jmeter/pull/333?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/jmeter/pull/333?src=pr=footer). Last 
update 
[94a6586...4bf9d40](https://codecov.io/gh/apache/jmeter/pull/333?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---

[GitHub] jmeter pull request #333: Added header check to checkstyle, fixed errors and...

2017-11-20 Thread ham1 
GitHub user ham1 opened a pull request:

https://github.com/apache/jmeter/pull/333

Added header check to checkstyle, fixed errors and minor cleanup

## Description
Added Java Apache licence header check, used a regex so that we don't have 
to change 100s of files and it still does the job of catching any file with a 
missing header, however it doesn't match the current format listed 
http://www.apache.org/dev/apply-license.html but it matches the majority of the 
ones in the code base at the moment.

## Motivation and Context
Prevent/notify when files are missing a header rather than rely on someone 
spotting it.

## How Has This Been Tested?
`ant checkstyle`

## Screenshots (if appropriate):

## Types of changes

- Dev enhancement

## Checklist:


- [x] My code follows the [code style][style-guide] of this project.
- [ ] I have updated the documentation accordingly.

[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ham1/jmeter checkstyle-improvements

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/333.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #333


commit 4bf9d4082832269ad737832659d4160aab767cd3
Author: Graham Russell 
Date:   2017-11-20T01:35:03Z

Added header check to checkstyle, fixed errors and minor cleanup




---

Re: svn commit: r1815703 - in /jmeter/trunk: src/core/org/apache/jmeter/gui/action/ src/core/org/apache/jmeter/gui/util/ src/core/org/apache/jmeter/resources/ xdocs/

2017-11-20 Thread Antonio Gomes Rodrigues 
Hi Felix,

2017-11-19 11:11 GMT+01:00 Felix Schumacher <
felix.schumac...@internetallee.de>:

> Am 18.11.2017 um 23:45 schrieb ago...@apache.org:
>
>>
>> +
>> +/**
>> + * @see org.apache.jmeter.gui.action.Command#doAction(ActionEvent)
>> + */
>> +@Override
>> +public void doAction(ActionEvent e) {
>> +String url = null;
>> +if (e.getActionCommand().equals(ActionNames.LINK_BUG_TRACKER)) {
>> +url = "https://jmeter.apache.org/issues.html;;
>>
> Should we hardcode URLs in the source code?


I have hardcoded the URLs in source code because it's only 2 URL and there
is little chance they will change.  I can improve the code to be more
generic, but it will complex it and I don't know if it's useless


>
> +} else if (e.getActionCommand().equals(A
>> ctionNames.LINK_NIGHTLY_BUILD)) {
>> +url = "https://jmeter.apache.org/nightly.html;;
>> +}
>>
> What happens, when url is still null? Should we still try to open a
> browser?

I will modify it by adding a nullcheck


>
> +try {
>> +java.awt.Desktop.getDesktop().browse(java.net.URI.create(url
>> ));
>> +} catch (IOException err) {
>> +log.error("OpenLinkAction: User default browser is not
>> found, or it fails to be launched, or the default handler application
>> failed to be launched on {}", err);
>> +} catch (UnsupportedOperationException err) {
>> +log.error("OpenLinkAction: Current platform does not support
>> the Desktop.Action.BROWSE actionon {}", err);
>> +} catch (SecurityException err) {
>> +log.error("OpenLinkAction: Security problem on {}", err);
>> +} catch (Exception err) {
>> +log.error("OpenLinkAction on {}", err);
>> +}
>> +}
>> +
>> +@Override
>> +public Set getActionNames() {
>> +return commands;
>> +}
>> +
>> +}
>>
>> Modified: jmeter/trunk/src/core/org/apache/jmeter/gui/util/JMeterMenuB
>> ar.java
>> URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apach
>> e/jmeter/gui/util/JMeterMenuBar.java?rev=1815703=1815702&
>> r2=1815703=diff
>> 
>> ==
>> --- jmeter/trunk/src/core/org/apache/jmeter/gui/util/JMeterMenuBar.java
>> (original)
>> +++ jmeter/trunk/src/core/org/apache/jmeter/gui/util/JMeterMenuBar.java
>> Sat Nov 18 22:45:15 2017
>> @@ -302,9 +302,18 @@ public class JMeterMenuBar extends JMenu
>> JMenuItem threadDump = makeMenuItemRes("thread_dump",
>> ActionNames.THREAD_DUMP);//$NON-NLS-1$
>>   -JMenuItem linkBugTracker =
>> makeMenuItemRes("link_bug_tracker", ActionNames.LINK_BUG_TRACKER);
>> //$NON-NLS-1$
>> -
>> -JMenuItem linkNightlyBuild = makeMenuItemRes("link_nightly_build",
>> ActionNames.LINK_NIGHTLY_BUILD);//$NON-NLS-1$
>> +JMenu usefulLinks = makeMenuRes("useful_links");//$NON-NLS-1$
>> +JMenuItem menuItem;
>> +menuItem = new JMenuItem(JMeterUtils.getLocal
>> eString("link_bug_tracker"));
>> +menuItem.addActionListener(ActionRouter.getInstance());
>> +menuItem.setActionCommand(ActionNames.LINK_BUG_TRACKER);
>> +menuItem.setName("link_bug_tracker");
>>
> I would have extracted the creation if the JMenuItem into a private
> method, as the same code fragment is used below with two different
> parameters: "link_nightly_build" and ActionNames.LINK_NIGHTLY_BUILD.
>
> Oh, there is one already: makeMenuItemRes (used below) does exactly that.
>

I will check it

>
> Regards,
>  Felix
>
>
> +usefulLinks.add(menuItem);
>> +menuItem = new JMenuItem(JMeterUtils.getLocal
>> eString("link_nightly_build"));
>> +menuItem.addActionListener(ActionRouter.getInstance());
>> +menuItem.setActionCommand(ActionNames.LINK_NIGHTLY_BUILD);
>> +menuItem.setName("link_nightly_build");
>> +usefulLinks.add(menuItem);
>> helpAbout = makeMenuItemRes("about", 'A', ActionNames.ABOUT);
>> //$NON-NLS-1$
>>   @@ -319,8 +328,7 @@ public class JMeterMenuBar extends JMenu
>>   addPluginsMenuItems(helpMenu, menuCreators, MENU_LOCATION.HELP);
>> helpMenu.addSeparator();
>> -helpMenu.add(linkBugTracker);
>> -helpMenu.add(linkNightlyBuild);
>> +helpMenu.add(usefulLinks);
>>   helpMenu.addSeparator();
>>   helpMenu.add(helpAbout);
>>   }
>>
>> Modified: jmeter/trunk/src/core/org/apache/jmeter/resources/messages.
>> properties
>> URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apach
>> e/jmeter/resources/messages.properties?rev=1815703=
>> 1815702=1815703=diff
>> 
>> ==
>> --- jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties
>> (original)
>> +++ jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties
>> Sat Nov 18 22:45:15 2017
>> @@ -1256,6 +1256,7 @@