[GitHub] jmeter pull request #350: Parallelised unit tests
GitHub user ham1 opened a pull request: https://github.com/apache/jmeter/pull/350 Parallelised unit tests ## Description introduced `JMeterSerialTest` interface for tests which need to be run in sequence not concurrently. Re-wrote `TestFileServer` in Spock to use private constructor to get around singleton and make clearer to understand. Added a test listener to time and log to file time taken for each unit test. Also refactored/re-formatted some code while investigating parallel test failures. `ant _test` time on a 4 core laptop: before: 1m 19s after: 51s on an 8 core PC: before: 59s after: 31s I'd welcome more testing on different configurations and review. ## Motivation and Context Speed up feedback ## How Has This Been Tested? 100 iterations of `ant _test` on an 8 core machine 50 iterations of `ant _test` on a 4 core machine ## Screenshots (if appropriate): ## Types of changes - Dev improvement ## Checklist: - [x] My code follows the [code style][style-guide] of this project. - [x] I have updated the documentation accordingly. [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines You can merge this pull request into a Git repository by running: $ git pull https://github.com/ham1/jmeter parallelise_unit_tests Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/350.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #350 commit 8e1c2b65221bccdcf93e29da6cd1875d016685b5 Author: Graham Russell Date: 2017-12-06T17:32:55Z Parallelised unit tests. Introduced JMeterSerialTest interface for tests which need to be run individually in sequence not concurrently. Re-wrote TestFileServer in Spock to use private constructor to get around singleton. Also refactored/re-formatted some code while investigating parallel test failures. ---
[GitHub] jmeter issue #345: Checkstyle
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/345 Hi team, anybody wants to merge this one ? if not Iâll do it this week-end. Thanks ---
[GitHub] jmeter issue #350: Parallelised unit tests
Github user codecov-io commented on the issue: https://github.com/apache/jmeter/pull/350 # [Codecov](https://codecov.io/gh/apache/jmeter/pull/350?src=pr&el=h1) Report > Merging [#350](https://codecov.io/gh/apache/jmeter/pull/350?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/jmeter/commit/9874acaf7db599d73624fc6f30ca448e9299ae0e?src=pr&el=desc) will **increase** coverage by `<.01%`. > The diff coverage is `89.28%`. [](https://codecov.io/gh/apache/jmeter/pull/350?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## trunk #350 +/- ## + Coverage 58.29% 58.29% +<.01% - Complexity1020710228 +21 Files 1160 1160 Lines 7446674424 -42 Branches 7365 7362 -3 - Hits 4340943388 -21 + Misses2856128535 -26 - Partials 2496 2501 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/jmeter/pull/350?src=pr&el=tree) | Coverage Π| Complexity Π| | |---|---|---|---| | [...isualizers/backend/SamplerMetricTimedModeTest.java](https://codecov.io/gh/apache/jmeter/pull/350/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvdmlzdWFsaXplcnMvYmFja2VuZC9TYW1wbGVyTWV0cmljVGltZWRNb2RlVGVzdC5qYXZh) | `100% <ø> (ø)` | `7 <0> (ø)` | :arrow_down: | | [...isualizers/backend/SamplerMetricFixedModeTest.java](https://codecov.io/gh/apache/jmeter/pull/350/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvdmlzdWFsaXplcnMvYmFja2VuZC9TYW1wbGVyTWV0cmljRml4ZWRNb2RlVGVzdC5qYXZh) | `100% <ø> (ø)` | `9 <0> (ø)` | :arrow_down: | | [...ter/protocol/http/control/TestCacheManagerHC4.java](https://codecov.io/gh/apache/jmeter/pull/350/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9jb250cm9sL1Rlc3RDYWNoZU1hbmFnZXJIQzQuamF2YQ==) | `78.18% <ø> (ø)` | `12 <0> (ø)` | :arrow_down: | | [...g/apache/jmeter/assertions/SMIMEAssertionTest.java](https://codecov.io/gh/apache/jmeter/pull/350/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvYXNzZXJ0aW9ucy9TTUlNRUFzc2VydGlvblRlc3QuamF2YQ==) | `100% <100%> (ø)` | `9 <1> (ø)` | :arrow_down: | | [...c/org/apache/jmeter/reporters/TestResultSaver.java](https://codecov.io/gh/apache/jmeter/pull/350/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvcmVwb3J0ZXJzL1Rlc3RSZXN1bHRTYXZlci5qYXZh) | `100% <100%> (ø)` | `7 <1> (ø)` | :arrow_down: | | [...rc/core/org/apache/jmeter/services/FileServer.java](https://codecov.io/gh/apache/jmeter/pull/350/diff?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvc2VydmljZXMvRmlsZVNlcnZlci5qYXZh) | `71.13% <100%> (-0.08%)` | `56 <3> (ø)` | | | [...t/src/org/apache/jmeter/config/TestCVSDataSet.java](https://codecov.io/gh/apache/jmeter/pull/350/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvY29uZmlnL1Rlc3RDVlNEYXRhU2V0LmphdmE=) | `96.17% <100%> (ø)` | `10 <1> (ø)` | :arrow_down: | | [...ache/jmeter/functions/TestFileRowColContainer.java](https://codecov.io/gh/apache/jmeter/pull/350/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvZnVuY3Rpb25zL1Rlc3RGaWxlUm93Q29sQ29udGFpbmVyLmphdmE=) | `82.71% <100%> (ø)` | `6 <3> (ø)` | :arrow_down: | | [...c/org/apache/jmeter/samplers/TestSampleResult.java](https://codecov.io/gh/apache/jmeter/pull/350/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvc2FtcGxlcnMvVGVzdFNhbXBsZVJlc3VsdC5qYXZh) | `93.85% <100%> (ø)` | `24 <4> (ø)` | :arrow_down: | | [...t/src/org/apache/jmeter/functions/PackageTest.java](https://codecov.io/gh/apache/jmeter/pull/350/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvZnVuY3Rpb25zL1BhY2thZ2VUZXN0LmphdmE=) | `91.63% <100%> (ø)` | `25 <1> (ø)` | :arrow_down: | | ... and [18 more](https://codecov.io/gh/apache/jmeter/pull/350/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/jmeter/pull/350?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Π= absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/jmeter/pull/350?src=pr&el=footer). Last update [9874aca...bbdb3e3](https://codecov.io/gh/apache/jmeter/pull/350?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---
[GitHub] jmeter pull request #345: Checkstyle
Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/345 ---
Re: svn commit: r1817321 [1/3] - in /jmeter/trunk: ./ docs/images/screenshots/ docs/images/screenshots/http-config/ docs/images/screenshots/webtest/ src/components/org/apache/jmeter/assertions/ src/co
On Wed, Dec 6, 2017 at 11:21 PM, wrote: > Author: agomes > Date: Wed Dec 6 22:21:19 2017 > New Revision: 1817321 > > URL: http://svn.apache.org/viewvc?rev=1817321&view=rev > Log: > This closes #345 - Updated to latest checkstyle (v8.5), Added many more > rules to checkstyle, Included checking of test files and more file types. > Contributed by Graham Russell > > Modified: > jmeter/trunk/build.properties > jmeter/trunk/build.xml > jmeter/trunk/checkstyle-suppressions.xml > jmeter/trunk/checkstyle.xml > jmeter/trunk/docs/images/screenshots/Proxy_Run.png > jmeter/trunk/docs/images/screenshots/Select-Templates-Icon.png > jmeter/trunk/docs/images/screenshots/Test_Generated.png > jmeter/trunk/docs/images/screenshots/Validate-Test-Plan.png > jmeter/trunk/docs/images/screenshots/example-recording.png > jmeter/trunk/docs/images/screenshots/example-thread-group.png > jmeter/trunk/docs/images/screenshots/http-config/http- > request-defaults.png > jmeter/trunk/docs/images/screenshots/template_menu.png > jmeter/trunk/docs/images/screenshots/webtest/http-defaults1.png > jmeter/trunk/docs/images/screenshots/webtest/http-defaults2.png > jmeter/trunk/docs/images/screenshots/webtest/http-request1.png > jmeter/trunk/docs/images/screenshots/webtest/http-request2.png > jmeter/trunk/docs/images/screenshots/webtest/http_login.png > jmeter/trunk/docs/images/screenshots/webtest/threadgroup.png > jmeter/trunk/docs/images/screenshots/webtest/threadgroup2.png > jmeter/trunk/src/components/org/apache/jmeter/assertions/ > JSONPathAssertion.java > jmeter/trunk/src/components/org/apache/jmeter/assertions/ > ResponseAssertion.java > jmeter/trunk/src/components/org/apache/jmeter/assertions/ > gui/BeanShellAssertionGui.java > jmeter/trunk/src/components/org/apache/jmeter/assertions/ > gui/JSONPathAssertionGui.java > jmeter/trunk/src/components/org/apache/jmeter/control/ > ThroughputController.java > jmeter/trunk/src/components/org/apache/jmeter/extractor/ > gui/HtmlExtractorGui.java > jmeter/trunk/src/components/org/apache/jmeter/extractor/ > json/jsonpath/JSONManager.java > jmeter/trunk/src/components/org/apache/jmeter/reporters/ > MailerModel.java > jmeter/trunk/src/components/org/apache/jmeter/timers/ > ConstantThroughputTimerBeanInfo.java > jmeter/trunk/src/components/org/apache/jmeter/visualizers/Graph.java > jmeter/trunk/src/components/org/apache/jmeter/visualizers/ > RenderAsXML.java > jmeter/trunk/src/components/org/apache/jmeter/visualizers/ > RenderInBrowser.java > jmeter/trunk/src/components/org/apache/jmeter/visualizers/ > ViewResultsFullVisualizer.java > jmeter/trunk/src/components/org/apache/jmeter/visualizers/ > backend/BackendListener.java > jmeter/trunk/src/core/org/apache/jmeter/NewDriver.java > jmeter/trunk/src/core/org/apache/jmeter/assertions/gui/ > AbstractAssertionGui.java > jmeter/trunk/src/core/org/apache/jmeter/config/gui/ > SimpleConfigGui.java > jmeter/trunk/src/core/org/apache/jmeter/functions/gui/ > FunctionHelper.java > jmeter/trunk/src/core/org/apache/jmeter/gui/GlobalUndoableEdit.java > jmeter/trunk/src/core/org/apache/jmeter/gui/UndoHistoryItem.java > jmeter/trunk/src/core/org/apache/jmeter/gui/action/RemoteStart.java > jmeter/trunk/src/core/org/apache/jmeter/gui/util/HorizontalPanel.java > jmeter/trunk/src/core/org/apache/jmeter/gui/util/MenuFactory.java > jmeter/trunk/src/core/org/apache/jmeter/gui/util/PowerTableModel.java > jmeter/trunk/src/core/org/apache/jmeter/gui/util/VerticalPanel.java > jmeter/trunk/src/core/org/apache/jmeter/gui/util/theme/ > darcula_theme.xml > jmeter/trunk/src/core/org/apache/jmeter/report/core/SampleBuilder.java > jmeter/trunk/src/core/org/apache/jmeter/report/core/ > SampleMetaDataParser.java > jmeter/trunk/src/core/org/apache/jmeter/report/core/SampleWriter.java > jmeter/trunk/src/core/org/apache/jmeter/report/ > dashboard/TemplateVisitor.java > jmeter/trunk/src/core/org/apache/jmeter/report/ > processor/FilterConsumer.java > jmeter/trunk/src/core/org/apache/jmeter/report/ > processor/TaggerConsumer.java > jmeter/trunk/src/core/org/apache/jmeter/reporters/ > ResultCollectorHelper.java > jmeter/trunk/src/core/org/apache/jmeter/reporters/gui/ > ResultActionGui.java > jmeter/trunk/src/core/org/apache/jmeter/resources/ > messages_fr.properties > jmeter/trunk/src/core/org/apache/jmeter/samplers/ > AsynchSampleSender.java > jmeter/trunk/src/core/org/apache/jmeter/samplers/ > SampleSenderFactory.java > jmeter/trunk/src/core/org/apache/jmeter/samplers/ > StatisticalSampleSender.java > jmeter/trunk/src/core/org/apache/jmeter/save/CSVSaveService.java > jmeter/trunk/src/core/org/apache/jmeter/save/ > ScriptWrapperConverter.java > jmeter/trunk/src/core/org/apache/jmeter/save/converters/ > HashTreeConverter.java > jmeter/trunk/src/core/org/apach
Re: svn commit: r1817321 [1/3] - in /jmeter/trunk: ./ docs/images/screenshots/ docs/images/screenshots/http-config/ docs/images/screenshots/webtest/ src/components/org/apache/jmeter/assertions/ src/co
PNG Files reverted 2017-12-06 23:37 GMT+01:00 Philippe Mouawad : > On Wed, Dec 6, 2017 at 11:21 PM, wrote: > > > Author: agomes > > Date: Wed Dec 6 22:21:19 2017 > > New Revision: 1817321 > > > > URL: http://svn.apache.org/viewvc?rev=1817321&view=rev > > Log: > > This closes #345 - Updated to latest checkstyle (v8.5), Added many more > > rules to checkstyle, Included checking of test files and more file types. > > Contributed by Graham Russell > > > > Modified: > > jmeter/trunk/build.properties > > jmeter/trunk/build.xml > > jmeter/trunk/checkstyle-suppressions.xml > > jmeter/trunk/checkstyle.xml > > jmeter/trunk/docs/images/screenshots/Proxy_Run.png > > jmeter/trunk/docs/images/screenshots/Select-Templates-Icon.png > > jmeter/trunk/docs/images/screenshots/Test_Generated.png > > jmeter/trunk/docs/images/screenshots/Validate-Test-Plan.png > > jmeter/trunk/docs/images/screenshots/example-recording.png > > jmeter/trunk/docs/images/screenshots/example-thread-group.png > > jmeter/trunk/docs/images/screenshots/http-config/http- > > request-defaults.png > > jmeter/trunk/docs/images/screenshots/template_menu.png > > jmeter/trunk/docs/images/screenshots/webtest/http-defaults1.png > > jmeter/trunk/docs/images/screenshots/webtest/http-defaults2.png > > jmeter/trunk/docs/images/screenshots/webtest/http-request1.png > > jmeter/trunk/docs/images/screenshots/webtest/http-request2.png > > jmeter/trunk/docs/images/screenshots/webtest/http_login.png > > jmeter/trunk/docs/images/screenshots/webtest/threadgroup.png > > jmeter/trunk/docs/images/screenshots/webtest/threadgroup2.png > > jmeter/trunk/src/components/org/apache/jmeter/assertions/ > > JSONPathAssertion.java > > jmeter/trunk/src/components/org/apache/jmeter/assertions/ > > ResponseAssertion.java > > jmeter/trunk/src/components/org/apache/jmeter/assertions/ > > gui/BeanShellAssertionGui.java > > jmeter/trunk/src/components/org/apache/jmeter/assertions/ > > gui/JSONPathAssertionGui.java > > jmeter/trunk/src/components/org/apache/jmeter/control/ > > ThroughputController.java > > jmeter/trunk/src/components/org/apache/jmeter/extractor/ > > gui/HtmlExtractorGui.java > > jmeter/trunk/src/components/org/apache/jmeter/extractor/ > > json/jsonpath/JSONManager.java > > jmeter/trunk/src/components/org/apache/jmeter/reporters/ > > MailerModel.java > > jmeter/trunk/src/components/org/apache/jmeter/timers/ > > ConstantThroughputTimerBeanInfo.java > > jmeter/trunk/src/components/org/apache/jmeter/visualizers/Graph.java > > jmeter/trunk/src/components/org/apache/jmeter/visualizers/ > > RenderAsXML.java > > jmeter/trunk/src/components/org/apache/jmeter/visualizers/ > > RenderInBrowser.java > > jmeter/trunk/src/components/org/apache/jmeter/visualizers/ > > ViewResultsFullVisualizer.java > > jmeter/trunk/src/components/org/apache/jmeter/visualizers/ > > backend/BackendListener.java > > jmeter/trunk/src/core/org/apache/jmeter/NewDriver.java > > jmeter/trunk/src/core/org/apache/jmeter/assertions/gui/ > > AbstractAssertionGui.java > > jmeter/trunk/src/core/org/apache/jmeter/config/gui/ > > SimpleConfigGui.java > > jmeter/trunk/src/core/org/apache/jmeter/functions/gui/ > > FunctionHelper.java > > jmeter/trunk/src/core/org/apache/jmeter/gui/GlobalUndoableEdit.java > > jmeter/trunk/src/core/org/apache/jmeter/gui/UndoHistoryItem.java > > jmeter/trunk/src/core/org/apache/jmeter/gui/action/RemoteStart.java > > jmeter/trunk/src/core/org/apache/jmeter/gui/util/ > HorizontalPanel.java > > jmeter/trunk/src/core/org/apache/jmeter/gui/util/MenuFactory.java > > jmeter/trunk/src/core/org/apache/jmeter/gui/util/ > PowerTableModel.java > > jmeter/trunk/src/core/org/apache/jmeter/gui/util/VerticalPanel.java > > jmeter/trunk/src/core/org/apache/jmeter/gui/util/theme/ > > darcula_theme.xml > > jmeter/trunk/src/core/org/apache/jmeter/report/core/ > SampleBuilder.java > > jmeter/trunk/src/core/org/apache/jmeter/report/core/ > > SampleMetaDataParser.java > > jmeter/trunk/src/core/org/apache/jmeter/report/core/ > SampleWriter.java > > jmeter/trunk/src/core/org/apache/jmeter/report/ > > dashboard/TemplateVisitor.java > > jmeter/trunk/src/core/org/apache/jmeter/report/ > > processor/FilterConsumer.java > > jmeter/trunk/src/core/org/apache/jmeter/report/ > > processor/TaggerConsumer.java > > jmeter/trunk/src/core/org/apache/jmeter/reporters/ > > ResultCollectorHelper.java > > jmeter/trunk/src/core/org/apache/jmeter/reporters/gui/ > > ResultActionGui.java > > jmeter/trunk/src/core/org/apache/jmeter/resources/ > > messages_fr.properties > > jmeter/trunk/src/core/org/apache/jmeter/samplers/ > > AsynchSampleSender.java > > jmeter/trunk/src/core/org/apache/jmeter/samplers/ > > SampleSenderFactory.java > > jmeter/trunk/src/core/org/apache/jmeter/samplers/ > > StatisticalSampleSender.java > >
