buildbot success in on jmeter-trunk

2018-04-02 Thread buildbot
The Buildbot has detected a restored build on builder jmeter-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/3691

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: bb_slave1_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit' 
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1828164
Blamelist: pmouawad

Build succeeded!

Sincerely,
 -The Buildbot





Re: HTTP Request : What to do with the Parameters tab entries for every method (was HTTP Request : Behaviour of PUT)

2018-04-02 Thread Philippe Mouawad
Hello,
Fixed within:
https://bz.apache.org/bugzilla/show_bug.cgi?id=62248

Regards

On Tue, Aug 29, 2017 at 11:01 PM, Philippe Mouawad <
philippe.moua...@gmail.com> wrote:

> Thanks Felix
>
> On Tue, Aug 29, 2017 at 2:21 PM, Felix Schumacher <
> felix.schumac...@internetallee.de> wrote:
>
>> Am 27.08.2017 um 21:56 schrieb Philippe Mouawad:
>>
>>> Hello,
>>> Any thought  on this ?
>>> It is related to Bug *60782*
>>> 
>>> Thanks
>>>
>> If I read it right, it is about two things.
>>
>> First, whether PUT (and other methods) should behave consistently and NOT
>> ignore the parameters tab.
>> +1 from me. PUT and consorts should not ignore the parameters.
>>
>> Second, whether the parameters entered in the tab should be appended to
>> the url, or posted as body.
>> Current behaviour GET appends, POST uses the body and every other method
>> ignores them.
>>
>> I would start using the body for all methods except GET, as this is in my
>> mind the most likely intended behaviour.
>>
>> Felix (very sorry, that it took me so long to answer this)
>>
>>
>>>
>>> On Tue, Feb 28, 2017 at 10:46 PM, Philippe Mouawad <
>>> philippe.moua...@gmail.com> wrote:
>>>
>>> Hello,
 As per sebb will, I open a new discussion to decide:
 1) what to do for each method
 2) Which one takes precedence

 Regards
 Philippe



>>>
>>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>
>
>


-- 
Cordialement.
Philippe Mouawad.


Re: HTTP Request : Behaviour of PUT

2018-04-02 Thread Philippe Mouawad
Fixed in:
https://bz.apache.org/bugzilla/show_bug.cgi?id=62248

On Sat, May 20, 2017 at 4:30 PM, Philippe Mouawad <
philippe.moua...@gmail.com> wrote:

> Hi,
> New ping.
>
> Thanks for any feedback
>
> On Wednesday, April 19, 2017, Philippe Mouawad 
> wrote:
>
>> Hello,
>> Any thoughts on that ?
>> Thanks
>>
>> On Sat, Mar 18, 2017 at 2:00 PM, Philippe Mouawad <
>> philippe.moua...@gmail.com> wrote:
>>
>>> Hello,
>>> For follow up, discussion was related to:
>>> https://bz.apache.org/bugzilla/show_bug.cgi?id=60782
>>>
>>> Regards
>>>
>>> On Tue, Feb 28, 2017 at 6:00 PM, sebb  wrote:
>>>
 On 28 February 2017 at 12:11, Philippe Mouawad
  wrote:
 > Hello,
 > It seems other method are also concerned.
 > Except for POST, do you think all methods should put in URL the
 parameters
 > in table ?

 The problem with PUT is that it does nothing with the Parameters tab
 entries.

 Whether it should append them to the URL or send them as body text is
 another discussion.

 Also whether parameters are allowed in both places, and if so, which
 takes precedence.

 > Regards
 >
 > On Mon, Feb 27, 2017 at 11:37 PM, Philippe Mouawad <
 > philippe.moua...@gmail.com> wrote:
 >
 >> Ok, I have a fix then.
 >> I'll commit it.
 >>
 >> On Mon, Feb 27, 2017 at 11:33 PM, sebb  wrote:
 >>
 >>> PUT seems to ignore the Parameters tab entirely.
 >>>
 >>> That does not seem right.
 >>>
 >>> Get appends any Parameters to the URL.
 >>>
 >>> On 27 February 2017 at 22:22, Philippe Mouawad
 >>>  wrote:
 >>> > Hello,
 >>> > Currently when you set this in HTTP REquest:
 >>> >
 >>> > Method : PUT
 >>> > Path: /test?name0=value0
 >>> > Send Parameters with Request : name1 in Name: column / value1 in
 Value
 >>> >
 >>> > JMeter emits :
 >>> > PUT http://localhost:8081/test?name0=value0
 >>> >
 >>> > Ignoring Send Parameters with Request content.
 >>> >
 >>> > Is this regular ?
 >>> >
 >>> > --
 >>> > Cordialement.
 >>> > Philippe Mouawad.
 >>>
 >>
 >>
 >>
 >> --
 >> Cordialement.
 >> Philippe Mouawad.
 >>
 >>
 >>
 >
 >
 > --
 > Cordialement.
 > Philippe Mouawad.

>>>
>>>
>>>
>>> --
>>> Cordialement.
>>> Philippe Mouawad.
>>>
>>>
>>>
>>
>>
>> --
>> Cordialement.
>> Philippe Mouawad.
>>
>>
>>
>
> --
> Cordialement.
> Philippe Mouawad.
>
>
>
>


-- 
Cordialement.
Philippe Mouawad.


[GitHub] jmeter pull request #378: Fix 43612

2018-04-02 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/378


---