buildbot failure in on jmeter-nightly
The Buildbot has detected a new failure on builder jmeter-nightly while building . Full details are available at: https://ci.apache.org/builders/jmeter-nightly/builds/1182 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: bb_slave7_ubuntu Build Reason: The Nightly scheduler named 'jmeterNightly' triggered this build Build Source Stamp: [branch jmeter/trunk] HEAD Blamelist: BUILD FAILED: failed shell_5 Sincerely, -The Buildbot
[GitHub] jmeter issue #404: Use log string format instead of doing the concatenation ...
Github user codecov-io commented on the issue: https://github.com/apache/jmeter/pull/404 # [Codecov](https://codecov.io/gh/apache/jmeter/pull/404?src=pr=h1) Report > Merging [#404](https://codecov.io/gh/apache/jmeter/pull/404?src=pr=desc) into [trunk](https://codecov.io/gh/apache/jmeter/commit/3b0824af03d9bf51d1604b3ac39186c891295234?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `33.33%`. [](https://codecov.io/gh/apache/jmeter/pull/404?src=pr=tree) ```diff @@ Coverage Diff @@ ## trunk #404 +/- ## + Coverage 58.58% 58.58% +<.01% + Complexity1061810617 -1 Files 1193 1193 Lines 7596675959 -7 Branches 7349 7344 -5 + Hits 4450144502 +1 + Misses2895528952 -3 + Partials 2510 2505 -5 ``` | [Impacted Files](https://codecov.io/gh/apache/jmeter/pull/404?src=pr=tree) | Coverage Π| Complexity Π| | |---|---|---|---| | [.../jmeter/protocol/http/sampler/HTTPSamplerBase.java](https://codecov.io/gh/apache/jmeter/pull/404/diff?src=pr=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9zYW1wbGVyL0hUVFBTYW1wbGVyQmFzZS5qYXZh) | `62.07% <33.33%> (+1.21%)` | `193 <6> (ø)` | :arrow_down: | | [...s/org/apache/jmeter/timers/PoissonRandomTimer.java](https://codecov.io/gh/apache/jmeter/pull/404/diff?src=pr=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvdGltZXJzL1BvaXNzb25SYW5kb21UaW1lci5qYXZh) | `72.97% <0%> (-5.41%)` | `9% <0%> (-1%)` | | | [...ocol/jms/org/apache/jmeter/protocol/jms/Utils.java](https://codecov.io/gh/apache/jmeter/pull/404/diff?src=pr=tree#diff-c3JjL3Byb3RvY29sL2ptcy9vcmcvYXBhY2hlL2ptZXRlci9wcm90b2NvbC9qbXMvVXRpbHMuamF2YQ==) | `54.83% <0%> (-2.16%)` | `15% <0%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/jmeter/pull/404?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Π= absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/jmeter/pull/404?src=pr=footer). Last update [3b0824a...bf424d4](https://codecov.io/gh/apache/jmeter/pull/404?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---
[GitHub] jmeter pull request #404: Use log string format instead of doing the concate...
GitHub user FSchumacher opened a pull request: https://github.com/apache/jmeter/pull/404 Use log string format instead of doing the concatenation ourselves ## Description Simplify code. ## Motivation and Context Make code a bit more readable by using placeholders for the parameters. We can get rid of a few `if` statements, where parameters are used directly in the log statements. ## How Has This Been Tested? No functional change. ## Screenshots (if appropriate): ## Types of changes - code cleanup ## Checklist: - [x] My code follows the [code style][style-guide] of this project. [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines You can merge this pull request into a Git repository by running: $ git pull https://github.com/FSchumacher/jmeter use-log-string-format Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/404.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #404 commit bf424d461e4fc16d2142865f92bbf8ac0e72c807 Author: Felix Schumacher Date: 2018-10-10T20:21:43Z Use log string format instead of doing the concatenation ourselves Make code a bit more readable by using placeholders for the parameters. We can get rid of a few `if` statements, where parameters are used directly in the log statements. ---
[GitHub] jmeter issue #403: Use simpler code for "static" String concatenation
Github user codecov-io commented on the issue: https://github.com/apache/jmeter/pull/403 # [Codecov](https://codecov.io/gh/apache/jmeter/pull/403?src=pr=h1) Report > Merging [#403](https://codecov.io/gh/apache/jmeter/pull/403?src=pr=desc) into [trunk](https://codecov.io/gh/apache/jmeter/commit/3b0824af03d9bf51d1604b3ac39186c891295234?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `53.84%`. [](https://codecov.io/gh/apache/jmeter/pull/403?src=pr=tree) ```diff @@ Coverage Diff @@ ## trunk #403 +/- ## + Coverage 58.58% 58.58% +<.01% - Complexity1061810619 +1 Files 1193 1193 Lines 7596675964 -2 Branches 7349 7348 -1 Hits 4450144501 Misses2895528955 + Partials 2510 2508 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/jmeter/pull/403?src=pr=tree) | Coverage Π| Complexity Π| | |---|---|---|---| | [...s/org/apache/jmeter/extractor/XPath2Extractor.java](https://codecov.io/gh/apache/jmeter/pull/403/diff?src=pr=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvZXh0cmFjdG9yL1hQYXRoMkV4dHJhY3Rvci5qYXZh) | `25.3% <0%> (ø)` | `14 <0> (ø)` | :arrow_down: | | [...ts/org/apache/jmeter/extractor/RegexExtractor.java](https://codecov.io/gh/apache/jmeter/pull/403/diff?src=pr=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvZXh0cmFjdG9yL1JlZ2V4RXh0cmFjdG9yLmphdmE=) | `86.6% <100%> (ø)` | `68 <0> (ø)` | :arrow_down: | | [...s/org/apache/jmeter/assertions/XPathAssertion.java](https://codecov.io/gh/apache/jmeter/pull/403/diff?src=pr=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvYXNzZXJ0aW9ucy9YUGF0aEFzc2VydGlvbi5qYXZh) | `65.38% <33.33%> (+0.82%)` | `24 <0> (ø)` | :arrow_down: | | [...ts/org/apache/jmeter/extractor/XPathExtractor.java](https://codecov.io/gh/apache/jmeter/pull/403/diff?src=pr=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvZXh0cmFjdG9yL1hQYXRoRXh0cmFjdG9yLmphdmE=) | `82.17% <66.66%> (ø)` | `43 <2> (ø)` | :arrow_down: | | [...rg/apache/jmeter/functions/XPathFileContainer.java](https://codecov.io/gh/apache/jmeter/pull/403/diff?src=pr=tree#diff-c3JjL2Z1bmN0aW9ucy9vcmcvYXBhY2hlL2ptZXRlci9mdW5jdGlvbnMvWFBhdGhGaWxlQ29udGFpbmVyLmphdmE=) | `86.2% <66.66%> (+6.2%)` | `8 <0> (ø)` | :arrow_down: | | [...ocol/jms/org/apache/jmeter/protocol/jms/Utils.java](https://codecov.io/gh/apache/jmeter/pull/403/diff?src=pr=tree#diff-c3JjL3Byb3RvY29sL2ptcy9vcmcvYXBhY2hlL2ptZXRlci9wcm90b2NvbC9qbXMvVXRpbHMuamF2YQ==) | `54.83% <0%> (-2.16%)` | `15% <0%> (ø)` | | | [...che/jmeter/protocol/http/sampler/HTTPJavaImpl.java](https://codecov.io/gh/apache/jmeter/pull/403/diff?src=pr=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9zYW1wbGVyL0hUVFBKYXZhSW1wbC5qYXZh) | `65.75% <0%> (+0.34%)` | `51% <0%> (+1%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/jmeter/pull/403?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Π= absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/jmeter/pull/403?src=pr=footer). Last update [3b0824a...79890d4](https://codecov.io/gh/apache/jmeter/pull/403?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---
[GitHub] jmeter pull request #403: Use simpler code for "static" String concatenation
GitHub user FSchumacher opened a pull request:
https://github.com/apache/jmeter/pull/403
Use simpler code for "static" String concatenation
## Description
Simplify code for String concatenation
## Motivation and Context
Java is smart enough to compile simple string concatenation `"something" +
x` to
the same code as `new StringBuilder("something").append(x).toString()`.
The latter is really hard to read, so use the simpler one.
While at it, use string formats for the logger (as it is some sort of string
concatenation, too). And since we use the string formatter, we don't have
to guard the log level anymore for the simple case.
## How Has This Been Tested?
## Screenshots (if appropriate):
## Types of changes
- code simplification, no functional change
## Checklist:
- [x] My code follows the [code style][style-guide] of this project.
[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/FSchumacher/jmeter
simple-string-instead-stringbuilder
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/403.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #403
commit 79890d4312a6797a96624498545e02c1c35f98c1
Author: Felix Schumacher
Date: 2018-10-10T19:43:01Z
Use simpler code for "static" String concatenation
Java is smart enough to compile simple string concatenation to
the same code as `new StringBuilder("something").append("other
thing").toString()`.
The latter is really hard to read, so use the simpler one.
While at it, use string formats for the logger (as it is some sort of string
concatenation, too). And since we use the string formatter, we don't have
to guard the log level anymore for the simple case.
---
[GitHub] jmeter pull request #402: Use isEmpty instead of comparing size of a collect...
Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/402 ---
