[GitHub] [jmeter] FSchumacher commented on pull request #608: Bug 64553 When using Transaction Controller, send Bytes and Received Bytes are displayed as 0 in the influxdb(BackendListener)

2020-08-27 Thread GitBox


FSchumacher commented on pull request #608:
URL: https://github.com/apache/jmeter/pull/608#issuecomment-682145319


   > Hello @FSchumacher , @ham1 ,
   > Thanks for improving the PR.
   > Can it be merged now ?
   
   If it is still doing, what you intended, you can merge the PR.
   
   Felix
   
   > 
   > Regards
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




Re: Release a new version 5.3.1 ?

2020-08-27 Thread Felix Schumacher



Am 27. August 2020 15:53:31 MESZ schrieb Philippe Mouawad 
:
>Hello,
>Oups previous mail was sent too fast.
>
>I hope you're all fine and have spent  nice holidays if you did.
>
>I think we are ready for a release right ?
>Pending issues are:
>- https://github.com/apache/jmeter/pull/608 for bug 64553
>- https://bz.apache.org/bugzilla/show_bug.cgi?id=64624 which has a
>patch
>from Felix waiting for confirmation

Here it would be nice, if you could have a look at it, as you did the original 
implementation, if I recall correctly. 

Another pr (#595) that could probably be merged is the one about freestyle 
naming for samples recorded by the proxy. 

And what about #593? 

>
>Since 5.3 has some regressions, it would be nice to release a version
>soon.

+1

Felix 

>Thanks


Re: Release a new version 5.3.1 ?

2020-08-27 Thread Philippe Mouawad
Hello,
Oups previous mail was sent too fast.

I hope you're all fine and have spent  nice holidays if you did.

I think we are ready for a release right ?
Pending issues are:
- https://github.com/apache/jmeter/pull/608 for bug 64553
- https://bz.apache.org/bugzilla/show_bug.cgi?id=64624 which has a patch
from Felix waiting for confirmation

Since 5.3 has some regressions, it would be nice to release a version soon.
Thanks

-- 
Cordialement.
Philippe Mouawad.


>
On Thu, Aug 27, 2020 at 3:49 PM Philippe Mouawad 
wrote:

> Hello,
>
> I think we are ready for a release right ?
> Pending issues are:
> - https://github.com/apache/jmeter/pull/608 for bug 64553
>
> On Sun, Jul 26, 2020 at 7:54 PM Philippe Mouawad <
> philippe.moua...@gmail.com> wrote:
>
>> Hello,
>> Thanks for the answer.
>> Unfortunately, we need to wait for 3 fixes in Darklaf:
>>
>>- https://bz.apache.org/bugzilla/show_bug.cgi?id=64626
>>- https://bz.apache.org/bugzilla/show_bug.cgi?id=64625
>>- https://bz.apache.org/bugzilla/show_bug.cgi?id=64453
>>
>> The first one being a blocker for any release.
>>
>> Regards
>>
>> On Sun, Jul 26, 2020 at 7:49 PM Milamber  wrote:
>>
>>>
>>> Why not. The release process is fast.
>>>
>>> On 7/25/20 1:14 PM, Philippe Mouawad wrote:
>>> > Hello,
>>> > Shouldn’t we release a new version 5.3.1 ?
>>> >
>>> > The 5.3 version has many GUI issues that are particularly visible on
>>> > Windows OS making it partly unusable.
>>> > Some are visible on all OS particularly with popular 3rd party plugins.
>>> > The workaround is to switch to system  LAF but users may not be aware
>>> of
>>> > this.
>>> >
>>> > There has been many fixes on Darklaf thanks to Jannis reactivity but
>>> there
>>> > are still now issues.
>>> > I wonder if we should not switch LAF on windows to the system one
>>> until we
>>> > have identified and fixed all issues.
>>> >
>>> >
>>> > Regards
>>> > Philippe
>>> >
>>> >
>>> >
>>>
>>>
>>
>> --
>> Cordialement.
>> Philippe Mouawad.
>>
>>
>>
>
> --
> Cordialement.
> Philippe Mouawad.
>
>
>

-- 
Cordialement.
Philippe Mouawad.


Re: Release a new version 5.3.1 ?

2020-08-27 Thread Philippe Mouawad
Hello,

I think we are ready for a release right ?
Pending issues are:
- https://github.com/apache/jmeter/pull/608 for bug 64553

On Sun, Jul 26, 2020 at 7:54 PM Philippe Mouawad 
wrote:

> Hello,
> Thanks for the answer.
> Unfortunately, we need to wait for 3 fixes in Darklaf:
>
>- https://bz.apache.org/bugzilla/show_bug.cgi?id=64626
>- https://bz.apache.org/bugzilla/show_bug.cgi?id=64625
>- https://bz.apache.org/bugzilla/show_bug.cgi?id=64453
>
> The first one being a blocker for any release.
>
> Regards
>
> On Sun, Jul 26, 2020 at 7:49 PM Milamber  wrote:
>
>>
>> Why not. The release process is fast.
>>
>> On 7/25/20 1:14 PM, Philippe Mouawad wrote:
>> > Hello,
>> > Shouldn’t we release a new version 5.3.1 ?
>> >
>> > The 5.3 version has many GUI issues that are particularly visible on
>> > Windows OS making it partly unusable.
>> > Some are visible on all OS particularly with popular 3rd party plugins.
>> > The workaround is to switch to system  LAF but users may not be aware of
>> > this.
>> >
>> > There has been many fixes on Darklaf thanks to Jannis reactivity but
>> there
>> > are still now issues.
>> > I wonder if we should not switch LAF on windows to the system one until
>> we
>> > have identified and fixed all issues.
>> >
>> >
>> > Regards
>> > Philippe
>> >
>> >
>> >
>>
>>
>
> --
> Cordialement.
> Philippe Mouawad.
>
>
>

-- 
Cordialement.
Philippe Mouawad.


[GitHub] [jmeter] pmouawad commented on pull request #608: Bug 64553 When using Transaction Controller, send Bytes and Received Bytes are displayed as 0 in the influxdb(BackendListener)

2020-08-27 Thread GitBox


pmouawad commented on pull request #608:
URL: https://github.com/apache/jmeter/pull/608#issuecomment-681960538


   Hello @FSchumacher , @ham1 ,
   Thanks for improving the PR.
   Can it be merged now ?
   
   Regards
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org