[GitHub] jmeter pull request #281: misc logging improvements
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/281 misc logging improvements misc logging improvements You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter logyeah Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/281.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #281 commit ba86af289c644fb82a3ae2e0b53f4eda15761960 Author: benoit Date: 2017-03-08T11:48:53Z misc logging improvements --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request #280: Misc clean up
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/280 Misc clean up mainly lambdas and commented code You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter miscclean Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/280.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #280 commit 8122fdeb7b3b779ffae7f2f7cf4d65c8c8d6fc2d Author: benoit Date: 2017-03-07T18:12:35Z use lambdas commit 7f3cc036dd6fa9b27ba568d6a6ca72ad3958658a Author: benoit Date: 2017-03-07T18:12:51Z add missing @Override commit ba987f0045c5b6fb4e3e8e727d34d30f98d1a550 Author: benoit Date: 2017-03-07T18:14:01Z remove code that was commented 10 years ago commit 47115c30297af3b56331c9b1cc21aff749c10d6e Author: benoit Date: 2017-03-07T18:17:16Z remove code that was commented 12 years ago commit db04821f2462f097ac5f3920edbd1db621670b85 Author: benoit Date: 2017-03-07T18:22:07Z if simplification commit 1e2492ea403d1e8e57f79b7c9fc2e86d5eb77b35 Author: benoit Date: 2017-03-07T18:22:53Z add missing @Deprecated commit 790fb38503ca11d31b5440b055a747d17770c644 Author: benoit Date: 2017-03-07T18:24:00Z clean up --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request #229: tiny memory allocation improvements
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/229 tiny memory allocation improvements add a test for JOrphanUtils#rightAlign You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter tiny Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/229.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #229 commit 805e4e5f20c805dbac1555a783665d32436e1ca9 Author: benoit Date: 2016-09-20T08:31:05Z tiny memory allocation improvement add a test for JOrphanUtils#rightAlign --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request #228: small memory improvement : do dot convert all the ...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/228 small memory improvement : do dot convert all the url to check the prefix You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter small-perf Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/228.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #228 commit f716f89e28aeab963a7a0f15c4b24927b475c7bf Author: benoit Date: 2016-09-08T12:32:00Z small memory improvement : do dot convert all the url to check the prefix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request #219: Bug 59885 Optimize css parsing for embedded resour...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/219 Bug 59885 Optimize css parsing for embedded resources download the css parser is essential to test real world applications with embedded resources download. But it's heavy on cpu and memory allocations. this commit add a lru cache which saves the url extracted from the css file. the key of the cache is the md5 of the css file. the cache is not enabled by default (but should probably be) To activate it, a value > 0 must be set for the key 'css.parser.cache.size' in the jmeter config file You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter css_parser_cache Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/219.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #219 commit 13578dd0a502244ac6329751d3f1dd83447569d0 Author: benoit Date: 2016-07-19T09:58:49Z Bug 59885 Optimize css parsing for embedded resources download the css parser is essential to test real world applications with embedded resources download. But it's heavy on cpu and memory allocations. this commit add a lru cache which saves the url extracted from the css file. the key of the cache is the md5 of the css file. the cache is not enabled by default (but should probably be) To activate it, a value > 0 must be set for the key 'css.parser.cache.size' in the jmeter config file --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request #218: Misc clean u
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/218 Misc clean u code duplication unused import etc.. You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter misc_http_cleanup Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/218.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #218 commit d4084d40a4b06dfaf9df0ec33fbd501b39fbeedc Author: benoit Date: 2016-07-19T07:35:21Z Misc clean up code duplication unused import etc.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request #217: Bug 59882 : JMeter memory allocations reduction
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/217 Bug 59882 : JMeter memory allocations reduction I've been profiling jmeter memory allocation under different conditions the PR linked to this bug gives substantial improvements. Gain really depends on the test but in the worst case (compressed content, no embedded resources) it's about 15% less allocations (in bytes) When not compressed (no embedded resources) and if content-length is sent by the server my test gives 30% reduction in bytes allocated As always YMMV but this PR is always a win in all my different tests. Reduction in memory allocated comes from Better usage of ByteArrayOutputStream by - directly accessing the buffer instead of copying it - or by using the commons-lang implementation which avoid copying memory around when extending the buffer - or by creating the string directly from the buffer instead of a temporary copy Avoid unneeded string concatenation due to missing log.isDebugEnabled() if possible use httpclient CharArrayBuffer to avoid memory allocations Do not create unneeded silent exceptions Do not allocate 2 empty iterators on each call to executeSamplePackage - LinkedList.iterator() is a stinky monkey. Also see HTTPCORE-361 Set better default size to StringBuilder buffers improve JOrphanUtils#replaceAllChars : provides a fast path which does not allocate memory etc.. **Remark** : When using ssl, jsse is a major source of unneeded allocation (sun.security.ssl.SSLContextImpl#getDefaultCipherSuiteList(boolean)) https://bugs.openjdk.java.net/browse/JDK-8133070 should improve the situation (I did not test it) the title of the bug is misleading as it's also about an internal cache beeing cleared on each method call. You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter memory-allocation1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/217.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #217 commit 6019c57fd9caf03d3df22ca5e7cf3888713f193f Author: benoit Date: 2016-07-12T07:29:15Z Profiling show that jmeter is doing a lot of unneeded memory allocation. use a specialized version of ByteArrayOutputStream which return its internal buffer when possible, this remove an allocation of byte[response size] when the content length is known and respected. do not create a buffer + copy when generating a md5 signature lazily allocate the ByteArrayOutputStream buffer which is not needed when it's an empty response commit 3ae3c497e182727736540526fcdedd73713b0f57 Author: benoit Date: 2016-07-12T20:11:45Z do not copy byte buffer on string construction commit f1e1d0e052bc453f1e768872f4458b636edea3d1 Author: benoit Date: 2016-07-12T20:12:42Z avoid stringbuilder alllocation commit e987f4af35d9f264ff530cbe60a962ed594794ca Author: benoit Date: 2016-07-12T20:13:49Z re-order test for speed commit ff991554431d1e89f88f3b0071f5de5a580613b3 Author: benoit Date: 2016-07-12T20:36:22Z getResponseHeaders is allocating too much memory try to give a better default size to the stringbuilder use httpclient CharArrayBuffer to avoid memory allocations commit 196910cba6fcef9b57081ef2f41d463b4617340f Author: benoit Date: 2016-07-12T20:47:30Z in the jmx file you often find : this makes getPortIfSpecified throws a "silent" exception this is bad as it's slow and allocates memory for the trace commit 2d215e9e8c6e3ec4a6777e78a34348c302411891 Author: benoit Date: 2016-07-12T21:25:33Z do not allocate 2 empty iterators on each call to executeSamplePackage. It's always >5% of the memory allocated during my tests commit 7a53bdc99631c9338660cb1284be7a19c5c39eb9 Author: benoit Date: 2016-07-13T07:43:54Z add a fast path which does not allocate memory when there is no arguments. construct the buffer with a better initial size to avoid re-allocations commit 3e2c5921ea61765137d2db6a6acfea1d327b67c9 Author: benoit Date: 2016-07-13T07:44:38Z avoid unneeded access to the property map and boolean parsing commit b59e095eaf115efbfb115b56362a54595a9684de Author: benoit Date: 2016-07-13T08:37:33Z add a better default sizing for the getConnectionHeaders buffer commit e52044a306f791ced03ed015bc827d8cc602b6ae Author: benoit Date: 2016-07-13T08:42:29Z re-use pattern instead of re-creating it commit 1c6fc75952ca5be66a448ca41c05bcff1be12266 Author: benoit Date: 2016-07-13T09:45:31Z improve JOrphanUtils#replaceAllChars provides a fast
[GitHub] jmeter pull request #216: re-use pattern when possible
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/216 re-use pattern when possible You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter pattern_reuse Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/216.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #216 commit 6b77107184a7acaeab14fc77cdd084bc061d2e03 Author: benoit Date: 2016-07-18T12:25:23Z re-use pattern when possible --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request #215: re-use GuiUtils#cancelEditing instead of duplicate...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/215 re-use GuiUtils#cancelEditing instead of duplicated code Share the cell editing cancellation You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter reuse_guiutil Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/215.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #215 commit 3c584981f34dc515b35d39640e0c5474ef8174ea Author: benoit Date: 2016-07-18T08:07:10Z re-use GuiUtils#cancelEditing instead of duplicated code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request #213: 59816 : Allow multiple selection and delete in 'HT...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/213 59816 : Allow multiple selection and delete in 'HTTP Header Manager' panel Share the editing cancellation in GuiUtils as for the stop editing. You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter headers-multi Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/213.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #213 commit 52ab212fab92d9c37331c071dd5983adaf623a1c Author: benoit Date: 2016-06-27T15:31:00Z 59816 : Allow multiple selection and delete in 'HTTP Header Manager' panel Share the editing cancellation in GuiUtils as for the stop editing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #212: Bug 59759 : Allow multiple selection and delete in 'HTTP ...
Github user benbenw commented on the issue: https://github.com/apache/jmeter/pull/212 slf4j is now supported instead of logkit --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request #212: Bug 59759 : Allow multiple selection and delete in...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/212 Bug 59759 : Allow multiple selection and delete in 'HTTP Authorization Manager' panel Yeah ! You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter auth-multi Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/212.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #212 commit 608d1f4e67584a7117225e341caffc51b07e469b Author: benoit Date: 2016-06-27T13:44:17Z Bug 59759 : Allow multiple selection and delete in 'HTTP Authorization Manager' panel --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: java constants naming
Github user benbenw closed the pull request at: https://github.com/apache/jmeter/pull/171 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: java constants naming
Github user benbenw commented on the pull request: https://github.com/apache/jmeter/pull/171#issuecomment-198878856 Hello vlsi I could but this will break your build as there are many remaining violations. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 59197 : it should be possible to only run...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/170 Bug 59197 : it should be possible to only run a single threadgroup or a selection of threadgroups. Right click on the TG and choose Start or Start no pauses You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter runtg Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/170.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #170 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: deprecate some methods in JMeterUtils
Github user benbenw commented on the pull request: https://github.com/apache/jmeter/pull/148#issuecomment-198284154 ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: java constants naming
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/171 java constants naming You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter javanaming Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/171.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #171 commit 2c291a3547387a43ecaed2aa926fef045d6f263d Author: benoit Date: 2016-03-18T16:37:13Z java constants naming --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: bug 58426 move the jtable hdpi ui improvement...
Github user benbenw closed the pull request at: https://github.com/apache/jmeter/pull/160 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: bug 58426 move the jtable hdpi ui improvement...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/160 bug 58426 move the jtable hdpi ui improvements into a single method You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter hdpifactor Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/160.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #160 commit 39f6dcc4d6b05cae41e4c13ae58af11d0c06018f Author: benoit Date: 2016-03-05T18:13:12Z bug 58426 move the jtable hdpi ui improvements into a single method --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Change the running indicator
Github user benbenw closed the pull request at: https://github.com/apache/jmeter/pull/152 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: PR for BUG 59116 without tab
Github user benbenw commented on the pull request: https://github.com/apache/jmeter/pull/158#issuecomment-192354414 you should close the previous PR (156). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 52073 Embedded Resources concurrent downl...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/155 Bug 52073 Embedded Resources concurrent download : Improve performances by avoiding shutdown of ThreadPoolExecutor at each sample. A shared thread pool is used for all the parallel downloads. A throttle mechanism is used per user to ensure the max concurrent downloads setting is not exceeded. A new parameter httpsampler.parallel_download_thread_keepalive_inseconds is used to set the thread TTL when idle (default 60s). the parameter httpsampler.await_termination_timeout is not used anymore and has been removed. TODO : ResourcesDownloader#shrink should be called at the end of a test to accelerate the release of the thread pool idle threads (not mandatory) the httpclient is shared between the threads of a given virtual user. the cache is shared between the threads of a given virtual user. You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter resdownload3 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/155.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #155 commit e5ac1cf4dcfb578444766300e9bc5005168acc46 Author: benoit Date: 2016-02-17T22:46:36Z Bug 52073 Embedded Resources concurrent download : Improve performances by avoiding shutdown of ThreadPoolExecutor at each sample. A shared thread pool is used for all the parallel downloads. A throttle mechanism is used per user to ensure the max concurrent downloads setting is not exceeded. A new parameter httpsampler.parallel_download_thread_keepalive_inseconds is used to set the thread TTL when idle (default 60s). the parameter httpsampler.await_termination_timeout is not used anymore and has been removed. TODO : ResourcesDownloader#shrink should be called at the end of a test to accelerate the release of the thread pool idle threads (not mandatory) the httpclient is shared between the threads of a given virtual user. the cache is shared between the threads of a given virtual user. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Remove commented code
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/154 Remove commented code You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter removedeadcode3 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/154.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #154 commit 45f8ccbba690afdb6c6fb1606591d8f388b7e76e Author: benoit Date: 2016-03-03T16:31:06Z Remove commented code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Change the running indicator
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/152 Change the running indicator This is from Milamber work on hdpi (BUG 58426). This patch does not contains the hdpi part but only the icon change You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter runningindicator Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/152.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #152 commit 0c3c52ebbd4c6b98aede1d4f89e7933a895529b0 Author: benoit Date: 2016-03-03T10:42:43Z Change the running indicator This is from Milamber work on hdpi (BUG 58426). This patch does not contains the hdpi part but only the icon change --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: deprecate some methods in JMeterUtils
Github user benbenw commented on the pull request: https://github.com/apache/jmeter/pull/148#issuecomment-191238251 add some javadoc the deprecated method --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: BUG 59095 drop UserParameterXMLParser (was de...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/150 BUG 59095 drop UserParameterXMLParser (was deprecated 8 years ago) and associated classes deprecate UserSequence You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter dropuserxml Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/150.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #150 commit fa507f8117fa080e7c15dacf3971fb28bb99761a Author: benoit Date: 2016-03-02T10:57:03Z BUG 59095 drop UserParameterXMLParser (was deprecated 8 years ago) and associated classes deprecate UserSequence --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: drop some deprecated methods
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/149 drop some deprecated methods Calculator#addValue 4 years ago StatisticalSampleResult constructor 7 years ago You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter dropdepre Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/149.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #149 commit 3fc56dd5b474cd423324b8c72a39eb2a74d37631 Author: benoit Date: 2016-03-02T10:34:43Z drop some deprecated methods Calculator#addValue 4 years ago StatisticalSampleResult constructor 7 years ago --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: deprecate some methods in JMeterUtils
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/148 deprecate some methods in JMeterUtils because creating a button with the netscape style could bring you to jail You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter dilavni Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/148.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #148 commit 67776632f6078fa74927d43e9c47eafceb4c1743 Author: benoit Date: 2016-03-01T20:52:31Z deprecate some methods in jmeterutils because creating a button with the netscape style could bring you to jail --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: move some tests in a dedicated class
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/147 move some tests in a dedicated class You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter splittest2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/147.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #147 commit cc5fb2b14a2ebed6260848fd32f336fd83683fe8 Author: benoit Date: 2016-03-01T17:48:57Z move some tests in a dedicated class --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: remove dead code
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/146 remove dead code remove meaningless comments change javadoc You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter yeahyeahyeah Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/146.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #146 commit d3b1cd1175e1f5a6049832d3773bd37e0d90db8a Author: benoit Date: 2016-03-01T17:46:06Z remove dead code remove meaningless comments change javadoc --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: remove dead code
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/145 remove dead code add comment / javadoc You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter cleanretemj Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/145.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #145 commit f3b7bfbdf3699c2349b8806431186840a9c357a6 Author: benoit Date: 2016-03-01T13:19:05Z remove dead code add comment / javadoc --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 59085 Http file panel : data lost on brow...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/144 Bug 59085 Http file panel : data lost on browse cancellation Http file panel : when clicking on 'browse' if the user cancel his action then the content of the parameter is lost. That's bad. You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter filepanelbrowse Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/144.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #144 commit 240f9b942cf57cf5aba40c9a91b6e4e80678ce62 Author: benoit Date: 2016-02-27T11:28:53Z Bug 59085 Http file panel : when clicking on 'browse' if the user cancel his action then the content of the parameter is lost. That's bad. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 59082 : remove the "TestCompiler.useStati...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/143 Bug 59082 : remove the "TestCompiler.useStaticSet" parameter remove the "TestCompiler.useStaticSet" parameter that was added 3.5 years ago as a way to revert to a previous behavior if something was wrong. The world did not collapse, the parameter is not needed anymore. TestCompiler#IS_USE_STATIC_SET was kept for compatibility. it will be removed in the next version. You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter staticset Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/143.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #143 commit 4bf6264baff8196c6fdc698c934595da02162f8f Author: benoit Date: 2016-02-27T09:21:19Z Bug 59082 : remove the "TestCompiler.useStaticSet" parameter that was added 3.5 years ago as a way to revert to a previous behavior if something was wrong. The world did not collapse, the parameter is not needed anymore. TestCompiler#IS_USE_STATIC_SET was kept for compatibility. it will be removed in the next version. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: rename variables for clarity
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/142 rename variables for clarity You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter ren1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/142.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #142 commit dcdae38dd04ef28ab7100d41a04757c41e5ef854 Author: benoit Date: 2016-02-27T08:22:44Z rename variables for clarity --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 59067 JMeter fail to iterate over SimpleC...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/141 Bug 59067 JMeter fail to iterate over SimpleController after an assertion error. Please review carefully as it may break the world... The controller does not restart at the first sampler The pb is that in JMeterThread#triggerEndOfLoopOnParentControllers the Sampler used is not always the "real" one, but it can be a TransactionSampler, if there are some other controllers (Simplecontroller) between this TransactionSampler and the http sampler, triggerEndOfLoop will not be called for those controllers. the idea behind the patch is to always do the tree traversal from the real sampler. You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter endofloop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/141.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #141 commit c866e4279031364f76e2f34cf3165253b1cdc9e5 Author: benoit Date: 2016-02-25T15:15:09Z Bug 59067 JMeter fail to iterate over SimpleController after an assertion error. The controller does not restart at the first sampler The pb is that in JMeterThread#triggerEndOfLoopOnParentControllers the Sampler used is not always the "real" one, but it can be a TransactionSampler, if there are some other controllers (Simplecontroller) between this TransactionSampler and the http sampler, triggerEndOfLoop will not be called for those controllers. the idea behind the patch is to always do the tree traversal from the real sampler. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 59060 : UrlConfigGui is now able to manag...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/140 Bug 59060 : UrlConfigGui is now able to manage file upload. It's disabled by default. Better screen space usage add some validation to prevent incoherent configuration You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter urlguimerge Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/140.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #140 commit 9e07849a51d0d3fb0ecfcc8b5cafc11b38469a69 Author: benoit Date: 2016-02-24T09:56:59Z Bug 59060 : UrlConfigGui is now able to manage file upload. It's disabled by default. Better screen space usage add some validation to prevent incoherent configuration --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 59046 - JMeter Gui Replace controller sho...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/139 Bug 59046 - JMeter Gui Replace controller should keep the name and the selection Keep the old name if it wasn't the default one. You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter changeparent Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/139.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #139 commit d557cbab84c73dd61e33c512915ecbc0d8a39343 Author: benoit Date: 2016-02-22T16:59:07Z Bug 59046 - JMeter Gui Replace controller should keep the name and the selection Keep the old name if it wasn't the default one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 59044 - Http Sampler : It should not be p...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/138 Bug 59044 - Http Sampler : It should not be possible to select the multipart encoding if the method is not POST You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter urlguimulti Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/138.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #138 commit 4aceba8f5edd675888d7d231b27b7797b9e0fa90 Author: benoit Date: 2016-02-22T15:56:00Z Bug 59044 - Http Sampler : It should not be possible to select the multipart encoding if the method is not POST --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: add more HC31 deprecations
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/137 add more HC31 deprecations You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter HC31deprecation Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/137.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #137 commit 9677b79c21b4f82e3a654b8f53de25c85249a5d5 Author: benoit Date: 2016-02-22T12:37:23Z add more HC31 deprecation --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 59034 - Parallel downloads connection man...
Github user benbenw commented on the pull request: https://github.com/apache/jmeter/pull/135#issuecomment-186911889 I've change a few things to this PR in the branch : https://github.com/benbenw/jmeter/tree/59034 - no thread pool creation if there's nothing to download - switch the parallel downloads to serial if parallelism = 1 - set the max connection per route based on the number of parallel downloads --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 52073 Embedded Resources concurrent downl...
Github user benbenw closed the pull request at: https://github.com/apache/jmeter/pull/132 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 52073 Embedded Resources concurrent downl...
Github user benbenw commented on the pull request: https://github.com/apache/jmeter/pull/132#issuecomment-186897757 I close this PR as it's hard to have both Bug 59034 and this one. I will retry after the jmeter 3.0 release --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: clean up : remove unused method
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/133 clean up : remove unused method rename parmeters for clarity You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter unused Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/133.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #133 commit dcfd99fec3d47e55c919ec9083408a6e8bb785bb Author: benoit Date: 2016-02-20T11:08:25Z clean up : remove unused method rename parmeters for clarity --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 52073 Embedded Resources concurrent downl...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/132 Bug 52073 Embedded Resources concurrent download : Improve performances by avoiding shutdown of ThreadPoolExecutor at each sample. Please test and review carefully A shared thread pool is used for all the parallel downloads. A throttle mechanism is used per user to ensure the max concurrent downloads setting is not exceeded. A new parameter httpsampler.parallel_download_thread_keepalive_inseconds is used to set the thread TTL when idle (default 60s). the parameter httpsampler.await_termination_timeout is not used anymore and has been removed. TODO : ResourcesDownloader#shrink should be called at the end of a test to accelerate the release of the thread pool idle threads (not mandatory) You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter resourcedownloader Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/132.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #132 commit 367b677c3f22b9693ceed4223a36ceba02235b87 Author: benoit Date: 2016-02-19T15:49:49Z Bug 52073 Embedded Resources concurrent download : Improve performances by avoiding shutdown of ThreadPoolExecutor at each sample. A shared thread pool is used for all the parallel downloads. A throttle mechanism is used per user to ensure the max concurrent downloads setting is not exceeded. A new parameter httpsampler.parallel_download_thread_keepalive_inseconds is used to set the thread TTL when idle (default 60s). the parameter httpsampler.await_termination_timeout is not used anymore and has been removed. TODO : ResourcesDownloader#shrink should be called at the end of a test to accelerate the release of the thread pool idle threads (not mandatory) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 59028 : use the SystemDefaultDnsResolver ...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/130 Bug 59028 : use the SystemDefaultDnsResolver singleton instead of a new one for each thread You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter dnsresolversingleton Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/130.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #130 commit 8ecadfc9b488c1480b3e5bf81bb475b66b5a2625 Author: benoit Date: 2016-02-18T16:29:26Z Bug 59028 : use the SystemDefaultDnsResolver singleton instead of a new one for each thread --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 57577 HttpSampler : Retrieve All Embedded...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/127 Bug 57577 HttpSampler : Retrieve All Embedded Resources should only compute size or hash can be activated with a new parameter httpsampler.ignore_embedded_resources_data (default to false) You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter 57577 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/127.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #127 commit 3d5e84780c7fb00319b4f74673db0dc6297c0584 Author: benoit Date: 2016-02-17T22:12:39Z Bug 57577 HttpSampler : Retrieve All Embedded Resources should only compute size or hash can be activated with a new parameter httpsampler.ignore_embedded_resources_data (default to false) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: move more tests into their own classes
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/125 move more tests into their own classes More tests executed as some of them were previously disabled in headless mode. You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter splittests Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/125.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #125 commit 90d034798c40fb14ae3acd64e972cd678197873c Author: benoit Date: 2016-02-04T20:45:22Z move more tests into their own classes More tests executed as some of them were previously disabled in headless mode. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: remove some redundant modifiers
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/116 remove some redundant modifiers You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter clean103 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/116.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #116 commit 97788ba0a5b9d29cb55edbc68cabc7d5aea0b4b1 Author: benoit Date: 2016-02-11T08:53:19Z remove some redundant modifiers --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Use java style array (vs C style) batch 2
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/115 Use java style array (vs C style) batch 2 rename variables (java naming convention) You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter clean102 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/115.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #115 commit d5bcf4da187d2e0665dccea70a3d19137d429445 Author: benoit Date: 2016-02-04T15:22:37Z Use java style array (vs C style) batch 2 rename variables --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 58989 : Record controller gui, add a butt...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/113 Bug 58989 : Record controller gui, add a button to clear all the recorded samples You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter recordclear Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/113.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #113 commit fb918dc2e47a8369f73a271bb518a1b35303c354 Author: benoit Date: 2016-02-10T16:11:14Z Record controller gui : add a button to clear all the recorded samples --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Use java style array (vs C style)
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/108 Use java style array (vs C style) rename variables You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter clean101 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/108.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #108 commit b39826236f6eb9398252c302c1fd8dc8aa2970fc Author: benoit Date: 2016-02-04T09:46:48Z Use java style array (vs C style) rename variables --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 58967 : use junit categories to exclude t...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/107 Bug 58967 : use junit categories to exclude tests that need a gui see https://github.com/junit-team/junit/wiki/Categories this is only available for junit 4 tests and not for junit 3 suite style tests. A test can be annotated with @Category(NeedGuiTests.class) and it will not be executed in headless mode Also remove the AllTests#suite implementation as it's not compatible with junit4 tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter junitcat2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/107.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #107 commit e2b1be2aa3f2a0870e8e65f4b5c6024e1a7188cc Author: benoit Date: 2016-02-03T17:02:20Z use junit categories (https://github.com/junit-team/junit/wiki/Categories) to exclude test that need a gui this is only available for junit 4 tests and not for junit 3 suite style tests. A test can be annotated with @Category(NeedGuiTests.class) and it will not be executed in headless mode Also remove the AllTests#suite implementation as it's not compatible with junit4 tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: un-duplicate the proxy handling
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/106 un-duplicate the proxy handling add comments You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter httpproxy Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/106.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #106 commit b24db15b481cf3676fe788e3de1505427691b462 Author: benoit Date: 2016-02-03T22:47:24Z un-duplicate the proxy handling add comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: http samplers : reorder the http method in th...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/105 http samplers : reorder the http method in the switch, move the most common ones first You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter httpmethod Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/105.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #105 commit 9abe9fe8dc45c31ad8ebf77925d8b9ddd71d1313 Author: benoit Date: 2016-02-03T21:52:52Z reorder the http method in the switch, move the most common ones first --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 58897 : Step 5 misc clean up
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/104 Bug 58897 : Step 5 misc clean up remove empty test remove commented code split some tests explicitly disable org.apache.jmeter.protocol.http.sampler.PackageTest when in headless mode You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter junit6 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/104.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #104 commit 8ff9ef1e1d3fda90eb89d8e8997539da7fd7ed85 Author: benoit Date: 2016-02-01T22:26:36Z Bug 58897 : Step 5 misc clean up remove empty test remove commented code split some tests explicitly disable org.apache.jmeter.protocol.http.sampler.PackageTest when in headless mode --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Misc clean up
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/101 Misc clean up rename variables remove commented code remove outdated comments You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter clean99 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/101.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #101 commit edf7bd7b0672f7f8f4d21e6d726987f7945ab1ff Author: benoit Date: 2016-02-02T09:30:46Z Misc clean up rename variables remove commented code remove outdated comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 58897 : Step 4 convert existing tests
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/100 Bug 58897 : Step 4 convert existing tests this patch is "mechanical" No change in the number of executed tests the "suite" style tests kept a junit 3 hierarchy You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter junit-part4 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/100.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #100 commit b210939deb9a749b59b21a9459f29bc78278d09c Author: benoit Date: 2016-01-20T20:43:33Z convert existing tests to junit 4 (partial) commit 2e44ca6846e309ab1eb5077764de068374a8c2b4 Author: benoit Date: 2016-01-20T21:01:11Z convert existing tests to junit4 commit 45f59701729f05b7aebee390368ea16e666f2f18 Author: benoit Date: 2016-01-21T21:26:28Z migrate to junit 4 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 58955 : Request view http does not correc...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/99 Bug 58955 : Request view http does not correctly display http parameters in multipart/form-data the provided PR does not implements 100% of the the rfc but it's better than the current implementation where the view does not understand multipart. You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter displaymultipart Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/99.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #99 commit f6f23952db7c2305d7dcef82e16f895ff4ff5e76 Author: benoit Date: 2016-02-01T10:20:14Z correctly display the http request parameters when the post is multipart/form-data. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 58954 : Request view http does not correc...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/98 Bug 58954 : Request view http does not correctly display http parameter if it contains '&'. the problem comes from the url decode done before the split of the parameters and not after. This patch also implements a less hacky solution for bugs 52491 and 54055 You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter displayhttpreq Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/98.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #98 commit 551f6fe9a40a893e198cedd4b82dd2a2033d1e75 Author: benoit Date: 2016-01-13T13:51:30Z Request view http does not correctly display http parameter if it contains '&'. the problem comes from the url decode done before the split of the parameters and not after. This patch also implements a non hacky solution for bugs 52491 and 54055 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: remove commented code
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/97 remove commented code You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter cleanup12 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/97.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #97 commit 54e1b9c917cd3fb4734005be676334d2d903d18b Author: benoit Date: 2016-02-01T11:53:54Z remove commented code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: misc clean of ldap code
Github user benbenw commented on the pull request: https://github.com/apache/jmeter/pull/96#issuecomment-177489147 user_defined is in a gui (LdapConfigGui) when is the gui serialized ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: misc clean of ldap code
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/96 misc clean of ldap code commented code, empty java doc, variables naming, etc... Does anybody use this code ? You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter ldapclean Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/96.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #96 commit 42c78514c9451988588e167c5e7800633f775075 Author: benoit Date: 2016-01-31T11:19:17Z misc clean of ldap code commented code, empty java doc, variables naming, etc... Does anybody use this code ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 58897 : Step 3 execute JUnit 4 tests
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/95 Bug 58897 : Step 3 execute JUnit 4 tests We now scan for classes that extends TestCase (junit3) and for classes that have at least one method annotated with @Test 2 new tests executed in TestSamplingStatCalculator You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter junit-part3 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/95.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #95 commit f52f54c9157d29ab06b5058dacebc58efadb9f64 Author: benoit Date: 2016-01-29T15:09:48Z Step 3 execute JUnit 4 tests We now scan for classes that extends TestCase (junit3) and for classes that have at least one method annotated with @Test 2 new tests executed in TestSamplingStatCalculator --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 58897: Step 2 Update the junit tests exec...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/94 Bug 58897: Step 2 Update the junit tests execution to a recent junit runner No change in the number of executed tests The console output changed but not the process return code Not that while it's a recent runner you can not use pure junit annotation tests as they're not detected in the classpath. It will be done in a subsequent patch This has only been tested locally, not on the build bot You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter junit-part2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/94.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #94 commit e88b720607b631a9ea8b08278f4a5c54d0c628e1 Author: benoit Date: 2016-01-28T23:28:38Z Update the junit tests execution to a recent junit runner No change in the number of executed tests The console output change but not the process return code Not that while it's a recent runner you can not use pure junit annotation tests as they're not detected in the classpath. It will be done in a subsequent patch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 58924 : Dashboard / report It should be p...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/90 Bug 58924 : Dashboard / report It should be possible to export the generated graph as image (PNG) this patch change the axis rendering to the canvas (vs css+html) the image export is done with the download attribute if supported see http://caniuse.com/#feat=download or by changing the browser location : with this method it's not possible to set the filename. You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter exportgraph Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/90.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #90 commit d756637dafb47d3aa8ce7c7be10b093bf24938c7 Author: benoit Date: 2016-01-27T11:34:00Z export graph as png this patch change the axis rendering to the canvas (vs css+html) the image export is done with the download attribute if supported see http://caniuse.com/#feat=download or by changing the browser location : with this method it's not possible to set the filename. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: make responseTime the first graph in the page
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/89 make responseTime the first graph in the page You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter dashboardgraphorder Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/89.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #89 commit 8aba7a81612368aa507e0786f881522bdd35fc28 Author: benoit Date: 2016-01-23T11:03:20Z make responseTime the first graph in the page --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 58913 : When closing jmeter should not in...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/88 Bug 58913 : When closing jmeter should not interpret cancel as "destroy my test plan" You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter jmeterclose Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/88.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #88 commit beb07fcac29cd94af897b98450c655513cc92178 Author: benoit Date: 2016-01-22T21:56:40Z When closing jmeter should not interpret cancel as "destroy my test plan" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 58912 : when several rows are selected, t...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/87 Bug 58912 : when several rows are selected, the delete action only delete the first one You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter assertguidelete Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/87.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #87 commit d1721adc65c9746a2e0106d4107ee8001550a698 Author: benoit Date: 2016-01-18T20:13:29Z when several rows are selected, the delete action only delete the first one --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
dev@jmeter.apache.org
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/86 Bug 58911 : it should be possible to copy&paste between http header managers You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter httpheaderpaste Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/86.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #86 commit 9b676de80d08e273d13a39a36586bfe137ad9b9d Author: benoit Date: 2016-01-22T14:37:45Z it should be possible to copy&paste between http header managers --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 58897 : DO NOT MERGE AS THIS !!!
Github user benbenw closed the pull request at: https://github.com/apache/jmeter/pull/84 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 58897 : part 1
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/85 Bug 58897 : part 1 - Move jorphan class finder to a more flexible solution when searching for classes (visitor / filter pattern) - Use it as preparatory step in Jorphan AllTests - Explicitly exclude JMeterTest and TestMenuFactory in headless mode - remove commented code & outdated comments No change in the number of executed tests * * in headless mode TestMenuFactory is now excluded, it was previously running as a side effect of the *strange* exception management, but it need a graphics environment. Jorphan AllTests is a stinky monkey. You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter classfinder Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/85.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #85 commit cb516529c7bed237be1d4c2a8134df48366ba19f Author: benoit Date: 2016-01-18T10:03:42Z - Move jorphan class finder to a more flexible solution when searching for classes (visitor / filter pattern) - Use it as preparatory step in Jorphan AllTests - Explicitly exclude JMeterTest and TestMenuFactory in headless mode - remove commented code & outdated comments No change in the number of executed tests * * in headless mode TestMenuFactory is now excluded, it was previously running as a side effect of the *strange* exception management, but it need a graphics environment. Jorphan AllTests is a stinky monkey. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 58897 : DO NOT MERGE AS THIS !!!
GitHub user benbenw opened a pull request:
https://github.com/apache/jmeter/pull/84
Bug 58897 : DO NOT MERGE AS THIS !!!
Some code added a few years ago silently disabled a *lot* of tests :
when run in headless mode (apache build bot ?) a HeadlessException is
thrown but wrapped in an ExceptionInInitializerError
this error stop the JmeterTest suite and the following tests are
disabled
- suiteSerializableElements
- suiteTestElements
- suiteBeanComponents
- new JMeterTest("createFunctionSet"));
- suiteFunctions
- new JMeterTest("checkGuiSet"));
- new JMeterTest("checkFunctionSet"));
- new JMeterTest("resetLocale")
this patch will re-enable those tests but some of them fail
Those tests need to be reviewed by a jmeter ninja or an archaeologist
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benbenw/jmeter enabletests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/84.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #84
commit db59c23c593f3a75350f98fb4f0224774fe17ebf
Author: benoit
Date: 2016-01-20T14:28:30Z
DO NOT MERGE AS THIS !!!
Some code added a few years ago silently disabled a *lot* of tests :
when run in headless mode (apache build bot ?) a HeadlessException is
thrown but wrapped in an ExceptionInInitializerError
this error stop the JmeterTest suite and the following tests are
disabled
- suiteSerializableElements
- suiteTestElements
- suiteBeanComponents
- new JMeterTest("createFunctionSet"));
- suiteFunctions
- new JMeterTest("checkGuiSet"));
- new JMeterTest("checkFunctionSet"));
- new JMeterTest("resetLocale")
this patch will re-enable those tests but some of them fail
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: Bug 56554 : the script cache key is now autom...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/83 Bug 56554 : the script cache key is now automatically generated. The md5 of the script content is used. The previous cacheKey property is still there for compatibility but can not be modified or viewed in the gui. a Compilable script will only be cached if the checkbox is checked in the gui Concerning backward compatibility : - cache key is empty -> checkbox is cleared, - cache key is set -> checkbox is checked. this patch keeps the initial cache key (if set) when saving : it makes the jmx file usable on a previous version of jmeter. if the checkbox is checked then the real cache key will be computed from the MD5 of the script (inline gui). You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter jsr223cache Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/83.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #83 commit ae9f4ff38eaa261af34341a5f29f91d006552dfa Author: benoit Date: 2016-01-07T08:52:15Z Bug 56554 : the script cache key is now automatically generated. The md5 of the script content is used. The previous cacheKey property is still there for compatibility but can not be modified or viewed in the gui. a Compilable script will only be cached if the checkbox is checked in the gui Concerning backward compatibility : - cache key is empty -> checkbox is cleared, - cache key is set -> checkbox is checked. this patch keeps the initial cache key (if set) when saving : it makes the jmx file usable on a previous version of jmeter. if the checkbox is checked then the real cache key will be computed from the MD5 of the script (inline gui). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Misc clean up (javadoc, commented code)
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/82 Misc clean up (javadoc, commented code) You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter javadocclean Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/82.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #82 commit 53287c64af779ee22c37e863979e8249319270a3 Author: benoit Date: 2016-01-18T14:50:56Z Misc javadoc clean up commit f181fc01e64f7eb9e3b0788ada460caecf96a872 Author: benoit Date: 2016-01-18T14:56:36Z Remove code commented 12 years ago --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Remove code that has been commented for the l...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/81 Remove code that has been commented for the last 10 years You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter commentedcoderip Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/81.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #81 commit f8654a355902d2da09c17e643e3a660757b06687 Author: benoit Date: 2016-01-18T10:06:02Z Remove code that has been commented for the last 10 years --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 58865 : allow empty default value in the ...
GitHub user benbenw opened a pull request:
https://github.com/apache/jmeter/pull/79
Bug 58865 : allow empty default value in the regex extractor
Example
with the following regex for the variable myvar
the browser will send baulpismuth=
but jmeter will send baulpismuth=${myvar}
as no match will be found and it's not possible to define an empty
default value
this PR add a checkbox (I love checkbox) to let the user choose an empty
default value
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benbenw/jmeter emptyregex
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/79.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #79
commit 6dcbb9d3594c5d2447b73325fbe451cf344584ad
Author: benoit
Date: 2016-01-13T14:55:34Z
allow empty default value in the regex extractor
Example
with the following regex for the variable myvar
the browser will send baulpismuth=
but jmeter will send baulpismuth=${myvar}
as no match will be found and it's not possible to define an empty
default value
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: Bug 58864 : when moving parameter with up / d...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/78 Bug 58864 : when moving parameter with up / down, ensure that the selection remains visible Disclaimer : Not perfect, the selection is not always visible but it's better than the current implementation You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter scrollupdown2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/78.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #78 commit ff03d0e4c39f4273a79a4aa16e08b5b03e38615f Author: benoit Date: 2016-01-13T21:43:24Z when moving parameter with up / down, ensure that the selection remain visible Not perfect, the selection is not always visible but it's better than the current implementation --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 58861: When clicking on up, down or detai...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/77 Bug 58861: When clicking on up, down or detail while in a cell of the argument panel, newly added content is lost It works fine for the "add from clipboard" button You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter tableediting Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/77.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #77 commit 07bd4a7e12ac4029ea277d216b3ca775e92f0a32 Author: benoit Date: 2016-01-13T08:26:34Z keep value edited when clicking on move up / down and detail it was already done for "add from clipboard" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 58860 : automatic variable generation in ...
GitHub user benbenw opened a pull request:
https://github.com/apache/jmeter/pull/76
Bug 58860 : automatic variable generation in http parameter
in the http panel, the right click on a row selection
give the ability to automatically replace the variables values of the
selected rows by a
variable.
the variable name is derived from the parameter name
eg myparam1 -> ${myparam1}
Right click menu :
https://cloud.githubusercontent.com/assets/5681005/12324756/40891b4a-bac5-11e5-856e-19044c874515.png";>
After replacement :
https://cloud.githubusercontent.com/assets/5681005/12324770/5a5174be-bac5-11e5-85a9-93c20e72d692.png";>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benbenw/jmeter variabilize
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/76.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #76
commit d7f0aa0885f0c4664a9eab61be3d65f155d8d288
Author: benoit
Date: 2016-01-14T12:43:09Z
in the http panel, the right click on a row selection give the ability
to automatically replace the variables values of the selected rows by a
variable.
the variable name is derived from the parameter name eg myparam1 ->
${myparam1}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: the request view http does not allow to resiz...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/75 the request view http does not allow to resize the parameters table first column. It's not possible to see the end of long parameter names. You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter requestviewhttpresize Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/75.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #75 commit 3c567bc993dbaae69728d7249c6931b79b56921c Author: benoit Date: 2016-01-14T09:11:23Z the request view http does not allow to resize the parameters table first column. It's not possible to see the end of long parameter names. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 58845 : http request view doesn't display...
Github user benbenw commented on the pull request: https://github.com/apache/jmeter/pull/70#issuecomment-171427042 ok attached the test I've used for my PR to bugzilla run the test and have a look at the result in the request http view parameters defined in the http sampler are missing the sampler is fine it's just the display --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 58845 : http request view doesn't display...
Github user benbenw commented on the pull request: https://github.com/apache/jmeter/pull/70#issuecomment-171412112 I can not add a test for the previous behavior as the method signature is wrong : the query is parsed into a Map where you can only have 1 value per parameter name... If you can have a look at bug 58851, I will add a test with my PR that test that all the parameters are displayed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: remove outdated comments (13 years old)
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/74 remove outdated comments (13 years old) You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter misccleanup1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/74.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #74 commit 2332dcd26f290cba7e94568aefb2152d4b803a7a Author: benoit Date: 2016-01-13T14:12:11Z remove outdated comments (13 years old) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 58845 : http request view doesn't display...
Github user benbenw commented on the pull request: https://github.com/apache/jmeter/pull/70#issuecomment-171288167 you mean a test for the new behavior ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: bug 58844 : button activation in the argument...
Github user benbenw commented on the pull request: https://github.com/apache/jmeter/pull/69#issuecomment-171250950 I will not mix code change and indent in my next PRs But I won't rework this one in the near future. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 58849 : add a search panel to the request...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/73 Bug 58849 : add a search panel to the request http view the search is only done on the parameters table the existing search extension used on jeditorpane was updated to make it work on any component (you have to implement the specific logic) You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter findrequestview Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/73.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #73 commit a41d3204b3ba5575574d49f723ce331e4f107803 Author: benoit Date: 2016-01-13T10:32:03Z add a search panel to the request http view. the search is only done on the parameters table the existing search extension used on jeditorpane was updated to make it work on any component (you have to implement the specific logic) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 58848 : when adding an argument (add butt...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/71 Bug 58848 : when adding an argument (add button or from clipboard) scroll the table to the new line You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter tablescroll Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/71.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #71 commit 957dc8a732967755ff710c0a60242c88c75b8fd0 Author: benoit Date: 2016-01-13T08:29:03Z when adding an argument (add button or from clipboard) scroll the table to the new line --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 56554 : the script cache key is now autom...
Github user benbenw closed the pull request at: https://github.com/apache/jmeter/pull/67 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 58845 : http request view doesn't display...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/70 Bug 58845 : http request view doesn't display all the parameters You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter requestviewhttp Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/70.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #70 commit 393be7bf79f9e45d42d881ffd1337ee83745de51 Author: benoit Date: 2016-01-12T23:40:51Z http request view doesn't display all the parameters --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: bug 58844 : button activation in the argument...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/69 bug 58844 : button activation in the arguments panel was broken. Logic wasn't completly implemented. some buttons were enabled even if the table was empty move the logic into a single method You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter argpanel Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/69.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #69 commit d092332cc032d765bda56aadc95ef3a94b2e91df Author: benoit Date: 2016-01-12T23:08:48Z button activation in the arguments panel was broken. Logic wasn't completly implemented. some buttons were enabled even if the table was empty move the logic into a single method --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: the file upload panel should be collapsed by ...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/68 the file upload panel should be collapsed by default also remove uneeded ":" in the table headers names (fr and en) You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter collapsefileupload Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/68.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #68 commit aeb55fb72336bc4093911466bcd791c1848215f1 Author: benoit Date: 2016-01-12T18:03:43Z the file upload panel should be collapsed by default --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 56554 : the script cache key is now autom...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/67 Bug 56554 : the script cache key is now automatically generated. The md5 of the script content is used. The previous cacheKey property is still there for compatibility but can not be modified or viewed in the gui. Note that with this change, a Compilable script will always be cached, it was not the case with the previous version if the user set the cacheKey property to an empty value. Documentation *was not* updated. You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter jsr223cache Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/67.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #67 commit 4e1c75e83475e1344cb510af6b7bb3b9dd9dd83a Author: benoit Date: 2016-01-07T08:52:15Z Bug 56554 : the script cache key is now automatically generated. The md5 of the script content is used. The previous cacheKey property is still there for compatibility but can not be modified or viewed in the gui. Note that with this change, a Compilable script will always be cached, it was not the case with the previous version if the user set the cacheKey property to an empty value. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: bug 58811 : When pasting arguments between ht...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/66 bug 58811 : When pasting arguments between http samplers the column "Encode" and "Include Equals" are lost. That's bad ! You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter pastehttparg Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/66.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #66 commit 6ad19a8e825b65d4022e1cb1beb2339631e0d38c Author: benoit Date: 2016-01-06T17:03:23Z When pasting arguments between http samplers the column "Encode" and "Include Equals" are lost. That's bad ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Remove the double while in the tree traversal
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/61 Remove the double while in the tree traversal remove the double while in the tree traversal extract the sampler execution in a dedicated method You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter treetraversal4 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/61.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #61 commit f7e3fa2b3bd7816fbbddf81d470d3162f3b4bf07 Author: benoit Date: 2015-12-13T20:52:17Z extract the sampler execution in a dedicated method commit 57628a0bc9d5b78b00614a52fa2196f60b71ab09 Author: benoit Date: 2015-12-13T21:07:44Z remove the double while in the tree traversal --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Misc code clean up
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/60 Misc code clean up add explanations remove commented code You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter misc-cleanup-4 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/60.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #60 commit 1d92375febaf1c25bb81342b5bf2915de48e9ae2 Author: benoit Date: 2015-12-14T08:41:02Z remove commented code add explanations --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Transaction Controller clarification : rename...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/59 Transaction Controller clarification : rename variables and methods to make it easier to understand You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter TransactionController-naming Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/59.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #59 commit 38e65113d072c2ab7f085a269ef5d8ca44d0ff48 Author: benoit Date: 2015-12-14T08:23:07Z Transaction Controller clarification : rename variables and methods to make it easier to understand --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 58726 - Remove the jmeterthread.startearl...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/58 Bug 58726 - Remove the jmeterthread.startearlier parameter this parameter was added 11 years ago (rev 325222) as a way to revert to a previous behaviour if a problem was found. Extract of jmeter.properties # In case this causes problems, the previous behaviour can be restored by uncommenting the following line. We're now 11 years later and no pb were found, it's time to remove that parameter You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter startearlier-removal2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/58.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #58 commit 84037f23d3f9af56715ac91f1848fe58031eb603 Author: benoit Date: 2015-12-12T23:04:01Z Bug 58726 - Remove the jmeterthread.startearlier parameter this parameter was added 11 years ago (rev 325222) as a way to revert to a previous behaviour if a problem was found. Extract of jmeter.properties # In case this causes problems, the previous behaviour can be restored by uncommenting the following line. We're now 11 years later and no pb were found, it's time to remove that parameter --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 58726 - Remove the jmeterthread.startearl...
Github user benbenw closed the pull request at: https://github.com/apache/jmeter/pull/57 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 58726 - Remove the jmeterthread.startearl...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/57 Bug 58726 - Remove the jmeterthread.startearlier parameter this parameter was added 11 years ago (rev 325222) as a way to revert to a previous behaviour if a problem was found. Extract of jmeter.properties # In case this causes problems, the previous behaviour can be restored by uncommenting the following line. We're now 11 years later and no pb were found, it's time to remove that parameter You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter startearlier-removal Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/57.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #57 commit 37b195f414c3aa8c986dbcc6f4bce8061e0a5f3f Author: benoit Date: 2015-12-12T23:04:01Z Bug 58726 - Remove the jmeterthread.startearlier parameter this parameter was added 11 years ago (rev 325222) as a way to revert to a previous behaviour if a problem was found. Extract of jmeter.properties # In case this causes problems, the previous behaviour can be restored by uncommenting the following line. We're now 11 years later and no pb were found, it's time to remove that parameter --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Simplification and clarification of the test ...
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/56 Simplification and clarification of the test tree traversal. bug 52968 added a call to processSampler in order to mark the transaction sampler in error and generate the associated sampler result. Add an explanation for that and extract that code in a dedicated method to make clear that the triggerEndOfLoopOnParentControllers will not process any new sampler You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter treetraversal2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/56.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #56 commit 6369077db469692d916ee635ea9bfcc0438a17a8 Author: benoit Date: 2015-12-12T16:13:14Z Simplification and clarification of the test tree traversal. bug 52968 added a call to processSampler in order to mark the transaction sampler in error and generate the associated sampler result. Add an explanation for that and extract that code in a dedicated method to make clear that the triggerEndOfLoopOnParentControllers will not process any new sampler --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
