[GitHub] jmeter issue #401: Bug 62257 - Expand/Collapse short key doesn't work with n...

[orimarko]

Github user orimarko commented on the issue:

https://github.com/apache/jmeter/pull/401
  
As I see it, both key combinations are the same key in different location 
in keyboard
Therefore there's no need to change documentation


---

[GitHub] jmeter issue #401: Bug 62257 - Expand/Collapse short key doesn't work with n...

[orimarko]

Github user orimarko commented on the issue:

https://github.com/apache/jmeter/pull/401
  
Hello

I'm fixing an issue of - sign. From
https://wiki.apache.org/jmeter/JMeterShortcuts :

* Collapse All : CTRL+"-" (not working on Mac)

* Expand All : CTRL+SHIFT+"-" (not working on Mac)

"-" sign can be found twice in keyboard. The numpad sign wqsn't working of
windows, so I add it to Collapse/Expand actions
בתאריך שבת, 13 באוק׳ 2018, 17:59, מאת Felix Schumacher ‏<
notificati...@github.com>:

> Thanks for your contribution and for the correction of your name ;)
>
> Have you tried shift+left cursor and shift+right cursor? They work fine
> on my install. Why would we want to have more than one keyboard short cut
> for the same functionality?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/jmeter/pull/401#issuecomment-429548713>, or 
mute
> the thread
> 
<https://github.com/notifications/unsubscribe-auth/AQV-YTpmLZgJEGZxe66BwFZX4sNi6gHkks5ukf_hgaJpZM4XHusr>
> .
>

בתאריך 13 באוק׳ 2018 5:59 PM,‏ "Felix Schumacher" 

כתב:

Thanks for your contribution and for the correction of your name ;)

Have you tried shift+left cursor and shift+right cursor? They work fine on
my install. Why would we want to have more than one keyboard short cut for
the same functionality?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/apache/jmeter/pull/401#issuecomment-429548713>, or mute
the thread

<https://github.com/notifications/unsubscribe-auth/AQV-YTpmLZgJEGZxe66BwFZX4sNi6gHkks5ukf_hgaJpZM4XHusr>
.



---

[GitHub] jmeter pull request #401: Bug 62257 - Expand/Collapse short key doesn't work...

[orimarko]

GitHub user orimarko opened a pull request:

https://github.com/apache/jmeter/pull/401

Bug 62257 - Expand/Collapse short key doesn't work with numpad -

## Description
Fixed Bug 62257 - Expand/Collapse short key doesn't work with numpad -

Add new keystrokes for numpad - sign for expanding/collapsing JMeter tree

## Motivation and Context
Fixing open issue since JMeter 4 version:
https://bz.apache.org/bugzilla/show_bug.cgi?id=62257

## How Has This Been Tested?
Tested using ant run_gui
Tested on Windows 7
Only added functionality to code

## Types of changes
- Bug fix (non-breaking change which fixes an issue)

## Checklist:
- [x ] My code follows the [code style][style-guide] of this project.
- [x ] I have updated the documentation accordingly.

[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/orimarko/jmeter trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/401.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #401


commit d87612133e064f54568654f9b128fef9dea6c6a3
Author: orimarko 
Date:   2018-10-04T07:50:41Z

Update KeyStrokes.java

commit 70de4e8b38c97916b72582468a074635f24f83e7
Author: orimarko 
Date:   2018-10-04T07:54:43Z

Update KeyStrokes.java

commit 29491e611975ce4c0afd9d878f57c24778b40ad4
Author: orimarko 
Date:   2018-10-04T07:56:40Z

Update JMeterTreeListener.java

commit 3e6d28384e9e9406077608a1cb06dd47d08db99b
Author: orimarko 
Date:   2018-10-04T09:34:20Z

Update changes.xml




---