[GitHub] jmeter pull request #377: fixed wrong example for loop controller iteration ...

2018-02-21 Thread ptrd
GitHub user ptrd opened a pull request:

https://github.com/apache/jmeter/pull/377

fixed wrong example for loop controller iteration variable

## Description
Fixed small (but confusing) error in documentation.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ptrd/jmeter fixdocs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/377.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #377


commit dbbfe72f94373adb66cad603576fee77999ba056
Author: Peter Doornbosch <peter.doornbosch@...>
Date:   2018-02-21T20:05:59Z

fixed wrong example for loop controller iteration variable




---


[GitHub] jmeter issue #364: let GUI component (dynamically) decide whether it can be ...

2017-12-29 Thread ptrd
Github user ptrd commented on the issue:

https://github.com/apache/jmeter/pull/364
  
Do you need anything from me to get this PR accepted? Can i help in any 
way? Please let me know if this is the case.
Regards
Peter



---


[GitHub] jmeter pull request #364: let GUI component (dynamically) decide whether it ...

2017-12-21 Thread ptrd
GitHub user ptrd opened a pull request:

https://github.com/apache/jmeter/pull/364

let GUI component (dynamically) decide whether it can be added via th…

…e menu or not; the menu item will be enabled/disabled accordingly.

## Description
Added the ability to have menu items for GUI components dynamically 
disabled/enabled.
The question whether a specific test element can be added (to the testplan) 
is delegated to the corresponding GUI component.

## Motivation and Context
In my websocket plugin 
(https://bitbucket.org/pjtr/jmeter-websocket-samplers), i have a config element 
that enables the user to configure specific (advanced) properties of the plugin 
(previously, this was done via JMeter properties, which is of course 
cumbersome). To avoid funny behaviour in the plugin and to avoid confusion of 
the user, such a config element should only be added once.

## How Has This Been Tested?
I tested it with my websocket plugin, see 
https://bitbucket.org/pjtr/jmeter-websocket-samplers/commits/branch/limit-number-of-advanced-options-element

## Screenshots (if appropriate):

## Types of changes

- New feature (non-breaking change which adds functionality)

## Checklist:


- [ x] My code follows the [code style][style-guide] of this project.
- [ ] I have updated the documentation accordingly.

[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ptrd/jmeter dynamic-add-menu

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/364.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #364


commit 72fccd5a6771565ffade43cce41763c3bc2df52f
Author: Peter Doornbosch <peter.doornbosch@...>
Date:   2017-12-21T21:00:21Z

let GUI component (dynamically) decide whether it can be added via the menu 
or not; the menu item will be enabled/disabled accordingly.




---


[GitHub] jmeter issue #361: More hooks for testplan modifications

2017-12-20 Thread ptrd
Github user ptrd commented on the issue:

https://github.com/apache/jmeter/pull/361
  
Thanks Philippe.


---