[GitHub] jmeter issue #345: Checkstyle

[romani]

Github user romani commented on the issue:

https://github.com/apache/jmeter/pull/345
  
@ham1 , ReturnCount check is commented out.  Please point me to place where 
you configure it.


---

[GitHub] jmeter issue #345: Checkstyle

[romani]

Github user romani commented on the issue:

https://github.com/apache/jmeter/pull/345
  
Looks like a reason was in `maxForVoid` with default value., Right ?


---

[GitHub] jmeter issue #345: Checkstyle

[romani]

Github user romani commented on the issue:

https://github.com/apache/jmeter/pull/345
  
@ham1 , if you enforce(ERROR level) more than half of Checks on this 
project, we can use jmeter project in each commit (in checkstyle) regression 
testing.


---

[GitHub] jmeter issue #345: Checkstyle

[romani]

Github user romani commented on the issue:

https://github.com/apache/jmeter/pull/345
  
if master branch of this project (jmeter) start to use about 80 Checks in 
its config with ERROR severity and no violations reported, we can start to use 
jmeter in out CI for regression testing. 

just keep enforcing more and more rules, and pin me then you are done.


---