[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2

[ra0077]

Github user ra0077 commented on the issue:

https://github.com/apache/jmeter/pull/223
  
PR commited


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2

[Antonio Gomes Rodrigues]

Hi,

Do you mean set the language to groovy in the UI when we had the component?

Antonio

2016-08-11 15:42 GMT+02:00 vlsi :

> Github user vlsi commented on the issue:
>
> https://github.com/apache/jmeter/pull/223
>
> > remove log to avoid performance problem
>
> +1
>
> Technically speaking, I would prefer set the language to "groovy" if
> it was not specified.
>
> That would make the UI clear (user will see what the language is), and
> that would setup proper syntax highlight mode (much easier to program).
> If the conversion is done at load time, then additional log warning is
> just fine as well.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2

[milamberspace]

Github user milamberspace commented on the issue:

https://github.com/apache/jmeter/pull/223
  
OK for me too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2

[vlsi]

Github user vlsi commented on the issue:

https://github.com/apache/jmeter/pull/223
  
> remove log to avoid performance problem

+1

Technically speaking, I would prefer set the language to "groovy" if it was 
not specified.

That would make the UI clear (user will see what the language is), and that 
would setup proper syntax highlight mode (much easier to program).
If the conversion is done at load time, then additional log warning is just 
fine as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2

[ra0077]

Github user ra0077 commented on the issue:

https://github.com/apache/jmeter/pull/223
  
Hi all,

I have check in JMeter source code if this "problem" (take a default 
solution if nothing is setted in GUI) and I have find "CSS/JQuery Extractor" 
element

If you check the documentation 
(https://jmeter.apache.org/usermanual/component_reference.html#CSS/JQuery_Extractor),
 we can read "If selector is set to empty, default implementation(JSoup) will 
be used"

I have check the source code and make a test and when selector is set to 
empty, there is no log written.

I propose to make the same thing to this PR (remove log to avoid 
performance problem + have a clear documentation)

Are you ok?

Antonio




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2

[pmouawad]

Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/223
  
Hello,
In my opinion, you should commit it and we can improve it with further 
commits.
I agree with @vlsi  on the performance involvement of warn logging , but 
we'll find a solution if you don't want to PR again.

Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2

[ra0077]

Github user ra0077 commented on the issue:

https://github.com/apache/jmeter/pull/223
  
It's don't work :-(

protected ScriptEngine getScriptEngine() throws ScriptException {
String lang = getScriptLanguage();

if (StringUtils.isEmpty(lang)) {
lang = DEFAULT_SCRIPT_LANGUAGE;
setScriptLanguage(lang);
log.warn("Script language has not been chosen on the UI: 
"+getName()+", the script will be interpreted as a groovy script");
}

ScriptEngine scriptEngine = getInstance().getEngineByName(lang);
if (scriptEngine == null) {
throw new ScriptException("Cannot find engine named: 
'"+lang+"', ensure you set language field in JSR223 Test Element: "+getName());
}

return scriptEngine;
}





---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2

[ra0077]

Github user ra0077 commented on the issue:

https://github.com/apache/jmeter/pull/223
  
Hi ubikloadpack,

Your solution seem good

I will implement it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2

[ubikloadpack]

Github user ubikloadpack commented on the issue:

https://github.com/apache/jmeter/pull/223
  
Hello,
Thanks for PR.
My notes:

- defaultScriptLanguage should be uppercase being a constant.

- use StringUtils.isEmpty to avoid spaces breaking the control

- Maybe a solution to @vlsi note is to set the script , something like this 
(note that I don't think it will set the lang on the final test but only avoid 
repeating the log message for the same element each time it runs

`if (StringUtils.isEmpty(lang)) {
lang = DEFAULT_SCRIPT_LANGUAGE;
setScript(lang);
log.warn("Script language has not been chosen on the UI: 
"+getName()+", the script will be interpreted as a groovy script");
}
`

Regards
@ubikloadpack


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2

[vlsi]

Github user vlsi commented on the issue:

https://github.com/apache/jmeter/pull/223
  
>I don't know how to implement

For instance, a boolean flag that is cleared after the fist warning is 
printed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2

[ra0077]

Github user ra0077 commented on the issue:

https://github.com/apache/jmeter/pull/223
  
Hi vladimir,

Can you give me more details to avoid logging a warning on each sampler 
execution?
I don't know how to implement

Thanks
Antonio


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2

[vlsi]

Github user vlsi commented on the issue:

https://github.com/apache/jmeter/pull/223
  
-1 for logging a warning on each sampler execution.
Typical user would never open log files, and get bad performance results 
(or even log overflow of some kind)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---