[GitHub] jmeter issue #313: BZ61466: Comment addition to SampleResults

2017-10-13 Thread vherilier
Github user vherilier commented on the issue:

https://github.com/apache/jmeter/pull/313
  
I attached an archive that contains 2 files:
* a EXP.jtl one
* a EXP.xml one containing PerfPublisher test results content used in my 
case by Jenkins to manage test results reports and comparisons.

[reporter.zip](https://github.com/apache/jmeter/files/1382987/reporter.zip)

Only testcases results are reported (not their test step ones) for 
PerfPublisher and they matches Transaction Controllers elements in the related 
.jmx file

IMHO, in .jtl files, "comments" should be added too because it may improve 
test reporting accuracy even from a .jtl file


---


[GitHub] jmeter issue #313: BZ61466: Comment addition to SampleResults

2017-10-12 Thread pmouawad
Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/313
  
Hello @vherilier ,
There is indeed a problem (good catch) as this new field should be 
persisted to XML/CSV.
But my issue here is that it only concerns Transaction Controller and would 
be in SampleResult.

Should we use it everywhere instead of limiting it to Transaction 
Controller ?

At Team,  what's your thought ?

@vherilier , could you show some report were feature is used so that we can 
grasp the benefit of it ?

Thanks


---


[GitHub] jmeter issue #313: BZ61466: Comment addition to SampleResults

2017-10-12 Thread vherilier
Github user vherilier commented on the issue:

https://github.com/apache/jmeter/pull/313
  
Hi @pmouawad ,

Starting the feature documentation part, an issue came to me about about 
how and where defining the global property.
"Sampler Result Save configuration" properties could proposed this new one 
directly and the .jtl could integrate it because .jtl files cold be used to 
generate test results reports too.

What do you think about ?

BR,
--Vincent


---


[GitHub] jmeter issue #313: BZ61466: Comment addition to SampleResults

2017-10-11 Thread pmouawad
Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/313
  
Thanks @vherilier  for your update, it looks good to me.

May I ask one last thing, there is no documentation nor illustration of how 
this feature can be used.
So if we want this feature to be popular there should be some sexy use case 
showing an example integration with some screenshot.
Thanks




---


[GitHub] jmeter issue #313: BZ61466: Comment addition to SampleResults

2017-10-10 Thread vherilier
Github user vherilier commented on the issue:

https://github.com/apache/jmeter/pull/313
  
Hello @pmouawad ,

Hope it will cover your suggestion :)


---


[GitHub] jmeter issue #313: BZ61466: Comment addition to SampleResults

2017-10-05 Thread vherilier
Github user vherilier commented on the issue:

https://github.com/apache/jmeter/pull/313
  
I'll do it ASAP.
Thank you for the suggestion.


---


[GitHub] jmeter issue #313: BZ61466: Comment addition to SampleResults

2017-10-03 Thread pmouawad
Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/313
  
Hello @vherilier ,
Thanks for PR.

Could you amend it to:
- Add a property that would apply to all TC
- add a TristateCheckBox in GUI  'Use comment in SampleResult'

I think this will cover all cases:

- Send comments for ALL TC
- Don't send comments
- Send for all except some
- Send for none except some

And test this value to add it to sampler.
Of course JUnit are welcome.

I'll be happy to merge it once done.
Thank you.


---