[GitHub] jmeter issue #342: More edge cases for changeCase function and slight behavi...

2017-12-01 Thread pmouawad 
Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/342
  
Hi Felix,
It seems there is a consensus to drop CamelCase from function.
I agree also with it as I have never really needed in all my tests camel 
case nor any member of our team. So I have a doubt  whether it would be useful.




---

[GitHub] jmeter issue #342: More edge cases for changeCase function and slight behavi...

2017-11-28 Thread FSchumacher 
Github user FSchumacher commented on the issue:

https://github.com/apache/jmeter/pull/342
  
@pmouawad do you mean trim for all cases (upper, lower and capitalize)?


---

[GitHub] jmeter issue #342: More edge cases for changeCase function and slight behavi...

2017-11-26 Thread pmouawad 
Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/342
  
+1 for trim
Ok for me to merge. 


---

[GitHub] jmeter issue #342: More edge cases for changeCase function and slight behavi...

2017-11-25 Thread codecov-io 
Github user codecov-io commented on the issue:

https://github.com/apache/jmeter/pull/342
  
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/342?src=pr=h1) 
Report
> Merging 
[#342](https://codecov.io/gh/apache/jmeter/pull/342?src=pr=desc) into 
[trunk](https://codecov.io/gh/apache/jmeter/commit/59f75bb89c37d265eaf74e309b27918d7c7750d7?src=pr=desc)
 will **increase** coverage by `0.01%`.
> The diff coverage is `100%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/jmeter/pull/342/graphs/tree.svg?token=6Q7CI1wFSh=pr=650=150)](https://codecov.io/gh/apache/jmeter/pull/342?src=pr=tree)

```diff
@@ Coverage Diff  @@
##  trunk #342  +/-   ##

+ Coverage 57.89%   57.91%   +0.01% 
- Complexity1002410032   +8 

  Files  1146 1147   +1 
  Lines 7376273790  +28 
  Branches   7327 7329   +2 

+ Hits  4270842734  +26 
- Misses2857628577   +1 
- Partials   2478 2479   +1
```


| [Impacted 
Files](https://codecov.io/gh/apache/jmeter/pull/342?src=pr=tree) | Coverage 
Δ | Complexity Δ | |
|---|---|---|---|
| 
[...rc/org/apache/jmeter/functions/TestChangeCase.java](https://codecov.io/gh/apache/jmeter/pull/342?src=pr=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvZnVuY3Rpb25zL1Rlc3RDaGFuZ2VDYXNlLmphdmE=)
 | `94% <100%> (ø)` | `13 <0> (ø)` | :arrow_down: |
| 
[...pache/jmeter/functions/TestChangeCaseExamples.java](https://codecov.io/gh/apache/jmeter/pull/342?src=pr=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvZnVuY3Rpb25zL1Rlc3RDaGFuZ2VDYXNlRXhhbXBsZXMuamF2YQ==)
 | `100% <100%> (ø)` | `7 <7> (?)` | |
| 
[...ctions/org/apache/jmeter/functions/ChangeCase.java](https://codecov.io/gh/apache/jmeter/pull/342?src=pr=tree#diff-c3JjL2Z1bmN0aW9ucy9vcmcvYXBhY2hlL2ptZXRlci9mdW5jdGlvbnMvQ2hhbmdlQ2FzZS5qYXZh)
 | `98.43% <100%> (+0.1%)` | `19 <1> (+1)` | :arrow_up: |
| 
[...ocol/jms/org/apache/jmeter/protocol/jms/Utils.java](https://codecov.io/gh/apache/jmeter/pull/342?src=pr=tree#diff-c3JjL3Byb3RvY29sL2ptcy9vcmcvYXBhY2hlL2ptZXRlci9wcm90b2NvbC9qbXMvVXRpbHMuamF2YQ==)
 | `54.83% <0%> (-2.16%)` | `15% <0%> (ø)` | |
| 
[...apache/jmeter/extractor/TestBoundaryExtractor.java](https://codecov.io/gh/apache/jmeter/pull/342?src=pr=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvZXh0cmFjdG9yL1Rlc3RCb3VuZGFyeUV4dHJhY3Rvci5qYXZh)
 | `97.88% <0%> (ø)` | `17% <0%> (ø)` | :arrow_down: |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/jmeter/pull/342?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/jmeter/pull/342?src=pr=footer). Last 
update 
[59f75bb...3d576bf](https://codecov.io/gh/apache/jmeter/pull/342?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---