[GitHub] jmeter issue #401: Bug 62257 - Expand/Collapse short key doesn't work with n...

[orimarko]

Github user orimarko commented on the issue:

https://github.com/apache/jmeter/pull/401
  
As I see it, both key combinations are the same key in different location 
in keyboard
Therefore there's no need to change documentation


---

[GitHub] jmeter issue #401: Bug 62257 - Expand/Collapse short key doesn't work with n...

[FSchumacher]

Github user FSchumacher commented on the issue:

https://github.com/apache/jmeter/pull/401
  
Do you think, we should support both key combinations, or should we rather 
fix the documentation to use the working combinations?


---

[GitHub] jmeter issue #401: Bug 62257 - Expand/Collapse short key doesn't work with n...

[orimarko]

Github user orimarko commented on the issue:

https://github.com/apache/jmeter/pull/401
  
Hello

I'm fixing an issue of - sign. From
https://wiki.apache.org/jmeter/JMeterShortcuts :

* Collapse All : CTRL+"-" (not working on Mac)

* Expand All : CTRL+SHIFT+"-" (not working on Mac)

"-" sign can be found twice in keyboard. The numpad sign wqsn't working of
windows, so I add it to Collapse/Expand actions
בתאריך שבת, 13 באוק׳ 2018, 17:59, מאת Felix Schumacher ‏<
notificati...@github.com>:

> Thanks for your contribution and for the correction of your name ;)
>
> Have you tried shift+left cursor and shift+right cursor? They work fine
> on my install. Why would we want to have more than one keyboard short cut
> for the same functionality?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>

בתאריך 13 באוק׳ 2018 5:59 PM,‏ "Felix Schumacher" 

כתב:

Thanks for your contribution and for the correction of your name ;)

Have you tried shift+left cursor and shift+right cursor? They work fine on
my install. Why would we want to have more than one keyboard short cut for
the same functionality?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
, or mute
the thread


.



---

[GitHub] jmeter issue #401: Bug 62257 - Expand/Collapse short key doesn't work with n...

[FSchumacher]

Github user FSchumacher commented on the issue:

https://github.com/apache/jmeter/pull/401
  
Thanks for your contribution and for the correction of your name ;)

Have you tried `shift`+`left cursor` and `shift`+`right cursor`? They work 
fine on my install. Why would we want to have more than one keyboard short cut 
for the same functionality?


---

[GitHub] jmeter issue #401: Bug 62257 - Expand/Collapse short key doesn't work with n...

[codecov-io]

Github user codecov-io commented on the issue:

https://github.com/apache/jmeter/pull/401
  
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/401?src=pr&el=h1) 
Report
> Merging 
[#401](https://codecov.io/gh/apache/jmeter/pull/401?src=pr&el=desc) into 
[trunk](https://codecov.io/gh/apache/jmeter/commit/86d466bc5e3f366e3fae72f7bc62e1cddd78f2e7?src=pr&el=desc)
 will **decrease** coverage by `<.01%`.
> The diff coverage is `33.33%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/jmeter/pull/401/graphs/tree.svg?width=650&token=6Q7CI1wFSh&height=150&src=pr)](https://codecov.io/gh/apache/jmeter/pull/401?src=pr&el=tree)

```diff
@@ Coverage Diff  @@
##  trunk #401  +/-   ##

- Coverage 58.57%   58.56%   -0.01% 
  Complexity1061510615  

  Files  1193 1193  
  Lines 7595675970  +14 
  Branches   7347 7351   +4 

+ Hits  4448844494   +6 
- Misses2895728964   +7 
- Partials   2511 2512   +1
```


| [Impacted 
Files](https://codecov.io/gh/apache/jmeter/pull/401?src=pr&el=tree) | Coverage 
Δ | Complexity Δ | |
|---|---|---|---|
| 
[...jmeter/protocol/http/sampler/TestHTTPSamplers.java](https://codecov.io/gh/apache/jmeter/pull/401/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9zYW1wbGVyL1Rlc3RIVFRQU2FtcGxlcnMuamF2YQ==)
 | `100% <ø> (ø)` | `20 <0> (ø)` | :arrow_down: |
| 
[...org/apache/jmeter/gui/tree/JMeterTreeListener.java](https://codecov.io/gh/apache/jmeter/pull/401/diff?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvZ3VpL3RyZWUvSk1ldGVyVHJlZUxpc3RlbmVyLmphdmE=)
 | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| 
[.../core/org/apache/jmeter/gui/action/KeyStrokes.java](https://codecov.io/gh/apache/jmeter/pull/401/diff?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvZ3VpL2FjdGlvbi9LZXlTdHJva2VzLmphdmE=)
 | `89.83% <100%> (+0.35%)` | `1 <0> (ø)` | :arrow_down: |
| 
[...c/core/org/apache/jmeter/reporters/Summariser.java](https://codecov.io/gh/apache/jmeter/pull/401/diff?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvcmVwb3J0ZXJzL1N1bW1hcmlzZXIuamF2YQ==)
 | `85.49% <0%> (-0.77%)` | `18% <0%> (-1%)` | |
| 
[src/core/org/apache/jmeter/gui/action/Start.java](https://codecov.io/gh/apache/jmeter/pull/401/diff?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvZ3VpL2FjdGlvbi9TdGFydC5qYXZh)
 | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| 
[src/core/org/apache/jmeter/engine/TreeCloner.java](https://codecov.io/gh/apache/jmeter/pull/401/diff?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvZW5naW5lL1RyZWVDbG9uZXIuamF2YQ==)
 | `100% <0%> (ø)` | `11% <0%> (ø)` | :arrow_down: |
| 
[src/core/org/apache/jmeter/JMeter.java](https://codecov.io/gh/apache/jmeter/pull/401/diff?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvSk1ldGVyLmphdmE=)
 | `38.39% <0%> (+0.18%)` | `45% <0%> (+1%)` | :arrow_up: |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/jmeter/pull/401?src=pr&el=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/jmeter/pull/401?src=pr&el=footer). Last 
update 
[86d466b...5155599](https://codecov.io/gh/apache/jmeter/pull/401?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---