[GitHub] jmeter pull request: Refactored addKeyData in AbstractGraphConsume...

[ham1]

Github user ham1 commented on the pull request:

https://github.com/apache/jmeter/pull/129#issuecomment-185733398
  
@pmouawad Yes, you are correct. Good spot. I will try again and also try to 
keep formatting separate from changes - would 2 commits on the same PR be 
preferred or just 2 PRs for formatting and code change?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request: Refactored addKeyData in AbstractGraphConsume...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/129


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request: Refactored addKeyData in AbstractGraphConsume...

[pmouawad]

Github user pmouawad commented on the pull request:

https://github.com/apache/jmeter/pull/129#issuecomment-185728403
  
Hello,
I think there is an issue with your refactoring of AbstractGraphConsumer.
at lines 341 to 351, you have refactored the Map iteration but:
1) One contains:
`
coordResult.addResult(new ValueResultData(
Double.valueOf(percentile)));
coordResult.addResult(new ValueResultData(value));
`
2/ The other one contains:

`coordResult.addResult(new ValueResultData(value));
coordResult.addResult(new ValueResultData(
Double.valueOf(percentile)));`


So unless I am missing something I don't think it is ok.

Besides, I prefer not to mix formatting with refactoring.
I will only include formatting from this PR.
Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request: Refactored addKeyData in AbstractGraphConsume...

[ham1]

GitHub user ham1 opened a pull request:

https://github.com/apache/jmeter/pull/129

Refactored addKeyData in AbstractGraphConsumer and other minor formatting 

Mainly removing duplicate code and renaming things to make it easier to 
understand.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ham1/jmeter refactor_and_reformat

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/129.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #129


commit ae13c78bfa38621c46987d524b2224f219aa0a4d
Author: Graham Russell 
Date:   2016-02-17T22:56:31Z

Refactored addKeyData in AbstractGraphConsumer and other minor formatting




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---