[GitHub] jmeter pull request: Removing duplicate code.

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/126


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request: Removing duplicate code.

[pmouawad]

Github user pmouawad commented on the pull request:

https://github.com/apache/jmeter/pull/126#issuecomment-185315393
  
Yes :-) fixed the comments
Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request: Removing duplicate code.

[ham1]

Github user ham1 commented on the pull request:

https://github.com/apache/jmeter/pull/126#issuecomment-185263205
  
Thanks @pmouawad, I think the comment was for PR #123 instead of this one?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request: Removing duplicate code.

[pmouawad]

Github user pmouawad commented on the pull request:

https://github.com/apache/jmeter/pull/126#issuecomment-185104857
  
Thanks for PR , if you can restrict it to String.format as per sebb notes.
Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request: Removing duplicate code.

[pmouawad]

Github user pmouawad commented on the pull request:

https://github.com/apache/jmeter/pull/126#issuecomment-185104753
  
Note from sebb on dev mailing list:

> -1
> Auto boxing is generally a bad idea as it can hide poor design (wrong
>choice of long/Long).
>It can also hide wrong choice of method (Long.parseLong/Long.decode)
>Implicit unboxing can hide potential NPE.
>About the only place where autoboxing is useful is in String.format,
>but that should not be used as an excuse to allow it elsewhere.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request: Removing duplicate code.

[ham1]

GitHub user ham1 opened a pull request:

https://github.com/apache/jmeter/pull/126

Removing duplicate code.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ham1/jmeter remove_duplicate_code

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/126.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #126


commit 60f88f9ecac442c6189d2dcec8487e181e60ebf1
Author: Graham Russell 
Date:   2016-02-14T00:44:26Z

Removing duplicate code.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---