[GitHub] jmeter pull request #366: Set max line length to 160 (eventual target 120).

2018-02-12 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/366


---


[GitHub] jmeter pull request #366: Set max line length to 160 (eventual target 120).

2017-12-23 Thread ham1
GitHub user ham1 opened a pull request:

https://github.com/apache/jmeter/pull/366

 Set max line length to 160 (eventual target 120). 

## Description
Added new checkstyle rule for max line length of 160; with the view to, 
eventually, make it around 120. I will create another PR with the rest of the 
changes from #358 once this is merged as it should make merging slightly easier.

Hopefully reducing the scope and splitting this into commits that each 
change a separate thing will help merging - let me know if it's too much and I 
could split further if required.

## Motivation and Context
This PR will prevent any extra long lines and extra long anonymous inner 
classes being accidentally added.

## Checklist:
- [x] My code follows the [code style][style-guide] of this project.
- [x] I have updated the documentation accordingly.

[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ham1/jmeter max_line_length

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/366.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #366


commit c02a4e7529cea8ea043fd918073f0b60774d1729
Author: Graham Russell 
Date:   2017-12-23T13:59:56Z

Set max line length to 160 (eventual target 120).

commit 00ab78f50374027f7506a8143fdbbfc07dbdc21c
Author: Graham Russell 
Date:   2017-12-23T14:02:05Z

removed blank lines and superfluous comments

commit 6dd2f65d48957adc81373919fcba77c0c6355c5b
Author: Graham Russell 
Date:   2017-12-23T14:02:24Z

formatting and spelling




---