[GitHub] jmeter pull request #374: Add a 'go to top' button that gets shown, when pag...

2018-02-11 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/374


---


[GitHub] jmeter pull request #374: Add a 'go to top' button that gets shown, when pag...

2018-02-01 Thread ham1
Github user ham1 commented on a diff in the pull request:

https://github.com/apache/jmeter/pull/374#discussion_r165516098
  
--- Diff: xdocs/stylesheets/website-style.xsl ---
@@ -143,6 +144,13 @@
 

[GitHub] jmeter pull request #374: Add a 'go to top' button that gets shown, when pag...

2018-02-01 Thread FSchumacher
GitHub user FSchumacher opened a pull request:

https://github.com/apache/jmeter/pull/374

Add a 'go to top' button that gets shown, when page is scrolled down

## Description
The JMeter html documentation contains rather long pages, which take a lot 
of time to scroll down and a long time to scroll back up again. This patch adds 
a button (link really) to the bottom of the screen, that gets shown, when a 
page is scrolled down. A click on the link will take the user back up to the 
top.

## How Has This Been Tested?
A test has been made with firefox (v58) on the locally generated pages (ant 
docs-site)

## Types of changes
- New feature (non-breaking change which adds functionality)

## Checklist:


- [x] My code follows the [code style][style-guide] of this project.
- [No documentation needed] I have updated the documentation accordingly.

[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/FSchumacher/jmeter go-to-top-button

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/374.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #374


commit 8fe98f385bd7174a66d7a02ee2db0e779e088863
Author: Felix Schumacher 
Date:   2018-02-01T21:03:32Z

Add a 'go to top' button that gets shown, when page is scrolled down




---