[GitHub] jmeter pull request #378: Fix 43612

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/378


---

[GitHub] jmeter pull request #378: Fix 43612

[artem-fedorov]

Github user artem-fedorov commented on a diff in the pull request:

https://github.com/apache/jmeter/pull/378#discussion_r175794961
  
--- Diff: 
src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java ---
@@ -1649,6 +1648,43 @@ else if(getSendParameterValuesAsPostBody()) {
 }
 StringEntity requestEntity = new 
StringEntity(entityBodyContent.toString(), charset);
 entity.setEntity(requestEntity);
+} else if (hasArguments()) {
--- End diff --

Done


---

[GitHub] jmeter pull request #378: Fix 43612

[undera]

Github user undera commented on a diff in the pull request:

https://github.com/apache/jmeter/pull/378#discussion_r175759441
  
--- Diff: 
src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java ---
@@ -1649,6 +1648,43 @@ else if(getSendParameterValuesAsPostBody()) {
 }
 StringEntity requestEntity = new 
StringEntity(entityBodyContent.toString(), charset);
 entity.setEntity(requestEntity);
+} else if (hasArguments()) {
--- End diff --

Is it possible to extract this long code piece into separate method? For 
better readability.


---

[GitHub] jmeter pull request #378: Fix 43612

[artem-fedorov]

GitHub user artem-fedorov opened a pull request:

https://github.com/apache/jmeter/pull/378

Fix 43612

Hello,

I tried to send PUT request with a few Parameters, but I don't see them in 
my Request. I found bug for it 
https://bz.apache.org/bugzilla/show_bug.cgi?id=43612 

If I send PUT request with RawBody it works fine. 

Please, review my PR with fix

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/artem-fedorov/jmeter fix-43612

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/378.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #378


commit 3a9dbfd3fc9d5d7d76b2d6d1c3db8f510f80ef8e
Author: Artem Fedorov 
Date:   2018-03-19T16:04:10Z

fix put arguments

commit 7cebb0e707e92be41ecfb6b68d288f78a7da66d8
Author: Artem Fedorov 
Date:   2018-03-19T16:04:18Z

changelog

commit 70f8004bc64dc0309198f998965556a75efa4663
Author: Artem Fedorov 
Date:   2018-03-20T08:50:56Z

add tests




---