[GitHub] jmeter pull request #386: Adds parameter supports for RMI keystore creation ...

2018-05-26 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/386


---


[GitHub] jmeter pull request #386: Adds parameter supports for RMI keystore creation ...

2018-05-23 Thread loganmzz
GitHub user loganmzz opened a pull request:

https://github.com/apache/jmeter/pull/386

Adds parameter supports for RMI keystore creation scripts

Helps to integrate script into non-interactive process.

## Description

Pass script parameters to keytool command


N/A

## Motivation and Context

It helps caller to customize key creation and also enable to integrate 
script into non-interactive process.


## How Has This Been Tested?

`${JMETER_HOME}/bin/create-rmi-keystore.sh -dname 'o=Foobar' -keypass 
'f0o84R!'`

`%JMETER_HOME%\bin\create-rmi-keystore.bat -dname 'o=Foobar' -keypass 
'f0o84R!'`


* Linux: Debian 8 (Docker) + Open JDK 8u111
* Windows:  7 Pro + Oracle JDK 8u152


N/A

## Screenshots (if appropriate):
N/A

## Types of changes

- Bug fix (non-breaking change which fixes an issue)

## Checklist:


- [x] My code follows the [code style][style-guide] of this project.
- [ ] I have updated the documentation accordingly.

[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/loganmzz/jmeter 
feature/rmi-create-script-support-parameters

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/386.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #386


commit 7a5e1ef1f3c4a5135b19d6b7f36408f7ea9faf05
Author: Logan Mauzaize (T524467) 
Date:   2018-05-23T12:26:31Z

Adds parameter supports for RMI keystore creation scripts

Helps to integrate script into non-interactive process.




---