[GitHub] jmeter pull request #408: Display an info message, when no JavaFX is found a...

2018-10-14 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/408


---


[GitHub] jmeter pull request #408: Display an info message, when no JavaFX is found a...

2018-10-13 Thread FSchumacher
GitHub user FSchumacher opened a pull request:

https://github.com/apache/jmeter/pull/408

Display an info message, when no JavaFX is found and RenderInBrowser …

…is used

## Description
Currently we will log a full exception stack trace in warning level, when no
JavaFX was found and `RenderInBrowser` is initialized.

Reduce the log level to info and display a short message that the user 
should
install JavaFX in their Java environment, if they want to use the renderer.

## Motivation and Context
The user is probably scared when an exception stack trace is shown in their 
log file. This change should help the user to take the needed steps more easily.

## How Has This Been Tested?
Tested through GUI.

## Types of changes
- Bug fix (non-breaking change which fixes an issue)

## Checklist:


- [x] My code follows the [code style][style-guide] of this project.
- [ ] I have updated the documentation accordingly.

[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/FSchumacher/jmeter no-exceptions-on-browser

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/408.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #408


commit 002d427c8e4553511be2c85ade4c2ffc3c2e1eae
Author: Felix Schumacher 
Date:   2018-10-13T14:49:46Z

Display an info message, when no JavaFX is found and RenderInBrowser is used

Currently we will log a full exception stack trace in warning leve, when no
JavaFX was found and RenderInBrowser is initialized.

Reduce the log level to info and display a short message that the user 
should
install JavaFX in their Java environment, if they want to use the renderer.




---