Re: Drop sampleresult.getbytes.headers_size and sampleresult.getbytes.body_real_size

[Philippe Mouawad]

Hello,
Unless there is a no go, I'll drop them this evening.

Regards

On Sun, Nov 5, 2017 at 10:36 AM, Antonio Gomes Rodrigues 
wrote:

> +1
>
> Le 5 nov. 2017 10:03, "Philippe Mouawad"  a
> écrit :
>
> > They we introduced by:
> >
> > https://github.com/apache/jmeter/commit/a75d1b6fe7af7663da9ff7933085d0
> > 5a6bcde6b6#diff-ab78dc079a4302336674a94d7bf861db
> >
> > Change was related to:
> >
> > - https://bz.apache.org/bugzilla/show_bug.cgi?id=43363
> >
> > Regards
> >
> > On Sun, Nov 5, 2017 at 9:56 AM, Philippe Mouawad <
> > p.moua...@ubik-ingenierie.com> wrote:
> >
> > > Hello,
> > > I propose to drop those 2 properties as:
> > >
> > >- Setting them to false does not work, see:
> > >   - https://bz.apache.org/bugzilla/show_bug.cgi?id=61587
> > >- it looks like they were introduced to allow reverting to 2.5
> > >behaviour, I think we can now drop it
> > >- I am not sure they are even used as we didn't get any bug report
> for
> > >now while the bug looks to me critical when they are set to false
> > >
> > > We have already a lot of properties, so 2 dropped will be a good thing.
> > > Regards
> > > --
> > > Cordialement.
> > > Philippe
> > >
> >
> >
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
> > Ubik-Ingénierie
> >
> > UBIK LOAD PACK Web Site 
> >
> > UBIK LOAD PACK on TWITTER 
> >
>



-- 
Cordialement.
Philippe Mouawad.

Re: Drop sampleresult.getbytes.headers_size and sampleresult.getbytes.body_real_size

[Antonio Gomes Rodrigues]

+1

Le 5 nov. 2017 10:03, "Philippe Mouawad"  a
écrit :

> They we introduced by:
>
> https://github.com/apache/jmeter/commit/a75d1b6fe7af7663da9ff7933085d0
> 5a6bcde6b6#diff-ab78dc079a4302336674a94d7bf861db
>
> Change was related to:
>
> - https://bz.apache.org/bugzilla/show_bug.cgi?id=43363
>
> Regards
>
> On Sun, Nov 5, 2017 at 9:56 AM, Philippe Mouawad <
> p.moua...@ubik-ingenierie.com> wrote:
>
> > Hello,
> > I propose to drop those 2 properties as:
> >
> >- Setting them to false does not work, see:
> >   - https://bz.apache.org/bugzilla/show_bug.cgi?id=61587
> >- it looks like they were introduced to allow reverting to 2.5
> >behaviour, I think we can now drop it
> >- I am not sure they are even used as we didn't get any bug report for
> >now while the bug looks to me critical when they are set to false
> >
> > We have already a lot of properties, so 2 dropped will be a good thing.
> > Regards
> > --
> > Cordialement.
> > Philippe
> >
>
>
>
> --
> Cordialement.
> Philippe Mouawad.
> Ubik-Ingénierie
>
> UBIK LOAD PACK Web Site 
>
> UBIK LOAD PACK on TWITTER 
>

Re: Drop sampleresult.getbytes.headers_size and sampleresult.getbytes.body_real_size

[Philippe Mouawad]

They we introduced by:

https://github.com/apache/jmeter/commit/a75d1b6fe7af7663da9ff7933085d05a6bcde6b6#diff-ab78dc079a4302336674a94d7bf861db

Change was related to:

- https://bz.apache.org/bugzilla/show_bug.cgi?id=43363

Regards

On Sun, Nov 5, 2017 at 9:56 AM, Philippe Mouawad <
p.moua...@ubik-ingenierie.com> wrote:

> Hello,
> I propose to drop those 2 properties as:
>
>- Setting them to false does not work, see:
>   - https://bz.apache.org/bugzilla/show_bug.cgi?id=61587
>- it looks like they were introduced to allow reverting to 2.5
>behaviour, I think we can now drop it
>- I am not sure they are even used as we didn't get any bug report for
>now while the bug looks to me critical when they are set to false
>
> We have already a lot of properties, so 2 dropped will be a good thing.
> Regards
> --
> Cordialement.
> Philippe
>



-- 
Cordialement.
Philippe Mouawad.
Ubik-Ingénierie

UBIK LOAD PACK Web Site 

UBIK LOAD PACK on TWITTER