Re: Why does LogkitLoggerAdapter implement Serializable?

2016-04-19 Thread Philippe Mouawad
Fixed by:
http://svn.apache.org/viewvc?rev=1739903=rev

On Tue, Apr 19, 2016 at 12:16 PM, Philippe Mouawad <
philippe.moua...@gmail.com> wrote:

> Hi Sebb,
> The ancestor is Serializable.
> Existing implementations for other log frameworks are Serializable so I
> would say yes.
>
>
>
> Regards
>
> On Tue, Apr 19, 2016 at 11:58 AM, sebb  wrote:
>
>> PING - I think we need to resolve this before the re-release
>>
>> On 2 April 2016 at 13:59, sebb  wrote:
>> > Anyone?
>> >
>> > Code was added by Philippe as part of Bugzilla Id: 59240
>> >
>> >
>> > On 1 April 2016 at 00:29, sebb  wrote:
>> >> Is there any need to serialise this class?
>> >>
>> >> If not, it should not implement the interface.
>> >> If so, it needs a dummy ctor to allow unit tests to work
>>
>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>
>
>


-- 
Cordialement.
Philippe Mouawad.


Re: Why does LogkitLoggerAdapter implement Serializable?

2016-04-19 Thread Philippe Mouawad
Hi Sebb,
The ancestor is Serializable.
Existing implementations for other log frameworks are Serializable so I
would say yes.



Regards

On Tue, Apr 19, 2016 at 11:58 AM, sebb  wrote:

> PING - I think we need to resolve this before the re-release
>
> On 2 April 2016 at 13:59, sebb  wrote:
> > Anyone?
> >
> > Code was added by Philippe as part of Bugzilla Id: 59240
> >
> >
> > On 1 April 2016 at 00:29, sebb  wrote:
> >> Is there any need to serialise this class?
> >>
> >> If not, it should not implement the interface.
> >> If so, it needs a dummy ctor to allow unit tests to work
>



-- 
Cordialement.
Philippe Mouawad.


Re: Why does LogkitLoggerAdapter implement Serializable?

2016-04-19 Thread sebb
PING - I think we need to resolve this before the re-release

On 2 April 2016 at 13:59, sebb  wrote:
> Anyone?
>
> Code was added by Philippe as part of Bugzilla Id: 59240
>
>
> On 1 April 2016 at 00:29, sebb  wrote:
>> Is there any need to serialise this class?
>>
>> If not, it should not implement the interface.
>> If so, it needs a dummy ctor to allow unit tests to work


Re: Why does LogkitLoggerAdapter implement Serializable?

2016-04-02 Thread sebb
Anyone?

Code was added by Philippe as part of Bugzilla Id: 59240


On 1 April 2016 at 00:29, sebb  wrote:
> Is there any need to serialise this class?
>
> If not, it should not implement the interface.
> If so, it needs a dummy ctor to allow unit tests to work