Re: svn commit: r1735407 - in /jmeter/trunk: build.properties build.xml eclipse.classpath lib/ lib/aareadme.txt res/maven/ApacheJMeter_parent.pom xdocs/changes.xml

2016-04-02 Thread sebb 
On 17 March 2016 at 20:38, sebb  wrote:
> I see the maintenance issue now.
>
> The LICENSE file relies on the contents of licenses/bin to document
> 3rd party jars.
> As such, even jars under the AL need a file.
>
> It would be easier for the user - and probably easier to maintain - if
> the LICENSE file listed all the 3rd party jars by name and version.
> For jars that are not under AL 2.0 there would need to be a pointer to
> the license under license/bin.
> But only distinct licenses would need to be present.
>
> When a jar is updated, only the LICENSE file would need to be updated
> with the new version unless the license also changed.
>
> The existing scheme worked OK when there weren't many 3rd party jars.
> Not sure it's working properly now.
>
> Note: we should also list the ASF jar versions in LICENSE to make it
> easier for users.
>
> It would even be possible then to write a test to scan LICENSE looking
> for jar versions and compare against build.properties.

https://bz.apache.org/bugzilla/show_bug.cgi?id=59262

>
>
> On 17 March 2016 at 20:03, Philippe Mouawad  
> wrote:
>> Ok, I understand.
>> Done
>>
>> On Thu, Mar 17, 2016 at 8:52 PM, sebb  wrote:
>>
>>> Yes, every 3rd party jar needs to be mentioned in LICENSE
>>>
>>> It's important that users have confidence that the code is available
>>> under the AL.
>>> If a jar is not mentioned, then it is not obvious whether it is
>>> compatible or not.
>>> Users should not have to work out which jars belong to the same project.
>>>
>>> On 17 March 2016 at 19:27, Philippe Mouawad 
>>> wrote:
>>> > But accessors-smart is part of json-smart:
>>> > https://github.com/netplex/json-smart-v2
>>> >
>>> > Do I need to add a file for accessort-smart ?
>>> >
>>> > This is becoming a bit cumbersome each time we change a version
>>> >
>>> > On Thu, Mar 17, 2016 at 8:24 PM, sebb  wrote:
>>> >
>>> >> All 3rd party jars need to be mentioned in LICENSE.txt even if they use
>>> >> AL2.0
>>> >>
>>> >> On 17 March 2016 at 19:22, Philippe Mouawad >> >
>>> >> wrote:
>>> >> > Done
>>> >> >
>>> >> > On Thu, Mar 17, 2016 at 4:56 PM, sebb  wrote:
>>> >> >
>>> >> >> This is a new 3rd party jar.
>>> >> >> The license needs to be checked for compatibility and if OK must be
>>> >> >> documented in LICENSE - and stored locally if it is not AL 2.0
>>> >> >>
>>> >> >>
>>> >> >> On 17 March 2016 at 12:14,   wrote:
>>> >> >> > Author: pmouawad
>>> >> >> > Date: Thu Mar 17 12:14:44 2016
>>> >> >> > New Revision: 1735407
>>> >> >> >
>>> >> >> > URL: http://svn.apache.org/viewvc?rev=1735407=rev
>>> >> >> > Log:
>>> >> >> > Bug 59187 - JSON Post Processor : java.lang.NoClassDefFoundError:
>>> >> >> net/minidev/asm/FieldFilter at
>>> >> >> net.minidev.json.reader.JsonWriter.(JsonWriter.java:157) (affects
>>> >> nightly
>>> >> >> build before 3.0 release)
>>> >> >> > Bugzilla Id: 59187
>>> >> >> >
>>> >> >> > Modified:
>>> >> >> > jmeter/trunk/build.properties
>>> >> >> > jmeter/trunk/build.xml
>>> >> >> > jmeter/trunk/eclipse.classpath
>>> >> >> > jmeter/trunk/lib/   (props changed)
>>> >> >> > jmeter/trunk/lib/aareadme.txt
>>> >> >> > jmeter/trunk/res/maven/ApacheJMeter_parent.pom
>>> >> >> > jmeter/trunk/xdocs/changes.xml
>>> >> >> >
>>> >> >> > Modified: jmeter/trunk/build.properties
>>> >> >> > URL:
>>> >> >>
>>> >>
>>> http://svn.apache.org/viewvc/jmeter/trunk/build.properties?rev=1735407=1735406=1735407=diff
>>> >> >> >
>>> >> >>
>>> >>
>>> ==
>>> >> >> > --- jmeter/trunk/build.properties (original)
>>> >> >> > +++ jmeter/trunk/build.properties Thu Mar 17 12:14:44 2016
>>> >> >> > @@ -42,11 +42,21 @@
>>> >> >> >
>>> >> >> >  maven2.repo = https://repo1.maven.org/maven2
>>> >> >> >
>>> >> >> > +accessors-smart.version = 1.1
>>> >> >> > +accessors-smart.jar =
>>> >> >> accessors-smart-${accessors-smart.version}.jar
>>> >> >> > +accessors-smart.loc =
>>> >> >> ${maven2.repo}/net/minidev/accessors-smart/${accessors-smart.version}
>>> >> >> > +accessors-smart.md5 = b75cda0d7dadff9e6c20f4e7f3c3bc82
>>> >> >> > +
>>> >> >> >  apache-bsf.version  = 2.4.0
>>> >> >> >  apache-bsf.jar  = bsf-${apache-bsf.version}.jar
>>> >> >> >  apache-bsf.loc  =
>>> >> >> ${maven2.repo}/bsf/bsf/${apache-bsf.version}
>>> >> >> >  apache-bsf.md5  = 16e82d858c648962fb5c959f21959039
>>> >> >> >
>>> >> >> > +asm.version = 5.1
>>> >> >> > +asm.jar = asm-${asm.version}.jar
>>> >> >> > +asm.loc =
>>> >> >> ${maven2.repo}/org/ow2/asm/asm/${asm.version}
>>> >> >> > +asm.md5 = 3770466405f163d6616b65c32e16a3cd
>>> >> >> > +
>>> >> >> >  avalon-framework.version= 4.1.4
>>> >> >>

Re: svn commit: r1735407 - in /jmeter/trunk: build.properties build.xml eclipse.classpath lib/ lib/aareadme.txt res/maven/ApacheJMeter_parent.pom xdocs/changes.xml

2016-03-19 Thread Philippe Mouawad 
But accessors-smart is part of json-smart:
https://github.com/netplex/json-smart-v2

Do I need to add a file for accessort-smart ?

This is becoming a bit cumbersome each time we change a version

On Thu, Mar 17, 2016 at 8:24 PM, sebb  wrote:

> All 3rd party jars need to be mentioned in LICENSE.txt even if they use
> AL2.0
>
> On 17 March 2016 at 19:22, Philippe Mouawad 
> wrote:
> > Done
> >
> > On Thu, Mar 17, 2016 at 4:56 PM, sebb  wrote:
> >
> >> This is a new 3rd party jar.
> >> The license needs to be checked for compatibility and if OK must be
> >> documented in LICENSE - and stored locally if it is not AL 2.0
> >>
> >>
> >> On 17 March 2016 at 12:14,   wrote:
> >> > Author: pmouawad
> >> > Date: Thu Mar 17 12:14:44 2016
> >> > New Revision: 1735407
> >> >
> >> > URL: http://svn.apache.org/viewvc?rev=1735407=rev
> >> > Log:
> >> > Bug 59187 - JSON Post Processor : java.lang.NoClassDefFoundError:
> >> net/minidev/asm/FieldFilter at
> >> net.minidev.json.reader.JsonWriter.(JsonWriter.java:157) (affects
> nightly
> >> build before 3.0 release)
> >> > Bugzilla Id: 59187
> >> >
> >> > Modified:
> >> > jmeter/trunk/build.properties
> >> > jmeter/trunk/build.xml
> >> > jmeter/trunk/eclipse.classpath
> >> > jmeter/trunk/lib/   (props changed)
> >> > jmeter/trunk/lib/aareadme.txt
> >> > jmeter/trunk/res/maven/ApacheJMeter_parent.pom
> >> > jmeter/trunk/xdocs/changes.xml
> >> >
> >> > Modified: jmeter/trunk/build.properties
> >> > URL:
> >>
> http://svn.apache.org/viewvc/jmeter/trunk/build.properties?rev=1735407=1735406=1735407=diff
> >> >
> >>
> ==
> >> > --- jmeter/trunk/build.properties (original)
> >> > +++ jmeter/trunk/build.properties Thu Mar 17 12:14:44 2016
> >> > @@ -42,11 +42,21 @@
> >> >
> >> >  maven2.repo = https://repo1.maven.org/maven2
> >> >
> >> > +accessors-smart.version = 1.1
> >> > +accessors-smart.jar =
> >> accessors-smart-${accessors-smart.version}.jar
> >> > +accessors-smart.loc =
> >> ${maven2.repo}/net/minidev/accessors-smart/${accessors-smart.version}
> >> > +accessors-smart.md5 = b75cda0d7dadff9e6c20f4e7f3c3bc82
> >> > +
> >> >  apache-bsf.version  = 2.4.0
> >> >  apache-bsf.jar  = bsf-${apache-bsf.version}.jar
> >> >  apache-bsf.loc  =
> >> ${maven2.repo}/bsf/bsf/${apache-bsf.version}
> >> >  apache-bsf.md5  = 16e82d858c648962fb5c959f21959039
> >> >
> >> > +asm.version = 5.1
> >> > +asm.jar = asm-${asm.version}.jar
> >> > +asm.loc =
> >> ${maven2.repo}/org/ow2/asm/asm/${asm.version}
> >> > +asm.md5 = 3770466405f163d6616b65c32e16a3cd
> >> > +
> >> >  avalon-framework.version= 4.1.4
> >> >  avalon-framework.jar=
> >> avalon-framework-${avalon-framework.version}.jar
> >> >  avalon-framework.loc=
> >>
> ${maven2.repo}/avalon-framework/avalon-framework/${avalon-framework.version}
> >> >
> >> > Modified: jmeter/trunk/build.xml
> >> > URL:
> >>
> http://svn.apache.org/viewvc/jmeter/trunk/build.xml?rev=1735407=1735406=1735407=diff
> >> >
> >>
> ==
> >> > --- jmeter/trunk/build.xml (original)
> >> > +++ jmeter/trunk/build.xml Thu Mar 17 12:14:44 2016
> >> > @@ -360,7 +360,9 @@
> >> >
> >> >
> >> >
> >> > +   
> >> >  
> >> > +
> >> >  
> >> >  
> >> >  
> >> > @@ -432,7 +434,9 @@
> >> >
> >> >
> >> >  
> >> > +   
> >> >  
> >> > +
> >> >  
> >> >  
> >> >  
> >> > @@ -2848,7 +2852,9 @@ run JMeter unless all the JMeter jars ar
> >> >  conditional execution (it would be a lot easier if antcall
> >> supported if/unless).
> >> >  -->
> >> >  
> >> > -
> >> > +
> >> > +   
> >> > +
> >> >  
> >> >  
> >> >  
> >> >
> >> > Modified: jmeter/trunk/eclipse.classpath
> >> > URL:
> >>
> http://svn.apache.org/viewvc/jmeter/trunk/eclipse.classpath?rev=1735407=1735406=1735407=diff
> >> >
> >>
> ==
> >> > --- jmeter/trunk/eclipse.classpath (original)
> >> > +++ jmeter/trunk/eclipse.classpath Thu Mar 17 12:14:44 2016
> >> > @@ -43,6 +43,8 @@
> >> >  >> path="src/protocol/native"/>
> >> >  >> path="src/protocol/tcp"/>
> >> >  path="test/src"/>
> >> > +
> >> > +
> >> >  >> path="lib/avalon-framework-4.1.4.jar"/>
> >> > 
> >> > 
> >> >
> >> > Propchange: jmeter/trunk/lib/
> >> >
> >>
> --
> >> > --- svn:ignore (original)
> >> > +++ svn:ignore Thu Mar 17 12:14:44 2016
> >> > @@ -1,5 +1,7 @@
> >> >  ext
> >> >  src
> >> >

Re: svn commit: r1735407 - in /jmeter/trunk: build.properties build.xml eclipse.classpath lib/ lib/aareadme.txt res/maven/ApacheJMeter_parent.pom xdocs/changes.xml

2016-03-19 Thread sebb 
All 3rd party jars need to be mentioned in LICENSE.txt even if they use AL2.0

On 17 March 2016 at 19:22, Philippe Mouawad  wrote:
> Done
>
> On Thu, Mar 17, 2016 at 4:56 PM, sebb  wrote:
>
>> This is a new 3rd party jar.
>> The license needs to be checked for compatibility and if OK must be
>> documented in LICENSE - and stored locally if it is not AL 2.0
>>
>>
>> On 17 March 2016 at 12:14,   wrote:
>> > Author: pmouawad
>> > Date: Thu Mar 17 12:14:44 2016
>> > New Revision: 1735407
>> >
>> > URL: http://svn.apache.org/viewvc?rev=1735407=rev
>> > Log:
>> > Bug 59187 - JSON Post Processor : java.lang.NoClassDefFoundError:
>> net/minidev/asm/FieldFilter at
>> net.minidev.json.reader.JsonWriter.(JsonWriter.java:157) (affects nightly
>> build before 3.0 release)
>> > Bugzilla Id: 59187
>> >
>> > Modified:
>> > jmeter/trunk/build.properties
>> > jmeter/trunk/build.xml
>> > jmeter/trunk/eclipse.classpath
>> > jmeter/trunk/lib/   (props changed)
>> > jmeter/trunk/lib/aareadme.txt
>> > jmeter/trunk/res/maven/ApacheJMeter_parent.pom
>> > jmeter/trunk/xdocs/changes.xml
>> >
>> > Modified: jmeter/trunk/build.properties
>> > URL:
>> http://svn.apache.org/viewvc/jmeter/trunk/build.properties?rev=1735407=1735406=1735407=diff
>> >
>> ==
>> > --- jmeter/trunk/build.properties (original)
>> > +++ jmeter/trunk/build.properties Thu Mar 17 12:14:44 2016
>> > @@ -42,11 +42,21 @@
>> >
>> >  maven2.repo = https://repo1.maven.org/maven2
>> >
>> > +accessors-smart.version = 1.1
>> > +accessors-smart.jar =
>> accessors-smart-${accessors-smart.version}.jar
>> > +accessors-smart.loc =
>> ${maven2.repo}/net/minidev/accessors-smart/${accessors-smart.version}
>> > +accessors-smart.md5 = b75cda0d7dadff9e6c20f4e7f3c3bc82
>> > +
>> >  apache-bsf.version  = 2.4.0
>> >  apache-bsf.jar  = bsf-${apache-bsf.version}.jar
>> >  apache-bsf.loc  =
>> ${maven2.repo}/bsf/bsf/${apache-bsf.version}
>> >  apache-bsf.md5  = 16e82d858c648962fb5c959f21959039
>> >
>> > +asm.version = 5.1
>> > +asm.jar = asm-${asm.version}.jar
>> > +asm.loc =
>> ${maven2.repo}/org/ow2/asm/asm/${asm.version}
>> > +asm.md5 = 3770466405f163d6616b65c32e16a3cd
>> > +
>> >  avalon-framework.version= 4.1.4
>> >  avalon-framework.jar=
>> avalon-framework-${avalon-framework.version}.jar
>> >  avalon-framework.loc=
>> ${maven2.repo}/avalon-framework/avalon-framework/${avalon-framework.version}
>> >
>> > Modified: jmeter/trunk/build.xml
>> > URL:
>> http://svn.apache.org/viewvc/jmeter/trunk/build.xml?rev=1735407=1735406=1735407=diff
>> >
>> ==
>> > --- jmeter/trunk/build.xml (original)
>> > +++ jmeter/trunk/build.xml Thu Mar 17 12:14:44 2016
>> > @@ -360,7 +360,9 @@
>> >
>> >
>> >
>> > +   
>> >  
>> > +
>> >  
>> >  
>> >  
>> > @@ -432,7 +434,9 @@
>> >
>> >
>> >  
>> > +   
>> >  
>> > +
>> >  
>> >  
>> >  
>> > @@ -2848,7 +2852,9 @@ run JMeter unless all the JMeter jars ar
>> >  conditional execution (it would be a lot easier if antcall
>> supported if/unless).
>> >  -->
>> >  
>> > -
>> > +
>> > +   
>> > +
>> >  
>> >  
>> >  
>> >
>> > Modified: jmeter/trunk/eclipse.classpath
>> > URL:
>> http://svn.apache.org/viewvc/jmeter/trunk/eclipse.classpath?rev=1735407=1735406=1735407=diff
>> >
>> ==
>> > --- jmeter/trunk/eclipse.classpath (original)
>> > +++ jmeter/trunk/eclipse.classpath Thu Mar 17 12:14:44 2016
>> > @@ -43,6 +43,8 @@
>> > > path="src/protocol/native"/>
>> > > path="src/protocol/tcp"/>
>> > 
>> > +
>> > +
>> > > path="lib/avalon-framework-4.1.4.jar"/>
>> > 
>> > 
>> >
>> > Propchange: jmeter/trunk/lib/
>> >
>> --
>> > --- svn:ignore (original)
>> > +++ svn:ignore Thu Mar 17 12:14:44 2016
>> > @@ -1,5 +1,7 @@
>> >  ext
>> >  src
>> > +accessors-smart-1.1.jar
>> > +asm-5.1.jar
>> >  avalon-framework-4.1.4.jar
>> >  bsf-2.4.0.jar
>> >  bsh-2.0b5.jar
>> >
>> > Modified: jmeter/trunk/lib/aareadme.txt
>> > URL:
>> http://svn.apache.org/viewvc/jmeter/trunk/lib/aareadme.txt?rev=1735407=1735406=1735407=diff
>> >
>> ==
>> > --- jmeter/trunk/lib/aareadme.txt (original)
>> > +++ jmeter/trunk/lib/aareadme.txt Thu Mar 17 12:14:44 2016
>> > @@ -13,6 +13,14 @@ Which jars are used by which modules?
>> >  
>> >  [not

Re: svn commit: r1735407 - in /jmeter/trunk: build.properties build.xml eclipse.classpath lib/ lib/aareadme.txt res/maven/ApacheJMeter_parent.pom xdocs/changes.xml

2016-03-19 Thread sebb 
Yes, every 3rd party jar needs to be mentioned in LICENSE

It's important that users have confidence that the code is available
under the AL.
If a jar is not mentioned, then it is not obvious whether it is
compatible or not.
Users should not have to work out which jars belong to the same project.

On 17 March 2016 at 19:27, Philippe Mouawad  wrote:
> But accessors-smart is part of json-smart:
> https://github.com/netplex/json-smart-v2
>
> Do I need to add a file for accessort-smart ?
>
> This is becoming a bit cumbersome each time we change a version
>
> On Thu, Mar 17, 2016 at 8:24 PM, sebb  wrote:
>
>> All 3rd party jars need to be mentioned in LICENSE.txt even if they use
>> AL2.0
>>
>> On 17 March 2016 at 19:22, Philippe Mouawad 
>> wrote:
>> > Done
>> >
>> > On Thu, Mar 17, 2016 at 4:56 PM, sebb  wrote:
>> >
>> >> This is a new 3rd party jar.
>> >> The license needs to be checked for compatibility and if OK must be
>> >> documented in LICENSE - and stored locally if it is not AL 2.0
>> >>
>> >>
>> >> On 17 March 2016 at 12:14,   wrote:
>> >> > Author: pmouawad
>> >> > Date: Thu Mar 17 12:14:44 2016
>> >> > New Revision: 1735407
>> >> >
>> >> > URL: http://svn.apache.org/viewvc?rev=1735407=rev
>> >> > Log:
>> >> > Bug 59187 - JSON Post Processor : java.lang.NoClassDefFoundError:
>> >> net/minidev/asm/FieldFilter at
>> >> net.minidev.json.reader.JsonWriter.(JsonWriter.java:157) (affects
>> nightly
>> >> build before 3.0 release)
>> >> > Bugzilla Id: 59187
>> >> >
>> >> > Modified:
>> >> > jmeter/trunk/build.properties
>> >> > jmeter/trunk/build.xml
>> >> > jmeter/trunk/eclipse.classpath
>> >> > jmeter/trunk/lib/   (props changed)
>> >> > jmeter/trunk/lib/aareadme.txt
>> >> > jmeter/trunk/res/maven/ApacheJMeter_parent.pom
>> >> > jmeter/trunk/xdocs/changes.xml
>> >> >
>> >> > Modified: jmeter/trunk/build.properties
>> >> > URL:
>> >>
>> http://svn.apache.org/viewvc/jmeter/trunk/build.properties?rev=1735407=1735406=1735407=diff
>> >> >
>> >>
>> ==
>> >> > --- jmeter/trunk/build.properties (original)
>> >> > +++ jmeter/trunk/build.properties Thu Mar 17 12:14:44 2016
>> >> > @@ -42,11 +42,21 @@
>> >> >
>> >> >  maven2.repo = https://repo1.maven.org/maven2
>> >> >
>> >> > +accessors-smart.version = 1.1
>> >> > +accessors-smart.jar =
>> >> accessors-smart-${accessors-smart.version}.jar
>> >> > +accessors-smart.loc =
>> >> ${maven2.repo}/net/minidev/accessors-smart/${accessors-smart.version}
>> >> > +accessors-smart.md5 = b75cda0d7dadff9e6c20f4e7f3c3bc82
>> >> > +
>> >> >  apache-bsf.version  = 2.4.0
>> >> >  apache-bsf.jar  = bsf-${apache-bsf.version}.jar
>> >> >  apache-bsf.loc  =
>> >> ${maven2.repo}/bsf/bsf/${apache-bsf.version}
>> >> >  apache-bsf.md5  = 16e82d858c648962fb5c959f21959039
>> >> >
>> >> > +asm.version = 5.1
>> >> > +asm.jar = asm-${asm.version}.jar
>> >> > +asm.loc =
>> >> ${maven2.repo}/org/ow2/asm/asm/${asm.version}
>> >> > +asm.md5 = 3770466405f163d6616b65c32e16a3cd
>> >> > +
>> >> >  avalon-framework.version= 4.1.4
>> >> >  avalon-framework.jar=
>> >> avalon-framework-${avalon-framework.version}.jar
>> >> >  avalon-framework.loc=
>> >>
>> ${maven2.repo}/avalon-framework/avalon-framework/${avalon-framework.version}
>> >> >
>> >> > Modified: jmeter/trunk/build.xml
>> >> > URL:
>> >>
>> http://svn.apache.org/viewvc/jmeter/trunk/build.xml?rev=1735407=1735406=1735407=diff
>> >> >
>> >>
>> ==
>> >> > --- jmeter/trunk/build.xml (original)
>> >> > +++ jmeter/trunk/build.xml Thu Mar 17 12:14:44 2016
>> >> > @@ -360,7 +360,9 @@
>> >> >
>> >> >
>> >> >
>> >> > +   
>> >> >  
>> >> > +
>> >> >  
>> >> >  
>> >> >  
>> >> > @@ -432,7 +434,9 @@
>> >> >
>> >> >
>> >> >  
>> >> > +   
>> >> >  
>> >> > +
>> >> >  
>> >> >  
>> >> >  
>> >> > @@ -2848,7 +2852,9 @@ run JMeter unless all the JMeter jars ar
>> >> >  conditional execution (it would be a lot easier if antcall
>> >> supported if/unless).
>> >> >  -->
>> >> >  
>> >> > -
>> >> > +
>> >> > +   
>> >> > +
>> >> >  
>> >> >  
>> >> >  
>> >> >
>> >> > Modified: jmeter/trunk/eclipse.classpath
>> >> > URL:
>> >>
>> http://svn.apache.org/viewvc/jmeter/trunk/eclipse.classpath?rev=1735407=1735406=1735407=diff
>> >> >
>> >>
>> ==
>> >> > --- jmeter/trunk/eclipse.classpath (original)
>> >> > +++ jmeter/trunk/eclipse.classpath Thu Mar 17 12:14:44 2016
>> >> > @@ -43,6 +43,8 @@
>> >>

Re: svn commit: r1735407 - in /jmeter/trunk: build.properties build.xml eclipse.classpath lib/ lib/aareadme.txt res/maven/ApacheJMeter_parent.pom xdocs/changes.xml

2016-03-19 Thread sebb 
I see the maintenance issue now.

The LICENSE file relies on the contents of licenses/bin to document
3rd party jars.
As such, even jars under the AL need a file.

It would be easier for the user - and probably easier to maintain - if
the LICENSE file listed all the 3rd party jars by name and version.
For jars that are not under AL 2.0 there would need to be a pointer to
the license under license/bin.
But only distinct licenses would need to be present.

When a jar is updated, only the LICENSE file would need to be updated
with the new version unless the license also changed.

The existing scheme worked OK when there weren't many 3rd party jars.
Not sure it's working properly now.

Note: we should also list the ASF jar versions in LICENSE to make it
easier for users.

It would even be possible then to write a test to scan LICENSE looking
for jar versions and compare against build.properties.


On 17 March 2016 at 20:03, Philippe Mouawad  wrote:
> Ok, I understand.
> Done
>
> On Thu, Mar 17, 2016 at 8:52 PM, sebb  wrote:
>
>> Yes, every 3rd party jar needs to be mentioned in LICENSE
>>
>> It's important that users have confidence that the code is available
>> under the AL.
>> If a jar is not mentioned, then it is not obvious whether it is
>> compatible or not.
>> Users should not have to work out which jars belong to the same project.
>>
>> On 17 March 2016 at 19:27, Philippe Mouawad 
>> wrote:
>> > But accessors-smart is part of json-smart:
>> > https://github.com/netplex/json-smart-v2
>> >
>> > Do I need to add a file for accessort-smart ?
>> >
>> > This is becoming a bit cumbersome each time we change a version
>> >
>> > On Thu, Mar 17, 2016 at 8:24 PM, sebb  wrote:
>> >
>> >> All 3rd party jars need to be mentioned in LICENSE.txt even if they use
>> >> AL2.0
>> >>
>> >> On 17 March 2016 at 19:22, Philippe Mouawad > >
>> >> wrote:
>> >> > Done
>> >> >
>> >> > On Thu, Mar 17, 2016 at 4:56 PM, sebb  wrote:
>> >> >
>> >> >> This is a new 3rd party jar.
>> >> >> The license needs to be checked for compatibility and if OK must be
>> >> >> documented in LICENSE - and stored locally if it is not AL 2.0
>> >> >>
>> >> >>
>> >> >> On 17 March 2016 at 12:14,   wrote:
>> >> >> > Author: pmouawad
>> >> >> > Date: Thu Mar 17 12:14:44 2016
>> >> >> > New Revision: 1735407
>> >> >> >
>> >> >> > URL: http://svn.apache.org/viewvc?rev=1735407=rev
>> >> >> > Log:
>> >> >> > Bug 59187 - JSON Post Processor : java.lang.NoClassDefFoundError:
>> >> >> net/minidev/asm/FieldFilter at
>> >> >> net.minidev.json.reader.JsonWriter.(JsonWriter.java:157) (affects
>> >> nightly
>> >> >> build before 3.0 release)
>> >> >> > Bugzilla Id: 59187
>> >> >> >
>> >> >> > Modified:
>> >> >> > jmeter/trunk/build.properties
>> >> >> > jmeter/trunk/build.xml
>> >> >> > jmeter/trunk/eclipse.classpath
>> >> >> > jmeter/trunk/lib/   (props changed)
>> >> >> > jmeter/trunk/lib/aareadme.txt
>> >> >> > jmeter/trunk/res/maven/ApacheJMeter_parent.pom
>> >> >> > jmeter/trunk/xdocs/changes.xml
>> >> >> >
>> >> >> > Modified: jmeter/trunk/build.properties
>> >> >> > URL:
>> >> >>
>> >>
>> http://svn.apache.org/viewvc/jmeter/trunk/build.properties?rev=1735407=1735406=1735407=diff
>> >> >> >
>> >> >>
>> >>
>> ==
>> >> >> > --- jmeter/trunk/build.properties (original)
>> >> >> > +++ jmeter/trunk/build.properties Thu Mar 17 12:14:44 2016
>> >> >> > @@ -42,11 +42,21 @@
>> >> >> >
>> >> >> >  maven2.repo = https://repo1.maven.org/maven2
>> >> >> >
>> >> >> > +accessors-smart.version = 1.1
>> >> >> > +accessors-smart.jar =
>> >> >> accessors-smart-${accessors-smart.version}.jar
>> >> >> > +accessors-smart.loc =
>> >> >> ${maven2.repo}/net/minidev/accessors-smart/${accessors-smart.version}
>> >> >> > +accessors-smart.md5 = b75cda0d7dadff9e6c20f4e7f3c3bc82
>> >> >> > +
>> >> >> >  apache-bsf.version  = 2.4.0
>> >> >> >  apache-bsf.jar  = bsf-${apache-bsf.version}.jar
>> >> >> >  apache-bsf.loc  =
>> >> >> ${maven2.repo}/bsf/bsf/${apache-bsf.version}
>> >> >> >  apache-bsf.md5  = 16e82d858c648962fb5c959f21959039
>> >> >> >
>> >> >> > +asm.version = 5.1
>> >> >> > +asm.jar = asm-${asm.version}.jar
>> >> >> > +asm.loc =
>> >> >> ${maven2.repo}/org/ow2/asm/asm/${asm.version}
>> >> >> > +asm.md5 = 3770466405f163d6616b65c32e16a3cd
>> >> >> > +
>> >> >> >  avalon-framework.version= 4.1.4
>> >> >> >  avalon-framework.jar=
>> >> >> avalon-framework-${avalon-framework.version}.jar
>> >> >> >  avalon-framework.loc=
>> >> >>
>> >>
>> ${maven2.repo}/avalon-framework/avalon-framework/${avalon-framework.version}
>> >> >> >
>> >> >> >

Re: svn commit: r1735407 - in /jmeter/trunk: build.properties build.xml eclipse.classpath lib/ lib/aareadme.txt res/maven/ApacheJMeter_parent.pom xdocs/changes.xml

2016-03-18 Thread sebb 
This is a new 3rd party jar.
The license needs to be checked for compatibility and if OK must be
documented in LICENSE - and stored locally if it is not AL 2.0


On 17 March 2016 at 12:14,   wrote:
> Author: pmouawad
> Date: Thu Mar 17 12:14:44 2016
> New Revision: 1735407
>
> URL: http://svn.apache.org/viewvc?rev=1735407=rev
> Log:
> Bug 59187 - JSON Post Processor : java.lang.NoClassDefFoundError: 
> net/minidev/asm/FieldFilter at 
> net.minidev.json.reader.JsonWriter.(JsonWriter.java:157) (affects nightly 
> build before 3.0 release)
> Bugzilla Id: 59187
>
> Modified:
> jmeter/trunk/build.properties
> jmeter/trunk/build.xml
> jmeter/trunk/eclipse.classpath
> jmeter/trunk/lib/   (props changed)
> jmeter/trunk/lib/aareadme.txt
> jmeter/trunk/res/maven/ApacheJMeter_parent.pom
> jmeter/trunk/xdocs/changes.xml
>
> Modified: jmeter/trunk/build.properties
> URL: 
> http://svn.apache.org/viewvc/jmeter/trunk/build.properties?rev=1735407=1735406=1735407=diff
> ==
> --- jmeter/trunk/build.properties (original)
> +++ jmeter/trunk/build.properties Thu Mar 17 12:14:44 2016
> @@ -42,11 +42,21 @@
>
>  maven2.repo = https://repo1.maven.org/maven2
>
> +accessors-smart.version = 1.1
> +accessors-smart.jar = accessors-smart-${accessors-smart.version}.jar
> +accessors-smart.loc = 
> ${maven2.repo}/net/minidev/accessors-smart/${accessors-smart.version}
> +accessors-smart.md5 = b75cda0d7dadff9e6c20f4e7f3c3bc82
> +
>  apache-bsf.version  = 2.4.0
>  apache-bsf.jar  = bsf-${apache-bsf.version}.jar
>  apache-bsf.loc  = ${maven2.repo}/bsf/bsf/${apache-bsf.version}
>  apache-bsf.md5  = 16e82d858c648962fb5c959f21959039
>
> +asm.version = 5.1
> +asm.jar = asm-${asm.version}.jar
> +asm.loc = ${maven2.repo}/org/ow2/asm/asm/${asm.version}
> +asm.md5 = 3770466405f163d6616b65c32e16a3cd
> +
>  avalon-framework.version= 4.1.4
>  avalon-framework.jar= 
> avalon-framework-${avalon-framework.version}.jar
>  avalon-framework.loc= 
> ${maven2.repo}/avalon-framework/avalon-framework/${avalon-framework.version}
>
> Modified: jmeter/trunk/build.xml
> URL: 
> http://svn.apache.org/viewvc/jmeter/trunk/build.xml?rev=1735407=1735406=1735407=diff
> ==
> --- jmeter/trunk/build.xml (original)
> +++ jmeter/trunk/build.xml Thu Mar 17 12:14:44 2016
> @@ -360,7 +360,9 @@
>
>
>
> +   
>  
> +
>  
>  
>  
> @@ -432,7 +434,9 @@
>
>
>  
> +   
>  
> +
>  
>  
>  
> @@ -2848,7 +2852,9 @@ run JMeter unless all the JMeter jars ar
>  conditional execution (it would be a lot easier if antcall supported 
> if/unless).
>  -->
>  
> -
> +
> +   
> +
>  
>  
>  
>
> Modified: jmeter/trunk/eclipse.classpath
> URL: 
> http://svn.apache.org/viewvc/jmeter/trunk/eclipse.classpath?rev=1735407=1735406=1735407=diff
> ==
> --- jmeter/trunk/eclipse.classpath (original)
> +++ jmeter/trunk/eclipse.classpath Thu Mar 17 12:14:44 2016
> @@ -43,6 +43,8 @@
>  path="src/protocol/native"/>
>  path="src/protocol/tcp"/>
> 
> +
> +
> 
> 
> 
>
> Propchange: jmeter/trunk/lib/
> --
> --- svn:ignore (original)
> +++ svn:ignore Thu Mar 17 12:14:44 2016
> @@ -1,5 +1,7 @@
>  ext
>  src
> +accessors-smart-1.1.jar
> +asm-5.1.jar
>  avalon-framework-4.1.4.jar
>  bsf-2.4.0.jar
>  bsh-2.0b5.jar
>
> Modified: jmeter/trunk/lib/aareadme.txt
> URL: 
> http://svn.apache.org/viewvc/jmeter/trunk/lib/aareadme.txt?rev=1735407=1735406=1735407=diff
> ==
> --- jmeter/trunk/lib/aareadme.txt (original)
> +++ jmeter/trunk/lib/aareadme.txt Thu Mar 17 12:14:44 2016
> @@ -13,6 +13,14 @@ Which jars are used by which modules?
>  
>  [not exhaustive]
>
> +asm-5.1 (org.ow2.asm)
> +--
> +- JSON Path extractor
> +
> +accessors-smart-1.1 (net.minidev)
> +--
> +- JSON Path extractor
> +
>  avalon-framework-4.1.4 (org.apache.avalon.framework)
>  --
>  - LogKit (LoggingManager)
> @@ -144,7 +152,7 @@ https://github.com/jayway/JsonPath
>  - JSON Path Extractor
>  - JSON Path Renderer
>
> -json-smart-2.2.1
> +json-smart-2.2.1 (net.minidev)
>  
>  https://github.com/netplex/json-smart-v2
>  - JSON Path Extractor
>
> Modified: jmeter/trunk/res/maven/ApacheJMeter_parent.pom
> URL: 
>

Re: svn commit: r1735407 - in /jmeter/trunk: build.properties build.xml eclipse.classpath lib/ lib/aareadme.txt res/maven/ApacheJMeter_parent.pom xdocs/changes.xml

2016-03-18 Thread Philippe Mouawad 
Done

On Thu, Mar 17, 2016 at 4:56 PM, sebb  wrote:

> This is a new 3rd party jar.
> The license needs to be checked for compatibility and if OK must be
> documented in LICENSE - and stored locally if it is not AL 2.0
>
>
> On 17 March 2016 at 12:14,   wrote:
> > Author: pmouawad
> > Date: Thu Mar 17 12:14:44 2016
> > New Revision: 1735407
> >
> > URL: http://svn.apache.org/viewvc?rev=1735407=rev
> > Log:
> > Bug 59187 - JSON Post Processor : java.lang.NoClassDefFoundError:
> net/minidev/asm/FieldFilter at
> net.minidev.json.reader.JsonWriter.(JsonWriter.java:157) (affects nightly
> build before 3.0 release)
> > Bugzilla Id: 59187
> >
> > Modified:
> > jmeter/trunk/build.properties
> > jmeter/trunk/build.xml
> > jmeter/trunk/eclipse.classpath
> > jmeter/trunk/lib/   (props changed)
> > jmeter/trunk/lib/aareadme.txt
> > jmeter/trunk/res/maven/ApacheJMeter_parent.pom
> > jmeter/trunk/xdocs/changes.xml
> >
> > Modified: jmeter/trunk/build.properties
> > URL:
> http://svn.apache.org/viewvc/jmeter/trunk/build.properties?rev=1735407=1735406=1735407=diff
> >
> ==
> > --- jmeter/trunk/build.properties (original)
> > +++ jmeter/trunk/build.properties Thu Mar 17 12:14:44 2016
> > @@ -42,11 +42,21 @@
> >
> >  maven2.repo = https://repo1.maven.org/maven2
> >
> > +accessors-smart.version = 1.1
> > +accessors-smart.jar =
> accessors-smart-${accessors-smart.version}.jar
> > +accessors-smart.loc =
> ${maven2.repo}/net/minidev/accessors-smart/${accessors-smart.version}
> > +accessors-smart.md5 = b75cda0d7dadff9e6c20f4e7f3c3bc82
> > +
> >  apache-bsf.version  = 2.4.0
> >  apache-bsf.jar  = bsf-${apache-bsf.version}.jar
> >  apache-bsf.loc  =
> ${maven2.repo}/bsf/bsf/${apache-bsf.version}
> >  apache-bsf.md5  = 16e82d858c648962fb5c959f21959039
> >
> > +asm.version = 5.1
> > +asm.jar = asm-${asm.version}.jar
> > +asm.loc =
> ${maven2.repo}/org/ow2/asm/asm/${asm.version}
> > +asm.md5 = 3770466405f163d6616b65c32e16a3cd
> > +
> >  avalon-framework.version= 4.1.4
> >  avalon-framework.jar=
> avalon-framework-${avalon-framework.version}.jar
> >  avalon-framework.loc=
> ${maven2.repo}/avalon-framework/avalon-framework/${avalon-framework.version}
> >
> > Modified: jmeter/trunk/build.xml
> > URL:
> http://svn.apache.org/viewvc/jmeter/trunk/build.xml?rev=1735407=1735406=1735407=diff
> >
> ==
> > --- jmeter/trunk/build.xml (original)
> > +++ jmeter/trunk/build.xml Thu Mar 17 12:14:44 2016
> > @@ -360,7 +360,9 @@
> >
> >
> >
> > +   
> >  
> > +
> >  
> >  
> >  
> > @@ -432,7 +434,9 @@
> >
> >
> >  
> > +   
> >  
> > +
> >  
> >  
> >  
> > @@ -2848,7 +2852,9 @@ run JMeter unless all the JMeter jars ar
> >  conditional execution (it would be a lot easier if antcall
> supported if/unless).
> >  -->
> >  
> > -
> > +
> > +   
> > +
> >  
> >  
> >  
> >
> > Modified: jmeter/trunk/eclipse.classpath
> > URL:
> http://svn.apache.org/viewvc/jmeter/trunk/eclipse.classpath?rev=1735407=1735406=1735407=diff
> >
> ==
> > --- jmeter/trunk/eclipse.classpath (original)
> > +++ jmeter/trunk/eclipse.classpath Thu Mar 17 12:14:44 2016
> > @@ -43,6 +43,8 @@
> >  path="src/protocol/native"/>
> >  path="src/protocol/tcp"/>
> > 
> > +
> > +
> >  path="lib/avalon-framework-4.1.4.jar"/>
> > 
> > 
> >
> > Propchange: jmeter/trunk/lib/
> >
> --
> > --- svn:ignore (original)
> > +++ svn:ignore Thu Mar 17 12:14:44 2016
> > @@ -1,5 +1,7 @@
> >  ext
> >  src
> > +accessors-smart-1.1.jar
> > +asm-5.1.jar
> >  avalon-framework-4.1.4.jar
> >  bsf-2.4.0.jar
> >  bsh-2.0b5.jar
> >
> > Modified: jmeter/trunk/lib/aareadme.txt
> > URL:
> http://svn.apache.org/viewvc/jmeter/trunk/lib/aareadme.txt?rev=1735407=1735406=1735407=diff
> >
> ==
> > --- jmeter/trunk/lib/aareadme.txt (original)
> > +++ jmeter/trunk/lib/aareadme.txt Thu Mar 17 12:14:44 2016
> > @@ -13,6 +13,14 @@ Which jars are used by which modules?
> >  
> >  [not exhaustive]
> >
> > +asm-5.1 (org.ow2.asm)
> > +--
> > +- JSON Path extractor
> > +
> > +accessors-smart-1.1 (net.minidev)
> > +--
> > +- JSON Path extractor
> > +
> >  avalon-framework-4.1.4 (org.apache.avalon.framework)
> >  --
> >  - LogKit