[jira] [Resolved] (JOSHUA-253) Enable execution of Unit tests

[Lewis John McGibbney (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JOSHUA-253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lewis John McGibbney resolved JOSHUA-253.
-
Resolution: Fixed

yeah we fixed it in the Maven work

> Enable execution of Unit tests
> --
>
> Key: JOSHUA-253
> URL: https://issues.apache.org/jira/browse/JOSHUA-253
> Project: Joshua
>  Issue Type: Test
>Affects Versions: 6.0
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
> Fix For: 6.1
>
> Attachments: JOSHUA-253.patch
>
>
> As per our [discussion on this 
> topic|http://www.mail-archive.com/dev%40joshua.incubator.apache.org/msg00270.html],
>  [~teofili] correctly identified that unit level tests are not executed.
> We need to fix this such that they are.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (JOSHUA-253) Enable execution of Unit tests

[Lewis John McGibbney (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JOSHUA-253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lewis John McGibbney reassigned JOSHUA-253:
---

Assignee: Lewis John McGibbney

> Enable execution of Unit tests
> --
>
> Key: JOSHUA-253
> URL: https://issues.apache.org/jira/browse/JOSHUA-253
> Project: Joshua
>  Issue Type: Test
>Affects Versions: 6.0
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
> Fix For: 6.1
>
> Attachments: JOSHUA-253.patch
>
>
> As per our [discussion on this 
> topic|http://www.mail-archive.com/dev%40joshua.incubator.apache.org/msg00270.html],
>  [~teofili] correctly identified that unit level tests are not executed.
> We need to fix this such that they are.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Build failed in Jenkins: joshua_master #39

[Apache Jenkins Server]

See 

Changes:

[post] fixed bleu script invocation

--
[...truncated 1271 lines...]
Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

Generating 

[jira] [Commented] (JOSHUA-274) Use another HTTPServer other than Suns

[Matt Post (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313474#comment-15313474
 ] 

Matt Post commented on JOSHUA-274:
--

[~chrismattmann], CXF looks interesting. It seems like this would be a 
replacement for the [Joshua Translation 
Engine|https://github.com/joshua-decoder/joshua_translation_engine/]? The one 
advantage to doing the front-end in Python is that often the input needs to go 
through pre-processing (tokenization — splitting out punctuation, and 
normalization — standardizing different forms of punctuation, character sets, 
and so on). This has to match what was done to the training data, and that is 
usually done using Perl and Python scripts. We could move all of that 
pre-processing to Java fairly transparently but it would take some work. I 
wonder if there is some overlap in what is done in projects like Tika?

> Use another HTTPServer other than Suns
> --
>
> Key: JOSHUA-274
> URL: https://issues.apache.org/jira/browse/JOSHUA-274
> Project: Joshua
>  Issue Type: Improvement
>  Components: decoders
>Affects Versions: 6.0.5
>Reporter: Lewis John McGibbney
>Priority: Critical
> Fix For: 6.1
>
>
> This issue concerns the use of the 
> [HttpServer|https://github.com/apache/incubator-joshua/blob/master/src/joshua/decoder/JoshuaDecoder.java#L31]
>  within JoshuaDecoder.java. 
> We should replace the com.sun.net.httpserver.HttpServer implementation and 
> other Sun classes with ones from the Java API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-274) Use another HTTPServer other than Suns

[Matt Post (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313467#comment-15313467
 ] 

Matt Post commented on JOSHUA-274:
--

Now that Decoder.decodeAll() returns an iterable Translations object, this is 
possible. One item I'd like feedback on, though, is passing metadata to the 
decoder. There are situations where I'd like to be able to do things like 
change decoder weights, add rules to a private rule table, change the pop 
limit, etc. Currently, I do this through a JSON object with a metadata field in 
HTTP server mode. If we lost that, do you have another idea for how to pass 
such information to the decoder?

Some ideas: 

- Input lines starting with '|' will be parsed as metadata. This is nice 
because | is already a meta-character that gets subbed out in preprocessing 
anyway, so we can be sure that a literal '|' means something special (it's also 
used in forced decoding)

- Use an SGML or other format, e.g., ...

I am thinking of just implementing the first solution. If you want to pass 
metadata, it's on a line by itself. Sentence will notice what it is, process 
it, and then return a Translation object that has a metadata field, that the 
caller can then evaluate (perhaps there will be some return data).

Thoughts?

> Use another HTTPServer other than Suns
> --
>
> Key: JOSHUA-274
> URL: https://issues.apache.org/jira/browse/JOSHUA-274
> Project: Joshua
>  Issue Type: Improvement
>  Components: decoders
>Affects Versions: 6.0.5
>Reporter: Lewis John McGibbney
>Priority: Critical
> Fix For: 6.1
>
>
> This issue concerns the use of the 
> [HttpServer|https://github.com/apache/incubator-joshua/blob/master/src/joshua/decoder/JoshuaDecoder.java#L31]
>  within JoshuaDecoder.java. 
> We should replace the com.sun.net.httpserver.HttpServer implementation and 
> other Sun classes with ones from the Java API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-274) Use another HTTPServer other than Suns

[Chris A. Mattmann (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313219#comment-15313219
 ] 

Chris A. Mattmann commented on JOSHUA-274:
--

why not use Apache CXF?

> Use another HTTPServer other than Suns
> --
>
> Key: JOSHUA-274
> URL: https://issues.apache.org/jira/browse/JOSHUA-274
> Project: Joshua
>  Issue Type: Improvement
>  Components: decoders
>Affects Versions: 6.0.5
>Reporter: Lewis John McGibbney
>Priority: Critical
> Fix For: 6.1
>
>
> This issue concerns the use of the 
> [HttpServer|https://github.com/apache/incubator-joshua/blob/master/src/joshua/decoder/JoshuaDecoder.java#L31]
>  within JoshuaDecoder.java. 
> We should replace the com.sun.net.httpserver.HttpServer implementation and 
> other Sun classes with ones from the Java API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Build failed in Jenkins: joshua_master #38

[Apache Jenkins Server]

See 

Changes:

[post] set default tmpdir to $TMP (from env)

--
[...truncated 1608 lines...]
jdk1.8.0_74/jre/lib/desktop/icons/HighContrastInverse/48x48/mimetypes/gnome-mime-application-x-java-jnlp-file.png
jdk1.8.0_74/jre/lib/desktop/icons/HighContrastInverse/48x48/mimetypes/gnome-mime-application-x-java-archive.png
jdk1.8.0_74/jre/lib/desktop/icons/HighContrastInverse/48x48/apps/
jdk1.8.0_74/jre/lib/desktop/icons/HighContrastInverse/48x48/apps/sun-javaws.png
jdk1.8.0_74/jre/lib/desktop/icons/HighContrastInverse/48x48/apps/sun-java.png
jdk1.8.0_74/jre/lib/desktop/icons/HighContrastInverse/48x48/apps/sun-jcontrol.png
jdk1.8.0_74/jre/lib/desktop/icons/hicolor/
jdk1.8.0_74/jre/lib/desktop/icons/hicolor/16x16/
jdk1.8.0_74/jre/lib/desktop/icons/hicolor/16x16/mimetypes/
jdk1.8.0_74/jre/lib/desktop/icons/hicolor/16x16/mimetypes/gnome-mime-text-x-java.png
jdk1.8.0_74/jre/lib/desktop/icons/hicolor/16x16/mimetypes/gnome-mime-application-x-java-jnlp-file.png
jdk1.8.0_74/jre/lib/desktop/icons/hicolor/16x16/mimetypes/gnome-mime-application-x-java-archive.png
jdk1.8.0_74/jre/lib/desktop/icons/hicolor/16x16/apps/
jdk1.8.0_74/jre/lib/desktop/icons/hicolor/16x16/apps/sun-javaws.png
jdk1.8.0_74/jre/lib/desktop/icons/hicolor/16x16/apps/sun-java.png
jdk1.8.0_74/jre/lib/desktop/icons/hicolor/16x16/apps/sun-jcontrol.png
jdk1.8.0_74/jre/lib/desktop/icons/hicolor/48x48/
jdk1.8.0_74/jre/lib/desktop/icons/hicolor/48x48/mimetypes/
jdk1.8.0_74/jre/lib/desktop/icons/hicolor/48x48/mimetypes/gnome-mime-text-x-java.png
jdk1.8.0_74/jre/lib/desktop/icons/hicolor/48x48/mimetypes/gnome-mime-application-x-java-jnlp-file.png
jdk1.8.0_74/jre/lib/desktop/icons/hicolor/48x48/mimetypes/gnome-mime-application-x-java-archive.png
jdk1.8.0_74/jre/lib/desktop/icons/hicolor/48x48/apps/
jdk1.8.0_74/jre/lib/desktop/icons/hicolor/48x48/apps/sun-javaws.png
jdk1.8.0_74/jre/lib/desktop/icons/hicolor/48x48/apps/sun-java.png
jdk1.8.0_74/jre/lib/desktop/icons/hicolor/48x48/apps/sun-jcontrol.png
jdk1.8.0_74/jre/lib/classlist
jdk1.8.0_74/jre/lib/images/
jdk1.8.0_74/jre/lib/images/cursors/
jdk1.8.0_74/jre/lib/images/cursors/motif_CopyDrop32x32.gif
jdk1.8.0_74/jre/lib/images/cursors/invalid32x32.gif
jdk1.8.0_74/jre/lib/images/cursors/motif_LinkNoDrop32x32.gif
jdk1.8.0_74/jre/lib/images/cursors/motif_MoveNoDrop32x32.gif
jdk1.8.0_74/jre/lib/images/cursors/motif_MoveDrop32x32.gif
jdk1.8.0_74/jre/lib/images/cursors/motif_CopyNoDrop32x32.gif
jdk1.8.0_74/jre/lib/images/cursors/motif_LinkDrop32x32.gif
jdk1.8.0_74/jre/lib/images/cursors/cursors.properties
jdk1.8.0_74/jre/lib/images/icons/
jdk1.8.0_74/jre/lib/images/icons/sun-java_HighContrastInverse.png
jdk1.8.0_74/jre/lib/images/icons/sun-java_LowContrast.png
jdk1.8.0_74/jre/lib/images/icons/sun-java_HighContrast.png
jdk1.8.0_74/jre/lib/images/icons/sun-java.png
jdk1.8.0_74/jre/lib/psfont.properties.ja
jdk1.8.0_74/jre/lib/security/
jdk1.8.0_74/jre/lib/security/US_export_policy.jar
jdk1.8.0_74/jre/lib/security/local_policy.jar
jdk1.8.0_74/jre/lib/security/javaws.policy
jdk1.8.0_74/jre/lib/security/blacklist
jdk1.8.0_74/jre/lib/security/java.security
jdk1.8.0_74/jre/lib/security/cacerts
jdk1.8.0_74/jre/lib/security/blacklisted.certs
jdk1.8.0_74/jre/lib/security/trusted.libraries
jdk1.8.0_74/jre/lib/security/java.policy
jdk1.8.0_74/jre/lib/fontconfig.Turbo.bfc
jdk1.8.0_74/jre/lib/plugin.jar
jdk1.8.0_74/jre/lib/resources.jar
jdk1.8.0_74/jre/lib/hijrah-config-umalqura.properties
jdk1.8.0_74/jre/lib/deploy/
jdk1.8.0_74/jre/lib/deploy/MixedCodeMainDialog.ui
jdk1.8.0_74/jre/lib/deploy/messages_ja.properties
jdk1.8.0_74/jre/lib/deploy/ffjcext.zip
jdk1.8.0_74/jre/lib/deploy/messages_pt_BR.properties
jdk1.8.0_74/jre/lib/deploy/messages_ko.properties
jdk1.8.0_74/jre/lib/deploy/messages_zh_TW.properties
jdk1.8.0_74/jre/lib/deploy/messages_it.properties
jdk1.8.0_74/jre/lib/deploy/MixedCodeMainDialogJs.ui
jdk1.8.0_74/jre/lib/deploy/messages_fr.properties
jdk1.8.0_74/jre/lib/deploy/java-icon.ico
jdk1.8.0_74/jre/lib/deploy/mixcode_s.png
jdk1.8.0_74/jre/lib/deploy/messages_de.properties
jdk1.8.0_74/jre/lib/deploy/messages_zh_CN.properties
jdk1.8.0_74/jre/lib/deploy/splash_11-lic.gif
jdk1.8.0_74/jre/lib/deploy/splash...@2x-lic.gif
jdk1.8.0_74/jre/lib/deploy/splash.gif
jdk1.8.0_74/jre/lib/deploy/messages.properties
jdk1.8.0_74/jre/lib/deploy/spl...@2x.gif
jdk1.8.0_74/jre/lib/deploy/messages_zh_HK.properties
jdk1.8.0_74/jre/lib/deploy/cautionshield.icns
jdk1.8.0_74/jre/lib/deploy/messages_es.properties
jdk1.8.0_74/jre/lib/deploy/messages_sv.properties
jdk1.8.0_74/jre/lib/fontconfig.properties.src
jdk1.8.0_74/jre/lib/jfr/
jdk1.8.0_74/jre/lib/jfr/profile.jfc
jdk1.8.0_74/jre/lib/jfr/default.jfc
jdk1.8.0_74/jre/lib/jvm.hprof.txt
jdk1.8.0_74/jre/lib/jce.jar
jdk1.8.0_74/jre/lib/calendars.properties
jdk1.8.0_74/jre/lib/fontconfig.SuSE.11.bfc
jdk1.8.0_74/jre/lib/logging.properties
jdk1.8.0_74/jre/lib/meta-index
jdk1.8.0_74/jre/lib/fontconfig.RedHat.5.bfc

[jira] [Commented] (JOSHUA-274) Use another HTTPServer other than Suns

[Thamme Gowda (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313173#comment-15313173
 ] 

Thamme Gowda commented on JOSHUA-274:
-

Kellen, yes lets keep the translation core library as minimal as possible. +1 
for pointing out the issue.

An option would be to setup submodule for this maven project to contain a 
Joshua REST service .
1. it will allow us to use Joshua from non-JVM languages. 
2. since the language packs/models are huge, its not good idea to use JOSHUA 
from command line when we are making too many calls (since loading takes plenty 
of time for each CLI call)

> Use another HTTPServer other than Suns
> --
>
> Key: JOSHUA-274
> URL: https://issues.apache.org/jira/browse/JOSHUA-274
> Project: Joshua
>  Issue Type: Improvement
>  Components: decoders
>Affects Versions: 6.0.5
>Reporter: Lewis John McGibbney
>Priority: Critical
> Fix For: 6.1
>
>
> This issue concerns the use of the 
> [HttpServer|https://github.com/apache/incubator-joshua/blob/master/src/joshua/decoder/JoshuaDecoder.java#L31]
>  within JoshuaDecoder.java. 
> We should replace the com.sun.net.httpserver.HttpServer implementation and 
> other Sun classes with ones from the Java API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (JOSHUA-262) Implement all logging as Slf4j over Log4j

[Matt Post (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JOSHUA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Post closed JOSHUA-262.

Resolution: Fixed

> Implement all logging as Slf4j over Log4j
> -
>
> Key: JOSHUA-262
> URL: https://issues.apache.org/jira/browse/JOSHUA-262
> Project: Joshua
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 6.0.5
>Reporter: Lewis John McGibbney
>Assignee: Thamme Gowda N
> Fix For: 6.1
>
>
> [~hsaputra] suggested that we implement all logging as Slf4j over Log4j. If 
> we use [parameterized logging 
> notation|http://www.slf4j.org/faq.html#logging_performance] we can have good 
> logging in place.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-253) Enable execution of Unit tests

[Matt Post (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313111#comment-15313111
 ] 

Matt Post commented on JOSHUA-253:
--

I believe this is now working via "mvn test". Can this be closed out? I get the 
following:

---
 T E S T S
---
Running TestSuite
WARN - sentence 0 too long 401, truncating to length 200
WARN - sentence 0 too long 401, truncating to length 200
WARN - sentence 0 too long 401, truncating to length 200
WARN - sentence 0 too long 401, truncating to length 200
WARN - no grammars supplied!  Supplying dummy glue grammar.
WARN - no grammars supplied!  Supplying dummy glue grammar.
WARN - no grammars supplied!  Supplying dummy glue grammar.
WARN - no grammars supplied!  Supplying dummy glue grammar.
Tests run: 111, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 1.261 sec - 
in TestSuite

Results :

Tests run: 111, Failures: 0, Errors: 0, Skipped: 1

> Enable execution of Unit tests
> --
>
> Key: JOSHUA-253
> URL: https://issues.apache.org/jira/browse/JOSHUA-253
> Project: Joshua
>  Issue Type: Test
>Affects Versions: 6.0
>Reporter: Lewis John McGibbney
> Fix For: 6.1
>
> Attachments: JOSHUA-253.patch
>
>
> As per our [discussion on this 
> topic|http://www.mail-archive.com/dev%40joshua.incubator.apache.org/msg00270.html],
>  [~teofili] correctly identified that unit level tests are not executed.
> We need to fix this such that they are.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-262) Implement all logging as Slf4j over Log4j

[Thamme Gowda (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313110#comment-15313110
 ] 

Thamme Gowda commented on JOSHUA-262:
-

Yes, I think we can close this [~post] 

> Implement all logging as Slf4j over Log4j
> -
>
> Key: JOSHUA-262
> URL: https://issues.apache.org/jira/browse/JOSHUA-262
> Project: Joshua
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 6.0.5
>Reporter: Lewis John McGibbney
>Assignee: Thamme Gowda N
> Fix For: 6.1
>
>
> [~hsaputra] suggested that we implement all logging as Slf4j over Log4j. If 
> we use [parameterized logging 
> notation|http://www.slf4j.org/faq.html#logging_performance] we can have good 
> logging in place.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (JOSHUA-254) Update README with correct branding

[Matt Post (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JOSHUA-254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Post closed JOSHUA-254.

Resolution: Fixed

> Update README with correct branding
> ---
>
> Key: JOSHUA-254
> URL: https://issues.apache.org/jira/browse/JOSHUA-254
> Project: Joshua
>  Issue Type: Task
>Affects Versions: 6.0.5
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
>Priority: Trivial
> Fix For: 6.1
>
>
> This issue is trivial and involves updating the project README to direct all 
> links to the correct place as well as address branding.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (JOSHUA-252) Make it possible to use Maven to build Joshua

[Matt Post (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JOSHUA-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Post closed JOSHUA-252.

Resolution: Fixed

> Make it possible to use Maven to build Joshua
> -
>
> Key: JOSHUA-252
> URL: https://issues.apache.org/jira/browse/JOSHUA-252
> Project: Joshua
>  Issue Type: Improvement
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> As per discussion on the dev@ list for now Ant is the official build tool for 
> Joshua however we would like to possibly switch to Maven if / when someone is 
> able to do so.
> Assigning to me for now as I could be able to look into this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (JOSHUA-256) Note that Joshua builds and runs with >= Java 1.8

[Matt Post (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JOSHUA-256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Post closed JOSHUA-256.

Resolution: Fixed

> Note that Joshua builds and runs with >= Java 1.8
> -
>
> Key: JOSHUA-256
> URL: https://issues.apache.org/jira/browse/JOSHUA-256
> Project: Joshua
>  Issue Type: Improvement
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
>Priority: Critical
> Fix For: 6.1
>
>
> Since the Joshua code was transitioned into the Incubator, code has been 
> committed which requires Java 1.8 minimum to compile and run. 
> We should note this within the README and also on the Website once we move 
> towards out first 6.1 Incubating release. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (JOSHUA-258) Add back penn-treebank-(de)tokenizer perl scripts

[Matt Post (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JOSHUA-258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Post closed JOSHUA-258.

Resolution: Fixed

This was addressed.

> Add back penn-treebank-(de)tokenizer perl scripts
> -
>
> Key: JOSHUA-258
> URL: https://issues.apache.org/jira/browse/JOSHUA-258
> Project: Joshua
>  Issue Type: Task
>Affects Versions: 6.0.5
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
> Fix For: 6.1
>
>
> I've been working with the 
> [joshua_translation_engine|https://github.com/joshua-decoder/joshua_translation_engine]
>  (which is friggin excellent, we will definately be standing this up on 
> something more heavyweight in the near future) and recently reported [issue 
> 15|https://github.com/joshua-decoder/joshua_translation_engine/issues/15]
> This issue therefore proposes to add back in penn-treebank-(de)tokenizer perl 
> scripts which were removed between 6.0.4 and 6.0.5 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (JOSHUA-261) Remove ext directory from source tree

[Matt Post (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JOSHUA-261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Post updated JOSHUA-261:
-
Description: 
Right now we have a bunch of cofe bundled in to the 
[ext|https://github.com/apache/incubator-joshua/tree/master/ext] directory. I 
don't think any of this code can be shipped with an Apache Joshua (Incubating) 
release so we need to think about a mechanism for removing it and making Joshua 
work in other ways.

Here is a partial roadmap:

[X] remove GIZA++ and symal
[ ] update [the developer 
documentation|https://cwiki.apache.org/confluence/display/JOSHUA/Development] 
to describe how to install them and put them in the path
[ ] update the pipeline scripts to not be hard-coded to $JOSHUA/bin
[X] update the build files to not try to build them

  was:
Right now we have a bunch of cofe bundled in to the 
[ext|https://github.com/apache/incubator-joshua/tree/master/ext] directory. I 
don't think any of this code can be shipped with an Apache Joshua (Incubating) 
release so we need to think about a mechanism for removing it and making Joshua 
work in other ways.

Here is a partial roadmap:

[ ] remove GIZA++ and symal
[ ] update [the developer 
documentation|https://cwiki.apache.org/confluence/display/JOSHUA/Development] 
to describe how to install them and put them in the path
[ ] update the pipeline scripts to not be hard-coded to $JOSHUA/bin
[ ] update the build files to not try to build them


> Remove ext directory from source tree
> -
>
> Key: JOSHUA-261
> URL: https://issues.apache.org/jira/browse/JOSHUA-261
> Project: Joshua
>  Issue Type: Task
>Affects Versions: 6.0.5
>Reporter: Lewis John McGibbney
>Priority: Blocker
> Fix For: 6.1
>
>
> Right now we have a bunch of cofe bundled in to the 
> [ext|https://github.com/apache/incubator-joshua/tree/master/ext] directory. I 
> don't think any of this code can be shipped with an Apache Joshua 
> (Incubating) release so we need to think about a mechanism for removing it 
> and making Joshua work in other ways.
> Here is a partial roadmap:
> [X] remove GIZA++ and symal
> [ ] update [the developer 
> documentation|https://cwiki.apache.org/confluence/display/JOSHUA/Development] 
> to describe how to install them and put them in the path
> [ ] update the pipeline scripts to not be hard-coded to $JOSHUA/bin
> [X] update the build files to not try to build them



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-262) Implement all logging as Slf4j over Log4j

[Matt Post (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313106#comment-15313106
 ] 

Matt Post commented on JOSHUA-262:
--

This is done, right? Can we close out this request, [~tgow...@gmail.com]?

> Implement all logging as Slf4j over Log4j
> -
>
> Key: JOSHUA-262
> URL: https://issues.apache.org/jira/browse/JOSHUA-262
> Project: Joshua
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 6.0.5
>Reporter: Lewis John McGibbney
>Assignee: Thamme Gowda N
> Fix For: 6.1
>
>
> [~hsaputra] suggested that we implement all logging as Slf4j over Log4j. If 
> we use [parameterized logging 
> notation|http://www.slf4j.org/faq.html#logging_performance] we can have good 
> logging in place.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-joshua issue #22: This patch enables junit tests. Fixes a bug with...

[mjpost]

Github user mjpost commented on the issue:

https://github.com/apache/incubator-joshua/pull/22
  
I am happy to have just learned about "mvn test" :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua issue #22: This patch enables junit tests. Fixes a bug with...

[KellenSunderland]

Github user KellenSunderland commented on the issue:

https://github.com/apache/incubator-joshua/pull/22
  
Thanks for the merge.  Looks like there's two tests still failing.  The 
build server is complaining about basicVocabTest, and you have issues with the 
multithreaded tests.  I'll take look at both of these.

I'll come totally clean here and admit I'm mostly testing with either 
intellij or 'mvn test'.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: joshua_master #37

[Apache Jenkins Server]

See 

Changes:

[kellens] Re-enabled JUnit tests with a newer surefire plugin; fixed some of the

--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on ubuntu-5 (docker Ubuntu ubuntu5 ubuntu yahoo-not-h2) in 
workspace 
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/incubator-joshua.git # timeout=10
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/incubator-joshua.git
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/incubator-joshua.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision 35e9c58ffead1b71de8cde5f6a3b74804e58b118 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 35e9c58ffead1b71de8cde5f6a3b74804e58b118
 > git rev-list c4ce122a77aebddc5bae3a8e5f1b9e377a74a00f # timeout=10
[joshua_master] $ /home/jenkins/tools/maven/apache-maven-3.0.4/bin/mvn clean 
deploy javadoc:aggregate
[INFO] Scanning for projects...
[INFO] 
[INFO] 
[INFO] Building Apache Joshua Machine Translation Toolkit 6.0.6-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.4.1:clean (default-clean) @ joshua ---
[INFO] Deleting 
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.2.1:process (default) @ joshua ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ joshua ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:compile (default-compile) @ joshua ---
[INFO] Compiling 264 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
joshua ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 336 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:testCompile (default-testCompile) @ 
joshua ---
[INFO] Compiling 41 source files to 

[INFO] 
[INFO] --- maven-surefire-plugin:2.19.1:test (default-test) @ joshua ---

---
 T E S T S
---
Running TestSuite
WARN - sentence 0 too long 401, truncating to length 200
WARN - sentence 0 too long 401, truncating to length 200
WARN - sentence 0 too long 401, truncating to length 200
WARN - sentence 0 too long 401, truncating to length 200
%
%
%
%
%
%
%
%
%
WARN - no grammars supplied!  Supplying dummy glue grammar.
WARN - no grammars supplied!  Supplying dummy glue grammar.
WARN - no grammars supplied!  Supplying dummy glue grammar.
WARN - no grammars supplied!  Supplying dummy glue grammar.
Tests run: 122, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 3.629 sec <<< 
FAILURE! - in TestSuite
basicVocabTest(org.apache.joshua.corpus.vocab.VocabularyTest)  Time elapsed: 
0.029 sec  <<< FAILURE!
java.lang.AssertionError: null
at 
org.apache.joshua.corpus.vocab.VocabularyTest.basicVocabTest(VocabularyTest.java:56)


Results :

Failed tests: 
  VocabularyTest.basicVocabTest:56 null

Tests run: 122, Failures: 1, Errors: 0, Skipped: 1

[INFO] 
[INFO] 
[INFO] Skipping Apache Joshua Machine Translation Toolkit
[INFO] This project has been banned from the build due to previous failures.
[INFO] 
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time: 24.139s
[INFO] Finished at: Thu Jun 02 14:14:51 UTC 2016
[INFO] Final Memory: 34M/639M
[INFO] 
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on 
project joshua: There are test failures.
[ERROR] 
[ERROR] Please refer to 

[GitHub] incubator-joshua issue #22: This patch enables junit tests. Fixes a bug with...

[mjpost]

Github user mjpost commented on the issue:

https://github.com/apache/incubator-joshua/pull/22
  
Okay, I merged this. Notes:

- To get it working, I had to rerun "mvn eclipse:eclipse"
- I also had to rebuild the JUnit test configuration. I think this might 
have to do with me not quite understanding JUnit eclipse integration
- I still have one unit test failing: 
`givenPackedGrammar_whenNTranslationsCalledConcurrently_thenReturnNResults()` 
(in `MultithreadedTranslationTest`)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request #22: This patch enables junit tests. Fixes a b...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-joshua/pull/22


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request #22: This patch enables junit tests. Fixes a b...

[KellenSunderland]

GitHub user KellenSunderland opened a pull request:

https://github.com/apache/incubator-joshua/pull/22

This patch enables junit tests.  Fixes a bug with FeatureVector

Re-enabled JUnit tests with a newer surefire plugin; fixed some of the 
tests; KenLM tests have been temporarily disabled. Cleaned whitespace.  Fixed a 
bug in featurevector

Run with "mvn test"

From Eclipse in Package Explorer right click on the package and "Run As -> 
JUnit"

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/KellenSunderland/incubator-joshua master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-joshua/pull/22.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #22


commit b1743cbad58523a6f33883fe971c20098fd5153c
Author: Kellen Sunderland 
Date:   2016-06-02T12:46:31Z

Re-enabled JUnit tests with a newer surefire plugin; fixed some of the 
tests; KenLM tests have been temporarily disabled. Cleaned whitespace.  Fixed a 
bug in featurevector




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---