[jira] [Created] (JOSHUA-312) Alignment is never cached

[Lewis John McGibbney (JIRA)]

Lewis John McGibbney created JOSHUA-312:
---

 Summary: Alignment is never cached
 Key: JOSHUA-312
 URL: https://issues.apache.org/jira/browse/JOSHUA-312
 Project: Joshua
  Issue Type: Improvement
  Components: alignment
Affects Versions: 6.0.5
Reporter: Lewis John McGibbney
Priority: Critical
 Fix For: 6.2


Say if a pipeline fails after alignment. The alignment result is never cached 
and it becomes necessary to undertake alignment... again!
We should investigate the process for caching alignments as it would really 
speed up rerunning end-to-end pipelines for large input datasets.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-299) Move regression tests to proper unit tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510410#comment-15510410
 ] 

ASF GitHub Bot commented on JOSHUA-299:
---

Github user lewismc commented on the issue:

https://github.com/apache/incubator-joshua/pull/67
  
ack ;)


> Move regression tests to proper unit tests
> --
>
> Key: JOSHUA-299
> URL: https://issues.apache.org/jira/browse/JOSHUA-299
> Project: Joshua
>  Issue Type: Bug
>Reporter: Matt Post
>Assignee: Lewis John McGibbney
> Fix For: 6.1
>
>  Time Spent: 2m
>  Remaining Estimate: 0h
>
> Many of the regression tests (test*.sh under src/test/resources) have been 
> moved to proper unit tests, but this move should be completed, and the 
> regression tests should be deleted. This should be done for 6.1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-joshua issue #67: JOSHUA-299 Move regression tests to proper unit ...

[lewismc]

Github user lewismc commented on the issue:

https://github.com/apache/incubator-joshua/pull/67
  
ack ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (JOSHUA-299) Move regression tests to proper unit tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510376#comment-15510376
 ] 

ASF GitHub Bot commented on JOSHUA-299:
---

Github user KellenSunderland commented on the issue:

https://github.com/apache/incubator-joshua/pull/67
  
Looks good to me.  Some nice cleanup there as well.  I can't comment on the 
change to the output format except to say that i don't really understand what 
was there previously. #


> Move regression tests to proper unit tests
> --
>
> Key: JOSHUA-299
> URL: https://issues.apache.org/jira/browse/JOSHUA-299
> Project: Joshua
>  Issue Type: Bug
>Reporter: Matt Post
>Assignee: Lewis John McGibbney
> Fix For: 6.1
>
>  Time Spent: 2m
>  Remaining Estimate: 0h
>
> Many of the regression tests (test*.sh under src/test/resources) have been 
> moved to proper unit tests, but this move should be completed, and the 
> regression tests should be deleted. This should be done for 6.1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-299) Move regression tests to proper unit tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510179#comment-15510179
 ] 

ASF GitHub Bot commented on JOSHUA-299:
---

GitHub user lewismc opened a pull request:

https://github.com/apache/incubator-joshua/pull/67

JOSHUA-299 Move regression tests to proper unit tests

Hi folks, this is one stage closer to us addressing 
https://issues.apache.org/jira/browse/JOSHUA-299

Of note here, I manually constructed the decoder output from essentially 
concatenating various output from a StructuredTranslation. What should be noted 
here is that we actually seem to loose some accuracy note the old file 
provided decoder output of ```0 ||| help ||| tm_glue_0=1.000 ||| 0.000``` 
whereas now we provide ```0 ||| help ||| tm_glue_0=1.0 ||| 0.0```

Any comments?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lewismc/incubator-joshua JOSHUA-299

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-joshua/pull/67.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #67


commit 5dd80a37217f4f61ca00aedd256947a412e13771
Author: Lewis John McGibbney 
Date:   2016-09-21T14:53:21Z

JOSHUA-299 Move regression tests to proper unit tests




> Move regression tests to proper unit tests
> --
>
> Key: JOSHUA-299
> URL: https://issues.apache.org/jira/browse/JOSHUA-299
> Project: Joshua
>  Issue Type: Bug
>Reporter: Matt Post
>Assignee: Lewis John McGibbney
> Fix For: 6.1
>
>
> Many of the regression tests (test*.sh under src/test/resources) have been 
> moved to proper unit tests, but this move should be completed, and the 
> regression tests should be deleted. This should be done for 6.1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-joshua issue #65: This PR is a first attempt to minimize ngram arr...

[KellenSunderland]

Github user KellenSunderland commented on the issue:

https://github.com/apache/incubator-joshua/pull/65
  
Well in that case I can open a PR without the DirectBuffer changes 
included.  They're pretty complicated and if they don't improve performance 
it's probably better to leave them out.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---