[GitHub] incubator-joshua issue #33: Refactored unit tests to all use TestNG, removed...

[KellenSunderland]

Github user KellenSunderland commented on the issue:

https://github.com/apache/incubator-joshua/pull/33
  
Hey Matt, $JOSHUA/lib is fine with me.  Just thought I'd double check that 
I shouldn't be giving it another path.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] incubator-joshua issue #33: Refactored unit tests to all use TestNG, removed...

[Matt Post]

Hi Kellen,

The current standard location for KenLM is $JOSHUA/lib. I'm happy to move this 
if there is a more conventional spot. $JOSHUA/target?

matt



> On Jul 29, 2016, at 3:47 AM, KellenSunderland  wrote:
> 
> Github user KellenSunderland commented on the issue:
> 
>https://github.com/apache/incubator-joshua/pull/33
> 
>Hey Matt, thanks for letting me know.  I missed adding a resource 
> directory (I always forget to git add dirs for some reason).  Things are 
> working for me locally now.
> 
>I had one small question: where should we point the test runner to look 
> for libkenlm.so?  At the moment I chose the rootdir/lib as it seems to be 
> auto-created when the ./downloaddeps script is run, but maybe there's a 
> better location?
> 
>Here's what I've run to verify the build locally:
> 
>#no KenLM
>export 
> JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk1.8.0_101.jdk/Contents/Home/
>export JOSHUA=`pwd`
>git clean -xdf
>mvn test
>Tests run: 120, Failures: 0, Errors: 0, Skipped: 10
>[INFO] BUILD SUCCESS
> 
>#no KenLM/ext
>git clean -xdf 
>rm -rf ext
>mvn test
>Tests run: 122, Failures: 0, Errors: 0, Skipped: 12, Time elapsed: 1.961 
> sec - in TestSuite
>[INFO] BUILD SUCCESS
> 
>#Fresh KenLM
>git clean -xdf
>rm -rf ext
>./download-deps.sh
>mvn test
>Tests run: 116, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.689 
> sec - in TestSuite
>[INFO] BUILD SUCCESS
> 
>-Kellen
> 
> 
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---

[GitHub] incubator-joshua issue #33: Refactored unit tests to all use TestNG, removed...

[mjpost]

Github user mjpost commented on the issue:

https://github.com/apache/incubator-joshua/pull/33
  
This passes for me, and $JOSHUA/lib is the currently correct place. I'm 
fine to move it if there is a more conventional location. Would $JOSHUA/target 
make more sense, or something else?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---