[GitHub] incubator-joshua pull request #32: JOSHUA-286 - Replace old joshua-decoder.o...
Github user asfgit closed the pull request at: https://github.com/apache/incubator-joshua/pull/32 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua pull request #32: JOSHUA-286 - Replace old joshua-decoder.o...
Github user mjpost commented on a diff in the pull request: https://github.com/apache/incubator-joshua/pull/32#discussion_r72616102 --- Diff: scripts/support/make-release.sh --- @@ -40,7 +40,7 @@ echo "Bundling up joshua-$version" [[ ! -d release ]] && mkdir release rm -f joshua-$version && ln -s $JOSHUA joshua-$version -wget -r http://joshua-decoder.org/ +wget -r http://joshua.apache.org/6.0/ --- End diff -- This was intended to bundle a crawl of the website with the release. It should be removed. Joshua is now hosted on Confluence, so the directory paths now longer work. Also, Confluence has better tools for documentation export if we should decide to use them in the future. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua pull request #32: JOSHUA-286 - Replace old joshua-decoder.o...
Github user mjpost commented on a diff in the pull request: https://github.com/apache/incubator-joshua/pull/32#discussion_r72615877 --- Diff: .gitignore --- @@ -42,6 +42,7 @@ doxygen_*.tmp .cachepipe joshua-decoder.org +joshua.apache.org --- End diff -- Yeah, agreed. I used to bundle a crawl of the website with the repo, but am no longer going to do so. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua pull request #32: JOSHUA-286 - Replace old joshua-decoder.o...
Github user lewismc commented on a diff in the pull request: https://github.com/apache/incubator-joshua/pull/32#discussion_r72566150 --- Diff: src/main/java/org/apache/joshua/decoder/Decoder.java --- @@ -496,7 +496,7 @@ public Decoder initialize(String configFile) { errMsg.append("FATAL: Invalid feature weight line found in config file.\n"); errMsg.append(String.format("The line was '%s'\n", pairStr)); errMsg.append("You might be using an old version of the config file that is no longer supported\n"); - errMsg.append("Check joshua-decoder.org or email joshua_supp...@googlegroups.com for help\n"); + errMsg.append("Check joshua.apache.org or email joshua_supp...@googlegroups.com for help\n"); --- End diff -- The email should be d...@joshua.apache.org --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua pull request #32: JOSHUA-286 - Replace old joshua-decoder.o...
Github user lewismc commented on a diff in the pull request: https://github.com/apache/incubator-joshua/pull/32#discussion_r72566062 --- Diff: scripts/support/make-release.sh --- @@ -40,7 +40,7 @@ echo "Bundling up joshua-$version" [[ ! -d release ]] && mkdir release rm -f joshua-$version && ln -s $JOSHUA joshua-$version -wget -r http://joshua-decoder.org/ +wget -r http://joshua.apache.org/6.0/ --- End diff -- Again, this site does not exist. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua pull request #32: JOSHUA-286 - Replace old joshua-decoder.o...
Github user lewismc commented on a diff in the pull request: https://github.com/apache/incubator-joshua/pull/32#discussion_r72566047 --- Diff: CHANGELOG --- @@ -139,7 +139,7 @@ They include: - Significantly improved and expanded documentation (both user and developer) - See http://joshua-decoder.org/4.0 or ./joshua-decoder.org/4.0/index.html (local mirror) + See http://apache.joshua.org/4.0 or ./apache.joshua.org/4.0/index.html (local mirror) --- End diff -- There is no such site as http://apache.joshua.org, it should be http://joshua.apache.org, also the CHANGELOG should not be altered at all as this indicates changes to previous releases. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua pull request #32: JOSHUA-286 - Replace old joshua-decoder.o...
Github user lewismc commented on a diff in the pull request: https://github.com/apache/incubator-joshua/pull/32#discussion_r72566005 --- Diff: .gitignore --- @@ -42,6 +42,7 @@ doxygen_*.tmp .cachepipe joshua-decoder.org +joshua.apache.org --- End diff -- both of these can be removed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua pull request #32: JOSHUA-286 - Replace old joshua-decoder.o...
GitHub user john-hewitt opened a pull request: https://github.com/apache/incubator-joshua/pull/32 JOSHUA-286 - Replace old joshua-decoder.org links with joshua.apache.org - Update links to documentation and support to reflect the move to Apache. - keep Gitignore entry for old website was kept to keep the repo clean. - Update links to the git repo as well. - old pages in the `docs` folder unchanged. You can merge this pull request into a Git repository by running: $ git pull https://github.com/john-hewitt/incubator-joshua JOSHUA-286 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-joshua/pull/32.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #32 commit 36a58e75e5deb71bdeed2980e740502fe3d516c2 Author: John Hewitt Date: 2016-07-28T02:57:04Z Replace old joshua-decoder.org links with joshua.apache.org Updating links to documentation and support to reflect the move to Apache. Gitignore entry was kept to keep the repo clean. References to the old git repo were updated as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---