[jira] [Commented] (JOSHUA-253) Enable execution of Unit tests
[ https://issues.apache.org/jira/browse/JOSHUA-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313111#comment-15313111 ] Matt Post commented on JOSHUA-253: -- I believe this is now working via "mvn test". Can this be closed out? I get the following: --- T E S T S --- Running TestSuite WARN - sentence 0 too long 401, truncating to length 200 WARN - sentence 0 too long 401, truncating to length 200 WARN - sentence 0 too long 401, truncating to length 200 WARN - sentence 0 too long 401, truncating to length 200 WARN - no grammars supplied! Supplying dummy glue grammar. WARN - no grammars supplied! Supplying dummy glue grammar. WARN - no grammars supplied! Supplying dummy glue grammar. WARN - no grammars supplied! Supplying dummy glue grammar. Tests run: 111, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 1.261 sec - in TestSuite Results : Tests run: 111, Failures: 0, Errors: 0, Skipped: 1 > Enable execution of Unit tests > -- > > Key: JOSHUA-253 > URL: https://issues.apache.org/jira/browse/JOSHUA-253 > Project: Joshua > Issue Type: Test >Affects Versions: 6.0 >Reporter: Lewis John McGibbney > Fix For: 6.1 > > Attachments: JOSHUA-253.patch > > > As per our [discussion on this > topic|http://www.mail-archive.com/dev%40joshua.incubator.apache.org/msg00270.html], > [~teofili] correctly identified that unit level tests are not executed. > We need to fix this such that they are. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-253) Enable execution of Unit tests
[ https://issues.apache.org/jira/browse/JOSHUA-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15270649#comment-15270649 ] Tommaso Teofili commented on JOSHUA-253: regarding unit tests, many of them cannot compile if I add _test_ as test directory (in pom.xml, just to make it easier) because of old / missing APIs; I would opt for keeping only the ones that can be compiled (maybe changing some imports and/or minor adjustments) and remove the others. I will collect the ones that I think should be removed. > Enable execution of Unit tests > -- > > Key: JOSHUA-253 > URL: https://issues.apache.org/jira/browse/JOSHUA-253 > Project: Joshua > Issue Type: Test >Affects Versions: 6.0 >Reporter: Lewis John McGibbney > Fix For: 6.1 > > > As per our [discussion on this > topic|http://www.mail-archive.com/dev%40joshua.incubator.apache.org/msg00270.html], > [~teofili] correctly identified that unit level tests are not executed. > We need to fix this such that they are. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-253) Enable execution of Unit tests
[ https://issues.apache.org/jira/browse/JOSHUA-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15270434#comment-15270434 ] Tommaso Teofili commented on JOSHUA-253: the unit tests I refer to are under _test/joshua_. I agree with [~KellenSunderland] that it'd be good to have the regression ones being run by a unit test runner. > Enable execution of Unit tests > -- > > Key: JOSHUA-253 > URL: https://issues.apache.org/jira/browse/JOSHUA-253 > Project: Joshua > Issue Type: Test >Affects Versions: 6.0 >Reporter: Lewis John McGibbney > Fix For: 6.1 > > > As per our [discussion on this > topic|http://www.mail-archive.com/dev%40joshua.incubator.apache.org/msg00270.html], > [~teofili] correctly identified that unit level tests are not executed. > We need to fix this such that they are. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [jira] [Commented] (JOSHUA-253) Enable execution of Unit tests
I am fine with you just doing this. The current setup was a something-is-better-than-nothing (which is true) hack, and I'd be happy to have better practices pushed into the project. matt (from my phone) > On Apr 27, 2016, at 2:39 PM, Kellen Sunderland (JIRA) wrote: > > >[ > https://issues.apache.org/jira/browse/JOSHUA-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15260709#comment-15260709 > ] > > Kellen Sunderland commented on JOSHUA-253: > -- > > We've got a few unit tests we've created for Joshua, and we'd like to > eventually hook them into the Joshua build process. > > This is one topic I'd like to discuss at ApacheCon. What I would like to > propose is to convert the current regression tests to be run by a unit test > runner (at the same time as the actual unit tests are run). The main > advantage of having the regression tests runnable from a unit test runner is > that we'll be able to debug when there's a failure (this is quite tricky at > the moment). > >> Enable execution of Unit tests >> -- >> >>Key: JOSHUA-253 >>URL: https://issues.apache.org/jira/browse/JOSHUA-253 >>Project: Joshua >> Issue Type: Test >> Affects Versions: 6.0 >> Reporter: Lewis John McGibbney >>Fix For: 6.1 >> >> >> As per our [discussion on this >> topic|http://www.mail-archive.com/dev%40joshua.incubator.apache.org/msg00270.html], >> [~teofili] correctly identified that unit level tests are not executed. >> We need to fix this such that they are. > > > > -- > This message was sent by Atlassian JIRA > (v6.3.4#6332)
[jira] [Commented] (JOSHUA-253) Enable execution of Unit tests
[ https://issues.apache.org/jira/browse/JOSHUA-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15260709#comment-15260709 ] Kellen Sunderland commented on JOSHUA-253: -- We've got a few unit tests we've created for Joshua, and we'd like to eventually hook them into the Joshua build process. This is one topic I'd like to discuss at ApacheCon. What I would like to propose is to convert the current regression tests to be run by a unit test runner (at the same time as the actual unit tests are run). The main advantage of having the regression tests runnable from a unit test runner is that we'll be able to debug when there's a failure (this is quite tricky at the moment). > Enable execution of Unit tests > -- > > Key: JOSHUA-253 > URL: https://issues.apache.org/jira/browse/JOSHUA-253 > Project: Joshua > Issue Type: Test >Affects Versions: 6.0 >Reporter: Lewis John McGibbney > Fix For: 6.1 > > > As per our [discussion on this > topic|http://www.mail-archive.com/dev%40joshua.incubator.apache.org/msg00270.html], > [~teofili] correctly identified that unit level tests are not executed. > We need to fix this such that they are. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-253) Enable execution of Unit tests
[ https://issues.apache.org/jira/browse/JOSHUA-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15260525#comment-15260525 ] Matt Post commented on JOSHUA-253: -- Yes, Tommaso is correct. test/ holds what I think are better termed regression tests, and executes any executable test*sh file under test, where returning 0 is success and otherwise is failure. I know there are unit tests scattered throughout the code but I have never run them. It would be great to have those start to be run as well. I know the Amazon folks have been contributing some, so maybe they could let us know? > Enable execution of Unit tests > -- > > Key: JOSHUA-253 > URL: https://issues.apache.org/jira/browse/JOSHUA-253 > Project: Joshua > Issue Type: Test >Affects Versions: 6.0 >Reporter: Lewis John McGibbney > Fix For: 6.1 > > > As per our [discussion on this > topic|http://www.mail-archive.com/dev%40joshua.incubator.apache.org/msg00270.html], > [~teofili] correctly identified that unit level tests are not executed. > We need to fix this such that they are. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-253) Enable execution of Unit tests
[ https://issues.apache.org/jira/browse/JOSHUA-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15260269#comment-15260269 ] Lewis John McGibbney commented on JOSHUA-253: - bq. so no Java unit test is executed as far as I know where are the unit tests? I can fix this right now if you can point them out. Thanks > Enable execution of Unit tests > -- > > Key: JOSHUA-253 > URL: https://issues.apache.org/jira/browse/JOSHUA-253 > Project: Joshua > Issue Type: Test >Affects Versions: 6.0 >Reporter: Lewis John McGibbney > Fix For: 6.1 > > > As per our [discussion on this > topic|http://www.mail-archive.com/dev%40joshua.incubator.apache.org/msg00270.html], > [~teofili] correctly identified that unit level tests are not executed. > We need to fix this such that they are. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-253) Enable execution of Unit tests
[ https://issues.apache.org/jira/browse/JOSHUA-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15260253#comment-15260253 ] Tommaso Teofili commented on JOSHUA-253: as far as I can see the ant test target executes the test/run-all-tests.sh script, which looks for all the files that end in test-sh and executes them, so no Java unit test is executed as far as I know, but only the test.sh scripts in descendants of $JOSHUA/test directory. > Enable execution of Unit tests > -- > > Key: JOSHUA-253 > URL: https://issues.apache.org/jira/browse/JOSHUA-253 > Project: Joshua > Issue Type: Test >Affects Versions: 6.0 >Reporter: Lewis John McGibbney > Fix For: 6.1 > > > As per our [discussion on this > topic|http://www.mail-archive.com/dev%40joshua.incubator.apache.org/msg00270.html], > [~teofili] correctly identified that unit level tests are not executed. > We need to fix this such that they are. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-253) Enable execution of Unit tests
[ https://issues.apache.org/jira/browse/JOSHUA-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15260231#comment-15260231 ] Lewis John McGibbney commented on JOSHUA-253: - [~teofili] [~post] where are the Unit tests we have to run? I've undertaken some analysis of the $JOSHUA_HOME/test diretory. As far as I can see they are invoked... so I am definitely missing something here. > Enable execution of Unit tests > -- > > Key: JOSHUA-253 > URL: https://issues.apache.org/jira/browse/JOSHUA-253 > Project: Joshua > Issue Type: Test >Affects Versions: 6.0 >Reporter: Lewis John McGibbney > Fix For: 6.1 > > > As per our [discussion on this > topic|http://www.mail-archive.com/dev%40joshua.incubator.apache.org/msg00270.html], > [~teofili] correctly identified that unit level tests are not executed. > We need to fix this such that they are. -- This message was sent by Atlassian JIRA (v6.3.4#6332)