[jira] [Commented] (JSPWIKI-1035) get rid of jspwiki.baseURL
[ https://issues.apache.org/jira/browse/JSPWIKI-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15783640#comment-15783640 ] Jürgen Weber commented on JSPWIKI-1035: --- I guess until now the installer did not start until you had set jspwiki.baseURL so you'd have to have a means to edit jspwiki-custom.properties anyway. So no reason to keep installer, everything installer does should be possible with jspwiki-custom.properties, isn't it? > get rid of jspwiki.baseURL > -- > > Key: JSPWIKI-1035 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1035 > Project: JSPWiki > Issue Type: Improvement > Components: Core & storage >Affects Versions: 2.10.2 >Reporter: Jürgen Weber >Assignee: Harry Metske > Attachments: DefaultURLConstructor.java.patch, WikiEngine.java.patch, > jspwiki.properties.patch > > > Could we get rid of jspwiki.baseURL and calculate it on > HttpServletRequest#getContextPath() ? > It's the only mandatory property you have to set for JSPWiki, so removing it > would make installation much easier. > And, first and foremost, it makes JSPWiki only work on exactly this URL, i.e. > you cannot use the same JSPWiki instance in an intranet and on the internet > (e.g. wiki.firm.com and wiki.firm.private), neither with and without JK'ed > Apache, neither SSL and non-SSL. > If you look at the source of https://jspwiki-wiki.apache.org/ > there are not many places where the whole base url is used. So, I wonder, if > context relative links could be sufficient. > http://stackoverflow.com/questions/4764405/how-to-use-relative-paths-without-including-the-context-root-name -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JSPWIKI-1035) get rid of jspwiki.baseURL
[ https://issues.apache.org/jira/browse/JSPWIKI-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15783530#comment-15783530 ] Harry Metske commented on JSPWIKI-1035: --- nice, tx > get rid of jspwiki.baseURL > -- > > Key: JSPWIKI-1035 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1035 > Project: JSPWiki > Issue Type: Improvement > Components: Core & storage >Affects Versions: 2.10.2 >Reporter: Jürgen Weber >Assignee: Harry Metske > Attachments: DefaultURLConstructor.java.patch, WikiEngine.java.patch, > jspwiki.properties.patch > > > Could we get rid of jspwiki.baseURL and calculate it on > HttpServletRequest#getContextPath() ? > It's the only mandatory property you have to set for JSPWiki, so removing it > would make installation much easier. > And, first and foremost, it makes JSPWiki only work on exactly this URL, i.e. > you cannot use the same JSPWiki instance in an intranet and on the internet > (e.g. wiki.firm.com and wiki.firm.private), neither with and without JK'ed > Apache, neither SSL and non-SSL. > If you look at the source of https://jspwiki-wiki.apache.org/ > there are not many places where the whole base url is used. So, I wonder, if > context relative links could be sufficient. > http://stackoverflow.com/questions/4764405/how-to-use-relative-paths-without-including-the-context-root-name -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JSPWIKI-1035) get rid of jspwiki.baseURL
[ https://issues.apache.org/jira/browse/JSPWIKI-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15783527#comment-15783527 ] Siegfried Goeschl commented on JSPWIKI-1035: [~metskem] I played with JSPWiki portable from the JSPWIKI-1035 branch and it looks good :-) > get rid of jspwiki.baseURL > -- > > Key: JSPWIKI-1035 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1035 > Project: JSPWiki > Issue Type: Improvement > Components: Core & storage >Affects Versions: 2.10.2 >Reporter: Jürgen Weber >Assignee: Harry Metske > Attachments: DefaultURLConstructor.java.patch, WikiEngine.java.patch, > jspwiki.properties.patch > > > Could we get rid of jspwiki.baseURL and calculate it on > HttpServletRequest#getContextPath() ? > It's the only mandatory property you have to set for JSPWiki, so removing it > would make installation much easier. > And, first and foremost, it makes JSPWiki only work on exactly this URL, i.e. > you cannot use the same JSPWiki instance in an intranet and on the internet > (e.g. wiki.firm.com and wiki.firm.private), neither with and without JK'ed > Apache, neither SSL and non-SSL. > If you look at the source of https://jspwiki-wiki.apache.org/ > there are not many places where the whole base url is used. So, I wonder, if > context relative links could be sufficient. > http://stackoverflow.com/questions/4764405/how-to-use-relative-paths-without-including-the-context-root-name -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JSPWIKI-1035) get rid of jspwiki.baseURL
[ https://issues.apache.org/jira/browse/JSPWIKI-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15783500#comment-15783500 ] Harry Metske commented on JSPWIKI-1035: --- I also don't use it, I think one of the reasons for it's existence is that some users do not have console access to their servers (mostly hosted environments), and the Installer then offers (limited) configuration options. Anyway, I think we can just keep the Installer as it is now. If there are no objections I like to merge JSPWIKI-1035 back to the master branch, > get rid of jspwiki.baseURL > -- > > Key: JSPWIKI-1035 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1035 > Project: JSPWiki > Issue Type: Improvement > Components: Core & storage >Affects Versions: 2.10.2 >Reporter: Jürgen Weber >Assignee: Harry Metske > Attachments: DefaultURLConstructor.java.patch, WikiEngine.java.patch, > jspwiki.properties.patch > > > Could we get rid of jspwiki.baseURL and calculate it on > HttpServletRequest#getContextPath() ? > It's the only mandatory property you have to set for JSPWiki, so removing it > would make installation much easier. > And, first and foremost, it makes JSPWiki only work on exactly this URL, i.e. > you cannot use the same JSPWiki instance in an intranet and on the internet > (e.g. wiki.firm.com and wiki.firm.private), neither with and without JK'ed > Apache, neither SSL and non-SSL. > If you look at the source of https://jspwiki-wiki.apache.org/ > there are not many places where the whole base url is used. So, I wonder, if > context relative links could be sufficient. > http://stackoverflow.com/questions/4764405/how-to-use-relative-paths-without-including-the-context-root-name -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Reopened] (JSPWIKI-1038) UI will not scroll in IE
[ https://issues.apache.org/jira/browse/JSPWIKI-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ed Ross reopened JSPWIKI-1038: -- does not work in IE/edge mode (works in IE emulation 5-10 but not Edge) > UI will not scroll in IE > > > Key: JSPWIKI-1038 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1038 > Project: JSPWiki > Issue Type: Bug > Components: Servlet Container/Java compatibility >Affects Versions: 2.10.2 > Environment: JSPWiki v2.10.3-svn-19 >Reporter: Ed Ross >Assignee: brushed > Labels: patch > Fix For: 2.10.3 > > > The previous issue was the content was not displayed in IE. That has been > resolved but when the page exceeds the size of the screen, there are no > scroll bars and not way to get to the hidden content. > This only seems to affect IE. Works in other browsers -- This message was sent by Atlassian JIRA (v6.3.4#6332)
