Re: Introducing Sachith Withana

2014-01-02 Thread Jun Rao
Sachith,

Thanks for you interest in Kafka. To get started, we some jiras tagged with
newbie that you can start looking.

Jun


On Wed, Jan 1, 2014 at 5:12 PM, Sachith Withana swsach...@gmail.com wrote:

 Hi All,

 I'm Sachith Withana, a 3rd year undergrad at University of Moratuwa, Sri
 Lanka studying Computer Science and Engineering. Currently I'm working on
 my internship at UITS, Indiana University on the Apache Airavata project.

 I'm really interested in the Apache Kafka project and I'd love to
 contribute. I'm considering to take on Distributed Computing as my area of
 research for post graduate studies and I know that contributing to Apache
 Kafka would help me a learn a lot.

 I went through the documentation and successfully completed the examples
 given. I'm getting into the code now.

 How would you recommend a newbie like me should proceed in contributing to
 the project while getting to know the code?

 Any help is appreciated.

 --
 Thanks,
 Sachith Withana



[jira] [Commented] (KAFKA-1074) Reassign partitions should delete the old replicas from disk

2014-01-02 Thread Jun Rao (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13860314#comment-13860314
 ] 

Jun Rao commented on KAFKA-1074:


Summary of changes since the previous patch.
LogCleaner:
* moved all variables and locks associated with state management into a 
separate class LogCleanerStates.
* removed the semaphore for unit test and used a simpler approach to just keep 
retrying every 10ms. Will file a separate jira for improving the unit test.
Log:
* limited the scope of a few methods to log.
LogManager:
* forced checkpointing recovery points in truncateFullyAndStartAt() as well.

 Reassign partitions should delete the old replicas from disk
 

 Key: KAFKA-1074
 URL: https://issues.apache.org/jira/browse/KAFKA-1074
 Project: Kafka
  Issue Type: Bug
  Components: core
Affects Versions: 0.8.0
Reporter: Jun Rao
Assignee: Jun Rao
 Fix For: 0.8.1

 Attachments: KAFKA-1074.patch, KAFKA-1074_2013-12-04_10:14:13.patch, 
 KAFKA-1074_2013-12-16_09:43:53.patch, KAFKA-1074_2014-01-02_08:36:37.patch


 Currently, after reassigning replicas to other brokers, the old replicas are 
 not removed from disk and have to be deleted manually.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Updated] (KAFKA-1074) Reassign partitions should delete the old replicas from disk

2014-01-02 Thread Jun Rao (JIRA)

 [ 
https://issues.apache.org/jira/browse/KAFKA-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jun Rao updated KAFKA-1074:
---

Attachment: KAFKA-1074_2014-01-02_08:36:37.patch

 Reassign partitions should delete the old replicas from disk
 

 Key: KAFKA-1074
 URL: https://issues.apache.org/jira/browse/KAFKA-1074
 Project: Kafka
  Issue Type: Bug
  Components: core
Affects Versions: 0.8.0
Reporter: Jun Rao
Assignee: Jun Rao
 Fix For: 0.8.1

 Attachments: KAFKA-1074.patch, KAFKA-1074_2013-12-04_10:14:13.patch, 
 KAFKA-1074_2013-12-16_09:43:53.patch, KAFKA-1074_2014-01-02_08:36:37.patch


 Currently, after reassigning replicas to other brokers, the old replicas are 
 not removed from disk and have to be deleted manually.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Created] (KAFKA-1197) Count of bytes or messages of a topic stored in kafka

2014-01-02 Thread Hanish Bansal (JIRA)
Hanish Bansal created KAFKA-1197:


 Summary: Count of bytes or messages of a topic stored in kafka
 Key: KAFKA-1197
 URL: https://issues.apache.org/jira/browse/KAFKA-1197
 Project: Kafka
  Issue Type: New Feature
  Components: core
Affects Versions: 0.8.0, 0.7.2
Reporter: Hanish Bansal
Priority: Minor


There should be direct way of measuring count of messages or bytes for a topic 
stored in Kafka.

There are already some very useful metrics like byteRate and messageRate using 
what we can see count of bytes/messages coming into Kafka broker.
I was looking for some jmx metrics that can give count of messages/bytes stored 
in kafka.

If we look into data stores like hbase we can see  how many messages are  
stored in hbase or if we look into search engine like elasticsearch then also 
we can see how many messages are stored/indexed in elasticsearch. In similar 
way i was expecting that there should be some way to see count of  messages or 
bytes for a topic stored in kafka without using any external tool.

It will be really helpful if there is some support for this using some jmx 
metric or by script.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


Re: Review Request 16360: Address Jun's comments

2014-01-02 Thread Jun Rao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16360/#review31041
---



core/src/main/scala/kafka/cluster/Partition.scala
https://reviews.apache.org/r/16360/#comment59388

This comment is no longer valid.



core/src/main/scala/kafka/server/ReplicaManager.scala
https://reviews.apache.org/r/16360/#comment59387

The ordering of correlationId and controllerId is reversed.



core/src/main/scala/kafka/server/ReplicaManager.scala
https://reviews.apache.org/r/16360/#comment59386

fetchers - fetcher


- Jun Rao


On Dec. 24, 2013, 7:07 p.m., Guozhang Wang wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/16360/
 ---
 
 (Updated Dec. 24, 2013, 7:07 p.m.)
 
 
 Review request for kafka.
 
 
 Bugs: KAFKA-1188
 https://issues.apache.org/jira/browse/KAFKA-1188
 
 
 Repository: kafka
 
 
 Description
 ---
 
 KAFKA-1118.v2
 
 
 KAFKA-1188.v1
 
 
 Diffs
 -
 
   core/src/main/scala/kafka/cluster/Partition.scala 
 5c9307d71641ccc6c09a54b69d5aa2b4bc2a4cde 
   core/src/main/scala/kafka/server/ReplicaManager.scala 
 242c18d47828b7c5e6b1fc219a0f1199fb1f9512 
 
 Diff: https://reviews.apache.org/r/16360/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Guozhang Wang
 




[jira] [Created] (KAFKA-1198) NullPointerException in describe topic

2014-01-02 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-1198:
--

 Summary: NullPointerException in describe topic
 Key: KAFKA-1198
 URL: https://issues.apache.org/jira/browse/KAFKA-1198
 Project: Kafka
  Issue Type: Bug
Affects Versions: 0.8.1
Reporter: Jun Rao


If topic is not specified, we get the following.

bin/kafka-topics.sh --zookeeper localhost:2181 --describe
(Error while executing topic command,java.lang.NullPointerException)

Also, list topic seems to always list all topics even when topics are specified.




--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


Re: Review Request 16360: Address Jun's comments v3

2014-01-02 Thread Guozhang Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16360/
---

(Updated Jan. 2, 2014, 6:44 p.m.)


Review request for kafka.


Summary (updated)
-

Address Jun's comments v3


Bugs: KAFKA-1188
https://issues.apache.org/jira/browse/KAFKA-1188


Repository: kafka


Description (updated)
---

KAFKA-1188.v3


KAFKA-1118.v2


KAFKA-1188.v1


Diffs (updated)
-

  core/src/main/scala/kafka/cluster/Partition.scala 
5c9307d71641ccc6c09a54b69d5aa2b4bc2a4cde 
  core/src/main/scala/kafka/server/ReplicaManager.scala 
242c18d47828b7c5e6b1fc219a0f1199fb1f9512 

Diff: https://reviews.apache.org/r/16360/diff/


Testing
---


Thanks,

Guozhang Wang



[jira] [Commented] (KAFKA-1188) Stale LeaderAndIsr request could be handled by the broker on Controller failover

2014-01-02 Thread Guozhang Wang (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13860586#comment-13860586
 ] 

Guozhang Wang commented on KAFKA-1188:
--

Updated reviewboard https://reviews.apache.org/r/16360/
 against branch origin/trunk

 Stale LeaderAndIsr request could be handled by the broker on Controller 
 failover
 

 Key: KAFKA-1188
 URL: https://issues.apache.org/jira/browse/KAFKA-1188
 Project: Kafka
  Issue Type: Bug
Reporter: Guozhang Wang
 Attachments: KAFKA-1188.patch, KAFKA-1188_2013-12-24_11:07:12.patch, 
 KAFKA-1188_2014-01-02_10:43:54.patch


 ... which will cause the broker to truncate log as responding in 
 makeFollower, and hence lose data. 
 One procedure to produce this issue:
 3 brokers, 3 partitions, replication factor = 3.
 1. Broker 1 is the original controller.
 2. Broker 3 lost registration, 1 send LeaderAndIsr to 1 for isr shrinking  
 (leader of partition 1), but not to 2 since it is not the leader.
 3. Broker 1 dies, new controller 2 sends all LeaderAndIsr to 2 and 3 
 (resumed), and 2 handles the makeFollower, truncates data.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] Subscription: outstanding kafka patches

2014-01-02 Thread jira
Issue Subscription
Filter: outstanding kafka patches (81 issues)
The list of outstanding kafka patches
Subscriber: kafka-mailing-list

Key Summary
KAFKA-1194  The kafka broker cannot delete the old log files after the 
configured time
https://issues.apache.org/jira/browse/KAFKA-1194
KAFKA-1188  Stale LeaderAndIsr request could be handled by the broker on 
Controller failover
https://issues.apache.org/jira/browse/KAFKA-1188
KAFKA-1187  Controller should retry connecting to brokers to send state change 
requests
https://issues.apache.org/jira/browse/KAFKA-1187
KAFKA-1185  Improve leader elector module to have a resign API
https://issues.apache.org/jira/browse/KAFKA-1185
KAFKA-1180  WhiteList topic filter gets a NullPointerException on complex Regex
https://issues.apache.org/jira/browse/KAFKA-1180
KAFKA-1173  Using Vagrant to get up and running with Apache Kafka
https://issues.apache.org/jira/browse/KAFKA-1173
KAFKA-1171  Gradle build for Kafka
https://issues.apache.org/jira/browse/KAFKA-1171
KAFKA-1170  ISR can be inconsistent during partition reassignment for low 
throughput partitions
https://issues.apache.org/jira/browse/KAFKA-1170
KAFKA-1156  Improve reassignment tool to output the existing assignment to 
facilitate rollbacks
https://issues.apache.org/jira/browse/KAFKA-1156
KAFKA-1147  Consumer socket timeout should be greater than fetch max wait
https://issues.apache.org/jira/browse/KAFKA-1147
KAFKA-1145  Broker fail to sync after restart
https://issues.apache.org/jira/browse/KAFKA-1145
KAFKA-1144  commitOffsets can be passed the offsets to commit
https://issues.apache.org/jira/browse/KAFKA-1144
KAFKA-1130  log.dirs is a confusing property name
https://issues.apache.org/jira/browse/KAFKA-1130
KAFKA-1116  Need to upgrade sbt-assembly to compile on scala 2.10.2
https://issues.apache.org/jira/browse/KAFKA-1116
KAFKA-1109  Need to fix GC log configuration code, not able to override 
KAFKA_GC_LOG_OPTS
https://issues.apache.org/jira/browse/KAFKA-1109
KAFKA-1106  HighwaterMarkCheckpoint failure puting broker into a bad state
https://issues.apache.org/jira/browse/KAFKA-1106
KAFKA-1093  Log.getOffsetsBefore(t, …) does not return the last confirmed 
offset before t
https://issues.apache.org/jira/browse/KAFKA-1093
KAFKA-1086  Improve GetOffsetShell to find metadata automatically
https://issues.apache.org/jira/browse/KAFKA-1086
KAFKA-1082  zkclient dies after UnknownHostException in zk reconnect
https://issues.apache.org/jira/browse/KAFKA-1082
KAFKA-1079  Liars in PrimitiveApiTest that promise to test api in compression 
mode, but don't do this actually
https://issues.apache.org/jira/browse/KAFKA-1079
KAFKA-1074  Reassign partitions should delete the old replicas from disk
https://issues.apache.org/jira/browse/KAFKA-1074
KAFKA-1049  Encoder implementations are required to provide an undocumented 
constructor.
https://issues.apache.org/jira/browse/KAFKA-1049
KAFKA-1032  Messages sent to the old leader will be lost on broker GC resulted 
failure
https://issues.apache.org/jira/browse/KAFKA-1032
KAFKA-1020  Remove getAllReplicasOnBroker from KafkaController
https://issues.apache.org/jira/browse/KAFKA-1020
KAFKA-1012  Implement an Offset Manager and hook offset requests to it
https://issues.apache.org/jira/browse/KAFKA-1012
KAFKA-1011  Decompression and re-compression on MirrorMaker could result in 
messages being dropped in the pipeline
https://issues.apache.org/jira/browse/KAFKA-1011
KAFKA-1005  kafka.perf.ConsumerPerformance not shutting down consumer
https://issues.apache.org/jira/browse/KAFKA-1005
KAFKA-998   Producer should not retry on non-recoverable error codes
https://issues.apache.org/jira/browse/KAFKA-998
KAFKA-997   Provide a strict verification mode when reading configuration 
properties
https://issues.apache.org/jira/browse/KAFKA-997
KAFKA-996   Capitalize first letter for log entries
https://issues.apache.org/jira/browse/KAFKA-996
KAFKA-984   Avoid a full rebalance in cases when a new topic is discovered but 
container/broker set stay the same
https://issues.apache.org/jira/browse/KAFKA-984
KAFKA-976   Order-Preserving Mirror Maker Testcase
https://issues.apache.org/jira/browse/KAFKA-976
KAFKA-967   Use key range in ProducerPerformance
https://issues.apache.org/jira/browse/KAFKA-967
KAFKA-917   Expose zk.session.timeout.ms in console consumer
https://issues.apache.org/jira/browse/KAFKA-917
KAFKA-885   sbt package builds two kafka jars
https://issues.apache.org/jira/browse/KAFKA-885
KAFKA-881   Kafka broker not respecting log.roll.hours

[jira] [Commented] (KAFKA-1193) Data loss if broker is killed using kill -9

2014-01-02 Thread Guozhang Wang (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13860639#comment-13860639
 ] 

Guozhang Wang commented on KAFKA-1193:
--

After thinking about this I am still leaning towards this being caused by 
KAFKA-1188, and probably the previous patch does not fully resolved the issue.

[~hanish.bansal.agarwal]] Could you retry this procedure after we have fully 
tested the patch and commit it to trunk?

 Data loss if broker is killed using kill -9
 ---

 Key: KAFKA-1193
 URL: https://issues.apache.org/jira/browse/KAFKA-1193
 Project: Kafka
  Issue Type: Bug
  Components: replication
Affects Versions: 0.8.0, 0.8.1
 Environment: Centos 6.3
Reporter: Hanish Bansal
Assignee: Neha Narkhede

 We are having kafka cluster of 2 nodes. (Using Kafka 0.8.0 version)
 Replication Factor: 2
 Number of partitions: 2
 Actual Behaviour:
 -
 Out of two nodes, if leader node goes down then data lost happens.
 Steps to Reproduce:
 --
 1. Create a 2 node kafka cluster with replication factor 2
 2. Start the Kafka cluster
 3. Create a topic lets say test-trunk111
 4. Restart any one node.
 5. Check topic status using kafka-list-topic tool.
 topic isr status is:
 topic: test-trunk111partition: 0leader: 0replicas: 1,0isr: 0,1
 topic: test-trunk111partition: 1leader: 0replicas: 0,1isr: 0,1
 If there is only one broker node in isr list then wait for some time and 
 again check isr status of topic. There should be 2 brokers in isr list.
 6. Start producing the data.
 7. Kill leader node (borker-0 in our case) meanwhile of data producing.
 8. After all data is produced start consumer.
 9. Observe the behaviour. There is data loss.
 After leader goes down, topic isr status is:
 topic: test-trunk111partition: 0leader: 1replicas: 1,0isr: 1
 topic: test-trunk111partition: 1leader: 1replicas: 0,1isr: 1
 We have tried below things to avoid data loss:
 
 1. Configured request.required.acks=-1 in producer configuration because as 
 mentioned in documentation 
 http://kafka.apache.org/documentation.html#producerconfigs, setting this 
 value to -1 provides guarantee that no messages will be lost.
 2. Increased the message.send.max.retries from 3 to 10 in producer 
 configuration.
 3. Set controlled.shutdown.enable to true in broker configuration.
 4. Tested with Kafka-0.8.1 after applying patch KAFKA-1188.patch available on 
 https://issues.apache.org/jira/browse/KAFKA-1188 
 Nothing work out from above things in case of leader node is killed using 
 kill -9 pid.
 Expected Behaviour:
 
 No data should be lost.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (KAFKA-1193) Data loss if broker is killed using kill -9

2014-01-02 Thread Guozhang Wang (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13860644#comment-13860644
 ] 

Guozhang Wang commented on KAFKA-1193:
--

Hanish, one thing I was wondering is do you always see data loss with step 5 
performed or do you see data loss from time to time? And also what is your 
producer's throughput?

 Data loss if broker is killed using kill -9
 ---

 Key: KAFKA-1193
 URL: https://issues.apache.org/jira/browse/KAFKA-1193
 Project: Kafka
  Issue Type: Bug
  Components: replication
Affects Versions: 0.8.0, 0.8.1
 Environment: Centos 6.3
Reporter: Hanish Bansal
Assignee: Neha Narkhede

 We are having kafka cluster of 2 nodes. (Using Kafka 0.8.0 version)
 Replication Factor: 2
 Number of partitions: 2
 Actual Behaviour:
 -
 Out of two nodes, if leader node goes down then data lost happens.
 Steps to Reproduce:
 --
 1. Create a 2 node kafka cluster with replication factor 2
 2. Start the Kafka cluster
 3. Create a topic lets say test-trunk111
 4. Restart any one node.
 5. Check topic status using kafka-list-topic tool.
 topic isr status is:
 topic: test-trunk111partition: 0leader: 0replicas: 1,0isr: 0,1
 topic: test-trunk111partition: 1leader: 0replicas: 0,1isr: 0,1
 If there is only one broker node in isr list then wait for some time and 
 again check isr status of topic. There should be 2 brokers in isr list.
 6. Start producing the data.
 7. Kill leader node (borker-0 in our case) meanwhile of data producing.
 8. After all data is produced start consumer.
 9. Observe the behaviour. There is data loss.
 After leader goes down, topic isr status is:
 topic: test-trunk111partition: 0leader: 1replicas: 1,0isr: 1
 topic: test-trunk111partition: 1leader: 1replicas: 0,1isr: 1
 We have tried below things to avoid data loss:
 
 1. Configured request.required.acks=-1 in producer configuration because as 
 mentioned in documentation 
 http://kafka.apache.org/documentation.html#producerconfigs, setting this 
 value to -1 provides guarantee that no messages will be lost.
 2. Increased the message.send.max.retries from 3 to 10 in producer 
 configuration.
 3. Set controlled.shutdown.enable to true in broker configuration.
 4. Tested with Kafka-0.8.1 after applying patch KAFKA-1188.patch available on 
 https://issues.apache.org/jira/browse/KAFKA-1188 
 Nothing work out from above things in case of leader node is killed using 
 kill -9 pid.
 Expected Behaviour:
 
 No data should be lost.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Comment Edited] (KAFKA-1193) Data loss if broker is killed using kill -9

2014-01-02 Thread Guozhang Wang (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13860639#comment-13860639
 ] 

Guozhang Wang edited comment on KAFKA-1193 at 1/2/14 7:30 PM:
--

After thinking about this I am still leaning towards this being caused by 
KAFKA-1188, and probably the previous patch does not fully resolved the issue.

[~hanish.bansal.agarwal] Could you retry this procedure after we have fully 
tested the patch and commit it to trunk?


was (Author: guozhang):
After thinking about this I am still leaning towards this being caused by 
KAFKA-1188, and probably the previous patch does not fully resolved the issue.

[~hanish.bansal.agarwal]] Could you retry this procedure after we have fully 
tested the patch and commit it to trunk?

 Data loss if broker is killed using kill -9
 ---

 Key: KAFKA-1193
 URL: https://issues.apache.org/jira/browse/KAFKA-1193
 Project: Kafka
  Issue Type: Bug
  Components: replication
Affects Versions: 0.8.0, 0.8.1
 Environment: Centos 6.3
Reporter: Hanish Bansal
Assignee: Neha Narkhede

 We are having kafka cluster of 2 nodes. (Using Kafka 0.8.0 version)
 Replication Factor: 2
 Number of partitions: 2
 Actual Behaviour:
 -
 Out of two nodes, if leader node goes down then data lost happens.
 Steps to Reproduce:
 --
 1. Create a 2 node kafka cluster with replication factor 2
 2. Start the Kafka cluster
 3. Create a topic lets say test-trunk111
 4. Restart any one node.
 5. Check topic status using kafka-list-topic tool.
 topic isr status is:
 topic: test-trunk111partition: 0leader: 0replicas: 1,0isr: 0,1
 topic: test-trunk111partition: 1leader: 0replicas: 0,1isr: 0,1
 If there is only one broker node in isr list then wait for some time and 
 again check isr status of topic. There should be 2 brokers in isr list.
 6. Start producing the data.
 7. Kill leader node (borker-0 in our case) meanwhile of data producing.
 8. After all data is produced start consumer.
 9. Observe the behaviour. There is data loss.
 After leader goes down, topic isr status is:
 topic: test-trunk111partition: 0leader: 1replicas: 1,0isr: 1
 topic: test-trunk111partition: 1leader: 1replicas: 0,1isr: 1
 We have tried below things to avoid data loss:
 
 1. Configured request.required.acks=-1 in producer configuration because as 
 mentioned in documentation 
 http://kafka.apache.org/documentation.html#producerconfigs, setting this 
 value to -1 provides guarantee that no messages will be lost.
 2. Increased the message.send.max.retries from 3 to 10 in producer 
 configuration.
 3. Set controlled.shutdown.enable to true in broker configuration.
 4. Tested with Kafka-0.8.1 after applying patch KAFKA-1188.patch available on 
 https://issues.apache.org/jira/browse/KAFKA-1188 
 Nothing work out from above things in case of leader node is killed using 
 kill -9 pid.
 Expected Behaviour:
 
 No data should be lost.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (KAFKA-1198) NullPointerException in describe topic

2014-01-02 Thread Guozhang Wang (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13860674#comment-13860674
 ] 

Guozhang Wang commented on KAFKA-1198:
--

1) List option will always get all the topics, only describe option will take 
the topic specification.

2) the getTopics function does not check if opts.topicOpt is specified, and 
hence throws the NullPointerException.

Proposed solution: check topicOpt unless it is the list option.

 NullPointerException in describe topic
 --

 Key: KAFKA-1198
 URL: https://issues.apache.org/jira/browse/KAFKA-1198
 Project: Kafka
  Issue Type: Bug
Affects Versions: 0.8.1
Reporter: Jun Rao

 If topic is not specified, we get the following.
 bin/kafka-topics.sh --zookeeper localhost:2181 --describe
 (Error while executing topic command,java.lang.NullPointerException)
 Also, list topic seems to always list all topics even when topics are 
 specified.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


Review Request 16579: Patch for KAFKA-1198

2014-01-02 Thread Guozhang Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16579/
---

Review request for kafka.


Bugs: KAFKA-1198
https://issues.apache.org/jira/browse/KAFKA-1198


Repository: kafka


Description
---

Dummy


KAFKA-1198.v1


Diffs
-

  core/src/main/scala/kafka/admin/TopicCommand.scala 
083fd632f66c0b48d3d8fe75f3820f8b0e40d291 

Diff: https://reviews.apache.org/r/16579/diff/


Testing
---


Thanks,

Guozhang Wang



[jira] [Updated] (KAFKA-1198) NullPointerException in describe topic

2014-01-02 Thread Guozhang Wang (JIRA)

 [ 
https://issues.apache.org/jira/browse/KAFKA-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guozhang Wang updated KAFKA-1198:
-

Attachment: KAFKA-1198.patch

 NullPointerException in describe topic
 --

 Key: KAFKA-1198
 URL: https://issues.apache.org/jira/browse/KAFKA-1198
 Project: Kafka
  Issue Type: Bug
Affects Versions: 0.8.1
Reporter: Jun Rao
 Attachments: KAFKA-1198.patch


 If topic is not specified, we get the following.
 bin/kafka-topics.sh --zookeeper localhost:2181 --describe
 (Error while executing topic command,java.lang.NullPointerException)
 Also, list topic seems to always list all topics even when topics are 
 specified.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (KAFKA-1198) NullPointerException in describe topic

2014-01-02 Thread Guozhang Wang (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13860919#comment-13860919
 ] 

Guozhang Wang commented on KAFKA-1198:
--

Created reviewboard https://reviews.apache.org/r/16579/
 against branch origin/trunk

 NullPointerException in describe topic
 --

 Key: KAFKA-1198
 URL: https://issues.apache.org/jira/browse/KAFKA-1198
 Project: Kafka
  Issue Type: Bug
Affects Versions: 0.8.1
Reporter: Jun Rao
 Attachments: KAFKA-1198.patch


 If topic is not specified, we get the following.
 bin/kafka-topics.sh --zookeeper localhost:2181 --describe
 (Error while executing topic command,java.lang.NullPointerException)
 Also, list topic seems to always list all topics even when topics are 
 specified.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)