Re: Create a space template for KIP
This is the template I am thinking about: https://confluence.atlassian.com/display/DOC/Working+with+Templates Jiangjie (Becket) Qin On 3/7/15, 1:35 PM, "Guozhang Wang" wrote: >Jiangjie, > >You can find the template here: > >https://cwiki.apache.org/confluence/display/KAFKA/KIP-Template > >Guozhang > >On Sat, Mar 7, 2015 at 12:35 PM, Jiangjie Qin >wrote: > >> I am not sure how others are creating KIP. I just copy/paste the >>template >> page to a blank page. I think it would good to add a space template >>under >> Apache Kafka so when creating the child page, people can just use that. >>Is >> it worth doing? I tried but it requires space administrator permission. >> >> Jiangjie (Becket) Qin >> >> > > >-- >-- Guozhang
Re: Create a space template for KIP
Hey Guozhang, Sorry for not making it clear. Yes, this is the template page that I usually copy from when creating new KIP. What I am suggesting is when we click on the "create child page", there will be list of template to choose from, it would be better if we can add the template there so we don¹t need to copy paste any more. I am not sure if adding a template to the Apache Kafka space is trivial or not though. Jiangjie (Becket) Qin On 3/7/15, 1:35 PM, "Guozhang Wang" wrote: >Jiangjie, > >You can find the template here: > >https://cwiki.apache.org/confluence/display/KAFKA/KIP-Template > >Guozhang > >On Sat, Mar 7, 2015 at 12:35 PM, Jiangjie Qin >wrote: > >> I am not sure how others are creating KIP. I just copy/paste the >>template >> page to a blank page. I think it would good to add a space template >>under >> Apache Kafka so when creating the child page, people can just use that. >>Is >> it worth doing? I tried but it requires space administrator permission. >> >> Jiangjie (Becket) Qin >> >> > > >-- >-- Guozhang
Re: Create a space template for KIP
Jiangjie, You can find the template here: https://cwiki.apache.org/confluence/display/KAFKA/KIP-Template Guozhang On Sat, Mar 7, 2015 at 12:35 PM, Jiangjie Qin wrote: > I am not sure how others are creating KIP. I just copy/paste the template > page to a blank page. I think it would good to add a space template under > Apache Kafka so when creating the child page, people can just use that. Is > it worth doing? I tried but it requires space administrator permission. > > Jiangjie (Becket) Qin > > -- -- Guozhang
[jira] [Commented] (KAFKA-2003) Add upgrade tests
[ https://issues.apache.org/jira/browse/KAFKA-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14351806#comment-14351806 ] Ashish K Singh commented on KAFKA-2003: --- [~gwenshap] Based on the discussion here and on KAFKA-1888. I think below is the action item we agree upon. 1. Kafka system sanity test, "check that everything is ok". Evaluate if existing system tests can cover this. If not, then can we add to the system tests. If not, then what would be a good maintainable solution. [~charmalloc] had some suggestion on KAFKA-1888. 2. Evaluate different options and either reuse existing system test or create/use some tool to ease testing upgrade and compatibility scenarios. 3. Build rolling upgrade tests using above tools. [~anigam] I assume you are interested in working on this. Could you update the status on KAFKA-1888. If the above plan sounds good to you, we can setup a call to discuss further and come up with a firm plan. > Add upgrade tests > - > > Key: KAFKA-2003 > URL: https://issues.apache.org/jira/browse/KAFKA-2003 > Project: Kafka > Issue Type: Improvement >Reporter: Gwen Shapira >Assignee: Ashish K Singh > > To test protocol changes, compatibility and upgrade process, we need a good > way to test different versions of the product together and to test end-to-end > upgrade process. > For example, for 0.8.2 to 0.8.3 test we want to check: > * Can we start a cluster with a mix of 0.8.2 and 0.8.3 brokers? > * Can a cluster of 0.8.3 brokers bump the protocol level one broker at a time? > * Can 0.8.2 clients run against a cluster of 0.8.3 brokers? > There are probably more questions. But an automated framework that can test > those and report results will be a good start. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Create a space template for KIP
I am not sure how others are creating KIP. I just copy/paste the template page to a blank page. I think it would good to add a space template under Apache Kafka so when creating the child page, people can just use that. Is it worth doing? I tried but it requires space administrator permission. Jiangjie (Becket) Qin
[DISCUSSION] KIP-15 close(timeout) for producer
Hi, I just created a KIP for adding a close(timeout) to new producer. Most of the previous discussions are in KAFKA-1660 where Parth Brahmbhatt has already done a lot of work. Since this is an interface change so we are going through the KIP process. Here is the KIP link: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=53739782 Thanks. Jiangjie (Becket) Qin
[jira] [Updated] (KAFKA-2009) Fix UncheckedOffset.removeOffset synchronization and trace logging issue in mirror maker
[ https://issues.apache.org/jira/browse/KAFKA-2009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-2009: Status: Patch Available (was: Open) > Fix UncheckedOffset.removeOffset synchronization and trace logging issue in > mirror maker > > > Key: KAFKA-2009 > URL: https://issues.apache.org/jira/browse/KAFKA-2009 > Project: Kafka > Issue Type: Bug >Reporter: Jiangjie Qin >Assignee: Jiangjie Qin > Attachments: KAFKA-2009.patch > > > This ticket is to fix the mirror maker problem on current trunk which is > introduced in KAFKA-1650. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-2009) Fix UncheckedOffset.removeOffset synchronization and trace logging issue in mirror maker
[ https://issues.apache.org/jira/browse/KAFKA-2009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-2009: Attachment: KAFKA-2009.patch > Fix UncheckedOffset.removeOffset synchronization and trace logging issue in > mirror maker > > > Key: KAFKA-2009 > URL: https://issues.apache.org/jira/browse/KAFKA-2009 > Project: Kafka > Issue Type: Bug >Reporter: Jiangjie Qin >Assignee: Jiangjie Qin > Attachments: KAFKA-2009.patch > > > This ticket is to fix the mirror maker problem on current trunk which is > introduced in KAFKA-1650. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2009) Fix UncheckedOffset.removeOffset synchronization and trace logging issue in mirror maker
[ https://issues.apache.org/jira/browse/KAFKA-2009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14351747#comment-14351747 ] Jiangjie Qin commented on KAFKA-2009: - Created reviewboard https://reviews.apache.org/r/31830/diff/ against branch origin/trunk > Fix UncheckedOffset.removeOffset synchronization and trace logging issue in > mirror maker > > > Key: KAFKA-2009 > URL: https://issues.apache.org/jira/browse/KAFKA-2009 > Project: Kafka > Issue Type: Bug >Reporter: Jiangjie Qin >Assignee: Jiangjie Qin > Attachments: KAFKA-2009.patch > > > This ticket is to fix the mirror maker problem on current trunk which is > introduced in KAFKA-1650. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Review Request 31830: Patch for KAFKA-2009
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31830/ --- Review request for kafka. Bugs: KAFKA-2009 https://issues.apache.org/jira/browse/KAFKA-2009 Repository: kafka Description --- Patch for KAFKA-2009, fix mirror maker UnackedOffset.removeOffset synchronization and a trace logging issue. Diffs - core/src/main/scala/kafka/tools/MirrorMaker.scala 5374280dc97dc8e01e9b3ba61fd036dc13ae48cb Diff: https://reviews.apache.org/r/31830/diff/ Testing --- Thanks, Jiangjie Qin
[jira] [Created] (KAFKA-2009) Fix UncheckedOffset.removeOffset synchronization and trace logging issue in mirror maker
Jiangjie Qin created KAFKA-2009: --- Summary: Fix UncheckedOffset.removeOffset synchronization and trace logging issue in mirror maker Key: KAFKA-2009 URL: https://issues.apache.org/jira/browse/KAFKA-2009 Project: Kafka Issue Type: Bug Reporter: Jiangjie Qin Assignee: Jiangjie Qin This ticket is to fix the mirror maker problem on current trunk which is introduced in KAFKA-1650. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-2008) Update num.consumer.fetchers description in Kafka documentation
[
https://issues.apache.org/jira/browse/KAFKA-2008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
TAO XIAO updated KAFKA-2008:
Description:
The description of num.consumer.fetchers currently shown in consumer config
section of Kafka document is not accurate.
num.consumer.fetchers actually controls the max number of fetcher threads per
broker. The actual number of fetcher threads is controlled by the combination
of topic, partition and num.consumer.fetchers
Reference source code in AbstractFetcherManager
private def getFetcherId(topic: String, partitionId: Int) : Int = {
Utils.abs(31 * topic.hashCode() + partitionId) % numFetchers
}
was:
The description of num.consumer.fetchers currently shown in consumer config
section of Kafka document is not accurate.
num.consumer.fetchers actually controls the max number of fetcher threads that
can be created in consumer. The actual number of fetcher threads is controlled
by the combination of topic, partition and num.consumer.fetchers
Reference source code in AbstractFetcherManager
private def getFetcherId(topic: String, partitionId: Int) : Int = {
Utils.abs(31 * topic.hashCode() + partitionId) % numFetchers
}
> Update num.consumer.fetchers description in Kafka documentation
> ---
>
> Key: KAFKA-2008
> URL: https://issues.apache.org/jira/browse/KAFKA-2008
> Project: Kafka
> Issue Type: Improvement
> Components: website
>Affects Versions: 0.8.2.0
>Reporter: TAO XIAO
>
> The description of num.consumer.fetchers currently shown in consumer config
> section of Kafka document is not accurate.
> num.consumer.fetchers actually controls the max number of fetcher threads per
> broker. The actual number of fetcher threads is controlled by the combination
> of topic, partition and num.consumer.fetchers
> Reference source code in AbstractFetcherManager
> private def getFetcherId(topic: String, partitionId: Int) : Int = {
> Utils.abs(31 * topic.hashCode() + partitionId) % numFetchers
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (KAFKA-2008) Update num.consumer.fetchers description in Kafka documentation
[
https://issues.apache.org/jira/browse/KAFKA-2008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
TAO XIAO updated KAFKA-2008:
Affects Version/s: 0.8.2.0
> Update num.consumer.fetchers description in Kafka documentation
> ---
>
> Key: KAFKA-2008
> URL: https://issues.apache.org/jira/browse/KAFKA-2008
> Project: Kafka
> Issue Type: Improvement
> Components: website
>Affects Versions: 0.8.2.0
>Reporter: TAO XIAO
>
> The description of num.consumer.fetchers currently shown in consumer config
> section of Kafka document is not accurate.
> num.consumer.fetchers actually controls the max number of fetcher threads
> that can be created in consumer. The actual number of fetcher threads is
> controlled by the combination of topic, partition and num.consumer.fetchers
> Reference source code in AbstractFetcherManager
> private def getFetcherId(topic: String, partitionId: Int) : Int = {
> Utils.abs(31 * topic.hashCode() + partitionId) % numFetchers
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (KAFKA-2008) Update num.consumer.fetchers description in Kafka documentation
TAO XIAO created KAFKA-2008:
---
Summary: Update num.consumer.fetchers description in Kafka
documentation
Key: KAFKA-2008
URL: https://issues.apache.org/jira/browse/KAFKA-2008
Project: Kafka
Issue Type: Improvement
Components: website
Reporter: TAO XIAO
The description of num.consumer.fetchers currently shown in consumer config
section of Kafka document is not accurate.
num.consumer.fetchers actually controls the max number of fetcher threads that
can be created in consumer. The actual number of fetcher threads is controlled
by the combination of topic, partition and num.consumer.fetchers
Reference source code in AbstractFetcherManager
private def getFetcherId(topic: String, partitionId: Int) : Int = {
Utils.abs(31 * topic.hashCode() + partitionId) % numFetchers
}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
