[jira] [Commented] (KAFKA-2934) Offset storage file configuration in Connect standalone mode is not included in StandaloneConfig
[ https://issues.apache.org/jira/browse/KAFKA-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155924#comment-15155924 ] ASF GitHub Bot commented on KAFKA-2934: --- GitHub user ZoneMayor reopened a pull request: https://github.com/apache/kafka/pull/734 KAFKA-2934: Offset storage file configuration in Connect standalone mode is not included in StandaloneConfig Added offsetBackingStore config to StandaloneConfig and DistributedConfig; Added config for offset.storage.topic and config.storage.topic into DistributedConfig; You can merge this pull request into a Git repository by running: $ git pull https://github.com/ZoneMayor/kafka trunk-KAFKA-2934 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/734.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #734 commit 34240b52e1b70aa172b65155f6042243d838b420 Author: ZoneMayorDate: 2015-12-18T07:22:20Z Merge pull request #12 from apache/trunk 2015-12-18 commit 52d02f333e86d06cfa8fff5facd18999b3db6d83 Author: ZoneMayor Date: 2015-12-30T03:08:08Z Merge pull request #13 from apache/trunk 2015-12-30 commit dd90fb07a073de2f58ba6d868348aeaf9e70a6a3 Author: jinxing Date: 2016-01-02T12:49:18Z KAFKA-2934: Offset storage file configuration in Connect standalone mode is not included in StandaloneConfig commit ff572f805de3eb7de94046f6e29aee7254262d4c Author: jinxing Date: 2016-01-02T14:21:19Z fix commit 394a1ab9e757d70d2cb83c70afcfbc5c13ca08a1 Author: jinxing Date: 2016-01-10T08:43:58Z Revert "fix" This reverts commit ff572f805de3eb7de94046f6e29aee7254262d4c. commit 1eff43becd670add7e437dec3e2f34cb384b4ccf Author: jinxing Date: 2016-01-10T08:44:10Z Revert "KAFKA-2934: Offset storage file configuration in Connect standalone mode is not included in StandaloneConfig" This reverts commit dd90fb07a073de2f58ba6d868348aeaf9e70a6a3. commit 133cb430c091957dc721bc9295dccbb98774b24c Author: jinxing Date: 2016-01-10T09:09:21Z KAFKA-2934: Offset storage file configuration in Connect standalone mode is not included in StandaloneConfig commit d56be0b9e0849660c07d656c6019f9cc2f17ae55 Author: ZoneMayor Date: 2016-01-10T09:24:06Z Merge pull request #14 from apache/trunk 2016-1-10 commit bbebd13d46930f875aac1d86f663c30daa8a9b28 Author: jinxing Date: 2016-01-12T02:48:54Z Merge branch 'trunk-KAFKA-2934' of https://github.com/ZoneMayor/kafka into trunk-KAFKA-2934 commit 5e0ba3b306afb871bf5de1f95ec47cec2874a5a0 Author: jinxing Date: 2016-01-12T03:41:51Z fix and add default value for offset.storage.file.filename, offset.storage.topic, config.storage.topic commit fbd380659727d991dff242be33cc6a3bb78f4861 Author: ZoneMayor Date: 2016-01-28T06:28:25Z Merge pull request #15 from apache/trunk 2016-01-28 commit 16d9990ff999ec900a041b501b0eb9d5a5a02810 Author: ZoneMayor Date: 2016-02-16T13:40:59Z Merge pull request #16 from apache/trunk 2016-02-16 commit cc6819942012174940fd8c2a79acccb6d3e05282 Author: ZoneMayor Date: 2016-02-18T08:42:48Z Merge pull request #17 from apache/trunk 2016-02-18 commit 76dc053011a99efdeba4b750dd20d3381e4af980 Author: jinxing Date: 2016-02-18T08:55:25Z Merge branch 'trunk-KAFKA-2934' of https://github.com/ZoneMayor/kafka into trunk-KAFKA-2934 commit 7c1413f29c9b3c95cffab7f60aa23972dada4bd7 Author: jinxing Date: 2016-02-18T13:02:44Z KAFKA-2934: fix commit a222d4fdded70355edbcda9d48ded12a1085461f Author: jinxing Date: 2016-02-18T14:05:03Z fix test commit 7ed1551469c86cfdd211b28d49dea95c7f85684a Author: jinxing Date: 2016-02-18T14:08:03Z fix > Offset storage file configuration in Connect standalone mode is not included > in StandaloneConfig > > > Key: KAFKA-2934 > URL: https://issues.apache.org/jira/browse/KAFKA-2934 > Project: Kafka > Issue Type: Bug > Components: copycat >Affects Versions: 0.9.0.0 >Reporter: Ewen Cheslack-Postava >Assignee: Ewen Cheslack-Postava > > The config is coded directly in FileOffsetBackingStore rather than being > listed (and validated) in StandaloneConfig. This also means it wouldn't be > included if we autogenerated docs from the config
[jira] [Commented] (KAFKA-2934) Offset storage file configuration in Connect standalone mode is not included in StandaloneConfig
[ https://issues.apache.org/jira/browse/KAFKA-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155923#comment-15155923 ] ASF GitHub Bot commented on KAFKA-2934: --- Github user ZoneMayor closed the pull request at: https://github.com/apache/kafka/pull/734 > Offset storage file configuration in Connect standalone mode is not included > in StandaloneConfig > > > Key: KAFKA-2934 > URL: https://issues.apache.org/jira/browse/KAFKA-2934 > Project: Kafka > Issue Type: Bug > Components: copycat >Affects Versions: 0.9.0.0 >Reporter: Ewen Cheslack-Postava >Assignee: Ewen Cheslack-Postava > > The config is coded directly in FileOffsetBackingStore rather than being > listed (and validated) in StandaloneConfig. This also means it wouldn't be > included if we autogenerated docs from the config classes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] kafka pull request: KAFKA-2934: Offset storage file configuration ...
Github user ZoneMayor closed the pull request at: https://github.com/apache/kafka/pull/734 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (KAFKA-3256) Large number of system test failures
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155911#comment-15155911 ] Anna Povzner commented on KAFKA-3256: - Also for completeness, the remaining system tests: mirror_maker_test.py, zookeeper_security_upgrade_test.py, and upgrade_test.py all use console consumer and set message_validator=is_int. So, they all expect console consumer to output values that are integers, and additional "CreateTime:> breaks that. > Large number of system test failures > > > Key: KAFKA-3256 > URL: https://issues.apache.org/jira/browse/KAFKA-3256 > Project: Kafka > Issue Type: Bug >Reporter: Geoff Anderson >Assignee: Jiangjie Qin > > Confluent's nightly run of the kafka system tests reported a large number of > failures beginning 2/20/2016 > Test run: 2016-02-19--001.1455897182--apache--trunk--eee9522/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-19--001.1455897182--apache--trunk--eee9522/report.html > Pass: 136 > Fail: 0 > Test run: 2016-02-20--001.1455979842--apache--trunk--5caa800/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-20--001.1455979842--apache--trunk--5caa800/report.html > Pass: 72 > Fail: 64 > I.e. trunk@eee9522 was the last passing run, and trunk@5caa800 had a large > number of failures. > Given its complexity, the most likely culprit is 45c8195fa, and I confirmed > this is the first commit with failures on a small number of tests. > [~becket_qin] do you mind investigating? > {code} > commit 5caa800e217c6b83f62ee3e6b5f02f56e331b309 > Author: Jun Rao> Date: Fri Feb 19 09:40:59 2016 -0800 > trivial fix to authorization CLI table > commit 45c8195fa14c766b200c720f316836dbb84e9d8b > Author: Jiangjie Qin > Date: Fri Feb 19 07:56:40 2016 -0800 > KAFKA-3025; Added timetamp to Message and use relative offset. > commit eee95228fabe1643baa016a2d49fb0a9fe2c66bd > Author: Yasuhiro Matsuda > Date: Thu Feb 18 09:39:30 2016 +0800 > MINOR: remove streams config params from producer/consumer configs > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (KAFKA-3256) Large number of system test failures
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155910#comment-15155910 ] Anna Povzner edited comment on KAFKA-3256 at 2/21/16 6:18 AM: -- I looked more into system tests to find where the format is expected, and there are several places actually: 1) Connect tests expect the output to be in JSON format. The value is published in JSON format, and since before the test was expecting the value only, the test was written to expect the console consumer output in JSON format. 2) Other tests such as reassign_partition, compatibility tests that are using ConsoleConsumer are setting message_validator=is_int when constructing it (because they were expecting only value of type integer in the console consumer output). This means that produce_consume_validate.py will be expecting consumer output to be an integer. I actually think unless we want a system test that specifically verifies a timestamp, we shouldn't modify existing tests to work with a console consumer output containing timestamp type and timestamp. So I agree with your decision to not output timestamp type and timestamp by default. If we want to write/extend system tests that specifically checks for timestamps (type or validates timestamp range), then we will use an output with a timestamp. was (Author: apovzner): I looked more into system tests to find where the format is expected, and there are several places actually: 1) Connect tests expect the output to be in JSON format. The value is published in JSON format, and since before the test was expecting the value only, the test was written to expect the console consumer output in JSON format. 2) Other tests such as reassign_partition, compatibility tests that are using ConsoleConsumer are setting message_validator=is_int when constructing it (because they were expecting only value of type integer in the console consumer output). This means that produce_consume_validate.py will be expecting consumer output to be an integer. I actually think unless we want a system test that specifically verify a timestamp, we shouldn't modify existing tests to work with a console consumer output containing timestamp type and timestamp. So I agree with your decision to not output timestamp type and timestamp by default. If we want to write/extend system tests that specifically checks for timestamps (type or validates timestamp range), then we will use an output with a timestamp. > Large number of system test failures > > > Key: KAFKA-3256 > URL: https://issues.apache.org/jira/browse/KAFKA-3256 > Project: Kafka > Issue Type: Bug >Reporter: Geoff Anderson >Assignee: Jiangjie Qin > > Confluent's nightly run of the kafka system tests reported a large number of > failures beginning 2/20/2016 > Test run: 2016-02-19--001.1455897182--apache--trunk--eee9522/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-19--001.1455897182--apache--trunk--eee9522/report.html > Pass: 136 > Fail: 0 > Test run: 2016-02-20--001.1455979842--apache--trunk--5caa800/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-20--001.1455979842--apache--trunk--5caa800/report.html > Pass: 72 > Fail: 64 > I.e. trunk@eee9522 was the last passing run, and trunk@5caa800 had a large > number of failures. > Given its complexity, the most likely culprit is 45c8195fa, and I confirmed > this is the first commit with failures on a small number of tests. > [~becket_qin] do you mind investigating? > {code} > commit 5caa800e217c6b83f62ee3e6b5f02f56e331b309 > Author: Jun Rao> Date: Fri Feb 19 09:40:59 2016 -0800 > trivial fix to authorization CLI table > commit 45c8195fa14c766b200c720f316836dbb84e9d8b > Author: Jiangjie Qin > Date: Fri Feb 19 07:56:40 2016 -0800 > KAFKA-3025; Added timetamp to Message and use relative offset. > commit eee95228fabe1643baa016a2d49fb0a9fe2c66bd > Author: Yasuhiro Matsuda > Date: Thu Feb 18 09:39:30 2016 +0800 > MINOR: remove streams config params from producer/consumer configs > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-3256) Large number of system test failures
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155910#comment-15155910 ] Anna Povzner commented on KAFKA-3256: - I looked more into system tests to find where the format is expected, and there are several places actually: 1) Connect tests expect the output to be in JSON format. The value is published in JSON format, and since before the test was expecting the value only, the test was written to expect the console consumer output in JSON format. 2) Other tests such as reassign_partition, compatibility tests that are using ConsoleConsumer are setting message_validator=is_int when constructing it (because they were expecting only value of type integer in the console consumer output). This means that produce_consume_validate.py will be expecting consumer output to be an integer. I actually think unless we want a system test that specifically verify a timestamp, we shouldn't modify existing tests to work with a console consumer output containing timestamp type and timestamp. So I agree with your decision to not output timestamp type and timestamp by default. If we want to write/extend system tests that specifically checks for timestamps (type or validates timestamp range), then we will use an output with a timestamp. > Large number of system test failures > > > Key: KAFKA-3256 > URL: https://issues.apache.org/jira/browse/KAFKA-3256 > Project: Kafka > Issue Type: Bug >Reporter: Geoff Anderson >Assignee: Jiangjie Qin > > Confluent's nightly run of the kafka system tests reported a large number of > failures beginning 2/20/2016 > Test run: 2016-02-19--001.1455897182--apache--trunk--eee9522/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-19--001.1455897182--apache--trunk--eee9522/report.html > Pass: 136 > Fail: 0 > Test run: 2016-02-20--001.1455979842--apache--trunk--5caa800/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-20--001.1455979842--apache--trunk--5caa800/report.html > Pass: 72 > Fail: 64 > I.e. trunk@eee9522 was the last passing run, and trunk@5caa800 had a large > number of failures. > Given its complexity, the most likely culprit is 45c8195fa, and I confirmed > this is the first commit with failures on a small number of tests. > [~becket_qin] do you mind investigating? > {code} > commit 5caa800e217c6b83f62ee3e6b5f02f56e331b309 > Author: Jun Rao> Date: Fri Feb 19 09:40:59 2016 -0800 > trivial fix to authorization CLI table > commit 45c8195fa14c766b200c720f316836dbb84e9d8b > Author: Jiangjie Qin > Date: Fri Feb 19 07:56:40 2016 -0800 > KAFKA-3025; Added timetamp to Message and use relative offset. > commit eee95228fabe1643baa016a2d49fb0a9fe2c66bd > Author: Yasuhiro Matsuda > Date: Thu Feb 18 09:39:30 2016 +0800 > MINOR: remove streams config params from producer/consumer configs > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-3235) Unclosed stream in AppInfoParser static block
[ https://issues.apache.org/jira/browse/KAFKA-3235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155887#comment-15155887 ] Ted Yu commented on KAFKA-3235: --- clients/src/main/java/org/apache/kafka/common/utils/AppInfoParser.java appears multiple times in the patch. Not sure if the patch was generated correctly. > Unclosed stream in AppInfoParser static block > - > > Key: KAFKA-3235 > URL: https://issues.apache.org/jira/browse/KAFKA-3235 > Project: Kafka > Issue Type: Bug >Reporter: Ted Yu >Priority: Minor > Fix For: 0.9.1.0 > > > {code} > static { > try { > Properties props = new Properties(); > > props.load(AppInfoParser.class.getResourceAsStream("/kafka/kafka-version.properties")); > version = props.getProperty("version", version).trim(); > commitId = props.getProperty("commitId", commitId).trim(); > {code} > The stream returned by getResourceAsStream() should be closed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-3256) Large number of system test failures
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155855#comment-15155855 ] Ismael Juma commented on KAFKA-3256: Yes, one patch would be enough for that option. > Large number of system test failures > > > Key: KAFKA-3256 > URL: https://issues.apache.org/jira/browse/KAFKA-3256 > Project: Kafka > Issue Type: Bug >Reporter: Geoff Anderson >Assignee: Jiangjie Qin > > Confluent's nightly run of the kafka system tests reported a large number of > failures beginning 2/20/2016 > Test run: 2016-02-19--001.1455897182--apache--trunk--eee9522/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-19--001.1455897182--apache--trunk--eee9522/report.html > Pass: 136 > Fail: 0 > Test run: 2016-02-20--001.1455979842--apache--trunk--5caa800/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-20--001.1455979842--apache--trunk--5caa800/report.html > Pass: 72 > Fail: 64 > I.e. trunk@eee9522 was the last passing run, and trunk@5caa800 had a large > number of failures. > Given its complexity, the most likely culprit is 45c8195fa, and I confirmed > this is the first commit with failures on a small number of tests. > [~becket_qin] do you mind investigating? > {code} > commit 5caa800e217c6b83f62ee3e6b5f02f56e331b309 > Author: Jun Rao> Date: Fri Feb 19 09:40:59 2016 -0800 > trivial fix to authorization CLI table > commit 45c8195fa14c766b200c720f316836dbb84e9d8b > Author: Jiangjie Qin > Date: Fri Feb 19 07:56:40 2016 -0800 > KAFKA-3025; Added timetamp to Message and use relative offset. > commit eee95228fabe1643baa016a2d49fb0a9fe2c66bd > Author: Yasuhiro Matsuda > Date: Thu Feb 18 09:39:30 2016 +0800 > MINOR: remove streams config params from producer/consumer configs > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-3256) Large number of system test failures
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155854#comment-15155854 ] Jiangjie Qin commented on KAFKA-3256: - [~ijuma] If we add a "print.timestamp" to console consumer and disable it by default then we only need one patch, right? > Large number of system test failures > > > Key: KAFKA-3256 > URL: https://issues.apache.org/jira/browse/KAFKA-3256 > Project: Kafka > Issue Type: Bug >Reporter: Geoff Anderson >Assignee: Jiangjie Qin > > Confluent's nightly run of the kafka system tests reported a large number of > failures beginning 2/20/2016 > Test run: 2016-02-19--001.1455897182--apache--trunk--eee9522/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-19--001.1455897182--apache--trunk--eee9522/report.html > Pass: 136 > Fail: 0 > Test run: 2016-02-20--001.1455979842--apache--trunk--5caa800/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-20--001.1455979842--apache--trunk--5caa800/report.html > Pass: 72 > Fail: 64 > I.e. trunk@eee9522 was the last passing run, and trunk@5caa800 had a large > number of failures. > Given its complexity, the most likely culprit is 45c8195fa, and I confirmed > this is the first commit with failures on a small number of tests. > [~becket_qin] do you mind investigating? > {code} > commit 5caa800e217c6b83f62ee3e6b5f02f56e331b309 > Author: Jun Rao> Date: Fri Feb 19 09:40:59 2016 -0800 > trivial fix to authorization CLI table > commit 45c8195fa14c766b200c720f316836dbb84e9d8b > Author: Jiangjie Qin > Date: Fri Feb 19 07:56:40 2016 -0800 > KAFKA-3025; Added timetamp to Message and use relative offset. > commit eee95228fabe1643baa016a2d49fb0a9fe2c66bd > Author: Yasuhiro Matsuda > Date: Thu Feb 18 09:39:30 2016 +0800 > MINOR: remove streams config params from producer/consumer configs > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-3256) Large number of system test failures
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155852#comment-15155852 ] Jiangjie Qin commented on KAFKA-3256: - I like this idea. We already have "print.key" as an option for console consumer. We can have a "print.timestamp" as well and disable it by default. > Large number of system test failures > > > Key: KAFKA-3256 > URL: https://issues.apache.org/jira/browse/KAFKA-3256 > Project: Kafka > Issue Type: Bug >Reporter: Geoff Anderson >Assignee: Jiangjie Qin > > Confluent's nightly run of the kafka system tests reported a large number of > failures beginning 2/20/2016 > Test run: 2016-02-19--001.1455897182--apache--trunk--eee9522/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-19--001.1455897182--apache--trunk--eee9522/report.html > Pass: 136 > Fail: 0 > Test run: 2016-02-20--001.1455979842--apache--trunk--5caa800/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-20--001.1455979842--apache--trunk--5caa800/report.html > Pass: 72 > Fail: 64 > I.e. trunk@eee9522 was the last passing run, and trunk@5caa800 had a large > number of failures. > Given its complexity, the most likely culprit is 45c8195fa, and I confirmed > this is the first commit with failures on a small number of tests. > [~becket_qin] do you mind investigating? > {code} > commit 5caa800e217c6b83f62ee3e6b5f02f56e331b309 > Author: Jun Rao> Date: Fri Feb 19 09:40:59 2016 -0800 > trivial fix to authorization CLI table > commit 45c8195fa14c766b200c720f316836dbb84e9d8b > Author: Jiangjie Qin > Date: Fri Feb 19 07:56:40 2016 -0800 > KAFKA-3025; Added timetamp to Message and use relative offset. > commit eee95228fabe1643baa016a2d49fb0a9fe2c66bd > Author: Yasuhiro Matsuda > Date: Thu Feb 18 09:39:30 2016 +0800 > MINOR: remove streams config params from producer/consumer configs > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (KAFKA-3256) Large number of system test failures
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155848#comment-15155848 ] Ismael Juma edited comment on KAFKA-3256 at 2/21/16 1:57 AM: - Whatever we decide, it would be good to do it in two steps (revert the output format change so that the system tests pass again and then discuss the best way to handle adding it back) as per Becket's suggestion. was (Author: ijuma): Whatever we decide, it would be good to do it in two steps (revert the output format change so that the system tests pass again and then discuss the best way to handle adding it back). > Large number of system test failures > > > Key: KAFKA-3256 > URL: https://issues.apache.org/jira/browse/KAFKA-3256 > Project: Kafka > Issue Type: Bug >Reporter: Geoff Anderson >Assignee: Jiangjie Qin > > Confluent's nightly run of the kafka system tests reported a large number of > failures beginning 2/20/2016 > Test run: 2016-02-19--001.1455897182--apache--trunk--eee9522/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-19--001.1455897182--apache--trunk--eee9522/report.html > Pass: 136 > Fail: 0 > Test run: 2016-02-20--001.1455979842--apache--trunk--5caa800/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-20--001.1455979842--apache--trunk--5caa800/report.html > Pass: 72 > Fail: 64 > I.e. trunk@eee9522 was the last passing run, and trunk@5caa800 had a large > number of failures. > Given its complexity, the most likely culprit is 45c8195fa, and I confirmed > this is the first commit with failures on a small number of tests. > [~becket_qin] do you mind investigating? > {code} > commit 5caa800e217c6b83f62ee3e6b5f02f56e331b309 > Author: Jun Rao> Date: Fri Feb 19 09:40:59 2016 -0800 > trivial fix to authorization CLI table > commit 45c8195fa14c766b200c720f316836dbb84e9d8b > Author: Jiangjie Qin > Date: Fri Feb 19 07:56:40 2016 -0800 > KAFKA-3025; Added timetamp to Message and use relative offset. > commit eee95228fabe1643baa016a2d49fb0a9fe2c66bd > Author: Yasuhiro Matsuda > Date: Thu Feb 18 09:39:30 2016 +0800 > MINOR: remove streams config params from producer/consumer configs > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-3256) Large number of system test failures
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155848#comment-15155848 ] Ismael Juma commented on KAFKA-3256: Whatever we decide, it would be good to do it in two steps (revert the output format change so that the system tests pass again and then discuss the best way to handle adding it back). > Large number of system test failures > > > Key: KAFKA-3256 > URL: https://issues.apache.org/jira/browse/KAFKA-3256 > Project: Kafka > Issue Type: Bug >Reporter: Geoff Anderson >Assignee: Jiangjie Qin > > Confluent's nightly run of the kafka system tests reported a large number of > failures beginning 2/20/2016 > Test run: 2016-02-19--001.1455897182--apache--trunk--eee9522/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-19--001.1455897182--apache--trunk--eee9522/report.html > Pass: 136 > Fail: 0 > Test run: 2016-02-20--001.1455979842--apache--trunk--5caa800/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-20--001.1455979842--apache--trunk--5caa800/report.html > Pass: 72 > Fail: 64 > I.e. trunk@eee9522 was the last passing run, and trunk@5caa800 had a large > number of failures. > Given its complexity, the most likely culprit is 45c8195fa, and I confirmed > this is the first commit with failures on a small number of tests. > [~becket_qin] do you mind investigating? > {code} > commit 5caa800e217c6b83f62ee3e6b5f02f56e331b309 > Author: Jun Rao> Date: Fri Feb 19 09:40:59 2016 -0800 > trivial fix to authorization CLI table > commit 45c8195fa14c766b200c720f316836dbb84e9d8b > Author: Jiangjie Qin > Date: Fri Feb 19 07:56:40 2016 -0800 > KAFKA-3025; Added timetamp to Message and use relative offset. > commit eee95228fabe1643baa016a2d49fb0a9fe2c66bd > Author: Yasuhiro Matsuda > Date: Thu Feb 18 09:39:30 2016 +0800 > MINOR: remove streams config params from producer/consumer configs > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-3256) Large number of system test failures
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155847#comment-15155847 ] Ismael Juma commented on KAFKA-3256: We may also consider outputting those fields only when a flag is set for compatibility reasons. > Large number of system test failures > > > Key: KAFKA-3256 > URL: https://issues.apache.org/jira/browse/KAFKA-3256 > Project: Kafka > Issue Type: Bug >Reporter: Geoff Anderson >Assignee: Jiangjie Qin > > Confluent's nightly run of the kafka system tests reported a large number of > failures beginning 2/20/2016 > Test run: 2016-02-19--001.1455897182--apache--trunk--eee9522/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-19--001.1455897182--apache--trunk--eee9522/report.html > Pass: 136 > Fail: 0 > Test run: 2016-02-20--001.1455979842--apache--trunk--5caa800/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-20--001.1455979842--apache--trunk--5caa800/report.html > Pass: 72 > Fail: 64 > I.e. trunk@eee9522 was the last passing run, and trunk@5caa800 had a large > number of failures. > Given its complexity, the most likely culprit is 45c8195fa, and I confirmed > this is the first commit with failures on a small number of tests. > [~becket_qin] do you mind investigating? > {code} > commit 5caa800e217c6b83f62ee3e6b5f02f56e331b309 > Author: Jun Rao> Date: Fri Feb 19 09:40:59 2016 -0800 > trivial fix to authorization CLI table > commit 45c8195fa14c766b200c720f316836dbb84e9d8b > Author: Jiangjie Qin > Date: Fri Feb 19 07:56:40 2016 -0800 > KAFKA-3025; Added timetamp to Message and use relative offset. > commit eee95228fabe1643baa016a2d49fb0a9fe2c66bd > Author: Yasuhiro Matsuda > Date: Thu Feb 18 09:39:30 2016 +0800 > MINOR: remove streams config params from producer/consumer configs > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-3256) Large number of system test failures
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155846#comment-15155846 ] Jiangjie Qin commented on KAFKA-3256: - Hmm, the reason we are printing the timestamp is because that is a user-specified field, just like key and value. ConsoleConsumer is supposed to print that if applicable. If fixing the integration tests format is time consuming, we can temporarily change the output format for ConsoleConsumer back to print only key and value. And we can have a follow-up patch for this ticket that updates both the ConsumerConsumer output format and integration test message format. > Large number of system test failures > > > Key: KAFKA-3256 > URL: https://issues.apache.org/jira/browse/KAFKA-3256 > Project: Kafka > Issue Type: Bug >Reporter: Geoff Anderson >Assignee: Jiangjie Qin > > Confluent's nightly run of the kafka system tests reported a large number of > failures beginning 2/20/2016 > Test run: 2016-02-19--001.1455897182--apache--trunk--eee9522/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-19--001.1455897182--apache--trunk--eee9522/report.html > Pass: 136 > Fail: 0 > Test run: 2016-02-20--001.1455979842--apache--trunk--5caa800/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-20--001.1455979842--apache--trunk--5caa800/report.html > Pass: 72 > Fail: 64 > I.e. trunk@eee9522 was the last passing run, and trunk@5caa800 had a large > number of failures. > Given its complexity, the most likely culprit is 45c8195fa, and I confirmed > this is the first commit with failures on a small number of tests. > [~becket_qin] do you mind investigating? > {code} > commit 5caa800e217c6b83f62ee3e6b5f02f56e331b309 > Author: Jun Rao> Date: Fri Feb 19 09:40:59 2016 -0800 > trivial fix to authorization CLI table > commit 45c8195fa14c766b200c720f316836dbb84e9d8b > Author: Jiangjie Qin > Date: Fri Feb 19 07:56:40 2016 -0800 > KAFKA-3025; Added timetamp to Message and use relative offset. > commit eee95228fabe1643baa016a2d49fb0a9fe2c66bd > Author: Yasuhiro Matsuda > Date: Thu Feb 18 09:39:30 2016 +0800 > MINOR: remove streams config params from producer/consumer configs > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (KAFKA-3256) Large number of system test failures
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155841#comment-15155841 ] Anna Povzner edited comment on KAFKA-3256 at 2/21/16 1:40 AM: -- [~becket_qin] The "No JSON object could be decoded" failure is also caused by ConsoleConsumer outputting timestamp type and timestamp. If I remove that output from ConsoleConsumer, I stop getting this failure. Also, once I did that, reassign_partitions_test also started passing. So, it leads me to believe that there is some common test tool which expects a particular *format* of an output, rather than a test expecting a specific output. What was the reason for outputting timestamp type and timestamp in ConsoleConsumer? If it does not bring much value, I propose to just got back to the original format of outputting key and value in ConsoleConsumer. I think that would fix most of the tests. was (Author: apovzner): [~becket_qin] The "No JSON object could be decoded" failure is also caused by ConsoleConsumer outputting timestamp type and timestamp. If I remove that output from ConsoleConsumer, I stop getting this failure. Also, once I did not, reassign_partitions_test also started passing. So, it leads me to believe that there is some common test tool which expects a particular *format* of an output, rather than a test expecting a specific output. What was the reason for outputting timestamp type and timestamp in ConsoleConsumer? If it does not bring much value, I propose to just got back to the original format of outputting key and value in ConsoleConsumer. I think that would fix most of the tests. > Large number of system test failures > > > Key: KAFKA-3256 > URL: https://issues.apache.org/jira/browse/KAFKA-3256 > Project: Kafka > Issue Type: Bug >Reporter: Geoff Anderson >Assignee: Jiangjie Qin > > Confluent's nightly run of the kafka system tests reported a large number of > failures beginning 2/20/2016 > Test run: 2016-02-19--001.1455897182--apache--trunk--eee9522/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-19--001.1455897182--apache--trunk--eee9522/report.html > Pass: 136 > Fail: 0 > Test run: 2016-02-20--001.1455979842--apache--trunk--5caa800/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-20--001.1455979842--apache--trunk--5caa800/report.html > Pass: 72 > Fail: 64 > I.e. trunk@eee9522 was the last passing run, and trunk@5caa800 had a large > number of failures. > Given its complexity, the most likely culprit is 45c8195fa, and I confirmed > this is the first commit with failures on a small number of tests. > [~becket_qin] do you mind investigating? > {code} > commit 5caa800e217c6b83f62ee3e6b5f02f56e331b309 > Author: Jun Rao> Date: Fri Feb 19 09:40:59 2016 -0800 > trivial fix to authorization CLI table > commit 45c8195fa14c766b200c720f316836dbb84e9d8b > Author: Jiangjie Qin > Date: Fri Feb 19 07:56:40 2016 -0800 > KAFKA-3025; Added timetamp to Message and use relative offset. > commit eee95228fabe1643baa016a2d49fb0a9fe2c66bd > Author: Yasuhiro Matsuda > Date: Thu Feb 18 09:39:30 2016 +0800 > MINOR: remove streams config params from producer/consumer configs > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-3256) Large number of system test failures
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155835#comment-15155835 ] Jiangjie Qin commented on KAFKA-3256: - Yes, fix to those tests are obvious. I am looking at the other two types of failure. {noformat} No JSON object could be decoded Traceback (most recent call last): File "/var/lib/jenkins/workspace/kafka_system_tests/kafka/venv/local/lib/python2.7/site-packages/ducktape-0.3.10-py2.7.egg/ducktape/tests/runner.py", line 102, in run_all_tests result.data = self.run_single_test() File "/var/lib/jenkins/workspace/kafka_system_tests/kafka/venv/local/lib/python2.7/site-packages/ducktape-0.3.10-py2.7.egg/ducktape/tests/runner.py", line 154, in run_single_test return self.current_test_context.function(self.current_test) File "/var/lib/jenkins/workspace/kafka_system_tests/kafka/venv/local/lib/python2.7/site-packages/ducktape-0.3.10-py2.7.egg/ducktape/mark/_mark.py", line 331, in wrapper return functools.partial(f, *args, **kwargs)(*w_args, **w_kwargs) File "/var/lib/jenkins/workspace/kafka_system_tests/kafka/tests/kafkatest/tests/connect_test.py", line 85, in test_file_source_and_sink actual = json.dumps([decoder(x) for x in self.consumer_validator.messages_consumed[1]]) File "/usr/lib/python2.7/json/__init__.py", line 338, in loads return _default_decoder.decode(s) File "/usr/lib/python2.7/json/decoder.py", line 366, in decode obj, end = self.raw_decode(s, idx=_w(s, 0).end()) File "/usr/lib/python2.7/json/decoder.py", line 384, in raw_decode raise ValueError("No JSON object could be decoded") {noformat} And {noformat} Consumer failed to start in a reasonable amount of time. Traceback (most recent call last): File "/var/lib/jenkins/workspace/kafka_system_tests/kafka/venv/local/lib/python2.7/site-packages/ducktape-0.3.10-py2.7.egg/ducktape/tests/runner.py", line 102, in run_all_tests result.data = self.run_single_test() File "/var/lib/jenkins/workspace/kafka_system_tests/kafka/venv/local/lib/python2.7/site-packages/ducktape-0.3.10-py2.7.egg/ducktape/tests/runner.py", line 154, in run_single_test return self.current_test_context.function(self.current_test) File "/var/lib/jenkins/workspace/kafka_system_tests/kafka/venv/local/lib/python2.7/site-packages/ducktape-0.3.10-py2.7.egg/ducktape/mark/_mark.py", line 331, in wrapper return functools.partial(f, *args, **kwargs)(*w_args, **w_kwargs) File "/var/lib/jenkins/workspace/kafka_system_tests/kafka/tests/kafkatest/tests/mirror_maker_test.py", line 139, in test_simple_end_to_end self.run_produce_consume_validate(core_test_action=self.wait_for_n_messages) File "/var/lib/jenkins/workspace/kafka_system_tests/kafka/tests/kafkatest/tests/produce_consume_validate.py", line 79, in run_produce_consume_validate raise e {noformat} I am not super familiar with those tests, so might it might take me some time to check. It looks we have problem when starting validating consumer. > Large number of system test failures > > > Key: KAFKA-3256 > URL: https://issues.apache.org/jira/browse/KAFKA-3256 > Project: Kafka > Issue Type: Bug >Reporter: Geoff Anderson >Assignee: Jiangjie Qin > > Confluent's nightly run of the kafka system tests reported a large number of > failures beginning 2/20/2016 > Test run: 2016-02-19--001.1455897182--apache--trunk--eee9522/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-19--001.1455897182--apache--trunk--eee9522/report.html > Pass: 136 > Fail: 0 > Test run: 2016-02-20--001.1455979842--apache--trunk--5caa800/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-20--001.1455979842--apache--trunk--5caa800/report.html > Pass: 72 > Fail: 64 > I.e. trunk@eee9522 was the last passing run, and trunk@5caa800 had a large > number of failures. > Given its complexity, the most likely culprit is 45c8195fa, and I confirmed > this is the first commit with failures on a small number of tests. > [~becket_qin] do you mind investigating? > {code} > commit 5caa800e217c6b83f62ee3e6b5f02f56e331b309 > Author: Jun Rao> Date: Fri Feb 19 09:40:59 2016 -0800 > trivial fix to authorization CLI table > commit 45c8195fa14c766b200c720f316836dbb84e9d8b > Author: Jiangjie Qin > Date: Fri Feb 19 07:56:40 2016 -0800 > KAFKA-3025; Added timetamp to Message and use relative offset. > commit eee95228fabe1643baa016a2d49fb0a9fe2c66bd > Author: Yasuhiro Matsuda > Date: Thu Feb 18 09:39:30 2016 +0800 > MINOR: remove streams config params from producer/consumer configs > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-3256) Large number of system test failures
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155832#comment-15155832 ] Anna Povzner commented on KAFKA-3256: - [~becket_qin] Most of these tests are reproducible locally, so should be easier to debug. I found the issue with some of the connect tests, which produce output like this: Expected ["foo", "bar", "baz", "razz", "ma", "tazz"] but saw ["CreateTime:1455962742782\tfoo", "CreateTime:1455962742789\tbar", "CreateTime:1455962742789\tbaz", "CreateTime:1455962758003\trazz", "CreateTime:1455962758009\tma", "CreateTime:1455962758009\ttazz"] in Kafka Traceback (most recent call last): File "/var/lib/jenkins/workspace/kafka_system_tests/kafka/venv/local/lib/python2.7/site-packages/ducktape-0.3.10-py2.7.egg/ducktape/tests/runner.py", line 102, in run_all_tests result.data = self.run_single_test() File "/var/lib/jenkins/workspace/kafka_system_tests/kafka/venv/local/lib/python2.7/site-packages/ducktape-0.3.10-py2.7.egg/ducktape/tests/runner.py", line 154, in run_single_test return self.current_test_context.function(self.current_test) File "/var/lib/jenkins/workspace/kafka_system_tests/kafka/venv/local/lib/python2.7/site-packages/ducktape-0.3.10-py2.7.egg/ducktape/mark/_mark.py", line 331, in wrapper return functools.partial(f, *args, **kwargs)(*w_args, **w_kwargs) File "/var/lib/jenkins/workspace/kafka_system_tests/kafka/tests/kafkatest/tests/connect_test.py", line 86, in test_file_source_and_sink assert expected == actual, "Expected %s but saw %s in Kafka" % (expected, actual) AssertionError: Expected ["foo", "bar", "baz", "razz", "ma", "tazz"] but saw ["CreateTime:1455962742782\tfoo", "CreateTime:1455962742789\tbar", "CreateTime:1455962742789\tbaz", "CreateTime:1455962758003\trazz", "CreateTime:1455962758009\tma", "CreateTime:1455962758009\ttazz"] in Kafka ConsoleConsumer was changed to also output timestamp type and timestamp value in addition to key/value. However, it looks connect tests expect output with just key and value. See test_file_source_and_sink in connect_test.py for example. > Large number of system test failures > > > Key: KAFKA-3256 > URL: https://issues.apache.org/jira/browse/KAFKA-3256 > Project: Kafka > Issue Type: Bug >Reporter: Geoff Anderson >Assignee: Jiangjie Qin > > Confluent's nightly run of the kafka system tests reported a large number of > failures beginning 2/20/2016 > Test run: 2016-02-19--001.1455897182--apache--trunk--eee9522/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-19--001.1455897182--apache--trunk--eee9522/report.html > Pass: 136 > Fail: 0 > Test run: 2016-02-20--001.1455979842--apache--trunk--5caa800/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-20--001.1455979842--apache--trunk--5caa800/report.html > Pass: 72 > Fail: 64 > I.e. trunk@eee9522 was the last passing run, and trunk@5caa800 had a large > number of failures. > Given its complexity, the most likely culprit is 45c8195fa, and I confirmed > this is the first commit with failures on a small number of tests. > [~becket_qin] do you mind investigating? > {code} > commit 5caa800e217c6b83f62ee3e6b5f02f56e331b309 > Author: Jun Rao> Date: Fri Feb 19 09:40:59 2016 -0800 > trivial fix to authorization CLI table > commit 45c8195fa14c766b200c720f316836dbb84e9d8b > Author: Jiangjie Qin > Date: Fri Feb 19 07:56:40 2016 -0800 > KAFKA-3025; Added timetamp to Message and use relative offset. > commit eee95228fabe1643baa016a2d49fb0a9fe2c66bd > Author: Yasuhiro Matsuda > Date: Thu Feb 18 09:39:30 2016 +0800 > MINOR: remove streams config params from producer/consumer configs > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-3256) Large number of system test failures
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155827#comment-15155827 ] Geoff Anderson commented on KAFKA-3256: --- [~becket_qin] The bucket is publicly readable as far as I can tell: If you have awscli installed (see http://docs.aws.amazon.com/cli/latest/userguide/installing.html), you can try {code} aws s3 cp --recursive s3://confluent-kafka-system-test-results/2016-02-20--001.1455979842--apache--trunk--5caa800 ./2016-02-20--001.1455979842--apache--trunk—5caa800 {code} Note that directories corresponding to individual tests are actually tarballed, and can be unpacked with: tar xzf INDIVIDUAL_TEST_DIRECTORY > Large number of system test failures > > > Key: KAFKA-3256 > URL: https://issues.apache.org/jira/browse/KAFKA-3256 > Project: Kafka > Issue Type: Bug >Reporter: Geoff Anderson >Assignee: Jiangjie Qin > > Confluent's nightly run of the kafka system tests reported a large number of > failures beginning 2/20/2016 > Test run: 2016-02-19--001.1455897182--apache--trunk--eee9522/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-19--001.1455897182--apache--trunk--eee9522/report.html > Pass: 136 > Fail: 0 > Test run: 2016-02-20--001.1455979842--apache--trunk--5caa800/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-20--001.1455979842--apache--trunk--5caa800/report.html > Pass: 72 > Fail: 64 > I.e. trunk@eee9522 was the last passing run, and trunk@5caa800 had a large > number of failures. > Given its complexity, the most likely culprit is 45c8195fa, and I confirmed > this is the first commit with failures on a small number of tests. > [~becket_qin] do you mind investigating? > {code} > commit 5caa800e217c6b83f62ee3e6b5f02f56e331b309 > Author: Jun Rao> Date: Fri Feb 19 09:40:59 2016 -0800 > trivial fix to authorization CLI table > commit 45c8195fa14c766b200c720f316836dbb84e9d8b > Author: Jiangjie Qin > Date: Fri Feb 19 07:56:40 2016 -0800 > KAFKA-3025; Added timetamp to Message and use relative offset. > commit eee95228fabe1643baa016a2d49fb0a9fe2c66bd > Author: Yasuhiro Matsuda > Date: Thu Feb 18 09:39:30 2016 +0800 > MINOR: remove streams config params from producer/consumer configs > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (KAFKA-3257) bootstrap-test-env.sh version check fails when grep has --colour option enabled.
Jiangjie Qin created KAFKA-3257: --- Summary: bootstrap-test-env.sh version check fails when grep has --colour option enabled. Key: KAFKA-3257 URL: https://issues.apache.org/jira/browse/KAFKA-3257 Project: Kafka Issue Type: Bug Components: system tests Affects Versions: 0.9.0.1 Reporter: Jiangjie Qin Fix For: 0.10.0.0 When checking the versions, we use the following command: {code} vagrant --version | egrep -o "[0-9]+\.[0-9]+\.[0-9]+" {code} This does not work if user box has --colour option enabled. In my case it complains: Found Vagrant version 1.8.1. Please upgrade to 1.6.4 or higher (see http://www.vagrantup.com for details) We should change this line to: {code} vagrant --version | egrep --colour=never -o "[0-9]+\.[0-9]+\.[0-9]+" {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-3256) Large number of system test failures
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155819#comment-15155819 ] Geoff Anderson commented on KAFKA-3256: --- [~becket_qin] Are you not able to navigate directly to this link and view the report? http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-20--001.1455979842--apache--trunk--5caa800/report.html > Large number of system test failures > > > Key: KAFKA-3256 > URL: https://issues.apache.org/jira/browse/KAFKA-3256 > Project: Kafka > Issue Type: Bug >Reporter: Geoff Anderson >Assignee: Jiangjie Qin > > Confluent's nightly run of the kafka system tests reported a large number of > failures beginning 2/20/2016 > Test run: 2016-02-19--001.1455897182--apache--trunk--eee9522/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-19--001.1455897182--apache--trunk--eee9522/report.html > Pass: 136 > Fail: 0 > Test run: 2016-02-20--001.1455979842--apache--trunk--5caa800/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-20--001.1455979842--apache--trunk--5caa800/report.html > Pass: 72 > Fail: 64 > I.e. trunk@eee9522 was the last passing run, and trunk@5caa800 had a large > number of failures. > Given its complexity, the most likely culprit is 45c8195fa, and I confirmed > this is the first commit with failures on a small number of tests. > [~becket_qin] do you mind investigating? > {code} > commit 5caa800e217c6b83f62ee3e6b5f02f56e331b309 > Author: Jun Rao> Date: Fri Feb 19 09:40:59 2016 -0800 > trivial fix to authorization CLI table > commit 45c8195fa14c766b200c720f316836dbb84e9d8b > Author: Jiangjie Qin > Date: Fri Feb 19 07:56:40 2016 -0800 > KAFKA-3025; Added timetamp to Message and use relative offset. > commit eee95228fabe1643baa016a2d49fb0a9fe2c66bd > Author: Yasuhiro Matsuda > Date: Thu Feb 18 09:39:30 2016 +0800 > MINOR: remove streams config params from producer/consumer configs > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (KAFKA-3256) Large number of system test failures
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155794#comment-15155794 ] Jiangjie Qin edited comment on KAFKA-3256 at 2/20/16 11:00 PM: --- [~hachikuji] It seems I am not able to access the test report on AWS S3. Do you mind uploading it in this ticket? was (Author: becket_qin): [~hachikuji] It seems I am not be able to access the test report on AWS S3. Do you mind uploading it in this ticket? > Large number of system test failures > > > Key: KAFKA-3256 > URL: https://issues.apache.org/jira/browse/KAFKA-3256 > Project: Kafka > Issue Type: Bug >Reporter: Geoff Anderson >Assignee: Jiangjie Qin > > Confluent's nightly run of the kafka system tests reported a large number of > failures beginning 2/20/2016 > Test run: 2016-02-19--001.1455897182--apache--trunk--eee9522/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-19--001.1455897182--apache--trunk--eee9522/report.html > Pass: 136 > Fail: 0 > Test run: 2016-02-20--001.1455979842--apache--trunk--5caa800/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-20--001.1455979842--apache--trunk--5caa800/report.html > Pass: 72 > Fail: 64 > I.e. trunk@eee9522 was the last passing run, and trunk@5caa800 had a large > number of failures. > Given its complexity, the most likely culprit is 45c8195fa, and I confirmed > this is the first commit with failures on a small number of tests. > [~becket_qin] do you mind investigating? > {code} > commit 5caa800e217c6b83f62ee3e6b5f02f56e331b309 > Author: Jun Rao> Date: Fri Feb 19 09:40:59 2016 -0800 > trivial fix to authorization CLI table > commit 45c8195fa14c766b200c720f316836dbb84e9d8b > Author: Jiangjie Qin > Date: Fri Feb 19 07:56:40 2016 -0800 > KAFKA-3025; Added timetamp to Message and use relative offset. > commit eee95228fabe1643baa016a2d49fb0a9fe2c66bd > Author: Yasuhiro Matsuda > Date: Thu Feb 18 09:39:30 2016 +0800 > MINOR: remove streams config params from producer/consumer configs > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-3256) Large number of system test failures
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155794#comment-15155794 ] Jiangjie Qin commented on KAFKA-3256: - [~hachikuji] It seems I am not be able to access the test report on AWS S3. Do you mind uploading it in this ticket? > Large number of system test failures > > > Key: KAFKA-3256 > URL: https://issues.apache.org/jira/browse/KAFKA-3256 > Project: Kafka > Issue Type: Bug >Reporter: Geoff Anderson >Assignee: Jiangjie Qin > > Confluent's nightly run of the kafka system tests reported a large number of > failures beginning 2/20/2016 > Test run: 2016-02-19--001.1455897182--apache--trunk--eee9522/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-19--001.1455897182--apache--trunk--eee9522/report.html > Pass: 136 > Fail: 0 > Test run: 2016-02-20--001.1455979842--apache--trunk--5caa800/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-20--001.1455979842--apache--trunk--5caa800/report.html > Pass: 72 > Fail: 64 > I.e. trunk@eee9522 was the last passing run, and trunk@5caa800 had a large > number of failures. > Given its complexity, the most likely culprit is 45c8195fa, and I confirmed > this is the first commit with failures on a small number of tests. > [~becket_qin] do you mind investigating? > {code} > commit 5caa800e217c6b83f62ee3e6b5f02f56e331b309 > Author: Jun Rao> Date: Fri Feb 19 09:40:59 2016 -0800 > trivial fix to authorization CLI table > commit 45c8195fa14c766b200c720f316836dbb84e9d8b > Author: Jiangjie Qin > Date: Fri Feb 19 07:56:40 2016 -0800 > KAFKA-3025; Added timetamp to Message and use relative offset. > commit eee95228fabe1643baa016a2d49fb0a9fe2c66bd > Author: Yasuhiro Matsuda > Date: Thu Feb 18 09:39:30 2016 +0800 > MINOR: remove streams config params from producer/consumer configs > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-3256) Large number of system test failures
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155793#comment-15155793 ] Jiangjie Qin commented on KAFKA-3256: - [~hachikuji] Sure, I'm investigating. > Large number of system test failures > > > Key: KAFKA-3256 > URL: https://issues.apache.org/jira/browse/KAFKA-3256 > Project: Kafka > Issue Type: Bug >Reporter: Geoff Anderson > > Confluent's nightly run of the kafka system tests reported a large number of > failures beginning 2/20/2016 > Test run: 2016-02-19--001.1455897182--apache--trunk--eee9522/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-19--001.1455897182--apache--trunk--eee9522/report.html > Pass: 136 > Fail: 0 > Test run: 2016-02-20--001.1455979842--apache--trunk--5caa800/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-20--001.1455979842--apache--trunk--5caa800/report.html > Pass: 72 > Fail: 64 > I.e. trunk@eee9522 was the last passing run, and trunk@5caa800 had a large > number of failures. > Given its complexity, the most likely culprit is 45c8195fa, and I confirmed > this is the first commit with failures on a small number of tests. > [~becket_qin] do you mind investigating? > {code} > commit 5caa800e217c6b83f62ee3e6b5f02f56e331b309 > Author: Jun Rao> Date: Fri Feb 19 09:40:59 2016 -0800 > trivial fix to authorization CLI table > commit 45c8195fa14c766b200c720f316836dbb84e9d8b > Author: Jiangjie Qin > Date: Fri Feb 19 07:56:40 2016 -0800 > KAFKA-3025; Added timetamp to Message and use relative offset. > commit eee95228fabe1643baa016a2d49fb0a9fe2c66bd > Author: Yasuhiro Matsuda > Date: Thu Feb 18 09:39:30 2016 +0800 > MINOR: remove streams config params from producer/consumer configs > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (KAFKA-3256) Large number of system test failures
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin reassigned KAFKA-3256: --- Assignee: Jiangjie Qin > Large number of system test failures > > > Key: KAFKA-3256 > URL: https://issues.apache.org/jira/browse/KAFKA-3256 > Project: Kafka > Issue Type: Bug >Reporter: Geoff Anderson >Assignee: Jiangjie Qin > > Confluent's nightly run of the kafka system tests reported a large number of > failures beginning 2/20/2016 > Test run: 2016-02-19--001.1455897182--apache--trunk--eee9522/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-19--001.1455897182--apache--trunk--eee9522/report.html > Pass: 136 > Fail: 0 > Test run: 2016-02-20--001.1455979842--apache--trunk--5caa800/ > Link: > http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-20--001.1455979842--apache--trunk--5caa800/report.html > Pass: 72 > Fail: 64 > I.e. trunk@eee9522 was the last passing run, and trunk@5caa800 had a large > number of failures. > Given its complexity, the most likely culprit is 45c8195fa, and I confirmed > this is the first commit with failures on a small number of tests. > [~becket_qin] do you mind investigating? > {code} > commit 5caa800e217c6b83f62ee3e6b5f02f56e331b309 > Author: Jun Rao> Date: Fri Feb 19 09:40:59 2016 -0800 > trivial fix to authorization CLI table > commit 45c8195fa14c766b200c720f316836dbb84e9d8b > Author: Jiangjie Qin > Date: Fri Feb 19 07:56:40 2016 -0800 > KAFKA-3025; Added timetamp to Message and use relative offset. > commit eee95228fabe1643baa016a2d49fb0a9fe2c66bd > Author: Yasuhiro Matsuda > Date: Thu Feb 18 09:39:30 2016 +0800 > MINOR: remove streams config params from producer/consumer configs > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (KAFKA-3256) Large number of system test failures
Geoff Anderson created KAFKA-3256: - Summary: Large number of system test failures Key: KAFKA-3256 URL: https://issues.apache.org/jira/browse/KAFKA-3256 Project: Kafka Issue Type: Bug Reporter: Geoff Anderson Confluent's nightly run of the kafka system tests reported a large number of failures beginning 2/20/2016 Test run: 2016-02-19--001.1455897182--apache--trunk--eee9522/ Link: http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-19--001.1455897182--apache--trunk--eee9522/report.html Pass: 136 Fail: 0 Test run: 2016-02-20--001.1455979842--apache--trunk--5caa800/ Link: http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/2016-02-20--001.1455979842--apache--trunk--5caa800/report.html Pass: 72 Fail: 64 I.e. trunk@eee9522 was the last passing run, and trunk@5caa800 had a large number of failures. Given its complexity, the most likely culprit is 45c8195fa, and I confirmed this is the first commit with failures on a small number of tests. [~becket_qin] do you mind investigating? {code} commit 5caa800e217c6b83f62ee3e6b5f02f56e331b309 Author: Jun RaoDate: Fri Feb 19 09:40:59 2016 -0800 trivial fix to authorization CLI table commit 45c8195fa14c766b200c720f316836dbb84e9d8b Author: Jiangjie Qin Date: Fri Feb 19 07:56:40 2016 -0800 KAFKA-3025; Added timetamp to Message and use relative offset. commit eee95228fabe1643baa016a2d49fb0a9fe2c66bd Author: Yasuhiro Matsuda Date: Thu Feb 18 09:39:30 2016 +0800 MINOR: remove streams config params from producer/consumer configs {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-3255) Extra unit tests for NetworkClient.connectionDelay(Node node, long now)
[ https://issues.apache.org/jira/browse/KAFKA-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155720#comment-15155720 ] Frank Scholten commented on KAFKA-3255: --- Done https://github.com/apache/kafka/pull/941 > Extra unit tests for NetworkClient.connectionDelay(Node node, long now) > --- > > Key: KAFKA-3255 > URL: https://issues.apache.org/jira/browse/KAFKA-3255 > Project: Kafka > Issue Type: Test > Components: core >Affects Versions: 0.9.0.1 >Reporter: Frank Scholten >Priority: Trivial > Labels: test > Fix For: 0.9.1.0 > > Attachments: KAFKA-3255.patch > > > I am exploring the Kafka codebase and noticed that this method was not > covered so I added some tests. Also saw that the method isConnecting is not > used anywhere in the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Issue Comment Deleted] (KAFKA-3255) Extra unit tests for NetworkClient.connectionDelay(Node node, long now)
[ https://issues.apache.org/jira/browse/KAFKA-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Frank Scholten updated KAFKA-3255: -- Comment: was deleted (was: Done https://github.com/apache/kafka/pull/941) > Extra unit tests for NetworkClient.connectionDelay(Node node, long now) > --- > > Key: KAFKA-3255 > URL: https://issues.apache.org/jira/browse/KAFKA-3255 > Project: Kafka > Issue Type: Test > Components: core >Affects Versions: 0.9.0.1 >Reporter: Frank Scholten >Priority: Trivial > Labels: test > Fix For: 0.9.1.0 > > Attachments: KAFKA-3255.patch > > > I am exploring the Kafka codebase and noticed that this method was not > covered so I added some tests. Also saw that the method isConnecting is not > used anywhere in the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-3255) Extra unit tests for NetworkClient.connectionDelay(Node node, long now)
[ https://issues.apache.org/jira/browse/KAFKA-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155719#comment-15155719 ] ASF GitHub Bot commented on KAFKA-3255: --- GitHub user frankscholten opened a pull request: https://github.com/apache/kafka/pull/941 KAFKA-3255 Added unit tests for NetworkClient.connectionDelay(Node node, long now) You can merge this pull request into a Git repository by running: $ git pull https://github.com/frankscholten/kafka tests/cluster-connection-states Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/941.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #941 > Extra unit tests for NetworkClient.connectionDelay(Node node, long now) > --- > > Key: KAFKA-3255 > URL: https://issues.apache.org/jira/browse/KAFKA-3255 > Project: Kafka > Issue Type: Test > Components: core >Affects Versions: 0.9.0.1 >Reporter: Frank Scholten >Priority: Trivial > Labels: test > Fix For: 0.9.1.0 > > Attachments: KAFKA-3255.patch > > > I am exploring the Kafka codebase and noticed that this method was not > covered so I added some tests. Also saw that the method isConnecting is not > used anywhere in the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] kafka pull request: KAFKA-3255 Added unit tests for NetworkClient....
GitHub user frankscholten opened a pull request: https://github.com/apache/kafka/pull/941 KAFKA-3255 Added unit tests for NetworkClient.connectionDelay(Node node, long now) You can merge this pull request into a Git repository by running: $ git pull https://github.com/frankscholten/kafka tests/cluster-connection-states Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/941.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #941 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (KAFKA-3255) Extra unit tests for NetworkClient.connectionDelay(Node node, long now)
[ https://issues.apache.org/jira/browse/KAFKA-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155707#comment-15155707 ] Ismael Juma commented on KAFKA-3255: Thanks for the patch. Would you consider submitting a pull request as per the following? https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes > Extra unit tests for NetworkClient.connectionDelay(Node node, long now) > --- > > Key: KAFKA-3255 > URL: https://issues.apache.org/jira/browse/KAFKA-3255 > Project: Kafka > Issue Type: Test > Components: core >Affects Versions: 0.9.0.1 >Reporter: Frank Scholten >Priority: Trivial > Labels: test > Fix For: 0.9.1.0 > > Attachments: KAFKA-3255.patch > > > I am exploring the Kafka codebase and noticed that this method was not > covered so I added some tests. Also saw that the method isConnecting is not > used anywhere in the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-3255) Extra unit tests for NetworkClient.connectionDelay(Node node, long now)
[ https://issues.apache.org/jira/browse/KAFKA-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-3255: --- Fix Version/s: (was: 0.9.0.1) 0.9.1.0 > Extra unit tests for NetworkClient.connectionDelay(Node node, long now) > --- > > Key: KAFKA-3255 > URL: https://issues.apache.org/jira/browse/KAFKA-3255 > Project: Kafka > Issue Type: Test > Components: core >Affects Versions: 0.9.0.1 >Reporter: Frank Scholten >Priority: Trivial > Labels: test > Fix For: 0.9.1.0 > > Attachments: KAFKA-3255.patch > > > I am exploring the Kafka codebase and noticed that this method was not > covered so I added some tests. Also saw that the method isConnecting is not > used anywhere in the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-3255) Extra unit tests for NetworkClient.connectionDelay(Node node, long now)
[ https://issues.apache.org/jira/browse/KAFKA-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Frank Scholten updated KAFKA-3255: -- Labels: test (was: ) Fix Version/s: 0.9.0.1 Status: Patch Available (was: Open) > Extra unit tests for NetworkClient.connectionDelay(Node node, long now) > --- > > Key: KAFKA-3255 > URL: https://issues.apache.org/jira/browse/KAFKA-3255 > Project: Kafka > Issue Type: Test > Components: core >Affects Versions: 0.9.0.1 >Reporter: Frank Scholten >Priority: Trivial > Labels: test > Fix For: 0.9.0.1 > > Attachments: KAFKA-3255.patch > > > I am exploring the Kafka codebase and noticed that this method was not > covered so I added some tests. Also saw that the method isConnecting is not > used anywhere in the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (KAFKA-3255) Extra unit tests for NetworkClient.connectionDelay(Node node, long now)
Frank Scholten created KAFKA-3255: - Summary: Extra unit tests for NetworkClient.connectionDelay(Node node, long now) Key: KAFKA-3255 URL: https://issues.apache.org/jira/browse/KAFKA-3255 Project: Kafka Issue Type: Test Components: core Affects Versions: 0.9.0.1 Reporter: Frank Scholten Priority: Trivial Attachments: KAFKA-3255.patch I am exploring the Kafka codebase and noticed that this method was not covered so I added some tests. Also saw that the method isConnecting is not used anywhere in the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-3255) Extra unit tests for NetworkClient.connectionDelay(Node node, long now)
[ https://issues.apache.org/jira/browse/KAFKA-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Frank Scholten updated KAFKA-3255: -- Attachment: KAFKA-3255.patch > Extra unit tests for NetworkClient.connectionDelay(Node node, long now) > --- > > Key: KAFKA-3255 > URL: https://issues.apache.org/jira/browse/KAFKA-3255 > Project: Kafka > Issue Type: Test > Components: core >Affects Versions: 0.9.0.1 >Reporter: Frank Scholten >Priority: Trivial > Attachments: KAFKA-3255.patch > > > I am exploring the Kafka codebase and noticed that this method was not > covered so I added some tests. Also saw that the method isConnecting is not > used anywhere in the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] kafka pull request: MINOR: Example style improvements
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/940 MINOR: Example style improvements These are minor, but no reason to make our example code look worse than it has to. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka example-style-improvements Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/940.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #940 commit c45b14400ca9a0a6d22ef5cb6266349aa6c62c71 Author: Ismael JumaDate: 2016-02-20T09:43:04Z Example style improvements These are minor, but no reason to make our example code look worse than it has to. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---