Re: [VOTE] 3.2.1 RC3

[Federico Valeri]

gpg: Good signature from "David Arthur (CODE SIGNING KEY)
" [unknown]

/tmp/tmp.lRpAY/kafka-3.2.1-src.tgz.sha512: OK

Build using Gradle 7.3.3, Java 11 and Scala 2.13.8
BUILD SUCCESSFUL in 5m 34s

Unit and integration tests:
BUILD SUCCESSFUL in 37m 47s

I also used Scala 2.13 binaries and staged Maven artifacts to run some
client applications.

+1 (non binding)

Thanks


On Fri, Jul 22, 2022 at 4:21 PM Christopher Shannon
 wrote:
>
> +1 (non binding)
>
> I built from source and ran through some of the tests including all the
> connect runtime tests. I verified that KAFKA-14079 was included and the fix
> looked good in my tests.
>
> On Thu, Jul 21, 2022 at 9:15 PM David Arthur  wrote:
>
> > Hello Kafka users, developers and client-developers,
> >
> > This is the first release candidate of Apache Kafka 3.2.1.
> >
> > This is a bugfix release with several fixes since the release of 3.2.0. A
> > few of the major issues include:
> >
> > * KAFKA-14062 OAuth client token refresh fails with SASL extensions
> > * KAFKA-14079 Memory leak in connectors using errors.tolerance=all
> > * KAFKA-14024 Cooperative rebalance regression causing clients to get stuck
> >
> >
> > Release notes for the 3.2.1 release:
> > https://home.apache.org/~davidarthur/kafka-3.2.1-rc3/RELEASE_NOTES.html
> >
> >
> >
> >  Please download, test and vote by Wednesday July 27, 2022 at 17:00 PT.
> > 
> > Kafka's KEYS file containing PGP keys we use to sign the release:
> > https://kafka.apache.org/KEYS
> >
> > Release artifacts to be voted upon (source and binary):
> > https://home.apache.org/~davidarthur/kafka-3.2.1-rc3/
> >
> > Maven artifacts to be voted upon:
> > https://repository.apache.org/content/groups/staging/org/apache/kafka/
> >
> > Javadoc: https://home.apache.org/~davidarthur/kafka-3.2.1-rc3/javadoc/
> >
> > Tag to be voted upon (off 3.2 branch) is the 3.2.1 tag:
> > https://github.com/apache/kafka/releases/tag/3.2.1-rc3
> >
> > Documentation: https://kafka.apache.org/32/documentation.html
> >
> > Protocol: https://kafka.apache.org/32/protocol.html
> >
> >
> > The past few builds have had flaky test failures. I will update this thread
> > with passing build links soon.
> >
> > Unit/Integration test job:
> > https://ci-builds.apache.org/job/Kafka/job/kafka/job/3.2/
> > System test job:
> > https://jenkins.confluent.io/job/system-test-kafka/job/3.2/
> >
> >
> > Thanks!
> > David Arthur
> >

[jira] [Created] (KAFKA-14099) No REST API request logs in Kafka connect

[Alexandre Garnier (Jira)]

Alexandre Garnier created KAFKA-14099:
-

 Summary: No REST API request logs in Kafka connect
 Key: KAFKA-14099
 URL: https://issues.apache.org/jira/browse/KAFKA-14099
 Project: Kafka
  Issue Type: Bug
  Components: KafkaConnect
Affects Versions: 3.2.0
Reporter: Alexandre Garnier


Prior to 2.2.1, when an REST API request was performed, there was a request log 
in the log file:
{code}
[2022-07-23 07:18:16,128] INFO 172.18.0.1 - - [23/Jul/2022:07:18:16 +] "GET 
/connectors HTTP/1.1" 200 2 "-" "curl/7.81.0" 66 
(org.apache.kafka.connect.runtime.rest.RestServer:62)
{code}
 

With a bisect, I found the problem comes from [PR 
6651|https://github.com/apache/kafka/pull/6651] to fix KAFKA-8304

>From what I understand of the problem, the ContextHandlerCollection is added 
>in the Server 
>(https://github.com/dongjinleekr/kafka/blob/63a6130af30536d67fca5802005695a84c875b5e/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestServer.java#L195)
> before handlers are really added in the ContextHandlerCollection 
>(https://github.com/dongjinleekr/kafka/blob/63a6130af30536d67fca5802005695a84c875b5e/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestServer.java#L296).
I don't know the impact on other handlers, but clearly it doesn't work for the 
RequestLogHandler

A solution I found for the logging issue is to set the RequestLog directly in 
the server without using an handlers:

{code}
diff --git 
i/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestServer.java
 
w/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestServer.java
index ab18419efc..4d09cc0e6c 100644
--- 
i/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestServer.java
+++ 
w/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestServer.java
@@ -187,6 +187,11 @@ public class RestServer {
 public void initializeServer() {
 log.info("Initializing REST server");
 
+Slf4jRequestLogWriter slf4jRequestLogWriter = new 
Slf4jRequestLogWriter();
+
slf4jRequestLogWriter.setLoggerName(RestServer.class.getCanonicalName());
+CustomRequestLog requestLog = new 
CustomRequestLog(slf4jRequestLogWriter, CustomRequestLog.EXTENDED_NCSA_FORMAT + 
" %{ms}T");
+jettyServer.setRequestLog(requestLog);
+
 /* Needed for graceful shutdown as per `setStopTimeout` documentation 
*/
 StatisticsHandler statsHandler = new StatisticsHandler();
 statsHandler.setHandler(handlers);
@@ -275,14 +280,7 @@ public class RestServer {
 configureHttpResponsHeaderFilter(context);
 }
 
-RequestLogHandler requestLogHandler = new RequestLogHandler();
-Slf4jRequestLogWriter slf4jRequestLogWriter = new 
Slf4jRequestLogWriter();
-
slf4jRequestLogWriter.setLoggerName(RestServer.class.getCanonicalName());
-CustomRequestLog requestLog = new 
CustomRequestLog(slf4jRequestLogWriter, CustomRequestLog.EXTENDED_NCSA_FORMAT + 
" %{ms}T");
-requestLogHandler.setRequestLog(requestLog);
-
 contextHandlers.add(new DefaultHandler());
-contextHandlers.add(requestLogHandler);
 
 handlers.setHandlers(contextHandlers.toArray(new Handler[0]));
 try {
{code}

Same issue raised on StackOverflow: 
https://stackoverflow.com/questions/67699702/no-rest-api-logs-in-kafka-connect



--
This message was sent by Atlassian Jira
(v8.20.10#820010)