[jira] [Created] (KAFKA-17765) Remove TestUtils.toSet
Chia-Ping Tsai created KAFKA-17765: -- Summary: Remove TestUtils.toSet Key: KAFKA-17765 URL: https://issues.apache.org/jira/browse/KAFKA-17765 Project: Kafka Issue Type: Sub-task Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai It can be replaced by either `Set.of` or `Set.copyOf` -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17760) Remove client instance from cache when received telemetry terminating request
[ https://issues.apache.org/jira/browse/KAFKA-17760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17760. Resolution: Won't Fix Thanks for all discussion! > Remove client instance from cache when received telemetry terminating request > - > > Key: KAFKA-17760 > URL: https://issues.apache.org/jira/browse/KAFKA-17760 > Project: Kafka > Issue Type: Improvement >Reporter: Apoorv Mittal >Assignee: Apoorv Mittal >Priority: Major > > https://github.com/apache/kafka/pull/17431#pullrequestreview-2359513693 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17763) Remove Utils.covariantCast
Chia-Ping Tsai created KAFKA-17763: -- Summary: Remove Utils.covariantCast Key: KAFKA-17763 URL: https://issues.apache.org/jira/browse/KAFKA-17763 Project: Kafka Issue Type: Sub-task Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai we can use `var` to replace casting. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17762) Remove Utils.isBlank
Chia-Ping Tsai created KAFKA-17762: -- Summary: Remove Utils.isBlank Key: KAFKA-17762 URL: https://issues.apache.org/jira/browse/KAFKA-17762 Project: Kafka Issue Type: Sub-task Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai Replace it by `String#isBlank` -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17758) Remove Utils.mkMap and Utils.mkEntry
Chia-Ping Tsai created KAFKA-17758: -- Summary: Remove Utils.mkMap and Utils.mkEntry Key: KAFKA-17758 URL: https://issues.apache.org/jira/browse/KAFKA-17758 Project: Kafka Issue Type: Sub-task Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai They can be replaced by Map.entry and Map.ofEntries -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17757) cleanup code case under JDK 11
Chia-Ping Tsai created KAFKA-17757: -- Summary: cleanup code case under JDK 11 Key: KAFKA-17757 URL: https://issues.apache.org/jira/browse/KAFKA-17757 Project: Kafka Issue Type: Improvement Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai We can leverage Java 11 features instead of relying on many small utility functions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17739) Clean up build.gradle to adopt the minimum Java version as 11.
[ https://issues.apache.org/jira/browse/KAFKA-17739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17739. Fix Version/s: 4.0.0 Resolution: Fixed > Clean up build.gradle to adopt the minimum Java version as 11. > -- > > Key: KAFKA-17739 > URL: https://issues.apache.org/jira/browse/KAFKA-17739 > Project: Kafka > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: TengYao Chi >Priority: Minor > Fix For: 4.0.0 > > > 1. minJavaVersion=11 > 2. remove sourceCompatibility and targetCompatibility > 3. cleanup all compatibility checks -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17384) Remove deprecated options in tools
[ https://issues.apache.org/jira/browse/KAFKA-17384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17384. Fix Version/s: 4.0.0 Resolution: Fixed > Remove deprecated options in tools > -- > > Key: KAFKA-17384 > URL: https://issues.apache.org/jira/browse/KAFKA-17384 > Project: Kafka > Issue Type: Improvement >Reporter: PoAn Yang >Assignee: PoAn Yang >Priority: Minor > Fix For: 4.0.0 > > > There're deprecated options in following tools. We can consider to remove > them in 4.0. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17387) Remove broker-list in VerifiableConsumer
[ https://issues.apache.org/jira/browse/KAFKA-17387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17387. Fix Version/s: 4.0.0 Resolution: Fixed > Remove broker-list in VerifiableConsumer > > > Key: KAFKA-17387 > URL: https://issues.apache.org/jira/browse/KAFKA-17387 > Project: Kafka > Issue Type: Sub-task >Reporter: PoAn Yang >Assignee: PoAn Yang >Priority: Minor > Fix For: 4.0.0 > > > The > [broker-list|https://github.com/apache/kafka/blob/944c1353a925858ea9bd9024a713cd7301f55133/tools/src/main/java/org/apache/kafka/tools/VerifiableConsumer.java#L522-L528] > is deprecated option in VerifiableConsumer. We can consider to remove it in > 4.0. > https://cwiki.apache.org/confluence/display/KAFKA/KIP-499+-+Unify+connection+name+flag+for+command+line+tool -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17738) upgrade base image from jdk8 to jdk11
[ https://issues.apache.org/jira/browse/KAFKA-17738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17738. Fix Version/s: 4.0.0 Resolution: Fixed > upgrade base image from jdk8 to jdk11 > - > > Key: KAFKA-17738 > URL: https://issues.apache.org/jira/browse/KAFKA-17738 > Project: Kafka > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Jhen Yung Hsu >Priority: Major > Fix For: 4.0.0 > > > as title -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17737) E2E tests need to drop Kafka versions prior to 1.0.0
[ https://issues.apache.org/jira/browse/KAFKA-17737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17737. Fix Version/s: 4.0.0 Resolution: Fixed > E2E tests need to drop Kafka versions prior to 1.0.0 > > > Key: KAFKA-17737 > URL: https://issues.apache.org/jira/browse/KAFKA-17737 > Project: Kafka > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Jhen Yung Hsu >Priority: Major > Fix For: 4.0.0 > > > There are three reasons for removing older Kafka versions from the > compatibility tests: > 1. Kafka versions prior to 1.0.0 can't run under JDK 11 (KAFKA-5076). > 2. The old protocol will be removed by KAFKA-16096. > 3. The base image needs to be upgraded to JDK 11, as JDK 8 will be dropped > (KAFKA-12894)." > The following E2E tests need to drop Kafka versions prior to 1.0.0. > 1. tests/kafkatest/tests/streams/streams_broker_compatibility_test.py > 2. tests/kafkatest/tests/client/client_compatibility_produce_consume_test.py > 3. tests/kafkatest/tests/client/client_compatibility_features_test.py > 4. > tests/kafkatest/tests/connect/connect_distributed_test.py::ConnectDistributedTest.test_broker_compatibility > Please note that this JIRA only removes broker-related tests. the old client > code can still run under JDK 11 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-16896) upgrade spotless version after we drop JDK8
[ https://issues.apache.org/jira/browse/KAFKA-16896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16896. Resolution: Fixed > upgrade spotless version after we drop JDK8 > --- > > Key: KAFKA-16896 > URL: https://issues.apache.org/jira/browse/KAFKA-16896 > Project: Kafka > Issue Type: Sub-task > Components: build >Affects Versions: 3.7.0 >Reporter: xuanzhang gong >Assignee: 黃竣陽 >Priority: Major > Fix For: 4.0.0 > > > we import spotless plugin in order to unify Kafka code style. > Spotless version > 6.14- support JDK8 > 6.15.0+ require JDK11 > 6.23.3+ support JDK 21 but build error in JDK 8 even though we apply false in > plugin block. > We couldn't find a suitable way to be compatible with all versions. > So far, here's how we do it: use 6.14.0 version, compatibility JDK8 , skip > JDK21. > We will upgrade spotless version to the latest when kafka drop support JDK8 > and drop CI in JDK8 > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17741) cleanup code base for JDK 11
Chia-Ping Tsai created KAFKA-17741: -- Summary: cleanup code base for JDK 11 Key: KAFKA-17741 URL: https://issues.apache.org/jira/browse/KAFKA-17741 Project: Kafka Issue Type: Sub-task Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai 1. `KafkaCompletableFuture` has many override methods from java 9, and they all need `@Override`annotation 2. remove `IS_JAVA9_COMPATIBLE` and `IS_JAVA11_COMPATIBLE` -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17740) Update Readme and documentation
Chia-Ping Tsai created KAFKA-17740: -- Summary: Update Readme and documentation Key: KAFKA-17740 URL: https://issues.apache.org/jira/browse/KAFKA-17740 Project: Kafka Issue Type: Sub-task Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai Update Readme and documentation (including the downloads page) not to mention Java 8 as a supported version. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17739) Clean up build.gradle to adopt the minimum Java version as 11.
Chia-Ping Tsai created KAFKA-17739: -- Summary: Clean up build.gradle to adopt the minimum Java version as 11. Key: KAFKA-17739 URL: https://issues.apache.org/jira/browse/KAFKA-17739 Project: Kafka Issue Type: Sub-task Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai 1. minJavaVersion=11 2. remove sourceCompatibility and targetCompatibility 3. cleanup all compatibility checks -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17738) upgrade base image from jdk8 to jdk11
Chia-Ping Tsai created KAFKA-17738: -- Summary: upgrade base image from jdk8 to jdk11 Key: KAFKA-17738 URL: https://issues.apache.org/jira/browse/KAFKA-17738 Project: Kafka Issue Type: Sub-task Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai as title -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17737) E2E tests need to drop Kafka versions prior to 1.0.0
Chia-Ping Tsai created KAFKA-17737: -- Summary: E2E tests need to drop Kafka versions prior to 1.0.0 Key: KAFKA-17737 URL: https://issues.apache.org/jira/browse/KAFKA-17737 Project: Kafka Issue Type: Sub-task Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai There are three reasons for removing older Kafka versions from the compatibility tests: 1. Kafka versions prior to 1.0.0 can't run under JDK 11 (KAFKA-5076). 2. The old protocol will be removed by KAFKA-16096. 3. The base image needs to be upgraded to JDK 11, as JDK 8 will be dropped (KAFKA-12894)." The following E2E tests need to drop Kafka versions prior to 1.0.0. 1. tests/kafkatest/tests/streams/streams_broker_compatibility_test.py 2. tests/kafkatest/tests/client/client_compatibility_produce_consume_test.py 3. tests/kafkatest/tests/client/client_compatibility_features_test.py 4. tests/kafkatest/tests/connect/connect_distributed_test.py::ConnectDistributedTest.test_broker_compatibility Please note that this JIRA only removes broker-related tests. the old client code can still run under JDK 11 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17736) Revisit all JMH
Chia-Ping Tsai created KAFKA-17736: -- Summary: Revisit all JMH Key: KAFKA-17736 URL: https://issues.apache.org/jira/browse/KAFKA-17736 Project: Kafka Issue Type: Bug Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai JMH code lacks tests, so it may become outdated or, worse, fail to run, as seen in KAFKA-17730. This JIRA is meant to demonstrate that we do care about maintaining JMH. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17729) Remove ZooKeeper from jmh-benchmarks
[ https://issues.apache.org/jira/browse/KAFKA-17729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17729. Fix Version/s: 4.0.0 Assignee: Mickael Maison Resolution: Fixed > Remove ZooKeeper from jmh-benchmarks > > > Key: KAFKA-17729 > URL: https://issues.apache.org/jira/browse/KAFKA-17729 > Project: Kafka > Issue Type: Sub-task >Reporter: Mickael Maison >Assignee: Mickael Maison >Priority: Major > Fix For: 4.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17655) add example of changing the e2e image name
[
https://issues.apache.org/jira/browse/KAFKA-17655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-17655.
Fix Version/s: 4.0.0
Resolution: Fixed
> add example of changing the e2e image name
> --
>
> Key: KAFKA-17655
> URL: https://issues.apache.org/jira/browse/KAFKA-17655
> Project: Kafka
> Issue Type: Improvement
>Reporter: Chia-Ping Tsai
>Assignee: kangning.li
>Priority: Major
> Fix For: 4.0.0
>
>
> The default Docker image name used by E2E is {{{}ducker-ak-openjdk-8{}}}.
> When switching to a different branch to run E2E tests, Docker may rebuild the
> image due to changes in the Dockerfile. We should include an example to
> remind developers that they can override the image name by setting the
> "image_name" environment variable. This allows using different names for each
> branch to prevent unnecessary rebuilding.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (KAFKA-17718) build code with JDK 17
[ https://issues.apache.org/jira/browse/KAFKA-17718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17718. Resolution: Won't Fix the issue will be fixed by KAFKA-16896 > build code with JDK 17 > -- > > Key: KAFKA-17718 > URL: https://issues.apache.org/jira/browse/KAFKA-17718 > Project: Kafka > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: Ming-Yen Chung >Priority: Major > > JDK 21 does not run the spotless check because the version of the spotless > plugin we are using doesn't support JDK 21. KAFKA-16896 will update the > plugin to support JDK 21 once JDK 8 is removed. > To avoid spotless errors, we should temporarily run the build with JDK 17. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17720) Remove zookeeper_migration_test.py
[ https://issues.apache.org/jira/browse/KAFKA-17720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17720. Fix Version/s: 4.0.0 Resolution: Fixed > Remove zookeeper_migration_test.py > -- > > Key: KAFKA-17720 > URL: https://issues.apache.org/jira/browse/KAFKA-17720 > Project: Kafka > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Ming-Yen Chung >Priority: Minor > Fix For: 4.0.0 > > > The related code are removed so `zookeeper_migration_test.py` is definitely > failed on trunk -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-15907) Remove previously deprecated Consumer features from 4.0
[ https://issues.apache.org/jira/browse/KAFKA-15907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-15907. Resolution: Fixed > Remove previously deprecated Consumer features from 4.0 > --- > > Key: KAFKA-15907 > URL: https://issues.apache.org/jira/browse/KAFKA-15907 > Project: Kafka > Issue Type: Task > Components: clients, consumer >Reporter: Kirk True >Priority: Major > Fix For: 4.0.0 > > > This Jira serves as the main collection of APIs, logic, etc. that were > previously marked as "deprecated" by other KIPs. With 4.0, we will be > updating the code to remove the deprecated features. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-15908) Remove deprecated Consumer API poll(long timeout)
[
https://issues.apache.org/jira/browse/KAFKA-15908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-15908.
Resolution: Fixed
> Remove deprecated Consumer API poll(long timeout)
> -
>
> Key: KAFKA-15908
> URL: https://issues.apache.org/jira/browse/KAFKA-15908
> Project: Kafka
> Issue Type: Sub-task
> Components: clients, consumer
>Reporter: Kirk True
>Assignee: Andrew Schofield
>Priority: Critical
> Labels: consumer-threading-refactor, timeout
> Fix For: 4.0.0
>
>
> Per
> [KIP-266|https://cwiki.apache.org/confluence/display/KAFKA/KIP-266%3A+Fix+consumer+indefinite+blocking+behavior],
> the {{Consumer.poll(long timeout)}} method was deprecated back in 2.0.0.
> In 3.7, there are two implementations, each with different behavior:
> * The {{LegacyKafkaConsumer}} implementation will continue to work but will
> log a warning about its removal
> * The {{AsyncKafkaConsumer}} implementation will throw an error.
> In 4.0, the `poll` method that takes a single `long` timeout will be removed
> altogether.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (KAFKA-17723) add @SuppressWarnings("this-escape") to MultiThreadedEventProcessor and DistributedHerder
Chia-Ping Tsai created KAFKA-17723:
--
Summary: add @SuppressWarnings("this-escape") to
MultiThreadedEventProcessor and DistributedHerder
Key: KAFKA-17723
URL: https://issues.apache.org/jira/browse/KAFKA-17723
Project: Kafka
Issue Type: Improvement
Reporter: Chia-Ping Tsai
Assignee: Chia-Ping Tsai
{code:java}
> Task :coordinator-common:compileJava FAILED
/root/kafka/coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/MultiThreadedEventProcessor.java:107:
warning: [this-escape] possible 'this' escape before subclass is fully
initialized
this.threads = IntStream.range(0, numThreads).mapToObj(threadId ->
^
error: warnings found and -Werror specified
{code}
{code:java}
> Task :connect:runtime:compileJava
/root/kafka/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:269:
warning: [this-escape] possible 'this' escape before subclass is fully
initialized
this(config, worker, worker.workerId(), kafkaClusterId,
statusBackingStore, configBackingStore, null, restUrl, restClient,
worker.metrics(),
^
/root/kafka/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:318:
warning: [this-escape] previous possible 'this' escape happens here via
invocation
new RebalanceListener(time), time, clientId,
logContext);
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (KAFKA-17722) Fix 'this' escape of BrokerTopicMetrics
Chia-Ping Tsai created KAFKA-17722:
--
Summary: Fix 'this' escape of BrokerTopicMetrics
Key: KAFKA-17722
URL: https://issues.apache.org/jira/browse/KAFKA-17722
Project: Kafka
Issue Type: Improvement
Reporter: Chia-Ping Tsai
Assignee: Chia-Ping Tsai
{code:java}
> Task :storage:compileJava FAILED
/root/kafka/storage/src/main/java/org/apache/kafka/storage/log/metrics/BrokerTopicMetrics.java:62:
warning: [this-escape] possible 'this' escape before subclass is fully
initialized
this(Optional.empty(), remoteStorageEnabled);
^
/root/kafka/storage/src/main/java/org/apache/kafka/storage/log/metrics/BrokerTopicMetrics.java:106:
warning: [this-escape] previous possible 'this' escape happens here via
invocation
metricGaugeTypeMap.put(RemoteStorageMetrics.REMOTE_COPY_LAG_BYTES_METRIC.getName(),
new GaugeWrapper(RemoteStorageMetrics.REMOTE_COPY_LAG_BYTES_METRIC.getName()));
^
/root/kafka/storage/src/main/java/org/apache/kafka/storage/log/metrics/BrokerTopicMetrics.java:66:
warning: [this-escape] possible 'this' escape before subclass is fully
initialized
this(Optional.of(name), remoteStorageEnabled);
^
/root/kafka/storage/src/main/java/org/apache/kafka/storage/log/metrics/BrokerTopicMetrics.java:106:
warning: [this-escape] previous possible 'this' escape happens here via
invocation
metricGaugeTypeMap.put(RemoteStorageMetrics.REMOTE_COPY_LAG_BYTES_METRIC.getName(),
new GaugeWrapper(RemoteStorageMetrics.REMOTE_COPY_LAG_BYTES_METRIC.getName()));
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (KAFKA-17721) Enable to configure listener name and protocol for controller
Chia-Ping Tsai created KAFKA-17721: -- Summary: Enable to configure listener name and protocol for controller Key: KAFKA-17721 URL: https://issues.apache.org/jira/browse/KAFKA-17721 Project: Kafka Issue Type: Sub-task Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai this is the follow-up of KAFKA-17256 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17720) Remove zookeeper_migration_test.py
Chia-Ping Tsai created KAFKA-17720: -- Summary: Remove zookeeper_migration_test.py Key: KAFKA-17720 URL: https://issues.apache.org/jira/browse/KAFKA-17720 Project: Kafka Issue Type: Sub-task Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai The related code are removed so `zookeeper_migration_test.py` is definitely failed on trunk -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17718) build code with JDK 17
Chia-Ping Tsai created KAFKA-17718: -- Summary: build code with JDK 17 Key: KAFKA-17718 URL: https://issues.apache.org/jira/browse/KAFKA-17718 Project: Kafka Issue Type: Improvement Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai JDK 21 does not run the spotless check because the version of the spotless plugin we are using doesn't support JDK 21. KAFKA-16896 will update the plugin to support JDK 21 once JDK 8 is removed. To avoid spotless errors, we should temporarily run the build with JDK 17. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17717) Remove ConfigUtils#translateDeprecatedConfigs
Chia-Ping Tsai created KAFKA-17717: -- Summary: Remove ConfigUtils#translateDeprecatedConfigs Key: KAFKA-17717 URL: https://issues.apache.org/jira/browse/KAFKA-17717 Project: Kafka Issue Type: Improvement Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai They are no longer needed. We can always retrieve them via Git if new deprecated configs are introduced in the future. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17714) Fix StorageToolTest.scala to compile under Scala 2.12
[ https://issues.apache.org/jira/browse/KAFKA-17714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17714. Resolution: Fixed > Fix StorageToolTest.scala to compile under Scala 2.12 > - > > Key: KAFKA-17714 > URL: https://issues.apache.org/jira/browse/KAFKA-17714 > Project: Kafka > Issue Type: Bug >Affects Versions: 3.9.0 >Reporter: Colin McCabe >Assignee: Colin McCabe >Priority: Blocker > Fix For: 3.9.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17716) remove junit-platform.properties
[ https://issues.apache.org/jira/browse/KAFKA-17716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17716. Resolution: Won't Fix > remove junit-platform.properties > > > Key: KAFKA-17716 > URL: https://issues.apache.org/jira/browse/KAFKA-17716 > Project: Kafka > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Major > > see https://github.com/apache/kafka/pull/17399#pullrequestreview-2353108773 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17716) remove junit-platform.properties
Chia-Ping Tsai created KAFKA-17716: -- Summary: remove junit-platform.properties Key: KAFKA-17716 URL: https://issues.apache.org/jira/browse/KAFKA-17716 Project: Kafka Issue Type: Sub-task Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai see https://github.com/apache/kafka/pull/17399#pullrequestreview-2353108773 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17715) Remove `force_use_zk_connection` from e2e
Chia-Ping Tsai created KAFKA-17715: -- Summary: Remove `force_use_zk_connection` from e2e Key: KAFKA-17715 URL: https://issues.apache.org/jira/browse/KAFKA-17715 Project: Kafka Issue Type: Sub-task Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai Since no E2E tests are using the argument, we should remove it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17624) Remove the E2E uses of accessing ACLs from zk
[ https://issues.apache.org/jira/browse/KAFKA-17624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17624. Fix Version/s: 4.0.0 Resolution: Fixed > Remove the E2E uses of accessing ACLs from zk > - > > Key: KAFKA-17624 > URL: https://issues.apache.org/jira/browse/KAFKA-17624 > Project: Kafka > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: TengYao Chi >Priority: Major > Fix For: 4.0.0 > > > To remove ZooKeeper code from AclCommand, we first need to remove the related > system tests. This task should remove zookeeper.py#list_acls and its usages, > including zookeeper_tls_test.py, zookeeper_tls_encrypt_only_test.py, > zookeeper_security_upgrade_test.py, `test_rolling_upgrade_phase_two`, > `test_rolling_upgrade_sasl_mechanism_phase_two`, and > upgrade_test.py#perform_upgrade. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17707) Remove zk from BaseConsumerTest
[
https://issues.apache.org/jira/browse/KAFKA-17707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-17707.
Fix Version/s: 4.0.0
Resolution: Fixed
> Remove zk from BaseConsumerTest
> ---
>
> Key: KAFKA-17707
> URL: https://issues.apache.org/jira/browse/KAFKA-17707
> Project: Kafka
> Issue Type: Sub-task
>Reporter: PoAn Yang
>Assignee: PoAn Yang
>Priority: Major
> Fix For: 4.0.0
>
>
> Remove {{{}Arguments.of("zk", "classic"){}}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (KAFKA-17564) Move BrokerFeatures to server module
[ https://issues.apache.org/jira/browse/KAFKA-17564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17564. Fix Version/s: 4.0.0 Resolution: Fixed > Move BrokerFeatures to server module > > > Key: KAFKA-17564 > URL: https://issues.apache.org/jira/browse/KAFKA-17564 > Project: Kafka > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: 黃竣陽 >Priority: Major > Fix For: 4.0.0 > > > as title -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17695) cleanup org.apache.kafka.common.test.TestUtils
[ https://issues.apache.org/jira/browse/KAFKA-17695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17695. Fix Version/s: 4.0.0 Resolution: Fixed > cleanup org.apache.kafka.common.test.TestUtils > -- > > Key: KAFKA-17695 > URL: https://issues.apache.org/jira/browse/KAFKA-17695 > Project: Kafka > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: 黃竣陽 >Priority: Minor > Fix For: 4.0.0 > > > It is copied from client module, so there are many unused code. Also, the > method should not be exposed publicly. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17529) Remove blacklist from MM2
[ https://issues.apache.org/jira/browse/KAFKA-17529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17529. Fix Version/s: 4.0.0 Resolution: Fixed > Remove blacklist from MM2 > - > > Key: KAFKA-17529 > URL: https://issues.apache.org/jira/browse/KAFKA-17529 > Project: Kafka > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Chia-Chuan Yu >Priority: Major > Fix For: 4.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17692) Remove KafkaServer references in streams tests
[ https://issues.apache.org/jira/browse/KAFKA-17692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17692. Fix Version/s: 4.0.0 Resolution: Fixed > Remove KafkaServer references in streams tests > -- > > Key: KAFKA-17692 > URL: https://issues.apache.org/jira/browse/KAFKA-17692 > Project: Kafka > Issue Type: Sub-task >Reporter: Mickael Maison >Assignee: Mickael Maison >Priority: Major > Fix For: 4.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17415) Avoid overflow of expiried timestamp
[ https://issues.apache.org/jira/browse/KAFKA-17415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17415. Resolution: Fixed > Avoid overflow of expiried timestamp > > > Key: KAFKA-17415 > URL: https://issues.apache.org/jira/browse/KAFKA-17415 > Project: Kafka > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: TengYao Chi >Priority: Major > Fix For: 4.0.0 > > > Both of zk and kraft modes do not handle the overflow, and hence setting a > large max life time will cause a negative expired timestamp and negative max > timestamp. That is unexpected behavior. > [0] > [https://github.com/apache/kafka/blob/0123bdcf06d2554ea62ba3a75af7c4b17eb4d23a/metadata/src/main/java/org/apache/kafka/controller/DelegationTokenControlManager.java#L191|https://github.com/apache/kafka/blob/4e846038a6313e28d3b3ee3d3c3163d1f26356bf/metadata/src/main/java/org/apache/kafka/controller/DelegationTokenControlManager.java#L188] > [1] > [https://github.com/apache/kafka/blob/0123bdcf06d2554ea62ba3a75af7c4b17eb4d23a/core/src/main/scala/kafka/server/DelegationTokenManagerZk.scala#L182|https://github.com/apache/kafka/blob/0123bdcf06d2554ea62ba3a75af7c4b17eb4d23a/core/src/main/scala/kafka/server/DelegationTokenManagerZk.scala#L297] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17709) remove retry_zinc
Chia-Ping Tsai created KAFKA-17709: -- Summary: remove retry_zinc Key: KAFKA-17709 URL: https://issues.apache.org/jira/browse/KAFKA-17709 Project: Kafka Issue Type: Improvement Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai The Jenkins CI was removed in [this commit|https://github.com/apache/kafka/commit/264131cdaaef3f4696942f26534b3f61f3a2a162], so the 'retry_zinc' file is no longer in use. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-12895) KIP-751: Drop support for Scala 2.12 in Kafka 4.0 (deprecate in 3.0)
[ https://issues.apache.org/jira/browse/KAFKA-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-12895. Resolution: Fixed > KIP-751: Drop support for Scala 2.12 in Kafka 4.0 (deprecate in 3.0) > > > Key: KAFKA-12895 > URL: https://issues.apache.org/jira/browse/KAFKA-12895 > Project: Kafka > Issue Type: Improvement >Reporter: Ismael Juma >Assignee: TengYao Chi >Priority: Major > Labels: kip > Fix For: 4.0.0 > > > We propose to deprecate Scala 2.12 support n Apache Kafka 3.0 and to drop it > in Apache Kafka 4.0. > > KIP: > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=181308218 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17708) Fix thread leak: controller-3000-ThrottledChannelReaper-ControllerMutation
Chia-Ping Tsai created KAFKA-17708:
--
Summary: Fix thread leak:
controller-3000-ThrottledChannelReaper-ControllerMutation
Key: KAFKA-17708
URL: https://issues.apache.org/jira/browse/KAFKA-17708
Project: Kafka
Issue Type: Bug
Reporter: Chia-Ping Tsai
Assignee: Chia-Ping Tsai
{code:java}
org.opentest4j.AssertionFailedError: Thread leak detected:
controller-3000-ThrottledChannelReaper-ControllerMutation ==> expected:
but was:
at
app//org.apache.kafka.common.test.api.ClusterTestExtensions.afterEach(ClusterTestExtensions.java:159)
at
java.base@17.0.12/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
at
java.base@17.0.12/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at
java.base@17.0.12/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179)
at
java.base@17.0.12/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at
java.base@17.0.12/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625)
at
java.base@17.0.12/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:762)
at
java.base@17.0.12/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:276)
at
java.base@17.0.12/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625)
at
java.base@17.0.12/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
at
java.base@17.0.12/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
at
java.base@17.0.12/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
at
java.base@17.0.12/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
at
java.base@17.0.12/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at
java.base@17.0.12/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
at java.base@17.0.12/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base@17.0.12/java.util.ArrayList.forEach(ArrayList.java:1511)
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (KAFKA-17672) Run quarantined tests separately
[ https://issues.apache.org/jira/browse/KAFKA-17672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17672. Fix Version/s: 4.0.0 Resolution: Fixed > Run quarantined tests separately > > > Key: KAFKA-17672 > URL: https://issues.apache.org/jira/browse/KAFKA-17672 > Project: Kafka > Issue Type: Sub-task >Reporter: David Arthur >Assignee: David Arthur >Priority: Major > Fix For: 4.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17706) Allow all imports for test-common and test-common-api
[ https://issues.apache.org/jira/browse/KAFKA-17706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17706. Fix Version/s: 4.0.0 Resolution: Fixed > Allow all imports for test-common and test-common-api > - > > Key: KAFKA-17706 > URL: https://issues.apache.org/jira/browse/KAFKA-17706 > Project: Kafka > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Minor > Fix For: 4.0.0 > > > Both modules are being refactored (KAFKA-17690 and KAFKA-17682), so this JIRA > will temporarily allow all imports for now. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-16610) Replace "Map#entrySet#forEach" by "Map#forEach"
[
https://issues.apache.org/jira/browse/KAFKA-16610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16610.
Resolution: Fixed
> Replace "Map#entrySet#forEach" by "Map#forEach"
> ---
>
> Key: KAFKA-16610
> URL: https://issues.apache.org/jira/browse/KAFKA-16610
> Project: Kafka
> Issue Type: Improvement
>Reporter: Chia-Ping Tsai
>Assignee: TengYao Chi
>Priority: Minor
> Fix For: 3.8.0
>
>
> {quote}
> Targets
> Occurrences of 'entrySet().forEach' in Project
> Found occurrences in Project (16 usages found)
> Unclassified (16 usages found)
> kafka.core.main (9 usages found)
> kafka.server (4 usages found)
> ControllerApis.scala (2 usages found)
> ControllerApis (2 usages found)
> handleIncrementalAlterConfigs (1 usage found)
> 774 controllerResults.entrySet().forEach(entry =>
> response.responses().add(
> handleLegacyAlterConfigs (1 usage found)
> 533 controllerResults.entrySet().forEach(entry =>
> response.responses().add(
> ControllerConfigurationValidator.scala (2 usages found)
> ControllerConfigurationValidator (2 usages found)
> validate (2 usages found)
> 99 config.entrySet().forEach(e => {
> 114 config.entrySet().forEach(e =>
> properties.setProperty(e.getKey, e.getValue))
> kafka.server.metadata (5 usages found)
> AclPublisher.scala (1 usage found)
> AclPublisher (1 usage found)
> onMetadataUpdate (1 usage found)
> 73 aclsDelta.changes().entrySet().forEach(e =>
> ClientQuotaMetadataManager.scala (3 usages found)
> ClientQuotaMetadataManager (3 usages found)
> handleIpQuota (1 usage found)
> 119 quotaDelta.changes().entrySet().forEach { e =>
> update (2 usages found)
> 54 quotasDelta.changes().entrySet().forEach { e =>
> 99 quotaDelta.changes().entrySet().forEach { e =>
> KRaftMetadataCache.scala (1 usage found)
> KRaftMetadataCache (1 usage found)
> getClusterMetadata (1 usage found)
> 491 topic.partitions().entrySet().forEach { entry
> =>
> kafka.core.test (1 usage found)
> unit.kafka.integration (1 usage found)
> KafkaServerTestHarness.scala (1 usage found)
> KafkaServerTestHarness (1 usage found)
> getTopicNames (1 usage found)
> 349
> controllerServer.controller.findAllTopicIds(ANONYMOUS_CONTEXT).get().entrySet().forEach
> {
> kafka.metadata.main (3 usages found)
> org.apache.kafka.controller (2 usages found)
> QuorumFeatures.java (1 usage found)
> toString() (1 usage found)
> 144 localSupportedFeatures.entrySet().forEach(f ->
> features.add(f.getKey() + ": " + f.getValue()));
> ReplicationControlManager.java (1 usage found)
> createTopic(ControllerRequestContext, CreatableTopic,
> List, Map,
> List, boolean) (1 usage found)
> 732 newParts.entrySet().forEach(e ->
> assignments.put(e.getKey(),
> org.apache.kafka.metadata.properties (1 usage found)
> MetaPropertiesEnsemble.java (1 usage found)
> toString() (1 usage found)
> 610 logDirProps.entrySet().forEach(
> kafka.metadata.test (1 usage found)
> org.apache.kafka.controller (1 usage found)
> ReplicationControlManagerTest.java (1 usage found)
> createTestTopic(String, int[][], Map,
> short) (1 usage found)
> 307 configs.entrySet().forEach(e ->
> topic.configs().add(
> kafka.streams.main (1 usage found)
> org.apache.kafka.streams.processor.internals (1 usage found)
> StreamsMetadataState.java (1 usage found)
> onChange(Map>,
> Map>, Map) (1
> usage found)
> 317 topicPartitionInfo.entrySet().forEach(entry ->
> this.partitionsByTopic
> kafka.tools.main (1 usage found)
> org.apache.kafka.tools (1 usage found)
> LeaderElectionCommand.java (1 usage found)
> electLeaders(Admin, ElectionType,
> Optiona
[jira] [Reopened] (KAFKA-16610) Replace "Map#entrySet#forEach" by "Map#forEach"
[
https://issues.apache.org/jira/browse/KAFKA-16610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reopened KAFKA-16610:
> Replace "Map#entrySet#forEach" by "Map#forEach"
> ---
>
> Key: KAFKA-16610
> URL: https://issues.apache.org/jira/browse/KAFKA-16610
> Project: Kafka
> Issue Type: Improvement
>Reporter: Chia-Ping Tsai
>Assignee: TengYao Chi
>Priority: Minor
> Fix For: 3.8.0
>
>
> {quote}
> Targets
> Occurrences of 'entrySet().forEach' in Project
> Found occurrences in Project (16 usages found)
> Unclassified (16 usages found)
> kafka.core.main (9 usages found)
> kafka.server (4 usages found)
> ControllerApis.scala (2 usages found)
> ControllerApis (2 usages found)
> handleIncrementalAlterConfigs (1 usage found)
> 774 controllerResults.entrySet().forEach(entry =>
> response.responses().add(
> handleLegacyAlterConfigs (1 usage found)
> 533 controllerResults.entrySet().forEach(entry =>
> response.responses().add(
> ControllerConfigurationValidator.scala (2 usages found)
> ControllerConfigurationValidator (2 usages found)
> validate (2 usages found)
> 99 config.entrySet().forEach(e => {
> 114 config.entrySet().forEach(e =>
> properties.setProperty(e.getKey, e.getValue))
> kafka.server.metadata (5 usages found)
> AclPublisher.scala (1 usage found)
> AclPublisher (1 usage found)
> onMetadataUpdate (1 usage found)
> 73 aclsDelta.changes().entrySet().forEach(e =>
> ClientQuotaMetadataManager.scala (3 usages found)
> ClientQuotaMetadataManager (3 usages found)
> handleIpQuota (1 usage found)
> 119 quotaDelta.changes().entrySet().forEach { e =>
> update (2 usages found)
> 54 quotasDelta.changes().entrySet().forEach { e =>
> 99 quotaDelta.changes().entrySet().forEach { e =>
> KRaftMetadataCache.scala (1 usage found)
> KRaftMetadataCache (1 usage found)
> getClusterMetadata (1 usage found)
> 491 topic.partitions().entrySet().forEach { entry
> =>
> kafka.core.test (1 usage found)
> unit.kafka.integration (1 usage found)
> KafkaServerTestHarness.scala (1 usage found)
> KafkaServerTestHarness (1 usage found)
> getTopicNames (1 usage found)
> 349
> controllerServer.controller.findAllTopicIds(ANONYMOUS_CONTEXT).get().entrySet().forEach
> {
> kafka.metadata.main (3 usages found)
> org.apache.kafka.controller (2 usages found)
> QuorumFeatures.java (1 usage found)
> toString() (1 usage found)
> 144 localSupportedFeatures.entrySet().forEach(f ->
> features.add(f.getKey() + ": " + f.getValue()));
> ReplicationControlManager.java (1 usage found)
> createTopic(ControllerRequestContext, CreatableTopic,
> List, Map,
> List, boolean) (1 usage found)
> 732 newParts.entrySet().forEach(e ->
> assignments.put(e.getKey(),
> org.apache.kafka.metadata.properties (1 usage found)
> MetaPropertiesEnsemble.java (1 usage found)
> toString() (1 usage found)
> 610 logDirProps.entrySet().forEach(
> kafka.metadata.test (1 usage found)
> org.apache.kafka.controller (1 usage found)
> ReplicationControlManagerTest.java (1 usage found)
> createTestTopic(String, int[][], Map,
> short) (1 usage found)
> 307 configs.entrySet().forEach(e ->
> topic.configs().add(
> kafka.streams.main (1 usage found)
> org.apache.kafka.streams.processor.internals (1 usage found)
> StreamsMetadataState.java (1 usage found)
> onChange(Map>,
> Map>, Map) (1
> usage found)
> 317 topicPartitionInfo.entrySet().forEach(entry ->
> this.partitionsByTopic
> kafka.tools.main (1 usage found)
> org.apache.kafka.tools (1 usage found)
> LeaderElectionCommand.java (1 usage found)
> electLeaders(Admin, ElectionType,
> Optional>) (1 usage found)
>
[jira] [Created] (KAFKA-17706) Disable checkstyle for test-common and test-common-api
Chia-Ping Tsai created KAFKA-17706: -- Summary: Disable checkstyle for test-common and test-common-api Key: KAFKA-17706 URL: https://issues.apache.org/jira/browse/KAFKA-17706 Project: Kafka Issue Type: Improvement Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai Both modules are being refactored (KAFKA-17690 and KAFKA-17682), so this JIRA will temporarily allow all imports for now. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17525) Convert the UnknownServerException to InvalidRequestException when altering client-metrics config at runtime
[
https://issues.apache.org/jira/browse/KAFKA-17525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-17525.
Fix Version/s: 4.0.0
Resolution: Fixed
> Convert the UnknownServerException to InvalidRequestException when altering
> client-metrics config at runtime
>
>
> Key: KAFKA-17525
> URL: https://issues.apache.org/jira/browse/KAFKA-17525
> Project: Kafka
> Issue Type: Improvement
>Reporter: Chia-Ping Tsai
>Assignee: TaiJuWu
>Priority: Minor
> Fix For: 4.0.0
>
>
> see following test:
> {code:bash}
> chia7712@fedora:~/project/kafka$ bin/kafka-configs.sh --bootstrap-server
> 192.168.1.149:2 --alter --entity-type client-metrics --entity-name test
> --add-config interval.ms=bbb
> Error while executing config command with args '--bootstrap-server
> 192.168.1.149:2 --alter --entity-type client-metrics --entity-name test
> --add-config interval.ms=bbb'
> java.util.concurrent.ExecutionException:
> org.apache.kafka.common.errors.UnknownServerException: The server experienced
> an unexpected error when processing the request.
> at
> java.base/java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:396)
> at
> java.base/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:2096)
> at
> org.apache.kafka.common.internals.KafkaFutureImpl.get(KafkaFutureImpl.java:180)
> at
> kafka.admin.ConfigCommand$.alterResourceConfig(ConfigCommand.scala:581)
> at kafka.admin.ConfigCommand$.alterConfig(ConfigCommand.scala:449)
> at kafka.admin.ConfigCommand$.processCommand(ConfigCommand.scala:351)
> at kafka.admin.ConfigCommand$.main(ConfigCommand.scala:100)
> at kafka.admin.ConfigCommand.main(ConfigCommand.scala)
> Caused by: org.apache.kafka.common.errors.UnknownServerException: The server
> experienced an unexpected error when processing the request.
> {code}
> By contrast, `topic` resource can handle the such error and then return
> `InvalidRequestException`
> {code:bash}
> chia7712@fedora:~/project/kafka$ bin/kafka-configs.sh --bootstrap-server
> 192.168.1.149:2 --alter --topic chia --add-config flush.ms=aaa
> Error while executing config command with args '--bootstrap-server
> 192.168.1.149:2 --alter --topic chia --add-config flush.ms=aaa'
> java.util.concurrent.ExecutionException:
> org.apache.kafka.common.errors.InvalidConfigurationException: Invalid value
> aaa for configuration flush.ms: Not a number of type LONG
> at
> java.base/java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:396)
> at
> java.base/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:2096)
> at
> org.apache.kafka.common.internals.KafkaFutureImpl.get(KafkaFutureImpl.java:180)
> at
> kafka.admin.ConfigCommand$.alterResourceConfig(ConfigCommand.scala:581)
> at kafka.admin.ConfigCommand$.alterConfig(ConfigCommand.scala:371)
> at kafka.admin.ConfigCommand$.processCommand(ConfigCommand.scala:351)
> at kafka.admin.ConfigCommand$.main(ConfigCommand.scala:100)
> at kafka.admin.ConfigCommand.main(ConfigCommand.scala)
> Caused by: org.apache.kafka.common.errors.InvalidConfigurationException:
> Invalid value aaa for configuration flush.ms: Not a number of type LONG
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (KAFKA-17658) Move BootstrapControllersIntegrationTest to kafka.server
[
https://issues.apache.org/jira/browse/KAFKA-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-17658.
Fix Version/s: 4.0.0
Resolution: Fixed
> Move BootstrapControllersIntegrationTest to kafka.server
>
>
> Key: KAFKA-17658
> URL: https://issues.apache.org/jira/browse/KAFKA-17658
> Project: Kafka
> Issue Type: Improvement
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Chuan Yu
>Priority: Minor
> Fix For: 4.0.0
>
>
> {{BootstrapControllersIntegrationTest}} is located in the
> {{kafka.server.test}} folder, but all the code in that folder pertains to the
> new test infrastructure. Clearly, {{BootstrapControllersIntegrationTest}} is
> in the wrong folder.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (KAFKA-17684) Run tests on Java 11 and Java 21
[ https://issues.apache.org/jira/browse/KAFKA-17684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17684. Fix Version/s: 4.0.0 Assignee: David Arthur Resolution: Fixed > Run tests on Java 11 and Java 21 > > > Key: KAFKA-17684 > URL: https://issues.apache.org/jira/browse/KAFKA-17684 > Project: Kafka > Issue Type: Sub-task >Reporter: David Arthur >Assignee: David Arthur >Priority: Major > Fix For: 4.0.0 > > > As part of KIP-1013, we are raising the minimum java version to 11. Until we > add support for Java 23, we should run our tests on 11 (the oldest supported) > and 21 (the newest supported). > > Our Github build should reflect this -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17659) Remove BrokerRegistrationRequestTest and remove EmbeddedZookeeper from RaftClusterInvocationContext
[ https://issues.apache.org/jira/browse/KAFKA-17659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17659. Resolution: Duplicate > Remove BrokerRegistrationRequestTest and remove EmbeddedZookeeper from > RaftClusterInvocationContext > --- > > Key: KAFKA-17659 > URL: https://issues.apache.org/jira/browse/KAFKA-17659 > Project: Kafka > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: TengYao Chi >Priority: Minor > > `BrokerRegistrationRequestTest` is the only one test using the > `EmbeddedZookeeper` of `RaftClusterInvocationContext`. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17695) cleanup org.apache.kafka.common.test.TestUtils
Chia-Ping Tsai created KAFKA-17695: -- Summary: cleanup org.apache.kafka.common.test.TestUtils Key: KAFKA-17695 URL: https://issues.apache.org/jira/browse/KAFKA-17695 Project: Kafka Issue Type: Improvement Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai It is copied from client module, so there are many unused code. Also, the method should not be exposed publicly. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17694) Migrate TopicCommandIntegrationTest to new test infra
Chia-Ping Tsai created KAFKA-17694: -- Summary: Migrate TopicCommandIntegrationTest to new test infra Key: KAFKA-17694 URL: https://issues.apache.org/jira/browse/KAFKA-17694 Project: Kafka Issue Type: Sub-task Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai as title -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17693) Remove testCheckEarliestLocalTimestampVersion and testCheckLatestTieredTimestampVersion
Chia-Ping Tsai created KAFKA-17693: -- Summary: Remove testCheckEarliestLocalTimestampVersion and testCheckLatestTieredTimestampVersion Key: KAFKA-17693 URL: https://issues.apache.org/jira/browse/KAFKA-17693 Project: Kafka Issue Type: New Feature Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai Also, `testListOffsetsRequestOldestVersion` should be moved to java `ListOffsetRequestTest` -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17690) add checkstyle file to test-common and test-common-api
Chia-Ping Tsai created KAFKA-17690: -- Summary: add checkstyle file to test-common and test-common-api Key: KAFKA-17690 URL: https://issues.apache.org/jira/browse/KAFKA-17690 Project: Kafka Issue Type: New Feature Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai test-common could leverage core's checkstyle file. test-common-api should use `test-common` code only after KAFKA-17682 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17451) Remove deprecated Consumer#committed
[ https://issues.apache.org/jira/browse/KAFKA-17451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17451. Fix Version/s: 4.0.0 Resolution: Fixed > Remove deprecated Consumer#committed > > > Key: KAFKA-17451 > URL: https://issues.apache.org/jira/browse/KAFKA-17451 > Project: Kafka > Issue Type: Sub-task > Components: clients, consumer >Reporter: Chia-Ping Tsai >Assignee: Ming-Yen Chung >Priority: Major > Fix For: 4.0.0 > > > The APIs were deprecated by KAFKA-8880 which is back in 2.4.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17689) Migrate TieredStorageTestHarness to new test infra
Chia-Ping Tsai created KAFKA-17689: -- Summary: Migrate TieredStorageTestHarness to new test infra Key: KAFKA-17689 URL: https://issues.apache.org/jira/browse/KAFKA-17689 Project: Kafka Issue Type: Sub-task Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai as title -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17511) Move ElectLeadersRequestOps to ElectLeadersRequest
[ https://issues.apache.org/jira/browse/KAFKA-17511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17511. Fix Version/s: 4.0.0 Resolution: Fixed > Move ElectLeadersRequestOps to ElectLeadersRequest > -- > > Key: KAFKA-17511 > URL: https://issues.apache.org/jira/browse/KAFKA-17511 > Project: Kafka > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Eric Chang >Priority: Major > Fix For: 4.0.0 > > > as title -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17688) Move TransactionsTest to storage module
Chia-Ping Tsai created KAFKA-17688: -- Summary: Move TransactionsTest to storage module Key: KAFKA-17688 URL: https://issues.apache.org/jira/browse/KAFKA-17688 Project: Kafka Issue Type: Sub-task Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17687) Remove the core.test from storage module's dependency
Chia-Ping Tsai created KAFKA-17687: -- Summary: Remove the core.test from storage module's dependency Key: KAFKA-17687 URL: https://issues.apache.org/jira/browse/KAFKA-17687 Project: Kafka Issue Type: Improvement Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai We need to rewrite some integration tests of storage module. 1. TransactionsWithTieredStoreTest 2. TieredStorageTestHarness -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17285) Consider using `Utils.closeQuietly` to replace `CoreUtils.swallow` when handling Closeable objects
[ https://issues.apache.org/jira/browse/KAFKA-17285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17285. Fix Version/s: 4.0.0 Resolution: Fixed > Consider using `Utils.closeQuietly` to replace `CoreUtils.swallow` when > handling Closeable objects > -- > > Key: KAFKA-17285 > URL: https://issues.apache.org/jira/browse/KAFKA-17285 > Project: Kafka > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: bboyleonp >Priority: Minor > Fix For: 4.0.0 > > > see https://github.com/apache/kafka/pull/16818#issuecomment-2273208674 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17589) Move JUnit extensions to test-common module
[ https://issues.apache.org/jira/browse/KAFKA-17589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17589. Fix Version/s: 4.0.0 Assignee: Chia-Ping Tsai (was: David Arthur) Resolution: Fixed > Move JUnit extensions to test-common module > --- > > Key: KAFKA-17589 > URL: https://issues.apache.org/jira/browse/KAFKA-17589 > Project: Kafka > Issue Type: Sub-task >Reporter: David Arthur >Assignee: Chia-Ping Tsai >Priority: Major > Fix For: 4.0.0 > > > Create a new Gradle module "test-common" where our JUnit extensions and > annotations can live. This module should have minimal dependencies. > In order to avoid compile-time dependencies on "core" for > ClusterTestExtension, we can leverage JUnit automatic extension loading with > SPI > https://junit.org/junit5/docs/current/user-guide/#extensions-registration-automatic > We can also use this module as a place to keep a single copy of > junit-platform.properties -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17685) make sure all modules have consistent testRuntimeOnly dependencies
Chia-Ping Tsai created KAFKA-17685: -- Summary: make sure all modules have consistent testRuntimeOnly dependencies Key: KAFKA-17685 URL: https://issues.apache.org/jira/browse/KAFKA-17685 Project: Kafka Issue Type: Improvement Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai see https://github.com/apache/kafka/pull/17318#discussion_r1784638364 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-16974) KRaft support in SslAdminIntegrationTest
[ https://issues.apache.org/jira/browse/KAFKA-16974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16974. Fix Version/s: 4.0.0 Resolution: Fixed > KRaft support in SslAdminIntegrationTest > > > Key: KAFKA-16974 > URL: https://issues.apache.org/jira/browse/KAFKA-16974 > Project: Kafka > Issue Type: Task > Components: core >Reporter: Mickael Maison >Assignee: Kuan Po Tseng >Priority: Major > Labels: kraft-test > Fix For: 4.0.0 > > > This class needs to be updated to support KRaft -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17258) Migrate AdminFenceProducersIntegrationTest to ClusterTestExtensions framework
[ https://issues.apache.org/jira/browse/KAFKA-17258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17258. Fix Version/s: 4.0.0 Resolution: Fixed > Migrate AdminFenceProducersIntegrationTest to ClusterTestExtensions framework > - > > Key: KAFKA-17258 > URL: https://issues.apache.org/jira/browse/KAFKA-17258 > Project: Kafka > Issue Type: Test >Reporter: PoAn Yang >Assignee: Ming-Yen Chung >Priority: Minor > Fix For: 4.0.0 > > > As title, we can migrate AdminFenceProducersIntegrationTest to Java and use > ClusterTestExtensions framework. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17682) Refactor RaftClusterInvocationContext to eliminate test-common-api dependencies
Chia-Ping Tsai created KAFKA-17682: -- Summary: Refactor RaftClusterInvocationContext to eliminate test-common-api dependencies Key: KAFKA-17682 URL: https://issues.apache.org/jira/browse/KAFKA-17682 Project: Kafka Issue Type: Improvement Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai see https://github.com/apache/kafka/pull/17318/files#r1784648528 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17681) Fix unstable consumer_test.py#test_fencing_static_consumer
Chia-Ping Tsai created KAFKA-17681:
--
Summary: Fix unstable consumer_test.py#test_fencing_static_consumer
Key: KAFKA-17681
URL: https://issues.apache.org/jira/browse/KAFKA-17681
Project: Kafka
Issue Type: Bug
Reporter: Chia-Ping Tsai
Assignee: Chia-Ping Tsai
{code:java}
AssertionError('Static consumers attempt to join with instance id in use
should not cause a rebalance.')
Traceback (most recent call last):
File
"/usr/local/lib/python3.9/dist-packages/ducktape/tests/runner_client.py", line
186, in _do_run
data = self.run_test()
File
"/usr/local/lib/python3.9/dist-packages/ducktape/tests/runner_client.py", line
246, in run_test
return self.test_context.function(self.test)
File "/usr/local/lib/python3.9/dist-packages/ducktape/mark/_mark.py", line
433, in wrapper
return functools.partial(f, *args, **kwargs)(*w_args, **w_kwargs)
File "/opt/kafka-dev/tests/kafkatest/tests/client/consumer_test.py", line
359, in test_fencing_static_consumer
assert num_rebalances == consumer.num_rebalances(), "Static consumers
attempt to join with instance id in use should not cause a rebalance. before: "
+ str(num_rebalances) + " after: " + str(consumer.num_rebalances())
AssertionError: Static consumers attempt to join with instance id in use should
not cause a rebalance.
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (KAFKA-17657) Replace the "consumer-fetch-manager-metrics" by groupName
[ https://issues.apache.org/jira/browse/KAFKA-17657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17657. Fix Version/s: 4.0.0 Resolution: Fixed > Replace the "consumer-fetch-manager-metrics" by groupName > - > > Key: KAFKA-17657 > URL: https://issues.apache.org/jira/browse/KAFKA-17657 > Project: Kafka > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: kangning.li >Priority: Trivial > Fix For: 4.0.0 > > > https://github.com/apache/kafka/blob/6ee46ea86530e019798ba0d4183164d7925dde63/clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchMetricsRegistry.java#L144 > The `groupName` is derived from the input, so using the constant > "consumer-fetch-manager-metrics" for the group is not appropriate. While it > hasn't caused issues so far because the input has always been "consumer," > addressing this now can help prevent potential bugs in the future. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17677) Consider removing `atomicGetOrUpdate`
Chia-Ping Tsai created KAFKA-17677: -- Summary: Consider removing `atomicGetOrUpdate` Key: KAFKA-17677 URL: https://issues.apache.org/jira/browse/KAFKA-17677 Project: Kafka Issue Type: Sub-task Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai discussion: https://github.com/apache/kafka/pull/17313#discussion_r1782157511 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17646) Fix flaky KafkaStreamsTest.testStateGlobalThreadClose
[
https://issues.apache.org/jira/browse/KAFKA-17646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-17646.
Fix Version/s: 4.0.0
Resolution: Fixed
> Fix flaky KafkaStreamsTest.testStateGlobalThreadClose
> -
>
> Key: KAFKA-17646
> URL: https://issues.apache.org/jira/browse/KAFKA-17646
> Project: Kafka
> Issue Type: Bug
> Components: streams, unit tests
>Reporter: Yu-Lin Chen
>Assignee: Yu-Lin Chen
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: 0001-reproduce-unexpected-state-transition.patch,
> 0002-reproduce-waiting-timeout-for-PENDING_ERROR.patch
>
>
> 22 flaky builds out of 584 in the past 28 days. (13 from jenkins, 9 from
> github) ([Report
> Link|https://ge.apache.org/scans/tests?search.rootProjectNames=kafka&search.startTimeMax=1727517159423&search.startTimeMin=172503360&search.tags=trunk&search.timeZoneId=Asia%2FTaipei&tests.container=org.apache.kafka.streams.KafkaStreamsTest&tests.test=testStateGlobalThreadClose()])
> Two types of error messages:
> 1. Unexpected state transition from ERROR to PENDING_SHUTDOWN ([Sep 24 2024
> at 15:45:33
> CST|https://ge.apache.org/s/ewblfqjcre6gu/tests/task/:streams:test/details/org.apache.kafka.streams.KafkaStreamsTest/testStateGlobalThreadClose()?expanded-stacktrace=WyIwIl0&top-execution=1])
> {code:java}
> java.lang.IllegalStateException: Stream-client test-client: Unexpected state
> transition from ERROR to PENDING_SHUTDOWN
> at org.apache.kafka.streams.KafkaStreams.setState(KafkaStreams.java:343)
> at org.apache.kafka.streams.KafkaStreams.close(KafkaStreams.java:1566)
> at org.apache.kafka.streams.KafkaStreams.close(KafkaStreams.java:1459)
> at
> org.apache.kafka.streams.KafkaStreamsTest.testStateGlobalThreadClose(KafkaStreamsTest.java:550)
>
> at java.lang.reflect.Method.invoke(Method.java:569)
> at java.util.ArrayList.forEach(ArrayList.java:1511)
> at java.util.ArrayList.forEach(ArrayList.java:1511)
> {code}
> 2. org.opentest4j.AssertionFailedError: Condition not met within timeout
> 15000. Thread never stopped. ==> expected: but was: ([Sep 26
> 2024 at 09:36:22
> CST|https://ge.apache.org/s/hetqkmasks5ve/tests/task/:streams:test/details/org.apache.kafka.streams.KafkaStreamsTest/testStateGlobalThreadClose()?expanded-stacktrace=WyIwIl0&top-execution=1])
> {code:java}
> at
> org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
>
> at
> org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
>
> at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
> at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
> at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:214)
> at
> org.apache.kafka.test.TestUtils.lambda$waitForCondition$3(TestUtils.java:396)
>
> at
> org.apache.kafka.test.TestUtils.retryOnExceptionWithTimeout(TestUtils.java:444)
>
> at org.apache.kafka.test.TestUtils.waitForCondition(TestUtils.java:393)
> at org.apache.kafka.test.TestUtils.waitForCondition(TestUtils.java:377)
> at org.apache.kafka.test.TestUtils.waitForCondition(TestUtils.java:350)
> at
> org.apache.kafka.streams.KafkaStreamsTest.testStateGlobalThreadClose(KafkaStreamsTest.java:546)
>
> at java.lang.reflect.Method.invoke(Method.java:569)
> at java.util.ArrayList.forEach(ArrayList.java:1511)
> at java.util.ArrayList.forEach(ArrayList.java:1511)
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (KAFKA-16769) Delete deprecated add.source.alias.to.metrics configuration
[ https://issues.apache.org/jira/browse/KAFKA-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16769. Resolution: Fixed > Delete deprecated add.source.alias.to.metrics configuration > --- > > Key: KAFKA-16769 > URL: https://issues.apache.org/jira/browse/KAFKA-16769 > Project: Kafka > Issue Type: Task > Components: mirrormaker >Reporter: Mickael Maison >Assignee: Mickael Maison >Priority: Major > Fix For: 4.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17656) Use parameterized logging for PartitionChangeBuilder
[ https://issues.apache.org/jira/browse/KAFKA-17656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17656. Fix Version/s: 4.0.0 Resolution: Fixed > Use parameterized logging for PartitionChangeBuilder > > > Key: KAFKA-17656 > URL: https://issues.apache.org/jira/browse/KAFKA-17656 > Project: Kafka > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: Ming-Yen Chung >Priority: Minor > Fix For: 4.0.0 > > > `PartitionChangeBuilder`contains several trace/debug level logs that use > non-constant strings. These should be optimized by using placeholders for > better performance and readability. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17668) Rewrite LogCleaner#maxOverCleanerThreads and LogCleanerManager#maintainUncleanablePartitions
Chia-Ping Tsai created KAFKA-17668: -- Summary: Rewrite LogCleaner#maxOverCleanerThreads and LogCleanerManager#maintainUncleanablePartitions Key: KAFKA-17668 URL: https://issues.apache.org/jira/browse/KAFKA-17668 Project: Kafka Issue Type: Sub-task Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai Both methods can be rewrite by scala 2.13 methods -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17634) Tighten up wakeup handling for share consumer
[ https://issues.apache.org/jira/browse/KAFKA-17634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17634. Fix Version/s: 4.0.0 Resolution: Fixed > Tighten up wakeup handling for share consumer > - > > Key: KAFKA-17634 > URL: https://issues.apache.org/jira/browse/KAFKA-17634 > Project: Kafka > Issue Type: Sub-task >Reporter: Andrew Schofield >Assignee: Andrew Schofield >Priority: Major > Fix For: 4.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17659) Remove BrokerRegistrationRequestTest and remove EmbeddedZookeeper from RaftClusterInvocationContext
Chia-Ping Tsai created KAFKA-17659: -- Summary: Remove BrokerRegistrationRequestTest and remove EmbeddedZookeeper from RaftClusterInvocationContext Key: KAFKA-17659 URL: https://issues.apache.org/jira/browse/KAFKA-17659 Project: Kafka Issue Type: Sub-task Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai `BrokerRegistrationRequestTest` is the only one test using the `EmbeddedZookeeper` of `RaftClusterInvocationContext`. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17658) Move BootstrapControllersIntegrationTest to kafka.server
Chia-Ping Tsai created KAFKA-17658:
--
Summary: Move BootstrapControllersIntegrationTest to kafka.server
Key: KAFKA-17658
URL: https://issues.apache.org/jira/browse/KAFKA-17658
Project: Kafka
Issue Type: Improvement
Reporter: Chia-Ping Tsai
Assignee: Chia-Ping Tsai
{{BootstrapControllersIntegrationTest}} is located in the {{kafka.server.test}}
folder, but all the code in that folder pertains to the new test
infrastructure. Clearly, {{BootstrapControllersIntegrationTest}} is in the
wrong folder.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (KAFKA-17657) Replace the "consumer-fetch-manager-metrics" by groupName
Chia-Ping Tsai created KAFKA-17657: -- Summary: Replace the "consumer-fetch-manager-metrics" by groupName Key: KAFKA-17657 URL: https://issues.apache.org/jira/browse/KAFKA-17657 Project: Kafka Issue Type: Improvement Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai https://github.com/apache/kafka/blob/6ee46ea86530e019798ba0d4183164d7925dde63/clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchMetricsRegistry.java#L144 The `groupName` is derived from the input, so using the constant "consumer-fetch-manager-metrics" for the group is not appropriate. While it hasn't caused issues so far because the input has always been "consumer," addressing this now can help prevent potential bugs in the future. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17656) Use parameterized logging for PartitionChangeBuilder
Chia-Ping Tsai created KAFKA-17656: -- Summary: Use parameterized logging for PartitionChangeBuilder Key: KAFKA-17656 URL: https://issues.apache.org/jira/browse/KAFKA-17656 Project: Kafka Issue Type: Improvement Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai `PartitionChangeBuilder`contains several trace/debug level logs that use non-constant strings. These should be optimized by using placeholders for better performance and readability. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17655) add example of changing the e2e image name
Chia-Ping Tsai created KAFKA-17655:
--
Summary: add example of changing the e2e image name
Key: KAFKA-17655
URL: https://issues.apache.org/jira/browse/KAFKA-17655
Project: Kafka
Issue Type: Improvement
Reporter: Chia-Ping Tsai
Assignee: Chia-Ping Tsai
The default Docker image name used by E2E is {{{}ducker-ak-openjdk-8{}}}. When
switching to a different branch to run E2E tests, Docker may rebuild the image
due to changes in the Dockerfile. We should include an example to remind
developers that they can override the image name by setting the "image_name"
environment variable. This allows using different names for each branch to
prevent unnecessary rebuilding.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (KAFKA-17653) Update Scala version to 2.13.15 for support Java 23
[ https://issues.apache.org/jira/browse/KAFKA-17653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17653. Fix Version/s: 4.0.0 Resolution: Fixed > Update Scala version to 2.13.15 for support Java 23 > --- > > Key: KAFKA-17653 > URL: https://issues.apache.org/jira/browse/KAFKA-17653 > Project: Kafka > Issue Type: Improvement >Affects Versions: 4.0.0 >Reporter: 黃竣陽 >Assignee: 黃竣陽 >Priority: Major > Fix For: 4.0.0 > > > as title -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17481) Revisit the slow integration tests
[ https://issues.apache.org/jira/browse/KAFKA-17481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17481. Resolution: Fixed > Revisit the slow integration tests > -- > > Key: KAFKA-17481 > URL: https://issues.apache.org/jira/browse/KAFKA-17481 > Project: Kafka > Issue Type: Test >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Major > > as title. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17654) Fix flaky ProducerIdManagerTest#testUnrecoverableErrors
Chia-Ping Tsai created KAFKA-17654: -- Summary: Fix flaky ProducerIdManagerTest#testUnrecoverableErrors Key: KAFKA-17654 URL: https://issues.apache.org/jira/browse/KAFKA-17654 Project: Kafka Issue Type: Test Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai https://github.com/apache/kafka/actions/runs/11079975812/attempts/2#summary-30806776266 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17473) Speed Up ClientTelemetryTest
[ https://issues.apache.org/jira/browse/KAFKA-17473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17473. Fix Version/s: 4.0.0 Resolution: Fixed > Speed Up ClientTelemetryTest > > > Key: KAFKA-17473 > URL: https://issues.apache.org/jira/browse/KAFKA-17473 > Project: Kafka > Issue Type: Sub-task >Reporter: 黃竣陽 >Assignee: 黃竣陽 >Priority: Minor > Fix For: 4.0.0 > > > see the comments: [https://github.com/apache/kafka/pull/16957] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-16761) ZkClusterInstance#start does not create ClusterConfigurableIntegrationHarness
[ https://issues.apache.org/jira/browse/KAFKA-16761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16761. Resolution: Won't Fix zk-related code is removed from trunk > ZkClusterInstance#start does not create ClusterConfigurableIntegrationHarness > - > > Key: KAFKA-16761 > URL: https://issues.apache.org/jira/browse/KAFKA-16761 > Project: Kafka > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Minor > > [https://github.com/apache/kafka/blob/440f5f6c09720bb9414524781342bbf35973c281/core/src/test/java/kafka/test/junit/ZkClusterInvocationContext.java#L103] > `ClusterConfigurableIntegrationHarness` is created only in "beforeEach" > phase, and that makes `ZkClusterInstance#start` does not work as it could > cause NPE. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-12358) Migrate to Java 11
[ https://issues.apache.org/jira/browse/KAFKA-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-12358. Resolution: Duplicate this will be fixed by KAFKA-12894 > Migrate to Java 11 > -- > > Key: KAFKA-12358 > URL: https://issues.apache.org/jira/browse/KAFKA-12358 > Project: Kafka > Issue Type: Improvement >Reporter: Dongjin Lee >Assignee: Dongjin Lee >Priority: Major > Labels: needs-kip > > I found this problem when I was working on > [KAFKA-12324|https://issues.apache.org/jira/browse/KAFKA-12324]. > As of present, Kafka Connect and Trogdor are using Jetty 9. Although Jetty's > stable release is 9.4, the Jetty community is now moving their focus to Jetty > 10 and 11, which requires Java 11 as a prerequisite. To minimize potential > security vulnerability, Kafka should migrate into Java 11 + Jetty 11 as soon > as Jetty 9.4 reaches the end of life. As a note, [Jetty 9.2 reached End of > Life in March > 2018|https://www.eclipse.org/lists/jetty-announce/msg00116.html] and 9.3 also > did in [February > 2020|https://www.eclipse.org/lists/jetty-announce/msg00140.html]. > In other words, the necessity of moving to Java 11 is heavily affected by > Jetty's maintenance plan. Jetty 9.4 seems like still be supported for a > certain period of time, but it is worth being aware of these relationships > and having a migration plan beforehand. > For the java-scala compatibility, we have no issue. The recommended Scala > versions to Java 11 are 2.13.0 and 2.12.4, and we are already using the later > version. See: > https://docs.scala-lang.org/overviews/jdk-compatibility/overview.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-16683) Extract security-related helpers from scala.TestUtils to java class
[ https://issues.apache.org/jira/browse/KAFKA-16683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16683. Fix Version/s: 4.0.0 Resolution: Fixed > Extract security-related helpers from scala.TestUtils to java class > --- > > Key: KAFKA-16683 > URL: https://issues.apache.org/jira/browse/KAFKA-16683 > Project: Kafka > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: PoAn Yang >Priority: Minor > Fix For: 4.0.0 > > > We can merge them into `JaasTestUtils and then rename `JaasTestUtils` to > `SecurityTestUtils. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17563) Move RequestConvertToJson to server module
[ https://issues.apache.org/jira/browse/KAFKA-17563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17563. Fix Version/s: 4.0.0 Resolution: Fixed > Move RequestConvertToJson to server module > -- > > Key: KAFKA-17563 > URL: https://issues.apache.org/jira/browse/KAFKA-17563 > Project: Kafka > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: kangning.li >Priority: Major > Fix For: 4.0.0 > > > as title -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17586) AsyncKafkaConsumer#seek should NOT wait the completion of backgound
[ https://issues.apache.org/jira/browse/KAFKA-17586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17586. Resolution: Not A Problem > AsyncKafkaConsumer#seek should NOT wait the completion of backgound > --- > > Key: KAFKA-17586 > URL: https://issues.apache.org/jira/browse/KAFKA-17586 > Project: Kafka > Issue Type: Bug > Components: clients, consumer >Reporter: Chia-Ping Tsai >Assignee: TaiJuWu >Priority: Major > Labels: kip-848-client-support > > see https://github.com/apache/kafka/pull/17230/files#r1768666772 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17624) Remove the E2E uses of accessing ACLs from zk
Chia-Ping Tsai created KAFKA-17624: -- Summary: Remove the E2E uses of accessing ACLs from zk Key: KAFKA-17624 URL: https://issues.apache.org/jira/browse/KAFKA-17624 Project: Kafka Issue Type: Sub-task Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai To remove ZooKeeper code from AclCommand, we first need to remove the related system tests. This task should remove zookeeper.py#list_acls and its usages, including zookeeper_tls_test.py, zookeeper_tls_encrypt_only_test.py, zookeeper_security_upgrade_test.py, `test_rolling_upgrade_phase_two`, `test_rolling_upgrade_sasl_mechanism_phase_two`, and upgrade_test.py#perform_upgrade. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17612) Remove some tests that only apply to ZK mode or migration
[ https://issues.apache.org/jira/browse/KAFKA-17612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17612. Fix Version/s: 4.0.0 Resolution: Fixed > Remove some tests that only apply to ZK mode or migration > - > > Key: KAFKA-17612 > URL: https://issues.apache.org/jira/browse/KAFKA-17612 > Project: Kafka > Issue Type: Sub-task >Reporter: Colin McCabe >Assignee: Colin McCabe >Priority: Major > Fix For: 4.0.0 > > > Remove some tests that only apply to ZK mode -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17619) Remove zk type and instance from ClusterTest
Chia-Ping Tsai created KAFKA-17619: -- Summary: Remove zk type and instance from ClusterTest Key: KAFKA-17619 URL: https://issues.apache.org/jira/browse/KAFKA-17619 Project: Kafka Issue Type: Sub-task Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai as title -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KAFKA-17610) Drop deprecated alterConfigs
Chia-Ping Tsai created KAFKA-17610: -- Summary: Drop deprecated alterConfigs Key: KAFKA-17610 URL: https://issues.apache.org/jira/browse/KAFKA-17610 Project: Kafka Issue Type: Improvement Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai Fix For: 4.0.0 `alterConfigs` is deprecated in 2.4.0, so it is time to remove it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-16908) Refactor QuorumConfig with AbstractConfig
[ https://issues.apache.org/jira/browse/KAFKA-16908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16908. Fix Version/s: 4.0.0 Resolution: Fixed > Refactor QuorumConfig with AbstractConfig > - > > Key: KAFKA-16908 > URL: https://issues.apache.org/jira/browse/KAFKA-16908 > Project: Kafka > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: kangning.li >Priority: Minor > Fix For: 4.0.0 > > > This is similar to KAFKA-16884 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17520) align the low bound of ducktape version
[ https://issues.apache.org/jira/browse/KAFKA-17520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17520. Fix Version/s: 4.0.0 Resolution: Fixed > align the low bound of ducktape version > > > Key: KAFKA-17520 > URL: https://issues.apache.org/jira/browse/KAFKA-17520 > Project: Kafka > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: Eric Chang >Priority: Minor > Fix For: 4.0.0 > > > There was a discussion for it: > https://github.com/apache/kafka/pull/14216#issuecomment-2117519600 > and I noticed this issue when trying to upgrade base image for e2e -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17602) Remove `ConfigUtils.translateDeprecatedConfigs` from JmxReporter
[ https://issues.apache.org/jira/browse/KAFKA-17602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17602. Fix Version/s: 4.0.0 Resolution: Fixed > Remove `ConfigUtils.translateDeprecatedConfigs` from JmxReporter > > > Key: KAFKA-17602 > URL: https://issues.apache.org/jira/browse/KAFKA-17602 > Project: Kafka > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Minor > Fix For: 4.0.0 > > > KAFKA-17528 removes the deprecated configs, we don't need to translate the > deprecated configs. > > https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java#L309 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17087) Deprecate `delete-config` of TopicCommand
[ https://issues.apache.org/jira/browse/KAFKA-17087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17087. Resolution: Fixed > Deprecate `delete-config` of TopicCommand > - > > Key: KAFKA-17087 > URL: https://issues.apache.org/jira/browse/KAFKA-17087 > Project: Kafka > Issue Type: Improvement > Components: tools >Reporter: Chia-Ping Tsai >Assignee: TengYao Chi >Priority: Minor > Labels: need-kip > Fix For: 4.0.0 > > > TopicCommand `delete-config` is an no-op, so we should deprecate it in 4.0 > and then remove it from 5.0. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17465) Refactor getMembersFromGroup to be non-blocking
[ https://issues.apache.org/jira/browse/KAFKA-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17465. Fix Version/s: 4.0.0 Resolution: Fixed > Refactor getMembersFromGroup to be non-blocking > --- > > Key: KAFKA-17465 > URL: https://issues.apache.org/jira/browse/KAFKA-17465 > Project: Kafka > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: TaiJuWu >Priority: Minor > Fix For: 4.0.0 > > > https://github.com/apache/kafka/blob/359ddce3b2ce9288389751f5a64a965db9bf12be/clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java#L4120 > The request used to collect all members is blocking, and we fix that blocking > call. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (KAFKA-17585) `offsetResetStrategyTimestamp` should return `long` instead of `Long`
[ https://issues.apache.org/jira/browse/KAFKA-17585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17585. Fix Version/s: 4.0.0 Resolution: Fixed > `offsetResetStrategyTimestamp` should return `long` instead of `Long` > - > > Key: KAFKA-17585 > URL: https://issues.apache.org/jira/browse/KAFKA-17585 > Project: Kafka > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: kangning.li >Priority: Trivial > Fix For: 4.0.0 > > > the null behavior was removed by > [https://github.com/apache/kafka/commit/2b233bfa5f35bf237effe8c5202fd2b80c601943,] > so we can return long and then remove the null check to simplify the code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
