[jira] [Updated] (KAFKA-1416) Unify sendMessages/getMessages in unit tests
[ https://issues.apache.org/jira/browse/KAFKA-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flutra Osmani updated KAFKA-1416: - Attachment: KAFKA-1416_2015-04-10_18:36:10.patch > Unify sendMessages/getMessages in unit tests > > > Key: KAFKA-1416 > URL: https://issues.apache.org/jira/browse/KAFKA-1416 > Project: Kafka > Issue Type: Bug >Reporter: Guozhang Wang >Assignee: Flutra Osmani > Labels: newbie > Attachments: KAFKA-1416.patch, KAFKA-1416_2015-03-01_17:24:55.patch, > KAFKA-1416_2015-03-26_00:20:36.patch, KAFKA-1416_2015-04-10_18:36:10.patch > > > Multiple unit tests have its own internal function to send/get messages from > the brokers. For example: > sendMessages in ZookeeperConsumerConnectorTest > produceMessage in UncleanLeaderElectionTest > sendMessages in FetcherTest > etc > It is better to unify them in TestUtils. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1416) Unify sendMessages/getMessages in unit tests
[ https://issues.apache.org/jira/browse/KAFKA-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490697#comment-14490697 ] Flutra Osmani commented on KAFKA-1416: -- Updated reviewboard https://reviews.apache.org/r/31606/diff/ against branch origin/trunk > Unify sendMessages/getMessages in unit tests > > > Key: KAFKA-1416 > URL: https://issues.apache.org/jira/browse/KAFKA-1416 > Project: Kafka > Issue Type: Bug >Reporter: Guozhang Wang >Assignee: Flutra Osmani > Labels: newbie > Attachments: KAFKA-1416.patch, KAFKA-1416_2015-03-01_17:24:55.patch, > KAFKA-1416_2015-03-26_00:20:36.patch, KAFKA-1416_2015-04-10_18:36:10.patch > > > Multiple unit tests have its own internal function to send/get messages from > the brokers. For example: > sendMessages in ZookeeperConsumerConnectorTest > produceMessage in UncleanLeaderElectionTest > sendMessages in FetcherTest > etc > It is better to unify them in TestUtils. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-1416) Unify sendMessages/getMessages in unit tests
[ https://issues.apache.org/jira/browse/KAFKA-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flutra Osmani updated KAFKA-1416: - Status: Patch Available (was: In Progress) > Unify sendMessages/getMessages in unit tests > > > Key: KAFKA-1416 > URL: https://issues.apache.org/jira/browse/KAFKA-1416 > Project: Kafka > Issue Type: Bug >Reporter: Guozhang Wang >Assignee: Flutra Osmani > Labels: newbie > Attachments: KAFKA-1416.patch, KAFKA-1416_2015-03-01_17:24:55.patch, > KAFKA-1416_2015-03-26_00:20:36.patch, KAFKA-1416_2015-04-10_18:36:10.patch > > > Multiple unit tests have its own internal function to send/get messages from > the brokers. For example: > sendMessages in ZookeeperConsumerConnectorTest > produceMessage in UncleanLeaderElectionTest > sendMessages in FetcherTest > etc > It is better to unify them in TestUtils. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1416) Unify sendMessages/getMessages in unit tests
[ https://issues.apache.org/jira/browse/KAFKA-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381494#comment-14381494 ] Flutra Osmani commented on KAFKA-1416: -- Updated reviewboard https://reviews.apache.org/r/31606/diff/ against branch origin/trunk > Unify sendMessages/getMessages in unit tests > > > Key: KAFKA-1416 > URL: https://issues.apache.org/jira/browse/KAFKA-1416 > Project: Kafka > Issue Type: Bug >Reporter: Guozhang Wang >Assignee: Flutra Osmani > Labels: newbie > Attachments: KAFKA-1416.patch, KAFKA-1416_2015-03-01_17:24:55.patch, > KAFKA-1416_2015-03-26_00:20:36.patch > > > Multiple unit tests have its own internal function to send/get messages from > the brokers. For example: > sendMessages in ZookeeperConsumerConnectorTest > produceMessage in UncleanLeaderElectionTest > sendMessages in FetcherTest > etc > It is better to unify them in TestUtils. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-1416) Unify sendMessages/getMessages in unit tests
[ https://issues.apache.org/jira/browse/KAFKA-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flutra Osmani updated KAFKA-1416: - Attachment: KAFKA-1416_2015-03-26_00:20:36.patch > Unify sendMessages/getMessages in unit tests > > > Key: KAFKA-1416 > URL: https://issues.apache.org/jira/browse/KAFKA-1416 > Project: Kafka > Issue Type: Bug >Reporter: Guozhang Wang >Assignee: Flutra Osmani > Labels: newbie > Attachments: KAFKA-1416.patch, KAFKA-1416_2015-03-01_17:24:55.patch, > KAFKA-1416_2015-03-26_00:20:36.patch > > > Multiple unit tests have its own internal function to send/get messages from > the brokers. For example: > sendMessages in ZookeeperConsumerConnectorTest > produceMessage in UncleanLeaderElectionTest > sendMessages in FetcherTest > etc > It is better to unify them in TestUtils. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1416) Unify sendMessages/getMessages in unit tests
[ https://issues.apache.org/jira/browse/KAFKA-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342592#comment-14342592 ] Flutra Osmani commented on KAFKA-1416: -- Updated reviewboard https://reviews.apache.org/r/31606/diff/ against branch origin/trunk > Unify sendMessages/getMessages in unit tests > > > Key: KAFKA-1416 > URL: https://issues.apache.org/jira/browse/KAFKA-1416 > Project: Kafka > Issue Type: Bug >Reporter: Guozhang Wang >Assignee: Flutra Osmani > Labels: newbie > Attachments: KAFKA-1416.patch, KAFKA-1416_2015-03-01_17:24:55.patch > > > Multiple unit tests have its own internal function to send/get messages from > the brokers. For example: > sendMessages in ZookeeperConsumerConnectorTest > produceMessage in UncleanLeaderElectionTest > sendMessages in FetcherTest > etc > It is better to unify them in TestUtils. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-1416) Unify sendMessages/getMessages in unit tests
[ https://issues.apache.org/jira/browse/KAFKA-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flutra Osmani updated KAFKA-1416: - Attachment: KAFKA-1416_2015-03-01_17:24:55.patch > Unify sendMessages/getMessages in unit tests > > > Key: KAFKA-1416 > URL: https://issues.apache.org/jira/browse/KAFKA-1416 > Project: Kafka > Issue Type: Bug >Reporter: Guozhang Wang >Assignee: Flutra Osmani > Labels: newbie > Attachments: KAFKA-1416.patch, KAFKA-1416_2015-03-01_17:24:55.patch > > > Multiple unit tests have its own internal function to send/get messages from > the brokers. For example: > sendMessages in ZookeeperConsumerConnectorTest > produceMessage in UncleanLeaderElectionTest > sendMessages in FetcherTest > etc > It is better to unify them in TestUtils. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1416) Unify sendMessages/getMessages in unit tests
[ https://issues.apache.org/jira/browse/KAFKA-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342574#comment-14342574 ] Flutra Osmani commented on KAFKA-1416: -- Thank you. I just committed a patch. > Unify sendMessages/getMessages in unit tests > > > Key: KAFKA-1416 > URL: https://issues.apache.org/jira/browse/KAFKA-1416 > Project: Kafka > Issue Type: Bug >Reporter: Guozhang Wang >Assignee: Flutra Osmani > Labels: newbie > Attachments: KAFKA-1416.patch > > > Multiple unit tests have its own internal function to send/get messages from > the brokers. For example: > sendMessages in ZookeeperConsumerConnectorTest > produceMessage in UncleanLeaderElectionTest > sendMessages in FetcherTest > etc > It is better to unify them in TestUtils. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1416) Unify sendMessages/getMessages in unit tests
[ https://issues.apache.org/jira/browse/KAFKA-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342565#comment-14342565 ] Flutra Osmani commented on KAFKA-1416: -- Created reviewboard https://reviews.apache.org/r/31606/diff/ against branch origin/trunk > Unify sendMessages/getMessages in unit tests > > > Key: KAFKA-1416 > URL: https://issues.apache.org/jira/browse/KAFKA-1416 > Project: Kafka > Issue Type: Bug >Reporter: Guozhang Wang >Assignee: Flutra Osmani > Labels: newbie > Attachments: KAFKA-1416.patch > > > Multiple unit tests have its own internal function to send/get messages from > the brokers. For example: > sendMessages in ZookeeperConsumerConnectorTest > produceMessage in UncleanLeaderElectionTest > sendMessages in FetcherTest > etc > It is better to unify them in TestUtils. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-1416) Unify sendMessages/getMessages in unit tests
[ https://issues.apache.org/jira/browse/KAFKA-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flutra Osmani updated KAFKA-1416: - Attachment: KAFKA-1416.patch > Unify sendMessages/getMessages in unit tests > > > Key: KAFKA-1416 > URL: https://issues.apache.org/jira/browse/KAFKA-1416 > Project: Kafka > Issue Type: Bug >Reporter: Guozhang Wang >Assignee: Flutra Osmani > Labels: newbie > Attachments: KAFKA-1416.patch > > > Multiple unit tests have its own internal function to send/get messages from > the brokers. For example: > sendMessages in ZookeeperConsumerConnectorTest > produceMessage in UncleanLeaderElectionTest > sendMessages in FetcherTest > etc > It is better to unify them in TestUtils. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-1416) Unify sendMessages/getMessages in unit tests
[ https://issues.apache.org/jira/browse/KAFKA-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flutra Osmani updated KAFKA-1416: - Status: Patch Available (was: Open) > Unify sendMessages/getMessages in unit tests > > > Key: KAFKA-1416 > URL: https://issues.apache.org/jira/browse/KAFKA-1416 > Project: Kafka > Issue Type: Bug >Reporter: Guozhang Wang >Assignee: Flutra Osmani > Labels: newbie > Attachments: KAFKA-1416.patch > > > Multiple unit tests have its own internal function to send/get messages from > the brokers. For example: > sendMessages in ZookeeperConsumerConnectorTest > produceMessage in UncleanLeaderElectionTest > sendMessages in FetcherTest > etc > It is better to unify them in TestUtils. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (KAFKA-1416) Unify sendMessages/getMessages in unit tests
[ https://issues.apache.org/jira/browse/KAFKA-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328188#comment-14328188 ] Flutra Osmani edited comment on KAFKA-1416 at 2/19/15 10:09 PM: May I (or how do I) assign this task to myself? I'd like to take a stab at it. was (Author: futtre): May I (or how do I) assign this task to myself? > Unify sendMessages/getMessages in unit tests > > > Key: KAFKA-1416 > URL: https://issues.apache.org/jira/browse/KAFKA-1416 > Project: Kafka > Issue Type: Bug >Reporter: Guozhang Wang > Labels: newbie > > Multiple unit tests have its own internal function to send/get messages from > the brokers. For example: > sendMessages in ZookeeperConsumerConnectorTest > produceMessage in UncleanLeaderElectionTest > sendMessages in FetcherTest > etc > It is better to unify them in TestUtils. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1416) Unify sendMessages/getMessages in unit tests
[ https://issues.apache.org/jira/browse/KAFKA-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328188#comment-14328188 ] Flutra Osmani commented on KAFKA-1416: -- May I (or how do I) assign this task to myself? > Unify sendMessages/getMessages in unit tests > > > Key: KAFKA-1416 > URL: https://issues.apache.org/jira/browse/KAFKA-1416 > Project: Kafka > Issue Type: Bug >Reporter: Guozhang Wang > Labels: newbie > > Multiple unit tests have its own internal function to send/get messages from > the brokers. For example: > sendMessages in ZookeeperConsumerConnectorTest > produceMessage in UncleanLeaderElectionTest > sendMessages in FetcherTest > etc > It is better to unify them in TestUtils. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
