[jira] [Commented] (KAFKA-1684) Implement TLS/SSL authentication
[ https://issues.apache.org/jira/browse/KAFKA-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181180#comment-14181180 ] Ivan Lyutov commented on KAFKA-1684: The high-level description is available in docs/SECURITY.md file > Implement TLS/SSL authentication > > > Key: KAFKA-1684 > URL: https://issues.apache.org/jira/browse/KAFKA-1684 > Project: Kafka > Issue Type: Sub-task > Components: security >Affects Versions: 0.9.0 >Reporter: Jay Kreps >Assignee: Ivan Lyutov > Attachments: KAFKA-1684.patch > > > Add an SSL port to the configuration and advertise this as part of the > metadata request. > If the SSL port is configured the socket server will need to add a second > Acceptor thread to listen on it. Connections accepted on this port will need > to go through the SSL handshake prior to being registered with a Processor > for request processing. > SSL requests and responses may need to be wrapped or unwrapped using the > SSLEngine that was initialized by the acceptor. This wrapping and unwrapping > is very similar to what will need to be done for SASL-based authentication > schemes. We should have a uniform interface that covers both of these and we > will need to store the instance in the session with the request. The socket > server will have to use this object when reading and writing requests. We > will need to take care with the FetchRequests as the current > FileChannel.transferTo mechanism will be incompatible with wrap/unwrap so we > can only use this optimization for unencrypted sockets that don't require > userspace translation (wrapping). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1684) Implement TLS/SSL authentication
[ https://issues.apache.org/jira/browse/KAFKA-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181176#comment-14181176 ] Ivan Lyutov commented on KAFKA-1684: Created reviewboard https://reviews.apache.org/r/27071/diff/ against branch apache/trunk > Implement TLS/SSL authentication > > > Key: KAFKA-1684 > URL: https://issues.apache.org/jira/browse/KAFKA-1684 > Project: Kafka > Issue Type: Sub-task > Components: security >Affects Versions: 0.9.0 >Reporter: Jay Kreps >Assignee: Ivan Lyutov > Attachments: KAFKA-1684.patch > > > Add an SSL port to the configuration and advertise this as part of the > metadata request. > If the SSL port is configured the socket server will need to add a second > Acceptor thread to listen on it. Connections accepted on this port will need > to go through the SSL handshake prior to being registered with a Processor > for request processing. > SSL requests and responses may need to be wrapped or unwrapped using the > SSLEngine that was initialized by the acceptor. This wrapping and unwrapping > is very similar to what will need to be done for SASL-based authentication > schemes. We should have a uniform interface that covers both of these and we > will need to store the instance in the session with the request. The socket > server will have to use this object when reading and writing requests. We > will need to take care with the FetchRequests as the current > FileChannel.transferTo mechanism will be incompatible with wrap/unwrap so we > can only use this optimization for unencrypted sockets that don't require > userspace translation (wrapping). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-1684) Implement TLS/SSL authentication
[ https://issues.apache.org/jira/browse/KAFKA-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1684: --- Attachment: KAFKA-1684.patch > Implement TLS/SSL authentication > > > Key: KAFKA-1684 > URL: https://issues.apache.org/jira/browse/KAFKA-1684 > Project: Kafka > Issue Type: Sub-task > Components: security >Affects Versions: 0.9.0 >Reporter: Jay Kreps >Assignee: Ivan Lyutov > Attachments: KAFKA-1684.patch > > > Add an SSL port to the configuration and advertise this as part of the > metadata request. > If the SSL port is configured the socket server will need to add a second > Acceptor thread to listen on it. Connections accepted on this port will need > to go through the SSL handshake prior to being registered with a Processor > for request processing. > SSL requests and responses may need to be wrapped or unwrapped using the > SSLEngine that was initialized by the acceptor. This wrapping and unwrapping > is very similar to what will need to be done for SASL-based authentication > schemes. We should have a uniform interface that covers both of these and we > will need to store the instance in the session with the request. The socket > server will have to use this object when reading and writing requests. We > will need to take care with the FetchRequests as the current > FileChannel.transferTo mechanism will be incompatible with wrap/unwrap so we > can only use this optimization for unencrypted sockets that don't require > userspace translation (wrapping). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-1684) Implement TLS/SSL authentication
[ https://issues.apache.org/jira/browse/KAFKA-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1684: --- Status: Patch Available (was: Open) > Implement TLS/SSL authentication > > > Key: KAFKA-1684 > URL: https://issues.apache.org/jira/browse/KAFKA-1684 > Project: Kafka > Issue Type: Sub-task > Components: security >Affects Versions: 0.9.0 >Reporter: Jay Kreps >Assignee: Ivan Lyutov > Attachments: KAFKA-1684.patch > > > Add an SSL port to the configuration and advertise this as part of the > metadata request. > If the SSL port is configured the socket server will need to add a second > Acceptor thread to listen on it. Connections accepted on this port will need > to go through the SSL handshake prior to being registered with a Processor > for request processing. > SSL requests and responses may need to be wrapped or unwrapped using the > SSLEngine that was initialized by the acceptor. This wrapping and unwrapping > is very similar to what will need to be done for SASL-based authentication > schemes. We should have a uniform interface that covers both of these and we > will need to store the instance in the session with the request. The socket > server will have to use this object when reading and writing requests. We > will need to take care with the FetchRequests as the current > FileChannel.transferTo mechanism will be incompatible with wrap/unwrap so we > can only use this optimization for unencrypted sockets that don't require > userspace translation (wrapping). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Review Request 27071: Patch for KAFKA-1684
/ReplicaVerificationTool.scala ba6ddd7a909df79a0f7d45e8b4a2af94ea0fceb6 core/src/main/scala/kafka/tools/SimpleConsumerPerformance.scala 7602b8d705970a5dab49ed36d117346a960701ac core/src/main/scala/kafka/tools/SimpleConsumerShell.scala b4f903b6c7c3bb725cac7c05eb1f885906413c4d core/src/main/scala/kafka/tools/UpdateOffsetsInZK.scala 111c9a8b94ce45d95551482e9fd3f8c1cccbf548 core/src/main/scala/kafka/utils/ZkUtils.scala a7b1fdcb50d5cf930352d37e39cb4fc9a080cb12 docs/SECURITY.md PRE-CREATION examples/src/main/java/kafka/examples/SimpleConsumerDemo.java c79192c5c195d4c3a7facf1be8f503478b6cc809 Diff: https://reviews.apache.org/r/27071/diff/ Testing --- Thanks, Ivan Lyutov
[jira] [Assigned] (KAFKA-1690) new java producer needs ssl support as a client
[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov reassigned KAFKA-1690: -- Assignee: Ivan Lyutov > new java producer needs ssl support as a client > --- > > Key: KAFKA-1690 > URL: https://issues.apache.org/jira/browse/KAFKA-1690 > Project: Kafka > Issue Type: Sub-task >Reporter: Joe Stein > Assignee: Ivan Lyutov > Fix For: 0.8.3 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (KAFKA-1691) new java consumer needs ssl support as a client
[ https://issues.apache.org/jira/browse/KAFKA-1691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov reassigned KAFKA-1691: -- Assignee: Ivan Lyutov > new java consumer needs ssl support as a client > --- > > Key: KAFKA-1691 > URL: https://issues.apache.org/jira/browse/KAFKA-1691 > Project: Kafka > Issue Type: Sub-task >Reporter: Joe Stein > Assignee: Ivan Lyutov > Fix For: 0.8.3 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-1493) Use a well-documented LZ4 compression format and remove redundant LZ4HC option
[ https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1493: --- Assignee: Ivan Lyutov (was: James Oliver) Status: Patch Available (was: Open) > Use a well-documented LZ4 compression format and remove redundant LZ4HC option > -- > > Key: KAFKA-1493 > URL: https://issues.apache.org/jira/browse/KAFKA-1493 > Project: Kafka > Issue Type: Improvement >Affects Versions: 0.8.2 >Reporter: James Oliver > Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1493.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1493) Use a well-documented LZ4 compression format and remove redundant LZ4HC option
[ https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14165275#comment-14165275 ] Ivan Lyutov commented on KAFKA-1493: Created reviewboard https://reviews.apache.org/r/26503/diff/ against branch apache/trunk > Use a well-documented LZ4 compression format and remove redundant LZ4HC option > -- > > Key: KAFKA-1493 > URL: https://issues.apache.org/jira/browse/KAFKA-1493 > Project: Kafka > Issue Type: Improvement >Affects Versions: 0.8.2 >Reporter: James Oliver >Assignee: James Oliver >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1493.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-1493) Use a well-documented LZ4 compression format and remove redundant LZ4HC option
[ https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1493: --- Attachment: KAFKA-1493.patch > Use a well-documented LZ4 compression format and remove redundant LZ4HC option > -- > > Key: KAFKA-1493 > URL: https://issues.apache.org/jira/browse/KAFKA-1493 > Project: Kafka > Issue Type: Improvement >Affects Versions: 0.8.2 >Reporter: James Oliver >Assignee: James Oliver >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1493.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Review Request 26503: Patch for KAFKA-1493
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26503/ --- Review request for kafka. Bugs: KAFKA-1493 https://issues.apache.org/jira/browse/KAFKA-1493 Repository: kafka Description --- KAFKA-1493 - implemented input/output lz4 streams for kafka message compression, added compression format description, minor typo fix. Diffs - clients/src/main/java/org/apache/kafka/common/message/KafkaLZ4BlockInputStream.java PRE-CREATION clients/src/main/java/org/apache/kafka/common/message/KafkaLZ4BlockOutputStream.java PRE-CREATION clients/src/main/java/org/apache/kafka/common/record/CompressionType.java 5227b2d7ab803389d1794f48c8232350c05b14fd clients/src/main/java/org/apache/kafka/common/record/Compressor.java 0323f5f7032dceb49d820c17a41b78c56591ffc4 config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 core/src/main/scala/kafka/message/CompressionCodec.scala de0a0fade5387db63299c6b112b3c9a5e41d82ec core/src/main/scala/kafka/message/CompressionFactory.scala 8420e13d0d8680648df78f22ada4a0d4e3ab8758 core/src/test/scala/unit/kafka/message/MessageCompressionTest.scala 6f0addcea64f1e78a4de50ec8135f4d02cebd305 Diff: https://reviews.apache.org/r/26503/diff/ Testing --- Thanks, Ivan Lyutov
[jira] [Updated] (KAFKA-1675) bootstrapping tidy-up
[ https://issues.apache.org/jira/browse/KAFKA-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1675: --- Attachment: KAFKA-1675.patch > bootstrapping tidy-up > - > > Key: KAFKA-1675 > URL: https://issues.apache.org/jira/browse/KAFKA-1675 > Project: Kafka > Issue Type: Bug >Reporter: Szczepan Faber > Assignee: Ivan Lyutov > Fix For: 0.8.2 > > Attachments: KAFKA-1675.patch > > > I'd like to suggest following changes: > 1. remove the 'gradlew' and 'gradlew.bat' scripts from the source tree. Those > scripts don't work, e.g. they fail with exception when invoked. I just got a > user report where those scripts were invoked by the user and it led to an > exception that was not easy to grasp. Bootstrapping step will generate those > files anyway. > 2. move the 'gradleVersion' extra property from the 'build.gradle' into > 'gradle.properties'. Otherwise it is hard to automate the bootstrapping > process - in order to find out the gradle version, I need to evaluate the > build script, and for that I need gradle with correct version (kind of a > vicious circle). Project properties declared in the gradle.properties file > can be accessed exactly the same as the 'ext' properties, for example: > 'project.gradleVersion'. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Review Request 26362: Patch for KAFKA-1675
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26362/ --- Review request for kafka. Bugs: KAFKA-1675 https://issues.apache.org/jira/browse/KAFKA-1675 Repository: kafka Description --- KAFKA-1675 - moved gradleVersion to gradle.properties, removed gradlew scripts Diffs - build.gradle 2e488a1ab0437e6aaf3221a938690cd2d98ecda8 gradle.properties 5d3155fd4461438d8b2ec4faa9534cc2383d4951 gradlew 91a7e269e19dfc62e27137a0b57ef3e430cee4fd gradlew.bat aec99730b4e8fcd90b57a0e8e01544fea7c31a89 Diff: https://reviews.apache.org/r/26362/diff/ Testing --- Thanks, Ivan Lyutov
[jira] [Commented] (KAFKA-1675) bootstrapping tidy-up
[ https://issues.apache.org/jira/browse/KAFKA-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14160314#comment-14160314 ] Ivan Lyutov commented on KAFKA-1675: Created reviewboard https://reviews.apache.org/r/26362/diff/ against branch apache/trunk > bootstrapping tidy-up > - > > Key: KAFKA-1675 > URL: https://issues.apache.org/jira/browse/KAFKA-1675 > Project: Kafka > Issue Type: Bug >Reporter: Szczepan Faber > Assignee: Ivan Lyutov > Fix For: 0.8.2 > > Attachments: KAFKA-1675.patch > > > I'd like to suggest following changes: > 1. remove the 'gradlew' and 'gradlew.bat' scripts from the source tree. Those > scripts don't work, e.g. they fail with exception when invoked. I just got a > user report where those scripts were invoked by the user and it led to an > exception that was not easy to grasp. Bootstrapping step will generate those > files anyway. > 2. move the 'gradleVersion' extra property from the 'build.gradle' into > 'gradle.properties'. Otherwise it is hard to automate the bootstrapping > process - in order to find out the gradle version, I need to evaluate the > build script, and for that I need gradle with correct version (kind of a > vicious circle). Project properties declared in the gradle.properties file > can be accessed exactly the same as the 'ext' properties, for example: > 'project.gradleVersion'. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-1675) bootstrapping tidy-up
[ https://issues.apache.org/jira/browse/KAFKA-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1675: --- Status: Patch Available (was: Open) > bootstrapping tidy-up > - > > Key: KAFKA-1675 > URL: https://issues.apache.org/jira/browse/KAFKA-1675 > Project: Kafka > Issue Type: Bug >Reporter: Szczepan Faber > Assignee: Ivan Lyutov > Fix For: 0.8.2 > > Attachments: KAFKA-1675.patch > > > I'd like to suggest following changes: > 1. remove the 'gradlew' and 'gradlew.bat' scripts from the source tree. Those > scripts don't work, e.g. they fail with exception when invoked. I just got a > user report where those scripts were invoked by the user and it led to an > exception that was not easy to grasp. Bootstrapping step will generate those > files anyway. > 2. move the 'gradleVersion' extra property from the 'build.gradle' into > 'gradle.properties'. Otherwise it is hard to automate the bootstrapping > process - in order to find out the gradle version, I need to evaluate the > build script, and for that I need gradle with correct version (kind of a > vicious circle). Project properties declared in the gradle.properties file > can be accessed exactly the same as the 'ext' properties, for example: > 'project.gradleVersion'. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1671) uploaded archives are missing for Scala version 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14160292#comment-14160292 ] Ivan Lyutov commented on KAFKA-1671: Created reviewboard https://reviews.apache.org/r/26360/diff/ against branch apache/trunk > uploaded archives are missing for Scala version 2.11 > > > Key: KAFKA-1671 > URL: https://issues.apache.org/jira/browse/KAFKA-1671 > Project: Kafka > Issue Type: Bug >Reporter: Joe Stein > Assignee: Ivan Lyutov >Priority: Blocker > Labels: newbie > Fix For: 0.8.2 > > Attachments: KAFKA-1671.patch > > > https://repository.apache.org/content/groups/staging/org/apache/kafka/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-1671) uploaded archives are missing for Scala version 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1671: --- Attachment: KAFKA-1671.patch > uploaded archives are missing for Scala version 2.11 > > > Key: KAFKA-1671 > URL: https://issues.apache.org/jira/browse/KAFKA-1671 > Project: Kafka > Issue Type: Bug >Reporter: Joe Stein > Assignee: Ivan Lyutov >Priority: Blocker > Labels: newbie > Fix For: 0.8.2 > > Attachments: KAFKA-1671.patch > > > https://repository.apache.org/content/groups/staging/org/apache/kafka/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-1671) uploaded archives are missing for Scala version 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1671: --- Status: Patch Available (was: Open) > uploaded archives are missing for Scala version 2.11 > > > Key: KAFKA-1671 > URL: https://issues.apache.org/jira/browse/KAFKA-1671 > Project: Kafka > Issue Type: Bug >Reporter: Joe Stein > Assignee: Ivan Lyutov >Priority: Blocker > Labels: newbie > Fix For: 0.8.2 > > Attachments: KAFKA-1671.patch > > > https://repository.apache.org/content/groups/staging/org/apache/kafka/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Review Request 26360: Patch for KAFKA-1671
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26360/ --- Review request for kafka. Bugs: KAFKA-1671 https://issues.apache.org/jira/browse/KAFKA-1671 Repository: kafka Description --- KAFKA-1671 - uploaded archives are missing for Scala version 2.11 Diffs - build.gradle 2e488a1ab0437e6aaf3221a938690cd2d98ecda8 Diff: https://reviews.apache.org/r/26360/diff/ Testing --- Thanks, Ivan Lyutov
[jira] [Assigned] (KAFKA-1671) uploaded archives are missing for Scala version 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov reassigned KAFKA-1671: -- Assignee: Ivan Lyutov > uploaded archives are missing for Scala version 2.11 > > > Key: KAFKA-1671 > URL: https://issues.apache.org/jira/browse/KAFKA-1671 > Project: Kafka > Issue Type: Bug >Reporter: Joe Stein > Assignee: Ivan Lyutov >Priority: Blocker > Labels: newbie > Fix For: 0.8.2 > > > https://repository.apache.org/content/groups/staging/org/apache/kafka/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 26332: Patch for KAFKA-1662
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26332/#review55417 --- Looks OK - Ivan Lyutov On Окт. 3, 2014, 11:14 п.п., Sriharsha Chintalapani wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26332/ > --- > > (Updated Окт. 3, 2014, 11:14 п.п.) > > > Review request for kafka. > > > Bugs: KAFKA-1662 > https://issues.apache.org/jira/browse/KAFKA-1662 > > > Repository: kafka > > > Description > --- > > KAFKA-1662. gradle release issue permgen space. > > > Diffs > - > > gradle.properties a04a6c8b98c892dd3370b3958793b2ba0d9b646c > > Diff: https://reviews.apache.org/r/26332/diff/ > > > Testing > --- > > > Thanks, > > Sriharsha Chintalapani > >
[jira] [Comment Edited] (KAFKA-1477) add authentication layer and initial JKS x509 implementation for brokers, producers and consumer for network communication
[ https://issues.apache.org/jira/browse/KAFKA-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14145087#comment-14145087 ] Ivan Lyutov edited comment on KAFKA-1477 at 9/23/14 5:33 PM: - Gwen Shapira, this patch is for securing existing port and nothing more. Of course, we plan to add support for simultaneous usage of secure and non-secure ports in future. was (Author: edgefox): Gwen Shapira, this patch is for securing existing port and nothing more. Of course, we plan to add support for simultaneous usage of secure and non-secure ports. > add authentication layer and initial JKS x509 implementation for brokers, > producers and consumer for network communication > -- > > Key: KAFKA-1477 > URL: https://issues.apache.org/jira/browse/KAFKA-1477 > Project: Kafka > Issue Type: New Feature >Reporter: Joe Stein >Assignee: Ivan Lyutov > Fix For: 0.9.0 > > Attachments: KAFKA-1477-binary.patch, KAFKA-1477.patch, > KAFKA-1477_2014-06-02_16:59:40.patch, KAFKA-1477_2014-06-02_17:24:26.patch, > KAFKA-1477_2014-06-03_13:46:17.patch, KAFKA-1477_trunk.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1477) add authentication layer and initial JKS x509 implementation for brokers, producers and consumer for network communication
[ https://issues.apache.org/jira/browse/KAFKA-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14145087#comment-14145087 ] Ivan Lyutov commented on KAFKA-1477: Gwen Shapira, this patch is for securing existing port and nothing more. Of course, we plan to add support for simultaneous usage of secure and non-secure ports. > add authentication layer and initial JKS x509 implementation for brokers, > producers and consumer for network communication > -- > > Key: KAFKA-1477 > URL: https://issues.apache.org/jira/browse/KAFKA-1477 > Project: Kafka > Issue Type: New Feature >Reporter: Joe Stein >Assignee: Ivan Lyutov > Fix For: 0.9.0 > > Attachments: KAFKA-1477-binary.patch, KAFKA-1477.patch, > KAFKA-1477_2014-06-02_16:59:40.patch, KAFKA-1477_2014-06-02_17:24:26.patch, > KAFKA-1477_2014-06-03_13:46:17.patch, KAFKA-1477_trunk.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1477) add authentication layer and initial JKS x509 implementation for brokers, producers and consumer for network communication
[ https://issues.apache.org/jira/browse/KAFKA-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14144683#comment-14144683 ] Ivan Lyutov commented on KAFKA-1477: Rajasekar Elango, ssl branch is located here http://github.com/edgefox/kafka/tree/kafka-ssl > add authentication layer and initial JKS x509 implementation for brokers, > producers and consumer for network communication > -- > > Key: KAFKA-1477 > URL: https://issues.apache.org/jira/browse/KAFKA-1477 > Project: Kafka > Issue Type: New Feature >Reporter: Joe Stein >Assignee: Ivan Lyutov > Fix For: 0.9.0 > > Attachments: KAFKA-1477-binary.patch, KAFKA-1477.patch, > KAFKA-1477_2014-06-02_16:59:40.patch, KAFKA-1477_2014-06-02_17:24:26.patch, > KAFKA-1477_2014-06-03_13:46:17.patch, KAFKA-1477_trunk.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1477) add authentication layer and initial JKS x509 implementation for brokers, producers and consumer for network communication
[ https://issues.apache.org/jira/browse/KAFKA-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14144682#comment-14144682 ] Ivan Lyutov commented on KAFKA-1477: I have updated the reviewboard https://reviews.apache.org/r/22131/ > add authentication layer and initial JKS x509 implementation for brokers, > producers and consumer for network communication > -- > > Key: KAFKA-1477 > URL: https://issues.apache.org/jira/browse/KAFKA-1477 > Project: Kafka > Issue Type: New Feature >Reporter: Joe Stein >Assignee: Ivan Lyutov > Fix For: 0.9.0 > > Attachments: KAFKA-1477-binary.patch, KAFKA-1477.patch, > KAFKA-1477_2014-06-02_16:59:40.patch, KAFKA-1477_2014-06-02_17:24:26.patch, > KAFKA-1477_2014-06-03_13:46:17.patch, KAFKA-1477_trunk.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 22131: Patch for KAFKA-1477
/ReplicaVerificationTool.scala af4783646803e58714770c21f8c3352370f26854 core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 36314f412a8281aece2789fd2b74a106b82c57d2 core/src/main/scala/kafka/utils/ZkUtils.scala a7b1fdcb50d5cf930352d37e39cb4fc9a080cb12 core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 1bf2667f47853585bc33ffb3e28256ec5f24ae84 core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071b1056e775326981573c9618d8046e601d core/src/test/scala/unit/kafka/network/SocketServerTest.scala 5f4d85254c384dcc27a5a84f0836ea225d3a901a core/src/test/scala/unit/kafka/utils/TestUtils.scala 2dbdd3c2f03caf1542e38e5e08a21f2a1c8b7657 gradle/wrapper/gradle-wrapper.jar a7634b071cb255e91a4572934e55b8cd8877b3e4 gradlew c312b910b570f46f0435302cda44295d8903c573 gradlew.bat 84974e20d1bef7ff9ef43933c913252189315458 Diff: https://reviews.apache.org/r/22131/diff/ Testing --- Thanks, Ivan Lyutov
Re: Review Request 22131: Patch for KAFKA-1477
af4783646803e58714770c21f8c3352370f26854 core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 36314f412a8281aece2789fd2b74a106b82c57d2 core/src/main/scala/kafka/utils/ZkUtils.scala a7b1fdcb50d5cf930352d37e39cb4fc9a080cb12 core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 1bf2667f47853585bc33ffb3e28256ec5f24ae84 core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071b1056e775326981573c9618d8046e601d core/src/test/scala/unit/kafka/network/SocketServerTest.scala 5f4d85254c384dcc27a5a84f0836ea225d3a901a core/src/test/scala/unit/kafka/utils/TestUtils.scala 2dbdd3c2f03caf1542e38e5e08a21f2a1c8b7657 gradle/wrapper/gradle-wrapper.jar a7634b071cb255e91a4572934e55b8cd8877b3e4 gradlew c312b910b570f46f0435302cda44295d8903c573 gradlew.bat 84974e20d1bef7ff9ef43933c913252189315458 Diff: https://reviews.apache.org/r/22131/diff/ Testing --- Thanks, Ivan Lyutov
[jira] [Updated] (KAFKA-1490) remove gradlew initial setup output from source distribution
[ https://issues.apache.org/jira/browse/KAFKA-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1490: --- Attachment: rb25703.patch Rebased to the latest trunk. Reviewboard has been updated accordingly. > remove gradlew initial setup output from source distribution > > > Key: KAFKA-1490 > URL: https://issues.apache.org/jira/browse/KAFKA-1490 > Project: Kafka > Issue Type: Bug >Reporter: Joe Stein > Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1490-2.patch, KAFKA-1490.patch, rb25703.patch > > > Our current source releases contains lots of stuff in the gradle folder we do > not need -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 25703: Patch for KAFKA-1490
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25703/ --- (Updated Sept. 23, 2014, 9:48 a.m.) Review request for kafka. Bugs: KAFKA-1490 https://issues.apache.org/jira/browse/KAFKA-1490 Repository: kafka Description --- Removed wrapper generated contents and added default task to generate gradle wrapper binary. remove gradlew initial setup output from source distribution Diffs (updated) - build.gradle f6e4f8ba080090e74e99e915c23b4ef4bf072e4e gradle/wrapper/gradle-wrapper.jar a7634b071cb255e91a4572934e55b8cd8877b3e4 gradle/wrapper/gradle-wrapper.properties d238df326fec6d925ccecdecaac0bcedf8e68672 wrapper.gradle PRE-CREATION Diff: https://reviews.apache.org/r/25703/diff/ Testing --- Thanks, Ivan Lyutov
[jira] [Updated] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1419: --- Attachment: KAFKA-1419_cross_build_for_scala_2_11_for_0_8_1_branch.patch Added the same patch for 0.8.1 branch > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2, 0.8.1.2 > > Attachments: KAFKA-1419-scalaBinaryVersion.patch, > KAFKA-1419-scalaBinaryVersion.patch, KAFKA-1419.patch, KAFKA-1419.patch, > KAFKA-1419_2014-07-28_15:05:16.patch, KAFKA-1419_2014-07-29_15:13:43.patch, > KAFKA-1419_2014-08-04_14:43:26.patch, KAFKA-1419_2014-08-05_12:51:16.patch, > KAFKA-1419_2014-08-07_10:17:34.patch, KAFKA-1419_2014-08-07_10:52:18.patch, > KAFKA-1419_cross_build_for_scala_2_11_for_0_8_1_branch.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-1477) add authentication layer and initial JKS x509 implementation for brokers, producers and consumer for network communication
[ https://issues.apache.org/jira/browse/KAFKA-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1477: --- Attachment: KAFKA-1477_trunk.patch Updated patch to current trunk > add authentication layer and initial JKS x509 implementation for brokers, > producers and consumer for network communication > -- > > Key: KAFKA-1477 > URL: https://issues.apache.org/jira/browse/KAFKA-1477 > Project: Kafka > Issue Type: New Feature >Reporter: Joe Stein > Assignee: Ivan Lyutov > Fix For: 0.9.0 > > Attachments: KAFKA-1477-binary.patch, KAFKA-1477.patch, > KAFKA-1477_2014-06-02_16:59:40.patch, KAFKA-1477_2014-06-02_17:24:26.patch, > KAFKA-1477_2014-06-03_13:46:17.patch, KAFKA-1477_trunk.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 22131: Patch for KAFKA-1477
af4783646803e58714770c21f8c3352370f26854 core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 36314f412a8281aece2789fd2b74a106b82c57d2 core/src/main/scala/kafka/utils/ZkUtils.scala a7b1fdcb50d5cf930352d37e39cb4fc9a080cb12 core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 1bf2667f47853585bc33ffb3e28256ec5f24ae84 core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071b1056e775326981573c9618d8046e601d core/src/test/scala/unit/kafka/network/SocketServerTest.scala 3b83a86a773147c9b29b4d271aee480efec748ad core/src/test/scala/unit/kafka/utils/TestUtils.scala c4e13c5240c8303853d08cc3b40088f8c7dae460 gradle/wrapper/gradle-wrapper.jar a7634b071cb255e91a4572934e55b8cd8877b3e4 gradlew c312b910b570f46f0435302cda44295d8903c573 gradlew.bat 84974e20d1bef7ff9ef43933c913252189315458 Diff: https://reviews.apache.org/r/22131/diff/ Testing --- Thanks, Ivan Lyutov
[jira] [Updated] (KAFKA-1622) project shouldn't require signing to build
[ https://issues.apache.org/jira/browse/KAFKA-1622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1622: --- Status: Patch Available (was: In Progress) > project shouldn't require signing to build > -- > > Key: KAFKA-1622 > URL: https://issues.apache.org/jira/browse/KAFKA-1622 > Project: Kafka > Issue Type: Bug >Reporter: Joe Stein > Assignee: Ivan Lyutov >Priority: Blocker > Labels: build, newbie, packaging > Fix For: 0.8.2 > > Attachments: KAFKA-1622.patch > > > we only need signing for uploadArchives that is it > The project trunk failed to build due to some signing/license checks (the > diff I used to get things to build is here: > https://gist.github.com/dehora/7e3c0bd75bb2b5d87557) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Review Request 25738: Made signing task to execute only when uploadArchives is called
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25738/ --- Review request for kafka. Bugs: KAFKA-1622 https://issues.apache.org/jira/browse/KAFKA-1622 Repository: kafka Description --- KAFKA-1622 - Made signing task to execute only when uploadArchives is called. Diffs - build.gradle 74c8c8a9e2f4d9a651181d5337d5a8f07f0cb313 Diff: https://reviews.apache.org/r/25738/diff/ Testing --- Thanks, Ivan Lyutov
[jira] [Updated] (KAFKA-1622) project shouldn't require signing to build
[ https://issues.apache.org/jira/browse/KAFKA-1622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1622: --- Attachment: KAFKA-1622.patch > project shouldn't require signing to build > -- > > Key: KAFKA-1622 > URL: https://issues.apache.org/jira/browse/KAFKA-1622 > Project: Kafka > Issue Type: Bug >Reporter: Joe Stein > Assignee: Ivan Lyutov >Priority: Blocker > Labels: build, newbie, packaging > Fix For: 0.8.2 > > Attachments: KAFKA-1622.patch > > > we only need signing for uploadArchives that is it > The project trunk failed to build due to some signing/license checks (the > diff I used to get things to build is here: > https://gist.github.com/dehora/7e3c0bd75bb2b5d87557) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1622) project shouldn't require signing to build
[ https://issues.apache.org/jira/browse/KAFKA-1622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14137408#comment-14137408 ] Ivan Lyutov commented on KAFKA-1622: Created reviewboard https://reviews.apache.org/r/25738/diff/ against branch apache/trunk > project shouldn't require signing to build > -- > > Key: KAFKA-1622 > URL: https://issues.apache.org/jira/browse/KAFKA-1622 > Project: Kafka > Issue Type: Bug >Reporter: Joe Stein >Assignee: Ivan Lyutov >Priority: Blocker > Labels: build, newbie, packaging > Fix For: 0.8.2 > > Attachments: KAFKA-1622.patch > > > we only need signing for uploadArchives that is it > The project trunk failed to build due to some signing/license checks (the > diff I used to get things to build is here: > https://gist.github.com/dehora/7e3c0bd75bb2b5d87557) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work started] (KAFKA-1622) project shouldn't require signing to build
[ https://issues.apache.org/jira/browse/KAFKA-1622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-1622 started by Ivan Lyutov. -- > project shouldn't require signing to build > -- > > Key: KAFKA-1622 > URL: https://issues.apache.org/jira/browse/KAFKA-1622 > Project: Kafka > Issue Type: Bug >Reporter: Joe Stein > Assignee: Ivan Lyutov >Priority: Blocker > Labels: build, newbie, packaging > Fix For: 0.8.2 > > > we only need signing for uploadArchives that is it > The project trunk failed to build due to some signing/license checks (the > diff I used to get things to build is here: > https://gist.github.com/dehora/7e3c0bd75bb2b5d87557) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 25703: Patch for KAFKA-1490
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25703/ --- (Updated Сен. 16, 2014, 6:54 п.п.) Review request for kafka. Bugs: KAFKA-1490 https://issues.apache.org/jira/browse/KAFKA-1490 Repository: kafka Description (updated) --- Removed wrapper generated contents and added default task to generate gradle wrapper binary. remove gradlew initial setup output from source distribution Diffs (updated) - build.gradle 74c8c8a9e2f4d9a651181d5337d5a8f07f0cb313 gradle/wrapper/gradle-wrapper.jar a7634b071cb255e91a4572934e55b8cd8877b3e4 gradle/wrapper/gradle-wrapper.properties d238df326fec6d925ccecdecaac0bcedf8e68672 wrapper.gradle PRE-CREATION Diff: https://reviews.apache.org/r/25703/diff/ Testing --- Thanks, Ivan Lyutov
[jira] [Comment Edited] (KAFKA-1490) remove gradlew initial setup output from source distribution
[ https://issues.apache.org/jira/browse/KAFKA-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14135928#comment-14135928 ] Ivan Lyutov edited comment on KAFKA-1490 at 9/16/14 6:41 PM: - https://reviews.apache.org/r/25703/ was (Author: edgefox): https://reviews.apache.org/r/25697/ > remove gradlew initial setup output from source distribution > > > Key: KAFKA-1490 > URL: https://issues.apache.org/jira/browse/KAFKA-1490 > Project: Kafka > Issue Type: Bug >Reporter: Joe Stein > Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1490-2.patch, KAFKA-1490.patch > > > Our current source releases contains lots of stuff in the gradle folder we do > not need -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1490) remove gradlew initial setup output from source distribution
[ https://issues.apache.org/jira/browse/KAFKA-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14135928#comment-14135928 ] Ivan Lyutov commented on KAFKA-1490: https://reviews.apache.org/r/25697/ > remove gradlew initial setup output from source distribution > > > Key: KAFKA-1490 > URL: https://issues.apache.org/jira/browse/KAFKA-1490 > Project: Kafka > Issue Type: Bug >Reporter: Joe Stein > Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1490-2.patch, KAFKA-1490.patch > > > Our current source releases contains lots of stuff in the gradle folder we do > not need -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-1490) remove gradlew initial setup output from source distribution
[ https://issues.apache.org/jira/browse/KAFKA-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1490: --- Attachment: KAFKA-1490-2.patch Ok, I applied the patch which replays the functionality from Samza. > remove gradlew initial setup output from source distribution > > > Key: KAFKA-1490 > URL: https://issues.apache.org/jira/browse/KAFKA-1490 > Project: Kafka > Issue Type: Bug >Reporter: Joe Stein > Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1490-2.patch, KAFKA-1490.patch > > > Our current source releases contains lots of stuff in the gradle folder we do > not need -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Review Request 25703: Patch for KAFKA-1490
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25703/ --- Review request for kafka. Bugs: KAFKA-1490 https://issues.apache.org/jira/browse/KAFKA-1490 Repository: kafka Description --- Removed wrapper generated contents and added default task to generate gradle wrapper binary. Diffs - build.gradle 74c8c8a9e2f4d9a651181d5337d5a8f07f0cb313 gradle/wrapper/gradle-wrapper.jar a7634b071cb255e91a4572934e55b8cd8877b3e4 gradle/wrapper/gradle-wrapper.properties d238df326fec6d925ccecdecaac0bcedf8e68672 wrapper.gradle PRE-CREATION Diff: https://reviews.apache.org/r/25703/diff/ Testing --- Thanks, Ivan Lyutov
[jira] [Commented] (KAFKA-1490) remove gradlew initial setup output from source distribution
[ https://issues.apache.org/jira/browse/KAFKA-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14135760#comment-14135760 ] Ivan Lyutov commented on KAFKA-1490: Sorry guys for my previous post. I've confused ".gradle" and "gradle" directories. So, my method should not work. However, I think that this issue is not related to Kafka project and should be resolved in Gradle instead. Furthermore, if we eventually resolve this issue, than it could cause gradle version problems in future for Gradle 1.x and 2.x users, since some plugins work under 1.x, but not under 2.x. > remove gradlew initial setup output from source distribution > > > Key: KAFKA-1490 > URL: https://issues.apache.org/jira/browse/KAFKA-1490 > Project: Kafka > Issue Type: Bug > Reporter: Joe Stein >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1490.patch > > > Our current source releases contains lots of stuff in the gradle folder we do > not need -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1490) remove gradlew initial setup output from source distribution
[ https://issues.apache.org/jira/browse/KAFKA-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14135703#comment-14135703 ] Ivan Lyutov commented on KAFKA-1490: I've deleted the gradlew output jar file and left properties file for configuration needs. If you want to use local gradle distribution use gradle, otherwise ./gradlew will download gradle with version specified in properties file > remove gradlew initial setup output from source distribution > > > Key: KAFKA-1490 > URL: https://issues.apache.org/jira/browse/KAFKA-1490 > Project: Kafka > Issue Type: Bug >Reporter: Joe Stein >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1490.patch > > > Our current source releases contains lots of stuff in the gradle folder we do > not need -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-1490) remove gradlew initial setup output from source distribution
[ https://issues.apache.org/jira/browse/KAFKA-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1490: --- Attachment: KAFKA-1490.patch > remove gradlew initial setup output from source distribution > > > Key: KAFKA-1490 > URL: https://issues.apache.org/jira/browse/KAFKA-1490 > Project: Kafka > Issue Type: Bug >Reporter: Joe Stein > Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1490.patch > > > Our current source releases contains lots of stuff in the gradle folder we do > not need -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Review Request 25697: Patch for KAFKA-1490
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25697/ --- Review request for kafka. Bugs: KAFKA-1490 https://issues.apache.org/jira/browse/KAFKA-1490 Repository: kafka Description --- remove gradlew initial setup output from source distribution Diffs - gradle/wrapper/gradle-wrapper.jar a7634b071cb255e91a4572934e55b8cd8877b3e4 Diff: https://reviews.apache.org/r/25697/diff/ Testing --- Thanks, Ivan Lyutov
[jira] [Work started] (KAFKA-1490) remove gradlew initial setup output from source distribution
[ https://issues.apache.org/jira/browse/KAFKA-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-1490 started by Ivan Lyutov. -- > remove gradlew initial setup output from source distribution > > > Key: KAFKA-1490 > URL: https://issues.apache.org/jira/browse/KAFKA-1490 > Project: Kafka > Issue Type: Bug >Reporter: Joe Stein > Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > > Our current source releases contains lots of stuff in the gradle folder we do > not need -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089125#comment-14089125 ] Ivan Lyutov commented on KAFKA-1419: Updated reviewboard https://reviews.apache.org/r/23895/diff/ against branch apache/trunk > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1419.patch, KAFKA-1419.patch, > KAFKA-1419_2014-07-28_15:05:16.patch, KAFKA-1419_2014-07-29_15:13:43.patch, > KAFKA-1419_2014-08-04_14:43:26.patch, KAFKA-1419_2014-08-05_12:51:16.patch, > KAFKA-1419_2014-08-07_10:17:34.patch, KAFKA-1419_2014-08-07_10:52:18.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1419: --- Attachment: KAFKA-1419_2014-08-07_10:52:18.patch > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1419.patch, KAFKA-1419.patch, > KAFKA-1419_2014-07-28_15:05:16.patch, KAFKA-1419_2014-07-29_15:13:43.patch, > KAFKA-1419_2014-08-04_14:43:26.patch, KAFKA-1419_2014-08-05_12:51:16.patch, > KAFKA-1419_2014-08-07_10:17:34.patch, KAFKA-1419_2014-08-07_10:52:18.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
Re: Review Request 23895: Patch for KAFKA-1419
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/ --- (Updated Aug. 7, 2014, 10:52 a.m.) Review request for kafka. Bugs: KAFKA-1419 https://issues.apache.org/jira/browse/KAFKA-1419 Repository: kafka Description (updated) --- KAFKA-1419 - cross build for scala 2.11 - dropped scala 2.8 support - minor bug fixes KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes - removed annotations 2.8 file KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes - removed annotations 2.8 file - updated kafka-run-class.sh to run kafka classes with proper version KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes - removed annotations 2.8 file KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes - removed annotations 2.8 file - changed default scala version to 2.10.1 KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes - removed annotations 2.8 file - changed default scala version to 2.10.1 Diffs (updated) - bin/kafka-run-class.sh 5d5021dff8daeaf8e35923f6df31d7fc3d850e68 build.gradle 9cbedb87e1e2b7d1c41f6a41c9adb4ad9c72930d core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala fecee8d5f7b32f483bb1bfc6a5080d589906f9c4 core/src/main/scala/kafka/message/ByteBufferMessageSet.scala 73401c5ff34d08abce22267aa9c4d86632c6fb74 core/src/main/scala/kafka/utils/Annotations_2.8.scala 28269eb037109f7680b9da732e4baa51c9a594b6 core/src/main/scala/kafka/utils/Annotations_2.9+.scala gradle.properties 4827769a3f8e34f0fe7e783eb58e44d4db04859b gradle/buildscript.gradle 225e0a82708bc5f390e5e2c1d4d9a0d06f491b95 gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 scala.gradle ebd21b870c0746aade63248344ab65d9b5baf820 Diff: https://reviews.apache.org/r/23895/diff/ Testing --- Thanks, Ivan Lyutov
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089103#comment-14089103 ] Ivan Lyutov commented on KAFKA-1419: Updated reviewboard https://reviews.apache.org/r/23895/diff/ against branch apache/trunk > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1419.patch, KAFKA-1419.patch, > KAFKA-1419_2014-07-28_15:05:16.patch, KAFKA-1419_2014-07-29_15:13:43.patch, > KAFKA-1419_2014-08-04_14:43:26.patch, KAFKA-1419_2014-08-05_12:51:16.patch, > KAFKA-1419_2014-08-07_10:17:34.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1419: --- Attachment: KAFKA-1419_2014-08-07_10:17:34.patch > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1419.patch, KAFKA-1419.patch, > KAFKA-1419_2014-07-28_15:05:16.patch, KAFKA-1419_2014-07-29_15:13:43.patch, > KAFKA-1419_2014-08-04_14:43:26.patch, KAFKA-1419_2014-08-05_12:51:16.patch, > KAFKA-1419_2014-08-07_10:17:34.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
Re: Review Request 23895: Patch for KAFKA-1419
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/ --- (Updated Aug. 7, 2014, 10:17 a.m.) Review request for kafka. Bugs: KAFKA-1419 https://issues.apache.org/jira/browse/KAFKA-1419 Repository: kafka Description (updated) --- KAFKA-1419 - cross build for scala 2.11 - dropped scala 2.8 support - minor bug fixes KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes - removed annotations 2.8 file KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes - removed annotations 2.8 file - updated kafka-run-class.sh to run kafka classes with proper version KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes - removed annotations 2.8 file Diffs (updated) - bin/kafka-run-class.sh 5d5021dff8daeaf8e35923f6df31d7fc3d850e68 build.gradle 9cbedb87e1e2b7d1c41f6a41c9adb4ad9c72930d core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala fecee8d5f7b32f483bb1bfc6a5080d589906f9c4 core/src/main/scala/kafka/message/ByteBufferMessageSet.scala 73401c5ff34d08abce22267aa9c4d86632c6fb74 core/src/main/scala/kafka/utils/Annotations_2.8.scala 28269eb037109f7680b9da732e4baa51c9a594b6 core/src/main/scala/kafka/utils/Annotations_2.9+.scala gradle.properties 4827769a3f8e34f0fe7e783eb58e44d4db04859b gradle/buildscript.gradle 225e0a82708bc5f390e5e2c1d4d9a0d06f491b95 gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 scala.gradle ebd21b870c0746aade63248344ab65d9b5baf820 Diff: https://reviews.apache.org/r/23895/diff/ Testing --- Thanks, Ivan Lyutov
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14086215#comment-14086215 ] Ivan Lyutov commented on KAFKA-1419: Updated reviewboard https://reviews.apache.org/r/23895/diff/ against branch apache/trunk > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1419.patch, KAFKA-1419.patch, > KAFKA-1419_2014-07-28_15:05:16.patch, KAFKA-1419_2014-07-29_15:13:43.patch, > KAFKA-1419_2014-08-04_14:43:26.patch, KAFKA-1419_2014-08-05_12:51:16.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1419: --- Attachment: KAFKA-1419_2014-08-05_12:51:16.patch > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1419.patch, KAFKA-1419.patch, > KAFKA-1419_2014-07-28_15:05:16.patch, KAFKA-1419_2014-07-29_15:13:43.patch, > KAFKA-1419_2014-08-04_14:43:26.patch, KAFKA-1419_2014-08-05_12:51:16.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
Re: Review Request 23895: Patch for KAFKA-1419
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/ --- (Updated Aug. 5, 2014, 12:52 p.m.) Review request for kafka. Bugs: KAFKA-1419 https://issues.apache.org/jira/browse/KAFKA-1419 Repository: kafka Description (updated) --- KAFKA-1419 - cross build for scala 2.11 - dropped scala 2.8 support - minor bug fixes KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes - removed annotations 2.8 file KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes - removed annotations 2.8 file - updated kafka-run-class.sh to run kafka classes with proper version Diffs (updated) - bin/kafka-run-class.sh 5d5021dff8daeaf8e35923f6df31d7fc3d850e68 build.gradle a72905df824ba68bed5d5170d18873c23e1782c9 core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala fecee8d5f7b32f483bb1bfc6a5080d589906f9c4 core/src/main/scala/kafka/message/ByteBufferMessageSet.scala 73401c5ff34d08abce22267aa9c4d86632c6fb74 core/src/main/scala/kafka/utils/Annotations_2.8.scala 28269eb037109f7680b9da732e4baa51c9a594b6 core/src/main/scala/kafka/utils/Annotations_2.9+.scala gradle.properties 4827769a3f8e34f0fe7e783eb58e44d4db04859b gradle/buildscript.gradle 225e0a82708bc5f390e5e2c1d4d9a0d06f491b95 gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 scala.gradle ebd21b870c0746aade63248344ab65d9b5baf820 Diff: https://reviews.apache.org/r/23895/diff/ Testing --- Thanks, Ivan Lyutov
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084715#comment-14084715 ] Ivan Lyutov commented on KAFKA-1419: Updated reviewboard https://reviews.apache.org/r/23895/diff/ against branch apache/trunk > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1419.patch, KAFKA-1419.patch, > KAFKA-1419_2014-07-28_15:05:16.patch, KAFKA-1419_2014-07-29_15:13:43.patch, > KAFKA-1419_2014-08-04_14:43:26.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1419: --- Attachment: KAFKA-1419_2014-08-04_14:43:26.patch > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1419.patch, KAFKA-1419.patch, > KAFKA-1419_2014-07-28_15:05:16.patch, KAFKA-1419_2014-07-29_15:13:43.patch, > KAFKA-1419_2014-08-04_14:43:26.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
Re: Review Request 23895: Patch for KAFKA-1419
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/ --- (Updated Aug. 4, 2014, 2:43 p.m.) Review request for kafka. Bugs: KAFKA-1419 https://issues.apache.org/jira/browse/KAFKA-1419 Repository: kafka Description (updated) --- KAFKA-1419 - cross build for scala 2.11 - dropped scala 2.8 support - minor bug fixes KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes - removed annotations 2.8 file Diffs (updated) - build.gradle a72905df824ba68bed5d5170d18873c23e1782c9 core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala fecee8d5f7b32f483bb1bfc6a5080d589906f9c4 core/src/main/scala/kafka/message/ByteBufferMessageSet.scala 73401c5ff34d08abce22267aa9c4d86632c6fb74 core/src/main/scala/kafka/utils/Annotations_2.8.scala 28269eb037109f7680b9da732e4baa51c9a594b6 core/src/main/scala/kafka/utils/Annotations_2.9+.scala gradle.properties 4827769a3f8e34f0fe7e783eb58e44d4db04859b gradle/buildscript.gradle 225e0a82708bc5f390e5e2c1d4d9a0d06f491b95 gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 scala.gradle ebd21b870c0746aade63248344ab65d9b5baf820 Diff: https://reviews.apache.org/r/23895/diff/ Testing --- Thanks, Ivan Lyutov
[jira] [Updated] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1419: --- Attachment: KAFKA-1419_2014-07-29_15:13:43.patch > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1419.patch, KAFKA-1419.patch, > KAFKA-1419_2014-07-28_15:05:16.patch, KAFKA-1419_2014-07-29_15:13:43.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14077817#comment-14077817 ] Ivan Lyutov commented on KAFKA-1419: Updated reviewboard https://reviews.apache.org/r/23895/diff/ against branch apache/trunk > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1419.patch, KAFKA-1419.patch, > KAFKA-1419_2014-07-28_15:05:16.patch, KAFKA-1419_2014-07-29_15:13:43.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
Re: Review Request 23895: Patch for KAFKA-1419
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/ --- (Updated July 29, 2014, 3:13 p.m.) Review request for kafka. Bugs: KAFKA-1419 https://issues.apache.org/jira/browse/KAFKA-1419 Repository: kafka Description (updated) --- KAFKA-1419 - cross build for scala 2.11 - dropped scala 2.8 support - minor bug fixes KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes Diffs (updated) - build.gradle a72905df824ba68bed5d5170d18873c23e1782c9 core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala fecee8d5f7b32f483bb1bfc6a5080d589906f9c4 core/src/main/scala/kafka/message/ByteBufferMessageSet.scala 73401c5ff34d08abce22267aa9c4d86632c6fb74 gradle.properties 4827769a3f8e34f0fe7e783eb58e44d4db04859b gradle/buildscript.gradle 225e0a82708bc5f390e5e2c1d4d9a0d06f491b95 gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 scala.gradle ebd21b870c0746aade63248344ab65d9b5baf820 Diff: https://reviews.apache.org/r/23895/diff/ Testing --- Thanks, Ivan Lyutov
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076285#comment-14076285 ] Ivan Lyutov commented on KAFKA-1419: Updated reviewboard https://reviews.apache.org/r/23895/diff/ against branch apache/trunk > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1419.patch, KAFKA-1419.patch, > KAFKA-1419_2014-07-28_15:05:16.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1419: --- Attachment: KAFKA-1419_2014-07-28_15:05:16.patch > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1419.patch, KAFKA-1419.patch, > KAFKA-1419_2014-07-28_15:05:16.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
Re: Review Request 23895: Patch for KAFKA-1419
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/ --- (Updated July 28, 2014, 3:07 p.m.) Review request for kafka. Bugs: KAFKA-1419 https://issues.apache.org/jira/browse/KAFKA-1419 Repository: kafka Description (updated) --- KAFKA-1419 - cross build for scala 2.11 - dropped scala 2.8 support - minor bug fixes Diffs (updated) - build.gradle a72905df824ba68bed5d5170d18873c23e1782c9 core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala fecee8d5f7b32f483bb1bfc6a5080d589906f9c4 core/src/main/scala/kafka/message/ByteBufferMessageSet.scala 73401c5ff34d08abce22267aa9c4d86632c6fb74 gradle.properties 4827769a3f8e34f0fe7e783eb58e44d4db04859b gradle/buildscript.gradle 225e0a82708bc5f390e5e2c1d4d9a0d06f491b95 gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 scala.gradle ebd21b870c0746aade63248344ab65d9b5baf820 Diff: https://reviews.apache.org/r/23895/diff/ Testing --- Thanks, Ivan Lyutov
[jira] [Updated] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1419: --- Attachment: KAFKA-1419.patch > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1419.patch, KAFKA-1419.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073337#comment-14073337 ] Ivan Lyutov commented on KAFKA-1419: Created reviewboard https://reviews.apache.org/r/23895/diff/ against branch apache/trunk > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1419.patch, KAFKA-1419.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
Review Request 23895: Patch for KAFKA-1419
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/ --- Review request for kafka. Bugs: KAFKA-1419 https://issues.apache.org/jira/browse/KAFKA-1419 Repository: kafka Description --- KAFKA-1419 - cross build for scala 2.11 Diffs - build.gradle a72905df824ba68bed5d5170d18873c23e1782c9 core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala fecee8d5f7b32f483bb1bfc6a5080d589906f9c4 core/src/main/scala/kafka/message/ByteBufferMessageSet.scala 73401c5ff34d08abce22267aa9c4d86632c6fb74 gradle.properties 4827769a3f8e34f0fe7e783eb58e44d4db04859b gradle/buildscript.gradle 225e0a82708bc5f390e5e2c1d4d9a0d06f491b95 gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 Diff: https://reviews.apache.org/r/23895/diff/ Testing --- Thanks, Ivan Lyutov
[jira] [Commented] (KAFKA-42) Support rebalancing the partitions with replication
[ https://issues.apache.org/jira/browse/KAFKA-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073298#comment-14073298 ] Ivan Lyutov commented on KAFKA-42: -- Updated reviewboard against branch apache/0.8.1 > Support rebalancing the partitions with replication > --- > > Key: KAFKA-42 > URL: https://issues.apache.org/jira/browse/KAFKA-42 > Project: Kafka > Issue Type: Bug > Components: core >Reporter: Jun Rao >Assignee: Neha Narkhede >Priority: Blocker > Labels: features > Fix For: 0.8.0 > > Attachments: KAFKA-42.patch, KAFKA-42_2014-07-24_15:36:04.patch, > KAFKA-42_2014-07-24_15:37:26.patch, kafka-42-v1.patch, kafka-42-v2.patch, > kafka-42-v3.patch, kafka-42-v4.patch, kafka-42-v5.patch > > Original Estimate: 240h > Remaining Estimate: 240h > > As new brokers are added, we need to support moving partition replicas from > one set of brokers to another, online. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073300#comment-14073300 ] Ivan Lyutov commented on KAFKA-1419: Created reviewboard against branch apache/0.8.1 > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1419.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1419: --- Attachment: KAFKA-1419.patch > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1419.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (KAFKA-42) Support rebalancing the partitions with replication
[ https://issues.apache.org/jira/browse/KAFKA-42?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-42: - Attachment: KAFKA-42_2014-07-24_15:37:26.patch > Support rebalancing the partitions with replication > --- > > Key: KAFKA-42 > URL: https://issues.apache.org/jira/browse/KAFKA-42 > Project: Kafka > Issue Type: Bug > Components: core >Reporter: Jun Rao >Assignee: Neha Narkhede >Priority: Blocker > Labels: features > Fix For: 0.8.0 > > Attachments: KAFKA-42.patch, KAFKA-42_2014-07-24_15:36:04.patch, > KAFKA-42_2014-07-24_15:37:26.patch, kafka-42-v1.patch, kafka-42-v2.patch, > kafka-42-v3.patch, kafka-42-v4.patch, kafka-42-v5.patch > > Original Estimate: 240h > Remaining Estimate: 240h > > As new brokers are added, we need to support moving partition replicas from > one set of brokers to another, online. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (KAFKA-42) Support rebalancing the partitions with replication
[ https://issues.apache.org/jira/browse/KAFKA-42?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-42: - Attachment: KAFKA-42_2014-07-24_15:36:04.patch > Support rebalancing the partitions with replication > --- > > Key: KAFKA-42 > URL: https://issues.apache.org/jira/browse/KAFKA-42 > Project: Kafka > Issue Type: Bug > Components: core >Reporter: Jun Rao >Assignee: Neha Narkhede >Priority: Blocker > Labels: features > Fix For: 0.8.0 > > Attachments: KAFKA-42.patch, KAFKA-42_2014-07-24_15:36:04.patch, > kafka-42-v1.patch, kafka-42-v2.patch, kafka-42-v3.patch, kafka-42-v4.patch, > kafka-42-v5.patch > > Original Estimate: 240h > Remaining Estimate: 240h > > As new brokers are added, we need to support moving partition replicas from > one set of brokers to another, online. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1308) Publish jar of test utilities to Maven
[
https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14035969#comment-14035969
]
Ivan Lyutov commented on KAFKA-1308:
+1
Patch looks nice. It might be very useful.
> Publish jar of test utilities to Maven
> --
>
> Key: KAFKA-1308
> URL: https://issues.apache.org/jira/browse/KAFKA-1308
> Project: Kafka
> Issue Type: Wish
>Affects Versions: 0.8.1
>Reporter: Martin Kleppmann
>Priority: Blocker
> Fix For: 0.8.2
>
> Attachments: KAFKA-1308.patch
>
>
> For projects that use Kafka, and want to write tests that exercise Kafka (in
> our case, Samza), it's useful to have access to Kafka's test utility classes
> such as kafka.zk.EmbeddedZookeeper and kafka.utils.TestUtils. We can use
> {{./gradlew testJar}} to build jar files that contain those classes, but as
> far as I know, these are currently not made available in a binary release.
> At the moment, we have to check those kafka*-test.jar files into the Samza
> repository. To avoid that, would it be possible to publish those jars of
> tests to Maven, so that they fit into the normal dependency management?
> Or perhaps, if publishing the tests themselves is not appropriate, we could
> move the test utilities into a separate module that is published, and make
> the tests depend on that module?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (KAFKA-1477) add authentication layer and initial JKS x509 implementation for brokers, producers and consumer for network communication
[ https://issues.apache.org/jira/browse/KAFKA-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14028352#comment-14028352 ] Ivan Lyutov commented on KAFKA-1477: Rajasekar, the previous patch failed to apply on latest trunk version(https://github.com/stealthly/kafka/tree/v0.8.2_KAFKA-1477). So, I had to do make the patch manually. There are still some items pending, such as making security off by default and more testing stuff. So, you can expect one more patch in the nearest future. > add authentication layer and initial JKS x509 implementation for brokers, > producers and consumer for network communication > -- > > Key: KAFKA-1477 > URL: https://issues.apache.org/jira/browse/KAFKA-1477 > Project: Kafka > Issue Type: New Feature >Reporter: Joe Stein >Assignee: Ivan Lyutov > Fix For: 0.8.2 > > Attachments: KAFKA-1477-binary.patch, KAFKA-1477.patch, > KAFKA-1477_2014-06-02_16:59:40.patch, KAFKA-1477_2014-06-02_17:24:26.patch, > KAFKA-1477_2014-06-03_13:46:17.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (KAFKA-1477) add authentication layer and initial JKS x509 implementation for brokers, producers and consumer for network communication
[ https://issues.apache.org/jira/browse/KAFKA-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1477: --- Attachment: KAFKA-1477-binary.patch > add authentication layer and initial JKS x509 implementation for brokers, > producers and consumer for network communication > -- > > Key: KAFKA-1477 > URL: https://issues.apache.org/jira/browse/KAFKA-1477 > Project: Kafka > Issue Type: New Feature >Reporter: Joe Stein > Assignee: Ivan Lyutov > Fix For: 0.8.2 > > Attachments: KAFKA-1477-binary.patch, KAFKA-1477.patch, > KAFKA-1477_2014-06-02_16:59:40.patch, KAFKA-1477_2014-06-02_17:24:26.patch, > KAFKA-1477_2014-06-03_13:46:17.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
Re: Review Request 22131: Patch for KAFKA-1477
> On June 3, 2014, 3:14 a.m., Joe Stein wrote: > > core/src/main/scala/kafka/network/BlockingChannel.scala, line 80 > > <https://reviews.apache.org/r/22131/diff/3/?file=601681#file601681line80> > > > > is this change and the ones below it, are they really required? Yes. Otherwise, there will be an exception thrown on consumer close. - Ivan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/#review44591 --- On June 3, 2014, 10:53 a.m., Ivan Lyutov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22131/ > --- > > (Updated June 3, 2014, 10:53 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1477 > https://issues.apache.org/jira/browse/KAFKA-1477 > > > Repository: kafka > > > Description > --- > > Updated according to requested changes: refactoring, minor edits. > > > Reverted gradle version > > > Added SSL for Kafka > > Minor fixes, cleanup > > Refactoring > > Fixed tests compilation error. > > > Diffs > - > > config/client.keystore PRE-CREATION > config/client.public-key PRE-CREATION > config/client.security.properties PRE-CREATION > config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f > config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 > config/server.keystore PRE-CREATION > config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 > config/server.public-key PRE-CREATION > config/server.security.properties PRE-CREATION > core/src/main/scala/kafka/api/FetchRequest.scala > a8b73acd1a813284744359e8434cb52d22063c99 > core/src/main/scala/kafka/client/ClientUtils.scala > ba5fbdcd9e60f953575e529325caf4c41e22f22d > core/src/main/scala/kafka/cluster/Broker.scala > 9407ed21fbbd57edeecd888edc32bea6a05d95b3 > core/src/main/scala/kafka/common/UnknownKeyStoreException.scala > PRE-CREATION > core/src/main/scala/kafka/consumer/ConsoleConsumer.scala > 1a16c691683dda0c53f316e3c4797ea38e776574 > core/src/main/scala/kafka/consumer/ConsumerConfig.scala > 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 > core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala > b9e2bea7b442a19bcebd1b350d39541a8c9dd068 > core/src/main/scala/kafka/consumer/SimpleConsumer.scala > 0e64632210385ef63c2ad3445b55ac4f37a63df2 > core/src/main/scala/kafka/controller/ControllerChannelManager.scala > 8763968fbff697e4c5c98ab1274627c192a4d26a > core/src/main/scala/kafka/network/BlockingChannel.scala > eb7bb14d94cb3648c06d4de36a3b34aacbde4556 > core/src/main/scala/kafka/network/SocketServer.scala > 4976d9c3a66bc965f5870a0736e21c7b32650bab > core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION > core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION > core/src/main/scala/kafka/network/security/SSLSocketChannel.scala > PRE-CREATION > core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION > core/src/main/scala/kafka/network/security/store/JKSInitializer.scala > PRE-CREATION > core/src/main/scala/kafka/producer/ConsoleProducer.scala > a2af988d99a94a20291d6a2dc9bec73197f1b756 > core/src/main/scala/kafka/producer/ProducerConfig.scala > 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 > core/src/main/scala/kafka/producer/ProducerPool.scala > 43df70bb461dd3e385e6b20396adef3c4016a3fc > core/src/main/scala/kafka/producer/SyncProducer.scala > 489f0077512d9a69be81649c490274964290fa40 > core/src/main/scala/kafka/producer/SyncProducerConfig.scala > 69b2d0c11bb1412ce76d566f285333c806be301a > core/src/main/scala/kafka/server/AbstractFetcherThread.scala > 3b15254f32252cf824d7a292889ac7662d73ada1 > core/src/main/scala/kafka/server/KafkaConfig.scala > ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 > core/src/main/scala/kafka/server/KafkaHealthcheck.scala > 4acdd70fe9c1ee78d6510741006c2ece65450671 > core/src/main/scala/kafka/server/KafkaServer.scala > c22e51e0412843ec993721ad3230824c0aadd2ba > core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala > 19df757d75fdbb3ff0b434b6cb10338ff5cc32da > core/src/main/scala/kafka/tools/GetOffsetShell.scala > fba652e3716a67b04431fc46790ad255201b639f > core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala > 91f072816418040a396a0cad26bc889f539dadd6 > core/src/main/scala/kafka/tools/Simp
[jira] [Commented] (KAFKA-1477) add authentication layer and initial JKS x509 implementation for brokers, producers and consumer for network communication
[ https://issues.apache.org/jira/browse/KAFKA-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14016379#comment-14016379 ] Ivan Lyutov commented on KAFKA-1477: Updated reviewboard https://reviews.apache.org/r/22131/ against branch apache/trunk > add authentication layer and initial JKS x509 implementation for brokers, > producers and consumer for network communication > -- > > Key: KAFKA-1477 > URL: https://issues.apache.org/jira/browse/KAFKA-1477 > Project: Kafka > Issue Type: New Feature >Reporter: Joe Stein >Assignee: Ivan Lyutov > Fix For: 0.8.2 > > Attachments: KAFKA-1477.patch, KAFKA-1477_2014-06-02_16:59:40.patch, > KAFKA-1477_2014-06-02_17:24:26.patch, KAFKA-1477_2014-06-03_13:46:17.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (KAFKA-1477) add authentication layer and initial JKS x509 implementation for brokers, producers and consumer for network communication
[ https://issues.apache.org/jira/browse/KAFKA-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1477: --- Attachment: KAFKA-1477_2014-06-03_13:46:17.patch > add authentication layer and initial JKS x509 implementation for brokers, > producers and consumer for network communication > -- > > Key: KAFKA-1477 > URL: https://issues.apache.org/jira/browse/KAFKA-1477 > Project: Kafka > Issue Type: New Feature >Reporter: Joe Stein > Assignee: Ivan Lyutov > Fix For: 0.8.2 > > Attachments: KAFKA-1477.patch, KAFKA-1477_2014-06-02_16:59:40.patch, > KAFKA-1477_2014-06-02_17:24:26.patch, KAFKA-1477_2014-06-03_13:46:17.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
Re: Review Request 22131: Patch for KAFKA-1477
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/ --- (Updated June 3, 2014, 10:53 a.m.) Review request for kafka. Bugs: KAFKA-1477 https://issues.apache.org/jira/browse/KAFKA-1477 Repository: kafka Description (updated) --- Updated according to requested changes: refactoring, minor edits. Reverted gradle version Added SSL for Kafka Minor fixes, cleanup Refactoring Fixed tests compilation error. Diffs (updated) - config/client.keystore PRE-CREATION config/client.public-key PRE-CREATION config/client.security.properties PRE-CREATION config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 config/server.keystore PRE-CREATION config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 config/server.public-key PRE-CREATION config/server.security.properties PRE-CREATION core/src/main/scala/kafka/api/FetchRequest.scala a8b73acd1a813284744359e8434cb52d22063c99 core/src/main/scala/kafka/client/ClientUtils.scala ba5fbdcd9e60f953575e529325caf4c41e22f22d core/src/main/scala/kafka/cluster/Broker.scala 9407ed21fbbd57edeecd888edc32bea6a05d95b3 core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 1a16c691683dda0c53f316e3c4797ea38e776574 core/src/main/scala/kafka/consumer/ConsumerConfig.scala 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068 core/src/main/scala/kafka/consumer/SimpleConsumer.scala 0e64632210385ef63c2ad3445b55ac4f37a63df2 core/src/main/scala/kafka/controller/ControllerChannelManager.scala 8763968fbff697e4c5c98ab1274627c192a4d26a core/src/main/scala/kafka/network/BlockingChannel.scala eb7bb14d94cb3648c06d4de36a3b34aacbde4556 core/src/main/scala/kafka/network/SocketServer.scala 4976d9c3a66bc965f5870a0736e21c7b32650bab core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION core/src/main/scala/kafka/network/security/SSLSocketChannel.scala PRE-CREATION core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION core/src/main/scala/kafka/network/security/store/JKSInitializer.scala PRE-CREATION core/src/main/scala/kafka/producer/ConsoleProducer.scala a2af988d99a94a20291d6a2dc9bec73197f1b756 core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 core/src/main/scala/kafka/producer/ProducerPool.scala 43df70bb461dd3e385e6b20396adef3c4016a3fc core/src/main/scala/kafka/producer/SyncProducer.scala 489f0077512d9a69be81649c490274964290fa40 core/src/main/scala/kafka/producer/SyncProducerConfig.scala 69b2d0c11bb1412ce76d566f285333c806be301a core/src/main/scala/kafka/server/AbstractFetcherThread.scala 3b15254f32252cf824d7a292889ac7662d73ada1 core/src/main/scala/kafka/server/KafkaConfig.scala ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 core/src/main/scala/kafka/server/KafkaHealthcheck.scala 4acdd70fe9c1ee78d6510741006c2ece65450671 core/src/main/scala/kafka/server/KafkaServer.scala c22e51e0412843ec993721ad3230824c0aadd2ba core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 19df757d75fdbb3ff0b434b6cb10338ff5cc32da core/src/main/scala/kafka/tools/GetOffsetShell.scala fba652e3716a67b04431fc46790ad255201b639f core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 91f072816418040a396a0cad26bc889f539dadd6 core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 747e07280cce72d621acbc771337b909a9b2487e core/src/main/scala/kafka/utils/ZkUtils.scala fcbe269b6057b45793ea95f357890d5d6922e8d4 core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071b1056e775326981573c9618d8046e601d core/src/test/scala/unit/kafka/network/SocketServerTest.scala 62fb02cf02d3876b9804d756c4bf8514554cc836 core/src/test/scala/unit/kafka/utils/TestUtils.scala 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb Diff: https://reviews.apache.org/r/22131/diff/ Testing --- Thanks, Ivan Lyutov
[jira] [Updated] (KAFKA-1477) add authentication layer and initial JKS x509 implementation for brokers, producers and consumer for network communication
[ https://issues.apache.org/jira/browse/KAFKA-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1477: --- Attachment: KAFKA-1477_2014-06-02_17:24:26.patch > add authentication layer and initial JKS x509 implementation for brokers, > producers and consumer for network communication > -- > > Key: KAFKA-1477 > URL: https://issues.apache.org/jira/browse/KAFKA-1477 > Project: Kafka > Issue Type: New Feature >Reporter: Joe Stein > Assignee: Ivan Lyutov > Fix For: 0.8.2 > > Attachments: KAFKA-1477.patch, KAFKA-1477_2014-06-02_16:59:40.patch, > KAFKA-1477_2014-06-02_17:24:26.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1477) add authentication layer and initial JKS x509 implementation for brokers, producers and consumer for network communication
[ https://issues.apache.org/jira/browse/KAFKA-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14015426#comment-14015426 ] Ivan Lyutov commented on KAFKA-1477: Updated reviewboard https://reviews.apache.org/r/22131/ against branch apache/trunk > add authentication layer and initial JKS x509 implementation for brokers, > producers and consumer for network communication > -- > > Key: KAFKA-1477 > URL: https://issues.apache.org/jira/browse/KAFKA-1477 > Project: Kafka > Issue Type: New Feature >Reporter: Joe Stein >Assignee: Ivan Lyutov > Fix For: 0.8.2 > > Attachments: KAFKA-1477.patch, KAFKA-1477_2014-06-02_16:59:40.patch, > KAFKA-1477_2014-06-02_17:24:26.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
Re: Review Request 22131: Patch for KAFKA-1477
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/ --- (Updated June 2, 2014, 2:32 p.m.) Review request for kafka. Bugs: KAFKA-1477 https://issues.apache.org/jira/browse/KAFKA-1477 Repository: kafka Description (updated) --- Reverted gradle version Added SSL for Kafka Minor fixes, cleanup Refactoring Fixed tests compilation error. Diffs (updated) - config/client.keystore PRE-CREATION config/client.public-key PRE-CREATION config/client.security.properties PRE-CREATION config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 config/server.keystore PRE-CREATION config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 config/server.public-key PRE-CREATION config/server.security.properties PRE-CREATION core/src/main/scala/kafka/api/FetchRequest.scala a8b73acd1a813284744359e8434cb52d22063c99 core/src/main/scala/kafka/client/ClientUtils.scala ba5fbdcd9e60f953575e529325caf4c41e22f22d core/src/main/scala/kafka/cluster/Broker.scala 9407ed21fbbd57edeecd888edc32bea6a05d95b3 core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 1a16c691683dda0c53f316e3c4797ea38e776574 core/src/main/scala/kafka/consumer/ConsumerConfig.scala 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068 core/src/main/scala/kafka/consumer/SimpleConsumer.scala 0e64632210385ef63c2ad3445b55ac4f37a63df2 core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 65f518d47c7555c42c4bff39c211814831f4b8b6 core/src/main/scala/kafka/controller/ControllerChannelManager.scala 8763968fbff697e4c5c98ab1274627c192a4d26a core/src/main/scala/kafka/network/BlockingChannel.scala eb7bb14d94cb3648c06d4de36a3b34aacbde4556 core/src/main/scala/kafka/network/SocketServer.scala 4976d9c3a66bc965f5870a0736e21c7b32650bab core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION core/src/main/scala/kafka/network/security/SSLSocketChannel.scala PRE-CREATION core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION core/src/main/scala/kafka/network/security/store/JKSInitializer.scala PRE-CREATION core/src/main/scala/kafka/producer/ConsoleProducer.scala a2af988d99a94a20291d6a2dc9bec73197f1b756 core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 core/src/main/scala/kafka/producer/ProducerPool.scala 43df70bb461dd3e385e6b20396adef3c4016a3fc core/src/main/scala/kafka/producer/SyncProducer.scala 489f0077512d9a69be81649c490274964290fa40 core/src/main/scala/kafka/producer/SyncProducerConfig.scala 69b2d0c11bb1412ce76d566f285333c806be301a core/src/main/scala/kafka/server/AbstractFetcherThread.scala 3b15254f32252cf824d7a292889ac7662d73ada1 core/src/main/scala/kafka/server/KafkaConfig.scala ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 core/src/main/scala/kafka/server/KafkaHealthcheck.scala 4acdd70fe9c1ee78d6510741006c2ece65450671 core/src/main/scala/kafka/server/KafkaServer.scala c22e51e0412843ec993721ad3230824c0aadd2ba core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 19df757d75fdbb3ff0b434b6cb10338ff5cc32da core/src/main/scala/kafka/tools/GetOffsetShell.scala fba652e3716a67b04431fc46790ad255201b639f core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 91f072816418040a396a0cad26bc889f539dadd6 core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 747e07280cce72d621acbc771337b909a9b2487e core/src/main/scala/kafka/utils/ZkUtils.scala fcbe269b6057b45793ea95f357890d5d6922e8d4 core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071b1056e775326981573c9618d8046e601d core/src/test/scala/unit/kafka/network/SocketServerTest.scala 62fb02cf02d3876b9804d756c4bf8514554cc836 core/src/test/scala/unit/kafka/utils/TestUtils.scala 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 Diff: https://reviews.apache.org/r/22131/diff/ Testing --- Thanks, Ivan Lyutov
[jira] [Updated] (KAFKA-1477) add authentication layer and initial JKS x509 implementation for brokers, producers and consumer for network communication
[ https://issues.apache.org/jira/browse/KAFKA-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1477: --- Attachment: KAFKA-1477_2014-06-02_16:59:40.patch > add authentication layer and initial JKS x509 implementation for brokers, > producers and consumer for network communication > -- > > Key: KAFKA-1477 > URL: https://issues.apache.org/jira/browse/KAFKA-1477 > Project: Kafka > Issue Type: New Feature >Reporter: Joe Stein > Assignee: Ivan Lyutov > Fix For: 0.8.2 > > Attachments: KAFKA-1477.patch, KAFKA-1477_2014-06-02_16:59:40.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1477) add authentication layer and initial JKS x509 implementation for brokers, producers and consumer for network communication
[ https://issues.apache.org/jira/browse/KAFKA-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14015408#comment-14015408 ] Ivan Lyutov commented on KAFKA-1477: Updated reviewboard https://reviews.apache.org/r/22131/ against branch apache/trunk > add authentication layer and initial JKS x509 implementation for brokers, > producers and consumer for network communication > -- > > Key: KAFKA-1477 > URL: https://issues.apache.org/jira/browse/KAFKA-1477 > Project: Kafka > Issue Type: New Feature >Reporter: Joe Stein >Assignee: Ivan Lyutov > Fix For: 0.8.2 > > Attachments: KAFKA-1477.patch, KAFKA-1477_2014-06-02_16:59:40.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
Re: Review Request 22131: Patch for KAFKA-1477
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/ --- (Updated June 2, 2014, 2:07 p.m.) Review request for kafka. Bugs: KAFKA-1477 https://issues.apache.org/jira/browse/KAFKA-1477 Repository: kafka Description (updated) --- Added SSL for Kafka Minor fixes, cleanup Refactoring Fixed tests compilation error. Diffs (updated) - config/client.keystore PRE-CREATION config/client.public-key PRE-CREATION config/client.security.properties PRE-CREATION config/consumer.properties 7343cbc28cf8b8de3f096d09c2be955bea73164f config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 config/server.keystore PRE-CREATION config/server.properties c9e923aed8551e0797b1ea6f69628b277faf8f48 config/server.public-key PRE-CREATION config/server.security.properties PRE-CREATION core/src/main/scala/kafka/api/FetchRequest.scala a8b73acd1a813284744359e8434cb52d22063c99 core/src/main/scala/kafka/client/ClientUtils.scala ba5fbdcd9e60f953575e529325caf4c41e22f22d core/src/main/scala/kafka/cluster/Broker.scala 9407ed21fbbd57edeecd888edc32bea6a05d95b3 core/src/main/scala/kafka/common/UnknownKeyStoreException.scala PRE-CREATION core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 1a16c691683dda0c53f316e3c4797ea38e776574 core/src/main/scala/kafka/consumer/ConsumerConfig.scala 1cf2f62ba02e4aa66bfa7575865e5d57baf82212 core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala b9e2bea7b442a19bcebd1b350d39541a8c9dd068 core/src/main/scala/kafka/consumer/SimpleConsumer.scala 0e64632210385ef63c2ad3445b55ac4f37a63df2 core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 65f518d47c7555c42c4bff39c211814831f4b8b6 core/src/main/scala/kafka/controller/ControllerChannelManager.scala 8763968fbff697e4c5c98ab1274627c192a4d26a core/src/main/scala/kafka/network/BlockingChannel.scala eb7bb14d94cb3648c06d4de36a3b34aacbde4556 core/src/main/scala/kafka/network/SocketServer.scala 4976d9c3a66bc965f5870a0736e21c7b32650bab core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION core/src/main/scala/kafka/network/security/SSLSocketChannel.scala PRE-CREATION core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION core/src/main/scala/kafka/network/security/store/JKSInitializer.scala PRE-CREATION core/src/main/scala/kafka/producer/ConsoleProducer.scala a2af988d99a94a20291d6a2dc9bec73197f1b756 core/src/main/scala/kafka/producer/ProducerConfig.scala 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 core/src/main/scala/kafka/producer/ProducerPool.scala 43df70bb461dd3e385e6b20396adef3c4016a3fc core/src/main/scala/kafka/producer/SyncProducer.scala 489f0077512d9a69be81649c490274964290fa40 core/src/main/scala/kafka/producer/SyncProducerConfig.scala 69b2d0c11bb1412ce76d566f285333c806be301a core/src/main/scala/kafka/server/AbstractFetcherThread.scala 3b15254f32252cf824d7a292889ac7662d73ada1 core/src/main/scala/kafka/server/KafkaConfig.scala ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 core/src/main/scala/kafka/server/KafkaHealthcheck.scala 4acdd70fe9c1ee78d6510741006c2ece65450671 core/src/main/scala/kafka/server/KafkaServer.scala c22e51e0412843ec993721ad3230824c0aadd2ba core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 19df757d75fdbb3ff0b434b6cb10338ff5cc32da core/src/main/scala/kafka/tools/GetOffsetShell.scala fba652e3716a67b04431fc46790ad255201b639f core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala 91f072816418040a396a0cad26bc889f539dadd6 core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 747e07280cce72d621acbc771337b909a9b2487e core/src/main/scala/kafka/utils/ZkUtils.scala fcbe269b6057b45793ea95f357890d5d6922e8d4 core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1 core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071b1056e775326981573c9618d8046e601d core/src/test/scala/unit/kafka/network/SocketServerTest.scala 62fb02cf02d3876b9804d756c4bf8514554cc836 core/src/test/scala/unit/kafka/utils/TestUtils.scala 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 Diff: https://reviews.apache.org/r/22131/diff/ Testing --- Thanks, Ivan Lyutov
[jira] [Commented] (KAFKA-1477) add authentication layer and initial JKS x509 implementation for brokers, producers and consumer for network communication
[ https://issues.apache.org/jira/browse/KAFKA-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14015384#comment-14015384 ] Ivan Lyutov commented on KAFKA-1477: Created reviewboard https://reviews.apache.org/r/22131/ against branch origin/trunk > add authentication layer and initial JKS x509 implementation for brokers, > producers and consumer for network communication > -- > > Key: KAFKA-1477 > URL: https://issues.apache.org/jira/browse/KAFKA-1477 > Project: Kafka > Issue Type: New Feature >Reporter: Joe Stein >Assignee: Ivan Lyutov > Fix For: 0.8.2 > > Attachments: KAFKA-1477.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (KAFKA-1477) add authentication layer and initial JKS x509 implementation for brokers, producers and consumer for network communication
[ https://issues.apache.org/jira/browse/KAFKA-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1477: --- Attachment: KAFKA-1477.patch > add authentication layer and initial JKS x509 implementation for brokers, > producers and consumer for network communication > -- > > Key: KAFKA-1477 > URL: https://issues.apache.org/jira/browse/KAFKA-1477 > Project: Kafka > Issue Type: New Feature >Reporter: Joe Stein > Assignee: Ivan Lyutov > Fix For: 0.8.2 > > Attachments: KAFKA-1477.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
Review Request 22131: Patch for KAFKA-1477
nit/kafka/admin/DeleteTopicTest.scala e704290e59dbd42b77c75c70e49a43116119856f core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala d39a9a4bf89af493122b663f1378b9d01c9440ec core/src/test/scala/unit/kafka/consumer/ConsumerIteratorTest.scala 9347ea60f2c02bd01b1c8507e30cb7dfdeaa5d72 core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala 258dd25a201cd9a9afd96d03a0ad3687c48f6f75 core/src/test/scala/unit/kafka/integration/AutoOffsetResetTest.scala e5703bc16b2ce2306395f0c773a0e8a82ac63176 core/src/test/scala/unit/kafka/integration/FetcherTest.scala 47130d33c36fabf19ffd94d488fd4281e23b1bdd core/src/test/scala/unit/kafka/integration/LazyInitProducerTest.scala c3c7631659fbd9265e45aa810d32faafe9aed1d1 core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala d44c3ff1d354874ed912dc8df960ff664f652786 core/src/test/scala/unit/kafka/integration/ProducerConsumerTestHarness.scala 731ee59e67e302f4cb1da12b1d4ae7ff59010aea core/src/test/scala/unit/kafka/integration/RollingBounceTest.scala e86ee803ab9c707820fc2d867212d500da760c3a core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 9998a1156d41d6afcaf5674bb9b45e16652c8167 core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala c5f2da993918242389fbb25bd903bf479e26f839 core/src/test/scala/unit/kafka/javaapi/consumer/ZookeeperConsumerConnectorTest.scala 43af649f3297644e8caea176a79cadde745be2a4 core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala 9aeb69d4934b9aa94e0899af14fc27e7c20f039f core/src/test/scala/unit/kafka/log/LogManagerTest.scala b4bee33191ebc0b4ab5a5f82fa232cd3bda8fef8 core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala 67497dd042dfd4ad54875fe29200d67f59137264 core/src/test/scala/unit/kafka/message/MessageCompressionTest.scala ed22931f24fed3530d374b56495a5e4bc89c72f2 core/src/test/scala/unit/kafka/network/SocketServerTest.scala c3b1ac445cf496dede87267a9601a466e453fecc core/src/test/scala/unit/kafka/producer/AsyncProducerTest.scala 18e355501808c00b610da8346e0dd1898d5b9301 core/src/test/scala/unit/kafka/producer/ProducerTest.scala 4b2e4ade70f6f3d1804f4627e1eb680f6721c93d core/src/test/scala/unit/kafka/producer/SyncProducerTest.scala 8d63e312d3edac0ee0400b8cf316828c2a5a064f core/src/test/scala/unit/kafka/server/DynamicConfigChangeTest.scala PRE-CREATION core/src/test/scala/unit/kafka/server/HighwatermarkPersistenceTest.scala a78f7cfa025b0c5d968381b6d5dc7aec894a612b core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala 38e3ae72a87e13f6e1a739cc8c75b781fb004133 core/src/test/scala/unit/kafka/server/LogOffsetTest.scala e1022850d1efc828b8135fb0aa3f19801afc core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala db0e58bb018f2030d06b65fa31461062fd9b1786 core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala ae9bb3a69d57143b868ead12d736377a001b1536 core/src/test/scala/unit/kafka/server/ReplicaFetchTest.scala dd85c718167158ad01f00d9aa6f990bf4ec9a6af core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala b5936d4101b513baa805ab26361fe965bdf980aa core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala 20fe93e623319fd82236eb6364d7f80bf7a256aa core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala 22bb6f2847b8895f8fbba6c531963ebb0fffe2ca core/src/test/scala/unit/kafka/utils/TestUtils.scala 2054c25bbced6bd90c092a1974975732ad346146 doap_Kafka.rdf PRE-CREATION gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 gradlew.bat PRE-CREATION kafka-patch-review.py dc6664d22a0b18f96d7d3513a6d1fe739d45c000 perf/src/main/scala/kafka/perf/ProducerPerformance.scala 9e4ebafc4557594d0d87a25e51a9432ef813bb9c system_test/README.txt 87937ecd7d637c62f2d401f54f1d669ac0d13f0a system_test/migration_tool_testsuite/0.7/config/log4j.properties PRE-CREATION system_test/migration_tool_testsuite/config/migration_producer.properties 17b5928a1213fc0cae7cd94cd214323ccca61d48 system_test/migration_tool_testsuite/migration_tool_test.py 2386a5884fcf86bac282ef28f07a3af740185f7f system_test/mirror_maker_testsuite/config/mirror_producer.properties 4391bc8b440255dc795d0a944fa9420060238984 system_test/producer_perf/config/server.properties 9f8a633ab2f92862e7e7bcc40d699daf00c69e23 system_test/utils/kafka_system_test_utils.py 35f2d1b0464edb738cd8e01f8654913776c49459 Diff: https://reviews.apache.org/r/22131/diff/ Testing --- Thanks, Ivan Lyutov
[jira] [Updated] (KAFKA-1351) String.format is very expensive in Scala
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1351: --- Attachment: KAFKA-1351_2014-04-09_15:40:11.patch > String.format is very expensive in Scala > > > Key: KAFKA-1351 > URL: https://issues.apache.org/jira/browse/KAFKA-1351 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.7.2, 0.8.0, 0.8.1 >Reporter: Neha Narkhede > Labels: newbie > Attachments: KAFKA-1351.patch, KAFKA-1351_2014-04-07_18:02:18.patch, > KAFKA-1351_2014-04-09_15:40:11.patch > > > As found in KAFKA-1350, logging is causing significant overhead in the > performance of a Kafka server. There are several info statements that use > String.format which is particularly expensive. We should investigate adding > our own version of String.format that merely uses string concatenation under > the covers. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13964090#comment-13964090 ] Ivan Lyutov commented on KAFKA-1351: Updated reviewboard https://reviews.apache.org/r/20083/ against branch apache/trunk > String.format is very expensive in Scala > > > Key: KAFKA-1351 > URL: https://issues.apache.org/jira/browse/KAFKA-1351 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.7.2, 0.8.0, 0.8.1 >Reporter: Neha Narkhede > Labels: newbie > Attachments: KAFKA-1351.patch, KAFKA-1351_2014-04-07_18:02:18.patch, > KAFKA-1351_2014-04-09_15:40:11.patch > > > As found in KAFKA-1350, logging is causing significant overhead in the > performance of a Kafka server. There are several info statements that use > String.format which is particularly expensive. We should investigate adding > our own version of String.format that merely uses string concatenation under > the covers. -- This message was sent by Atlassian JIRA (v6.2#6252)
Re: Review Request 20083: Patch for KAFKA-1351
/BoundedByteBufferReceive.scala a44254564531a3fc6008da2be6c1df8bdb75ec75 core/src/main/scala/kafka/network/RequestChannel.scala a6ec970d72fc8adc56bc6e200d1ff5bbf0d2b748 core/src/main/scala/kafka/network/SocketServer.scala dcfca3f4156957b0006ba9bfdeca848c115825a8 core/src/main/scala/kafka/producer/BrokerPartitionInfo.scala 13a8aa665016e19284c8ced35bac2195fe9e4378 core/src/main/scala/kafka/producer/ProducerPool.scala 43df70bb461dd3e385e6b20396adef3c4016a3fc core/src/main/scala/kafka/producer/SyncProducer.scala 489f0077512d9a69be81649c490274964290fa40 core/src/main/scala/kafka/producer/async/DefaultEventHandler.scala d8ac915de31a26d7aa67760d69373975cacd0c9d core/src/main/scala/kafka/server/AbstractFetcherManager.scala 9390edf37dae9815d4a3790fdd31dac422382698 core/src/main/scala/kafka/server/AbstractFetcherThread.scala db7017b8a8ff06384674f36792053e4bc68419f1 core/src/main/scala/kafka/server/KafkaApis.scala c068ef69207c351eec413a595f1747c59f8b3983 core/src/main/scala/kafka/server/KafkaHealthcheck.scala 4acdd70fe9c1ee78d6510741006c2ece65450671 core/src/main/scala/kafka/server/KafkaRequestHandler.scala 871212bf9110ca95ca7d2109be070f69d0f90247 core/src/main/scala/kafka/server/KafkaServer.scala c208f83bed7fb91f07fae42f2b66892e6d46fecc core/src/main/scala/kafka/server/OffsetCheckpoint.scala 19f61a9718a7f8e6f9bf743ac9eb2118d0fdd9b0 core/src/main/scala/kafka/server/OffsetManager.scala 89a88a7e4055f804429b64e85b2f65312d1e2155 core/src/main/scala/kafka/server/ReplicaFetcherManager.scala 351dbbad3bdb709937943b336a5b0a9e0162a5e2 core/src/main/scala/kafka/server/ReplicaFetcherThread.scala 75ae1e161769a020a102009df416009bd6710f4a core/src/main/scala/kafka/server/ReplicaManager.scala 0f5aaa9888d6c0ca0b073f4742bee14ad72d0484 core/src/main/scala/kafka/server/RequestPurgatory.scala c064c5c4cf1191335572da8a2caf5f95dce902c1 core/src/main/scala/kafka/server/TopicConfigManager.scala d41fd33d91406dfa2ce8c1e1b04a078e983ccadd core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala e5b6ff1e2544b043007cf16a6b9dd4451c839e63 core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 88f824fa5afe7964efc569bc0732fd40a55c5c93 core/src/main/scala/kafka/tools/DumpLogSegments.scala f0ab02a4e6dd1b945b263607c26ae22f00e6b158 core/src/main/scala/kafka/tools/ExportZkOffsets.scala 005231f38dd9cea60ec953a28a1ab57d3e316eed core/src/main/scala/kafka/tools/GetOffsetShell.scala fba652e3716a67b04431fc46790ad255201b639f core/src/main/scala/kafka/tools/ImportZkOffsets.scala c8023ee60c07b6e59906da9331bd5d764fd60cba core/src/main/scala/kafka/tools/MirrorMaker.scala e4d1a86f673f7df7fe71ce44e3550fcde8d01bba core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 747e07280cce72d621acbc771337b909a9b2487e core/src/main/scala/kafka/tools/TestLogCleaning.scala edb6e5f8fe511debd8b971dddb786e684ed7e1ac core/src/main/scala/kafka/tools/UpdateOffsetsInZK.scala 111c9a8b94ce45d95551482e9fd3f8c1cccbf548 core/src/main/scala/kafka/tools/VerifyConsumerRebalance.scala 92c0d1f979fba3496d1f092cc073073dcf4447e6 core/src/main/scala/kafka/tools/newproducer/MirrorMaker.scala a969a22c6b82ed5c9f053a50594b1c7a768efd0e core/src/main/scala/kafka/utils/Json.scala d1102844748f2e88f79932281fe95583a57d2d16 core/src/main/scala/kafka/utils/KafkaScheduler.scala 8e3750506c1803f34b9f1829b21097f1441d7463 core/src/main/scala/kafka/utils/Log4jController.scala a015c8109f050cabdea988f2215bd01ec0d8573a core/src/main/scala/kafka/utils/Throttler.scala d1a144d7882919426824799ff8e8a47f89c83158 core/src/main/scala/kafka/utils/Utils.scala 6bfbac16e2f8d68b8c711a0336c698aa6f610ae8 core/src/main/scala/kafka/utils/VerifiableProperties.scala d40b03ca844ebb3e4f91e8bc44bc5edcf4cb292c core/src/main/scala/kafka/utils/ZkUtils.scala 16bf7e3e87b520b31485199b2830494ca5f96c1a core/src/test/scala/unit/kafka/utils/UtilsTest.scala 920f318c85a747b689f97c0e73e4234f20b1460a Diff: https://reviews.apache.org/r/20083/diff/ Testing --- Thanks, Ivan Lyutov
Re: Review Request 20083: Patch for KAFKA-1351
> On April 9, 2014, 1:23 a.m., Jun Rao wrote: > > Thanks for the patch. Do you have any performance numbers? Sure, It showed ~37% perfomance gain on 1 Operations. See testFormatStringPerformance for details. - Ivan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20083/#review39852 --- On April 7, 2014, 3:02 p.m., Ivan Lyutov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20083/ > --- > > (Updated April 7, 2014, 3:02 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1351 > https://issues.apache.org/jira/browse/KAFKA-1351 > > > Repository: kafka > > > Description > --- > > KAFKA-1351 - Implemented more efficient substitution for String.format in > Scala. > > > Diffs > - > > core/src/main/scala/kafka/utils/Utils.scala > 6bfbac16e2f8d68b8c711a0336c698aa6f610ae8 > core/src/test/scala/unit/kafka/utils/UtilsTest.scala > 920f318c85a747b689f97c0e73e4234f20b1460a > > Diff: https://reviews.apache.org/r/20083/diff/ > > > Testing > --- > > > Thanks, > > Ivan Lyutov > >
[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961900#comment-13961900 ] Ivan Lyutov commented on KAFKA-1351: Updated reviewboard https://reviews.apache.org/r/20083/ against branch apache/trunk > String.format is very expensive in Scala > > > Key: KAFKA-1351 > URL: https://issues.apache.org/jira/browse/KAFKA-1351 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.7.2, 0.8.0, 0.8.1 >Reporter: Neha Narkhede > Labels: newbie > Attachments: KAFKA-1351.patch, KAFKA-1351_2014-04-07_18:02:18.patch > > > As found in KAFKA-1350, logging is causing significant overhead in the > performance of a Kafka server. There are several info statements that use > String.format which is particularly expensive. We should investigate adding > our own version of String.format that merely uses string concatenation under > the covers. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (KAFKA-1351) String.format is very expensive in Scala
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1351: --- Attachment: KAFKA-1351_2014-04-07_18:02:18.patch > String.format is very expensive in Scala > > > Key: KAFKA-1351 > URL: https://issues.apache.org/jira/browse/KAFKA-1351 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.7.2, 0.8.0, 0.8.1 >Reporter: Neha Narkhede > Labels: newbie > Attachments: KAFKA-1351.patch, KAFKA-1351_2014-04-07_18:02:18.patch > > > As found in KAFKA-1350, logging is causing significant overhead in the > performance of a Kafka server. There are several info statements that use > String.format which is particularly expensive. We should investigate adding > our own version of String.format that merely uses string concatenation under > the covers. -- This message was sent by Atlassian JIRA (v6.2#6252)
Re: Review Request 20083: Patch for KAFKA-1351
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20083/ --- (Updated April 7, 2014, 3:02 p.m.) Review request for kafka. Bugs: KAFKA-1351 https://issues.apache.org/jira/browse/KAFKA-1351 Repository: kafka Description (updated) --- KAFKA-1351 - Implemented more efficient substitution for String.format in Scala. Diffs (updated) - core/src/main/scala/kafka/utils/Utils.scala 6bfbac16e2f8d68b8c711a0336c698aa6f610ae8 core/src/test/scala/unit/kafka/utils/UtilsTest.scala 920f318c85a747b689f97c0e73e4234f20b1460a Diff: https://reviews.apache.org/r/20083/diff/ Testing --- Thanks, Ivan Lyutov
[jira] [Updated] (KAFKA-1351) String.format is very expensive in Scala
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1351: --- Attachment: KAFKA-1351.patch > String.format is very expensive in Scala > > > Key: KAFKA-1351 > URL: https://issues.apache.org/jira/browse/KAFKA-1351 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.7.2, 0.8.0, 0.8.1 >Reporter: Neha Narkhede > Labels: newbie > Attachments: KAFKA-1351.patch > > > As found in KAFKA-1350, logging is causing significant overhead in the > performance of a Kafka server. There are several info statements that use > String.format which is particularly expensive. We should investigate adding > our own version of String.format that merely uses string concatenation under > the covers. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961874#comment-13961874 ] Ivan Lyutov commented on KAFKA-1351: Created reviewboard https://reviews.apache.org/r/20083/ against branch apache/trunk > String.format is very expensive in Scala > > > Key: KAFKA-1351 > URL: https://issues.apache.org/jira/browse/KAFKA-1351 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.7.2, 0.8.0, 0.8.1 >Reporter: Neha Narkhede > Labels: newbie > Attachments: KAFKA-1351.patch > > > As found in KAFKA-1350, logging is causing significant overhead in the > performance of a Kafka server. There are several info statements that use > String.format which is particularly expensive. We should investigate adding > our own version of String.format that merely uses string concatenation under > the covers. -- This message was sent by Atlassian JIRA (v6.2#6252)
Review Request 20083: Patch for KAFKA-1351
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20083/ --- Review request for kafka. Bugs: KAFKA-1351 https://issues.apache.org/jira/browse/KAFKA-1351 Repository: kafka Description --- KAFKA-1351 - Implemented more efficient substitution for String.format in Scala. KAFKA-1352 - Reduce logging on the server. Logging improvement. KAFKA-1352 - Reduce logging on the server Merge remote-tracking branch 'apache/trunk' into trunk Merge branch 'trunk' of git://git.apache.org/kafka into trunk [KAFKA-1344] - comment edits. Minor refactoring. [KAFKA-1344] - removed --compress option since it's redundant. Added --compression-codec argument support to OldProducer as well. [KAFKA-1344] - Added compression codec option feature for ConsoleProducer Diffs - core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala ff5e81943e10ef37de16f657aeecc25e17d3e83a core/src/main/scala/kafka/server/AbstractFetcherThread.scala db7017b8a8ff06384674f36792053e4bc68419f1 core/src/main/scala/kafka/server/KafkaApis.scala c068ef69207c351eec413a595f1747c59f8b3983 core/src/main/scala/kafka/utils/Utils.scala 6bfbac16e2f8d68b8c711a0336c698aa6f610ae8 core/src/test/scala/unit/kafka/utils/UtilsTest.scala 920f318c85a747b689f97c0e73e4234f20b1460a Diff: https://reviews.apache.org/r/20083/diff/ Testing --- Thanks, Ivan Lyutov
[jira] [Commented] (KAFKA-1352) Reduce logging on the server
[ https://issues.apache.org/jira/browse/KAFKA-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13960226#comment-13960226 ] Ivan Lyutov commented on KAFKA-1352: Updated reviewboard https://reviews.apache.org/r/20030/ against branch apache/trunk > Reduce logging on the server > > > Key: KAFKA-1352 > URL: https://issues.apache.org/jira/browse/KAFKA-1352 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.8.0, 0.8.1 >Reporter: Neha Narkhede >Assignee: Ivan Lyutov > Labels: newbie, usability > Attachments: KAFKA-1352.patch, KAFKA-1352_2014-04-04_21:20:31.patch > > > We have excessive logging in the server, making the logs unreadable and also > affecting the performance of the server in practice. We need to clean the > logs to address these issues. -- This message was sent by Atlassian JIRA (v6.2#6252)
