[GitHub] kafka-site pull request: MINOR: Replace Scala style guide PDF link...
GitHub user RyanCoonan opened a pull request: https://github.com/apache/kafka-site/pull/13 MINOR: Replace Scala style guide PDF link with scala-lang.org link The style guide PDF currently linked to is mostly empty with just "Moved to " links. You can merge this pull request into a Git repository by running: $ git pull https://github.com/RyanCoonan/kafka-site patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka-site/pull/13.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #13 commit f1560fc4b6f1fca03fa81f90b1112004bc6d59b7 Author: Ryan Coonan Date: 2016-05-14T19:00:37Z Replace style guide link with scala-lang.org link The style guide PDF linked to currently just points to this page anyway. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka-site pull request: MINOR: Fix typos and formatting in coding...
GitHub user RyanCoonan opened a pull request: https://github.com/apache/kafka-site/pull/14 MINOR: Fix typos and formatting in coding-guide.html You can merge this pull request into a Git repository by running: $ git pull https://github.com/RyanCoonan/kafka-site patch-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka-site/pull/14.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #14 commit 9d646947cc5a63eaca34f1768f2909207c601340 Author: Ryan Coonan Date: 2016-05-14T20:19:17Z MINOR: Fix typos and formatting in coding-guide.html --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka-site pull request: MINOR: Replace Scala style guide PDF link...
Github user RyanCoonan commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/13#discussion_r63551060 --- Diff: coding-guide.html --- @@ -19,7 +19,7 @@ Scala -We are following the style guide given http://davetron5000.github.com/scala-style/ScalaStyleGuide.pdf ">here (though not perfectly). Below are some specifics worth noting: +We are following the style guide given http://docs.scala-lang.org/style/ ">here (though not perfectly). Below are some specifics worth noting: --- End diff -- Yes and no. Yes because it was already there, and I wasn't sure if there was some reason for it. No because I didn't choose for it to be there. I am somewhat removed from HTML-land so I didn't know it this was some convention or something. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka-site pull request: MINOR: Fix typos and formatting in coding...
Github user RyanCoonan closed the pull request at: https://github.com/apache/kafka-site/pull/14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka-site pull request: MINOR: Replace Scala style guide PDF link...
Github user RyanCoonan commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/13#discussion_r63553295 --- Diff: coding-guide.html --- @@ -19,7 +19,7 @@ Scala -We are following the style guide given http://davetron5000.github.com/scala-style/ScalaStyleGuide.pdf ">here (though not perfectly). Below are some specifics worth noting: +We are following the style guide given http://docs.scala-lang.org/style/ ">here (though not perfectly). Below are some specifics worth noting: --- End diff -- Removed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
