[jira] [Created] (KAFKA-15565) KafkaAdminClient does not honor request timeout ms

[Sankalp Bhatia (Jira)]

Sankalp Bhatia created KAFKA-15565:
--

 Summary: KafkaAdminClient does not honor request timeout ms 
 Key: KAFKA-15565
 URL: https://issues.apache.org/jira/browse/KAFKA-15565
 Project: Kafka
  Issue Type: Bug
Reporter: Sankalp Bhatia
Assignee: Sankalp Bhatia


It seems to me there is a bug in this line in the KafkaAdminClient. For the 
constructor arg defaultRequestTimeoutMs of NetworkClient [1], it uses a 
hardcoded value of 1 hour.  Ideally, this should be derived from the client 
config     /** request.timeout.ms */ from the 
AdminClientConfig[2]. 


References

[1]https://github.com/apache/kafka/blob/1c3eb4395a15cf4f45b6dc0d39effb3dc087f5a4/clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java#L521

[2]https://github.com/apache/kafka/blob/1c3eb4395a15cf4f45b6dc0d39effb3dc087f5a4/clients/src/main/java/org/apache/kafka/clients/admin/AdminClientConfig.java#L98



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: Is it safe to delete old log segments manually?

[Sankalp Bhatia]

Thank you for the response Peter. However, for us all the brokers are
currently offline. So if I delete the entire topic-partition directory in
one of the brokers, the first broker would start with no means to replicate
the data which we just deleted. What are your thoughts on this? Do you
think this approach will work safe in our case?

Thanks,
Sankalp

On Thu, 25 Mar 2021 at 21:09, Peter Bukowinski  wrote:

> Hi Sankalp,
>
> As long as you have replication, I’ve found it is safest to delete entire
> topic-partition directories than it is to delete individual log segments
> from them. For one, you get back more space. Second, you don’t have to
> worry about metadata corruption.
>
> When I’ve run out of disk space in the past, the first thing I did was
> reduce topic retention where I could, waited for the log cleanup routines
> to run, then I looked for and deleted associated topic partition
> directories on the brokers with filled disks before starting kafka on them.
> When the brokers rejoined the cluster, they started catching up on the
> deleted topic-partition directories.
>
> --
> Peter Bukowinski
>
> > On Mar 25, 2021, at 8:00 AM, Sankalp Bhatia 
> wrote:
> >
> > Hi All,
> >
> > Brokers in one of our Apache Kafka clusters are continuously crashing as
> > they have run out of disk space. As per my understanding, reducing the
> > value of retention.ms and retention.bytes properties will not work
> because
> > the broker is crashing before the log-retention thread can be scheduled (
> > link
> > <
> https://github.com/apache/kafka/blob/3eaf44ba8ea26a7a820894390e8877d404ddd5a2/core/src/main/scala/kafka/log/LogManager.scala#L394-L398
> >
> > ).
> > One option we are exploring is if we can manually delete some of the old
> > segment files to make some space in our data disk for the broker to
> startup
> > while reducing the retention.ms config at the same time. There is an old
> > email thread (link
> > <
> https://mail-archives.apache.org/mod_mbox/kafka-users/201403.mbox/%3CCAOG_4Qbwx44T-=vrpkvqgrum8lpmdzl2bxxrgz5c9h1_noh...@mail.gmail.com%3E
> >)
> > which suggests it is safe to do so, but we want to understand if there
> have
> > been recent changes to topic-partition metadata which we might end up
> > corrupting if we try this? If so, are there any tips to get around this
> > issue?
> >
> > Thanks,
> > Sankalp
>

Is it safe to delete old log segments manually?

[Sankalp Bhatia]

Hi All,

Brokers in one of our Apache Kafka clusters are continuously crashing as
they have run out of disk space. As per my understanding, reducing the
value of retention.ms and retention.bytes properties will not work because
the broker is crashing before the log-retention thread can be scheduled (
link

).
One option we are exploring is if we can manually delete some of the old
segment files to make some space in our data disk for the broker to startup
while reducing the retention.ms config at the same time. There is an old
email thread (link
)
which suggests it is safe to do so, but we want to understand if there have
been recent changes to topic-partition metadata which we might end up
corrupting if we try this? If so, are there any tips to get around this
issue?

Thanks,
Sankalp

kafka-reassign-partitions script for TLS enabled Zookeeper in Kafka 2.5

[Sankalp Bhatia]

Hi All,

KIP-455

mentions
that command line changes for script kafka-reassign-partitions is added in
kafka version 2.6. However, I noticed that KIP-515

(released
in 2.5) skipped adding a "*--zk-tls-config-file*" argument for this script
after mentioning this was being addressed in the former KIP, as a
bootstrap-server argument will be provided through those changes.

So I assume the only way to run this bash script in kafka version 2.5 is to
set system properties via the '-D'  arguments which are considered
insecure. Is my understanding correct? If making a change to add a config
file as an argument is an option, I would like to contribute with a
KIP/JIRA.

Thanks,
Sankalp

Permissions to create and assign JIRA issues

[Sankalp Bhatia]

Hi devs,

I would like to contribute and will be grateful if someone can grant me the
permissions to create and assign JIRA issues.

my id is : sankalpbhatia

Thanks in advance!

Re: Question around release plans for Apache Kafka 2.3.2 and 2.4.2

[Sankalp Bhatia]

Thanks Ismael for the response.

For our clusters running 2.3.1 and 2.4.1, we saw some issues which had
2.3.2 and 2.4.2 as the fix versions. I looked at 2.5.0 but since it
introduces some major changes like support for ZK encryption and a few
others, I was wondering if we should choose a smaller upgrade in such cases
as we don't really require the new features in 2.5 and above right now.

-
Sankalp

On Wed, 24 Jun 2020 at 14:23, Ismael Juma  wrote:

> Hi Sankalp,
>
> Is there a reason why you cannot upgrade to Apache Kafka 2.5.0 instead? We
> are working on the 2.5.1 release, which would be the recommended release.
>
> Ismael
>
> On Wed, Jun 24, 2020 at 6:18 AM Sankalp Bhatia 
> wrote:
>
> > Hi All,
> >
> > I would like to know if there are any plans to release a 2.3.2 and 2.4.2
> > versions for Apache Kafka in the near future. I see there are some issues
> > marked as fixed in these two versions
> > (https://tinyurl.com/ycdpz5cb).
> > However, I could not find a branch/tag corresponding to these versions in
> > the github repository (https://github.com/apache/kafka).
> >
> > Also, It would be great if someone can help me understand or share any
> > documentation around the release processes (specifically on when we
> decide
> > to release a new bug fix version like the ones mentioned above.)
> >
> > Thanks,
> > Sankalp
> >
>

Question around release plans for Apache Kafka 2.3.2 and 2.4.2

[Sankalp Bhatia]

Hi All,

I would like to know if there are any plans to release a 2.3.2 and 2.4.2
versions for Apache Kafka in the near future. I see there are some issues
marked as fixed in these two versions
(https://tinyurl.com/ycdpz5cb).
However, I could not find a branch/tag corresponding to these versions in
the github repository (https://github.com/apache/kafka).

Also, It would be great if someone can help me understand or share any
documentation around the release processes (specifically on when we decide
to release a new bug fix version like the ones mentioned above.)

Thanks,
Sankalp