[GitHub] kafka pull request #3554: KAFKA-5123 Refactor ZkUtils readData* methods

2017-12-14 Thread baluchicken
Github user baluchicken closed the pull request at:

https://github.com/apache/kafka/pull/3554


---


[GitHub] kafka pull request #3637: KAFKA-4879 KafkaConsumer.position may hang forever...

2017-08-07 Thread baluchicken
GitHub user baluchicken opened a pull request:

https://github.com/apache/kafka/pull/3637

KAFKA-4879 KafkaConsumer.position may hang forever when deleting a topic

@guozhangwang  I created this PR but it lacks the test. I also has the test 
but I wanted to ask which Test file should be the best candidate for this?
Also there is a TODO line which I created because that method already has a 
timeout parameter, what do you think how can we proceed there?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/baluchicken/kafka-1 KAFKA-4879

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3637.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3637


commit 211b2118b0ec5fd7ff5b499ef17c92b0d31e76e3
Author: Balint Molnar 
Date:   2017-08-07T14:54:34Z

KAFKA-4879 KafkaConsumer.position may hang forever when deleting a topic




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] kafka pull request #3554: KAFKA-5123 Refactor ZkUtils readData* methods

2017-07-20 Thread baluchicken
GitHub user baluchicken opened a pull request:

https://github.com/apache/kafka/pull/3554

KAFKA-5123 Refactor ZkUtils readData* methods



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/baluchicken/kafka-1 KAFKA-5123

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3554.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3554


commit a3cf1061727b9eef3899789aa482e8fb9c4534e2
Author: Balint Molnar 
Date:   2017-06-16T09:43:06Z

KAFKA-5123 Refactor ZkUtils readData* methods




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] kafka pull request #3281: KAFKA-5388 Replace zkClient.subscribe*Changes meth...

2017-06-09 Thread baluchicken
GitHub user baluchicken opened a pull request:

https://github.com/apache/kafka/pull/3281

KAFKA-5388 Replace zkClient.subscribe*Changes method with an equivalent 
zkUtils method

@ijuma can you please review if you have time:) ?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/baluchicken/kafka-1 KAFKA-5388

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3281.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3281


commit 32d54551746d303b977a5deb1e1cbc19d8dc33f2
Author: Balint Molnar 
Date:   2017-06-09T11:15:39Z

KAFKA-5388 Replace zkClient.subscribe*Changes method with an equivalent 
zkUtils method




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] kafka pull request #3245: KAFKA-5391 Replace zkClient.delete* method with an...

2017-06-06 Thread baluchicken
GitHub user baluchicken opened a pull request:

https://github.com/apache/kafka/pull/3245

KAFKA-5391 Replace zkClient.delete* method with an equivalent zkUtills

@ijuma can you please review.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/baluchicken/kafka-1 KAFKA-5391

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3245.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3245


commit b3128fd999b5d715b101dbbf81323492dd485cea
Author: Balint Molnar 
Date:   2017-06-06T13:56:04Z

KAFKA-5391 Replace zkClient.delete* method with an equivalent zkUtils method




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] kafka pull request #3243: KAFKA-5389 Replace zkClient.exists method with zkU...

2017-06-06 Thread baluchicken
GitHub user baluchicken opened a pull request:

https://github.com/apache/kafka/pull/3243

KAFKA-5389 Replace zkClient.exists method with zkUtils.pathExists

@ijuma can you please review

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/baluchicken/kafka-1 KAFKA-5389

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3243.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3243


commit 4b23b521ae9649870212bdcd2349dd4771f45592
Author: Balint Molnar 
Date:   2017-06-06T12:48:00Z

KAFKA-5389 Replace zkClient.exists method with zkUtils.pathExists




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] kafka pull request #3097: KAFKA-5134 Replace zkClient.getChildren method wit...

2017-05-19 Thread baluchicken
GitHub user baluchicken opened a pull request:

https://github.com/apache/kafka/pull/3097

KAFKA-5134 Replace zkClient.getChildren method with zkUtils.getChildren

@ijuma plz review. I also created a version where I didn't refactor the  
getPartitionAssignmentForTopics and the getConsumersPerTopic methods, but I 
thought maybe it is a good idea to do and move the logic (where there is no ZK 
connection) to the ZkUtils Object.
About the two new methods, I wanted to make them private and visible only 
for testing, but because the tests where I use them are not in the same package 
I couldn't do it. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/baluchicken/kafka-1 KAFKA-5134-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3097.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3097






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] kafka pull request #2981: KAFKA-5173: Add logging to dump JaasContext before...

2017-05-08 Thread baluchicken
Github user baluchicken closed the pull request at:

https://github.com/apache/kafka/pull/2981


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] kafka pull request #2981: KAFKA-5173: Add logging to dump JaasContext before...

2017-05-05 Thread baluchicken
GitHub user baluchicken opened a pull request:

https://github.com/apache/kafka/pull/2981

KAFKA-5173: Add logging to dump JaasContext before writing it to file

@rajinisivaram plz review.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/baluchicken/kafka-1 KAFKA-5173

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/2981.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2981


commit 50d1c172b56d09352df72eebd81102447923d975
Author: Balint Molnar 
Date:   2017-05-05T13:25:42Z

KAFKA-5173: Add logging to dump JaasContext before writing it to file




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] kafka pull request #2919: KAFKA-5127 Replace pattern matching with foreach w...

2017-04-26 Thread baluchicken
GitHub user baluchicken opened a pull request:

https://github.com/apache/kafka/pull/2919

KAFKA-5127 Replace pattern matching with foreach where the case None …

@ijuma plz review. This one is not complete because KafkaController, 
AdminUtils and ReplicaStateMachine has some of these but for those I will wait 
until the KAFKA-5028 and KAFKA-5103 are merged.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/baluchicken/kafka-1 KAFKA-5127

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/2919.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2919


commit 553ef1acd456799f9aa4871c0a1a764eb88fad51
Author: Balint Molnar 
Date:   2017-04-26T13:44:11Z

KAFKA-5127 Replace pattern matching with foreach where the case None is 
unused




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] kafka pull request #2888: KAFKA-5103 Refactor AdminUtils to use zkUtils meth...

2017-04-21 Thread baluchicken
GitHub user baluchicken opened a pull request:

https://github.com/apache/kafka/pull/2888

KAFKA-5103 Refactor AdminUtils to use zkUtils methods instad of zkUti…

@ijuma  plz review.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/baluchicken/kafka-1 KAFKA-5103

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/2888.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2888


commit a0ac0defa6560a1a2734f0b7c115ce4f6b5f61a1
Author: Balint Molnar 
Date:   2017-04-21T14:07:23Z

KAFKA-5103 Refactor AdminUtils to use zkUtils methods instad of 
zkUtils.zkClient




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] kafka pull request #2886: KAFKA-5101 Remove KafkaController's incrementContr...

2017-04-21 Thread baluchicken
GitHub user baluchicken opened a pull request:

https://github.com/apache/kafka/pull/2886

KAFKA-5101 Remove KafkaController's incrementControllerEpoch method p…

@ijuma minor fix. can you please review.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/baluchicken/kafka-1 KAFKA-5101

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/2886.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2886


commit e6b84b87aa39a1971758cd84d23ed2784f8953ac
Author: Balint Molnar 
Date:   2017-04-21T12:34:48Z

KAFKA-5101 Remove KafkaController's incrementControllerEpoch method 
parameter




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] kafka pull request #2732: KAFKA-4855 Struct SchemaBuilder should not allow d...

2017-03-24 Thread baluchicken
GitHub user baluchicken opened a pull request:

https://github.com/apache/kafka/pull/2732

KAFKA-4855 Struct SchemaBuilder should not allow duplicate fields

@ewencp can you please review.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/baluchicken/kafka-1 KAFKA-4855

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/2732.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2732


commit 2fd680a1e76ac3c4c0337e397979321cac49aefa
Author: Balint Molnar 
Date:   2017-03-24T12:49:07Z

KAFKA-4855 Struct SchemaBuilder should not allow duplicate fields




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] kafka pull request #2506: KAFKA-4703 Test with two SASL_SSL listeners with d...

2017-02-06 Thread baluchicken
GitHub user baluchicken opened a pull request:

https://github.com/apache/kafka/pull/2506

KAFKA-4703 Test with two SASL_SSL listeners with different JAAS contexts

@ijuma plz review

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/baluchicken/kafka-1 KAFKA-4703

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/2506.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2506


commit ecbf27736e746aceb368744c170a7a7fe2bbea09
Author: Balint Molnar 
Date:   2017-02-06T14:55:08Z

KAFKA-4703 Test with two SASL_SSL listeners with different JAAS contexts




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] kafka pull request #2423: KAFKA-4679 Remove unstable markers from Connect AP...

2017-01-23 Thread baluchicken
GitHub user baluchicken opened a pull request:

https://github.com/apache/kafka/pull/2423

KAFKA-4679 Remove unstable markers from Connect APIs

@ewencp ignore this PR if you are already started to work on this ticket.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/baluchicken/kafka-1 KAFKA-4679

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/2423.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2423


commit 9e680730a5bf14a50f075c7d1e71cd9e418e8a27
Author: Balint Molnar 
Date:   2017-01-23T13:09:04Z

KAFKA-4679 Remove unstable markers from Connect APIs




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] kafka pull request #2422: KAFKA-4679 Remove unstable markers from Connect AP...

2017-01-23 Thread baluchicken
Github user baluchicken closed the pull request at:

https://github.com/apache/kafka/pull/2422


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] kafka pull request #2422: KAFKA-4679 Remove unstable markers from Connect AP...

2017-01-23 Thread baluchicken
GitHub user baluchicken opened a pull request:

https://github.com/apache/kafka/pull/2422

KAFKA-4679 Remove unstable markers from Connect APIs

@ewencp ignore this PR if you are already started to work on this ticket.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/baluchicken/kafka-1 KAFKA-4679

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/2422.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2422


commit 42f5fc080ace8341ff7d405c089ceebd26048c6b
Author: Balint Molnar 
Date:   2017-01-23T12:59:25Z

KAFKA-4679 Remove unstable markers from Connect APIs




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] kafka pull request #2176: KAFKA-4403 Update KafkaBasedLog to use new endOffs...

2016-11-27 Thread baluchicken
GitHub user baluchicken opened a pull request:

https://github.com/apache/kafka/pull/2176

KAFKA-4403 Update KafkaBasedLog to use new endOffsets consumer API

@ewencp plz review

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/baluchicken/kafka-1 KAFKA-4403

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/2176.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2176


commit 58b215c4149bf16e597409962ead471bb5dc4d0b
Author: Balint Molnar 
Date:   2016-11-27T16:34:39Z

KAFKA-4403 Update KafkaBasedLog to use new endOffsets consumer API




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] kafka pull request #2161: KAFKA-4307 Inconsistent parameters between console...

2016-11-23 Thread baluchicken
GitHub user baluchicken opened a pull request:

https://github.com/apache/kafka/pull/2161

KAFKA-4307 Inconsistent parameters between console producer and consumer

@gwenshap please review

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/baluchicken/kafka-1 KAFKA-4307

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/2161.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2161


commit f2b2775ce8f3b70861d101545fb4bb966484ef84
Author: Balint Molnar 
Date:   2016-11-21T14:52:04Z

KAFKA-4307 Inconsistent parameters between console producer and consumer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] kafka pull request #2137: KAFKA-1548 Refactor the "replica_id" in requests

2016-11-15 Thread baluchicken
GitHub user baluchicken opened a pull request:

https://github.com/apache/kafka/pull/2137

KAFKA-1548 Refactor the "replica_id" in requests



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/baluchicken/kafka-1 KAFKA-1548

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/2137.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2137


commit 4e55654c288fa18ad294796b5d58c5bc8e198ccc
Author: Balint Molnar 
Date:   2016-11-15T13:27:09Z

KAFKA-1548 Refactor the "replica_id" in requests




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] kafka pull request #2083: KAFKA-4318 Migrate ProducerSendTest to the new con...

2016-11-01 Thread baluchicken
GitHub user baluchicken opened a pull request:

https://github.com/apache/kafka/pull/2083

KAFKA-4318 Migrate ProducerSendTest to the new consumer



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/baluchicken/kafka-1 KAFKA-4318

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/2083.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2083


commit 6376d7e4623d65c3af01c6dbf9225e8ac43a0b47
Author: Balint Molnar 
Date:   2016-11-01T09:16:17Z

KAFKA-4318 Migrate ProducerSendTest to the new consumer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---