[jira] [Work started] (KAFKA-3648) maxTimeToBlock should be enforced
[ https://issues.apache.org/jira/browse/KAFKA-3648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-3648 started by chen zhu. --- > maxTimeToBlock should be enforced > -- > > Key: KAFKA-3648 > URL: https://issues.apache.org/jira/browse/KAFKA-3648 > Project: Kafka > Issue Type: Bug >Reporter: chen zhu >Assignee: chen zhu > > Currently the maxTimeToBlock in allocate(int size, long maxTimeToBlock) in > clients/producer/internals/BufferPool.java is not updated after each loop. It > should be enforced. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-3648) maxTimeToBlock should be enforced
[ https://issues.apache.org/jira/browse/KAFKA-3648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chen zhu updated KAFKA-3648: Description: Currently the maxTimeToBlock in allocate(int size, long maxTimeToBlock) in clients/producer/internals/BufferPool.java is not updated after each loop. It should be enforced. (was: Currently the maxTimeToBlock in allocate(int size, long maxTimeToBlock) is not updated after each loop. It should be enforced. ) > maxTimeToBlock should be enforced > -- > > Key: KAFKA-3648 > URL: https://issues.apache.org/jira/browse/KAFKA-3648 > Project: Kafka > Issue Type: Bug >Reporter: chen zhu >Assignee: chen zhu > > Currently the maxTimeToBlock in allocate(int size, long maxTimeToBlock) in > clients/producer/internals/BufferPool.java is not updated after each loop. It > should be enforced. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work started] (KAFKA-3383) Producer should not remove an in flight request before successfully parsing the response.
[ https://issues.apache.org/jira/browse/KAFKA-3383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-3383 started by chen zhu. --- > Producer should not remove an in flight request before successfully parsing > the response. > - > > Key: KAFKA-3383 > URL: https://issues.apache.org/jira/browse/KAFKA-3383 > Project: Kafka > Issue Type: Bug >Affects Versions: 0.9.0.0 >Reporter: Jiangjie Qin >Assignee: chen zhu > Fix For: 0.10.0.0 > > > In the NetworkClient, we remove the in flight request before we successfully > parse the response. If the response parse failed, the request will not be > fulfilled but just lost. For a producer request, that means the callback of > the messages won't be fired forever. > We should only remove the in flight request after response parsing succeeds. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-3383) Producer should not remove an in flight request before successfully parsing the response.
[ https://issues.apache.org/jira/browse/KAFKA-3383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chen zhu updated KAFKA-3383: Summary: Producer should not remove an in flight request before successfully parsing the response. (was: Producer should not remove an in flight requests before successfully parsing the response.) > Producer should not remove an in flight request before successfully parsing > the response. > - > > Key: KAFKA-3383 > URL: https://issues.apache.org/jira/browse/KAFKA-3383 > Project: Kafka > Issue Type: Bug >Affects Versions: 0.9.0.0 >Reporter: Jiangjie Qin >Assignee: chen zhu > Fix For: 0.10.0.0 > > > In the NetworkClient, we remove the in flight request before we successfully > parse the response. If the response parse failed, the request will not be > fulfilled but just lost. For a producer request, that means the callback of > the messages won't be fired forever. > We should only remove the in flight request after response parsing succeeds. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (KAFKA-3383) Producer should not remove an in flight requests before successfully parsing the response.
[ https://issues.apache.org/jira/browse/KAFKA-3383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chen zhu reassigned KAFKA-3383: --- Assignee: chen zhu (was: Jiangjie Qin) > Producer should not remove an in flight requests before successfully parsing > the response. > -- > > Key: KAFKA-3383 > URL: https://issues.apache.org/jira/browse/KAFKA-3383 > Project: Kafka > Issue Type: Bug >Affects Versions: 0.9.0.0 >Reporter: Jiangjie Qin >Assignee: chen zhu > Fix For: 0.10.0.0 > > > In the NetworkClient, we remove the in flight request before we successfully > parse the response. If the response parse failed, the request will not be > fulfilled but just lost. For a producer request, that means the callback of > the messages won't be fired forever. > We should only remove the in flight request after response parsing succeeds. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-3261) Consolidate class kafka.cluster.BrokerEndPoint and kafka.cluster.EndPoint
[
https://issues.apache.org/jira/browse/KAFKA-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15184535#comment-15184535
]
chen zhu commented on KAFKA-3261:
-
[~guozhang] I am sorry for the late reply.
Are you suggesting to construct a new class that contains 4 fields: host, port,
broker id and protocol id, and allow broker id and protocol id to be None? If
so, that is certainly doable. But do you think this is better than current
implementation?
BTW, could you please explain ".. versioned based on protocol id"? I don't have
experience with that. Thanks!
> Consolidate class kafka.cluster.BrokerEndPoint and kafka.cluster.EndPoint
> -
>
> Key: KAFKA-3261
> URL: https://issues.apache.org/jira/browse/KAFKA-3261
> Project: Kafka
> Issue Type: Bug
>Reporter: Guozhang Wang
>Assignee: chen zhu
>
> These two classes are serving similar purposes and can be consolidated. Also
> as [~sasakitoa] suggested we can remove their "uriParseExp" variables but use
> (a possibly modified)
> {code}
> private static final Pattern HOST_PORT_PATTERN =
> Pattern.compile(".*?\\[?([0-9a-zA-Z\\-.:]*)\\]?:([0-9]+)");
> {code}
> in org.apache.kafka.common.utils.Utils instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-3261) Consolidate class kafka.cluster.BrokerEndPoint and kafka.cluster.EndPoint
[
https://issues.apache.org/jira/browse/KAFKA-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15184516#comment-15184516
]
chen zhu commented on KAFKA-3261:
-
[~ijuma] yes, that can be done.
But if we use the same regrex(in this case the regrex in EndPoint class), when
doing parsing in the BrokerEndPoint class, the input string will be split to
three parts: an empty string, host, and port. That might confuse readers as the
first part is always an empty string that is of no use in the class. Do you
think consolidating regrexes would be better/cleaner than the current
implementation?
> Consolidate class kafka.cluster.BrokerEndPoint and kafka.cluster.EndPoint
> -
>
> Key: KAFKA-3261
> URL: https://issues.apache.org/jira/browse/KAFKA-3261
> Project: Kafka
> Issue Type: Bug
>Reporter: Guozhang Wang
>Assignee: chen zhu
>
> These two classes are serving similar purposes and can be consolidated. Also
> as [~sasakitoa] suggested we can remove their "uriParseExp" variables but use
> (a possibly modified)
> {code}
> private static final Pattern HOST_PORT_PATTERN =
> Pattern.compile(".*?\\[?([0-9a-zA-Z\\-.:]*)\\]?:([0-9]+)");
> {code}
> in org.apache.kafka.common.utils.Utils instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-3261) Consolidate class kafka.cluster.BrokerEndPoint and kafka.cluster.EndPoint
[
https://issues.apache.org/jira/browse/KAFKA-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170945#comment-15170945
]
chen zhu commented on KAFKA-3261:
-
[~guozhang], it looks like we can not consolidate kafka.cluster.BrokerEndPoint
and kafka.cluster.EndPoint because they actually have different contents and
usage. BrokerEndPoint contains host, port and broker id whereas EndPoint
contains host, port and protocol id. Do you think this ticket should be closed?
> Consolidate class kafka.cluster.BrokerEndPoint and kafka.cluster.EndPoint
> -
>
> Key: KAFKA-3261
> URL: https://issues.apache.org/jira/browse/KAFKA-3261
> Project: Kafka
> Issue Type: Bug
>Reporter: Guozhang Wang
>Assignee: chen zhu
>
> These two classes are serving similar purposes and can be consolidated. Also
> as [~sasakitoa] suggested we can remove their "uriParseExp" variables but use
> (a possibly modified)
> {code}
> private static final Pattern HOST_PORT_PATTERN =
> Pattern.compile(".*?\\[?([0-9a-zA-Z\\-.:]*)\\]?:([0-9]+)");
> {code}
> in org.apache.kafka.common.utils.Utils instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Work started] (KAFKA-3257) bootstrap-test-env.sh version check fails when grep has --colour option enabled.
[
https://issues.apache.org/jira/browse/KAFKA-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on KAFKA-3257 started by chen zhu.
---
> bootstrap-test-env.sh version check fails when grep has --colour option
> enabled.
>
>
> Key: KAFKA-3257
> URL: https://issues.apache.org/jira/browse/KAFKA-3257
> Project: Kafka
> Issue Type: Bug
> Components: system tests
>Affects Versions: 0.9.0.1
>Reporter: Jiangjie Qin
>Assignee: chen zhu
> Labels: newbie++
> Fix For: 0.10.0.0
>
>
> When checking the versions, we use the following command:
> {code}
> vagrant --version | egrep -o "[0-9]+\.[0-9]+\.[0-9]+"
> {code}
> This does not work if user box has --colour option enabled. In my case it
> complains:
> Found Vagrant version 1.8.1. Please upgrade to 1.6.4 or higher (see
> http://www.vagrantup.com for details)
> We should change this line to:
> {code}
> vagrant --version | egrep --colour=never -o "[0-9]+\.[0-9]+\.[0-9]+"
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-3261) Consolidate class kafka.cluster.BrokerEndPoint and kafka.cluster.EndPoint
[
https://issues.apache.org/jira/browse/KAFKA-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15157976#comment-15157976
]
chen zhu commented on KAFKA-3261:
-
[~guozhang] Thanks for creating the patch. I will finish this one as follow-up
patch of KAFKA-2757.
> Consolidate class kafka.cluster.BrokerEndPoint and kafka.cluster.EndPoint
> -
>
> Key: KAFKA-3261
> URL: https://issues.apache.org/jira/browse/KAFKA-3261
> Project: Kafka
> Issue Type: Bug
>Reporter: Guozhang Wang
>Assignee: chen zhu
>
> These two classes are serving similar purposes and can be consolidated. Also
> as [~sasakitoa] suggested we can remove their "uriParseExp" variables but use
> (a possibly modified)
> {code}
> private static final Pattern HOST_PORT_PATTERN =
> Pattern.compile(".*?\\[?([0-9a-zA-Z\\-.:]*)\\]?:([0-9]+)");
> {code}
> in org.apache.kafka.common.utils.Utils instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Issue Comment Deleted] (KAFKA-3261) Consolidate class kafka.cluster.BrokerEndPoint and kafka.cluster.EndPoint
[
https://issues.apache.org/jira/browse/KAFKA-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chen zhu updated KAFKA-3261:
Comment: was deleted
(was: @guozhang Thanks for creating the patch. I will finish this one as
follow-up patch of KAFKA-2757.)
> Consolidate class kafka.cluster.BrokerEndPoint and kafka.cluster.EndPoint
> -
>
> Key: KAFKA-3261
> URL: https://issues.apache.org/jira/browse/KAFKA-3261
> Project: Kafka
> Issue Type: Bug
>Reporter: Guozhang Wang
>Assignee: chen zhu
>
> These two classes are serving similar purposes and can be consolidated. Also
> as [~sasakitoa] suggested we can remove their "uriParseExp" variables but use
> (a possibly modified)
> {code}
> private static final Pattern HOST_PORT_PATTERN =
> Pattern.compile(".*?\\[?([0-9a-zA-Z\\-.:]*)\\]?:([0-9]+)");
> {code}
> in org.apache.kafka.common.utils.Utils instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-3261) Consolidate class kafka.cluster.BrokerEndPoint and kafka.cluster.EndPoint
[
https://issues.apache.org/jira/browse/KAFKA-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15157974#comment-15157974
]
chen zhu commented on KAFKA-3261:
-
@guozhang Thanks for creating the patch. I will finish this one as follow-up
patch of KAFKA-2757.
> Consolidate class kafka.cluster.BrokerEndPoint and kafka.cluster.EndPoint
> -
>
> Key: KAFKA-3261
> URL: https://issues.apache.org/jira/browse/KAFKA-3261
> Project: Kafka
> Issue Type: Bug
>Reporter: Guozhang Wang
>Assignee: chen zhu
>
> These two classes are serving similar purposes and can be consolidated. Also
> as [~sasakitoa] suggested we can remove their "uriParseExp" variables but use
> (a possibly modified)
> {code}
> private static final Pattern HOST_PORT_PATTERN =
> Pattern.compile(".*?\\[?([0-9a-zA-Z\\-.:]*)\\]?:([0-9]+)");
> {code}
> in org.apache.kafka.common.utils.Utils instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (KAFKA-3261) Consolidate class kafka.cluster.BrokerEndPoint and kafka.cluster.EndPoint
[
https://issues.apache.org/jira/browse/KAFKA-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chen zhu reassigned KAFKA-3261:
---
Assignee: chen zhu
> Consolidate class kafka.cluster.BrokerEndPoint and kafka.cluster.EndPoint
> -
>
> Key: KAFKA-3261
> URL: https://issues.apache.org/jira/browse/KAFKA-3261
> Project: Kafka
> Issue Type: Bug
>Reporter: Guozhang Wang
>Assignee: chen zhu
>
> These two classes are serving similar purposes and can be consolidated. Also
> as [~sasakitoa] suggested we can remove their "uriParseExp" variables but use
> (a possibly modified)
> {code}
> private static final Pattern HOST_PORT_PATTERN =
> Pattern.compile(".*?\\[?([0-9a-zA-Z\\-.:]*)\\]?:([0-9]+)");
> {code}
> in org.apache.kafka.common.utils.Utils instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-2673) Log JmxTool output to logger
[ https://issues.apache.org/jira/browse/KAFKA-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146101#comment-15146101 ] chen zhu commented on KAFKA-2673: - No problem. Issue closed. > Log JmxTool output to logger > > > Key: KAFKA-2673 > URL: https://issues.apache.org/jira/browse/KAFKA-2673 > Project: Kafka > Issue Type: Improvement > Components: core >Affects Versions: 0.8.2.1 >Reporter: Eno Thereska >Assignee: chen zhu >Priority: Trivial > Labels: newbie > Fix For: 0.8.1.2 > > > Currently JmxTool outputs the data into a CSV file. It could be of value to > have the data sent to a logger specified in a log4j configuration file. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (KAFKA-2673) Log JmxTool output to logger
[ https://issues.apache.org/jira/browse/KAFKA-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146101#comment-15146101 ] chen zhu edited comment on KAFKA-2673 at 2/13/16 6:03 PM: -- [~enothereska], no problem. Issue closed. was (Author: chenzhu): No problem. Issue closed. > Log JmxTool output to logger > > > Key: KAFKA-2673 > URL: https://issues.apache.org/jira/browse/KAFKA-2673 > Project: Kafka > Issue Type: Improvement > Components: core >Affects Versions: 0.8.2.1 >Reporter: Eno Thereska >Assignee: chen zhu >Priority: Trivial > Labels: newbie > Fix For: 0.8.1.2 > > > Currently JmxTool outputs the data into a CSV file. It could be of value to > have the data sent to a logger specified in a log4j configuration file. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (KAFKA-2673) Log JmxTool output to logger
[ https://issues.apache.org/jira/browse/KAFKA-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chen zhu resolved KAFKA-2673. - Resolution: Not A Problem Not needed. > Log JmxTool output to logger > > > Key: KAFKA-2673 > URL: https://issues.apache.org/jira/browse/KAFKA-2673 > Project: Kafka > Issue Type: Improvement > Components: core >Affects Versions: 0.8.2.1 >Reporter: Eno Thereska >Assignee: chen zhu >Priority: Trivial > Labels: newbie > Fix For: 0.8.1.2 > > > Currently JmxTool outputs the data into a CSV file. It could be of value to > have the data sent to a logger specified in a log4j configuration file. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (KAFKA-2970) Both UpdateMetadataRequest.java and LeaderAndIsrRequest.java have an Endpoint class
[ https://issues.apache.org/jira/browse/KAFKA-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chen zhu reassigned KAFKA-2970: --- Assignee: chen zhu > Both UpdateMetadataRequest.java and LeaderAndIsrRequest.java have an Endpoint > class > --- > > Key: KAFKA-2970 > URL: https://issues.apache.org/jira/browse/KAFKA-2970 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.9.0.0 >Reporter: Grant Henke >Assignee: chen zhu > > Both UpdateMetadataRequest.java and LeaderAndIsrRequest.java have an Endpoint > class which contain the same information. These should be consolidated for > simplicity and inter-opt. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (KAFKA-2757) Consolidate BrokerEndPoint and EndPoint
[ https://issues.apache.org/jira/browse/KAFKA-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chen zhu reassigned KAFKA-2757: --- Assignee: chen zhu > Consolidate BrokerEndPoint and EndPoint > --- > > Key: KAFKA-2757 > URL: https://issues.apache.org/jira/browse/KAFKA-2757 > Project: Kafka > Issue Type: Bug >Reporter: Guozhang Wang >Assignee: chen zhu > Fix For: 0.9.1.0 > > > For code simplicity, it's better to consolidate these two classes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work started] (KAFKA-2757) Consolidate BrokerEndPoint and EndPoint
[ https://issues.apache.org/jira/browse/KAFKA-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-2757 started by chen zhu. --- > Consolidate BrokerEndPoint and EndPoint > --- > > Key: KAFKA-2757 > URL: https://issues.apache.org/jira/browse/KAFKA-2757 > Project: Kafka > Issue Type: Bug >Reporter: Guozhang Wang >Assignee: chen zhu > Fix For: 0.9.1.0 > > > For code simplicity, it's better to consolidate these two classes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2673) Log JmxTool output to logger
[ https://issues.apache.org/jira/browse/KAFKA-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145736#comment-15145736 ] chen zhu commented on KAFKA-2673: - Hi [~enothereska], currently JmxTool outputs the data to stdout. The output can be easily redirect to a log file if needed. I am not sure if it is useful to specify the file path in the log4j configuration, because in that case user needs to first add a new appender in the config/tools-log4j.properties, and uses the appender for class JmxTool at the INFO level. Can you elaborate a bit more on the benefits of doing so? > Log JmxTool output to logger > > > Key: KAFKA-2673 > URL: https://issues.apache.org/jira/browse/KAFKA-2673 > Project: Kafka > Issue Type: Improvement > Components: core >Affects Versions: 0.8.2.1 >Reporter: Eno Thereska >Assignee: chen zhu >Priority: Trivial > Labels: newbie > Fix For: 0.8.1.2 > > > Currently JmxTool outputs the data into a CSV file. It could be of value to > have the data sent to a logger specified in a log4j configuration file. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work started] (KAFKA-2673) Log JmxTool output to logger
[ https://issues.apache.org/jira/browse/KAFKA-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-2673 started by chen zhu. --- > Log JmxTool output to logger > > > Key: KAFKA-2673 > URL: https://issues.apache.org/jira/browse/KAFKA-2673 > Project: Kafka > Issue Type: Improvement > Components: core >Affects Versions: 0.8.2.1 >Reporter: Eno Thereska >Assignee: chen zhu >Priority: Trivial > Labels: newbie > Fix For: 0.8.1.2 > > > Currently JmxTool outputs the data into a CSV file. It could be of value to > have the data sent to a logger specified in a log4j configuration file. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (KAFKA-2673) Log JmxTool output to logger
[ https://issues.apache.org/jira/browse/KAFKA-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chen zhu reassigned KAFKA-2673: --- Assignee: chen zhu > Log JmxTool output to logger > > > Key: KAFKA-2673 > URL: https://issues.apache.org/jira/browse/KAFKA-2673 > Project: Kafka > Issue Type: Improvement > Components: core >Affects Versions: 0.8.2.1 >Reporter: Eno Thereska >Assignee: chen zhu >Priority: Trivial > Labels: newbie > Fix For: 0.8.1.2 > > > Currently JmxTool outputs the data into a CSV file. It could be of value to > have the data sent to a logger specified in a log4j configuration file. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (KAFKA-2676) AclCommandTest has wrong package name
[ https://issues.apache.org/jira/browse/KAFKA-2676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chen zhu reassigned KAFKA-2676: --- Assignee: chen zhu > AclCommandTest has wrong package name > -- > > Key: KAFKA-2676 > URL: https://issues.apache.org/jira/browse/KAFKA-2676 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.9.0.0 >Reporter: Jun Rao >Assignee: chen zhu > Labels: newbie > > AclCommandTest has the package unit.kafka.security.auth. We should remove the > unit par. ResourceTypeTest has the same issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
